From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.9904.1628175458396083424 for ; Thu, 05 Aug 2021 07:57:38 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=eT691/cH; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from localhost.localdomain (unknown [167.220.2.74]) by linux.microsoft.com (Postfix) with ESMTPSA id 066A920B36EE; Thu, 5 Aug 2021 07:57:38 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 066A920B36EE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1628175458; bh=HNsWSQKsBCVN9/Suo/eEG7Hjcd7dO9QdZaerhmiiff4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eT691/cHcJCKlvl0thSOCzpp5LOqhssBLXMBdAcL3Hh/5BKOuEBYFZw0Sl1aiIejJ QT2Y+AUCbuxJKKILz/lYMeGRW7criM4yljEfDzwX9OByY3ikEu/imK6BVcrVKUr3Bs bSuK2Fs95Ewy5ooRhOEgl/sD6C2OXIsNIWp3+Ncc= From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Liming Gao , Eric Dong Subject: [edk2-platforms][PATCH v1 3/5] MinPlatformPkg/TestPointCheckLib: Fix incorrect array index Date: Thu, 5 Aug 2021 10:57:04 -0400 Message-Id: <20210805145706.2470-4-mikuback@linux.microsoft.com> X-Mailer: git-send-email 2.28.0.windows.1 In-Reply-To: <20210805145706.2470-1-mikuback@linux.microsoft.com> References: <20210805145706.2470-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3520 TestPointSmmEndOfDxeSmrrFunctional() uses the incorrect byte index to skip the test. It should use byte 6 instead of byte 5. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Michael Kubacki --- Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPoin= tCheckLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib= /SmmTestPointCheckLib.c b/Platform/Intel/MinPlatformPkg/Test/Library/Test= PointCheckLib/SmmTestPointCheckLib.c index 4b4f874c7bbc..3e8b2621cccd 100644 --- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTes= tPointCheckLib.c +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTes= tPointCheckLib.c @@ -109,7 +109,7 @@ TestPointSmmEndOfDxeSmrrFunctional ( EFI_STATUS Status; BOOLEAN Result; =20 - if ((mFeatureImplemented[5] & TEST_POINT_BYTE6_SMM_END_OF_DXE_SMRR_FUN= CTIONAL) =3D=3D 0) { + if ((mFeatureImplemented[6] & TEST_POINT_BYTE6_SMM_END_OF_DXE_SMRR_FUN= CTIONAL) =3D=3D 0) { return EFI_SUCCESS; } =20 @@ -125,7 +125,7 @@ TestPointSmmEndOfDxeSmrrFunctional ( TestPointLibSetFeaturesVerified ( PLATFORM_TEST_POINT_ROLE_PLATFORM_IBV, NULL, - 5, + 6, TEST_POINT_BYTE6_SMM_END_OF_DXE_SMRR_FUNCTIONAL ); } --=20 2.28.0.windows.1