From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.40]) by mx.groups.io with SMTP id smtpd.web09.11242.1628180775731204869 for ; Thu, 05 Aug 2021 09:26:16 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=ttZPEJ1I; spf=pass (domain: arm.com, ip: 40.107.6.40, mailfrom: christopher.jones@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6m/Um4tNbhvE4SOg91+xE1DWBwbkSw+cX9gcSYEKsDI=; b=ttZPEJ1IkexlpnGHZgq9pUeINnOts8FIFGIr6AjCls4w7fel+j6gEv8yNOZ3OnLMms1o4bSqSxo9m3ffKdqMvYna65wJaTKgfY2slhqK1EI/AvvtuPdZGVvlEcahzBRuBkrWlPI2lpfR7CJNrSrFSHHzedXOOkWnfF9WVfoWRB8= Received: from DB8PR06CA0062.eurprd06.prod.outlook.com (2603:10a6:10:120::36) by AM6PR08MB4087.eurprd08.prod.outlook.com (2603:10a6:20b:ac::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.25; Thu, 5 Aug 2021 16:26:12 +0000 Received: from DB5EUR03FT048.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:120:cafe::66) by DB8PR06CA0062.outlook.office365.com (2603:10a6:10:120::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.15 via Frontend Transport; Thu, 5 Aug 2021 16:26:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT048.mail.protection.outlook.com (10.152.21.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.15 via Frontend Transport; Thu, 5 Aug 2021 16:26:12 +0000 Received: ("Tessian outbound efa8a7456a86:v101"); Thu, 05 Aug 2021 16:26:12 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 81311bbabcd5b055 X-CR-MTA-TID: 64aa7808 Received: from 90a29f60986c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 54633D85-5B0F-4A81-BB0C-55FF99FA72ED.1; Thu, 05 Aug 2021 16:26:02 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 90a29f60986c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 05 Aug 2021 16:26:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kc7tQL0aRjzIKwkZ9lxuLyJPi6dXSUpCpv4b3kFF4EnQW93sy6/qAwK83jBzLRS2Jz+OLi6LLPGR9OqvixyPW5SbqWRR/Fg3uI2kfL9QvYkmO7zvwE2WDbQrCVXi9Lb+Njbdb9GESvk0Yh54UJcQtbwy9NJ3MiiNp2SOmXvqeXYpfrM7Ym6xX32swULyQpxP36OdVINmxTNrxlhPEZmsdy/TcbtgN46AFIiKAzytNMJ34iy+Sj9XyRRLV+m8O9h0WKY3F+ROTEWgc3a0Wmqqhs3AVie5RLpzASpRXIBEK45RUr0SBOTFtG6TbeHguI+Wh5Tj+5hDY8yY7j57grdtFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6m/Um4tNbhvE4SOg91+xE1DWBwbkSw+cX9gcSYEKsDI=; b=iZlSa/Yqfl5gHBiGYnOZZ9Nx9/NkGwhsEZXQtv3ersxwnJMufOQwQn04WYjhkweK308vvC4q/B++7xCLUDWvnx5f28bccWhRwP6GtqzRvnOb+EiRPSi5Am9t8BRB1ihTaaMWoHP8eZEAE7M7kFcXCmEFPierQ7/XtFiLOgQ3sqw5gerB2ChaM9MDBNN+x4dqLh1D6JE4pZR/vAWqHo4TZAYtfrx7YhIkGPUK72FKPa+2XmuRjy7mAtdS2jKiWtwTcXdiFOD76E/XHSmbcAmE/bHWcAsaw85sZ2FrZbTJNasIhqO3KRyMqCohNdvwnRXjYi+oKaN8/e1/AbH46eAmOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6m/Um4tNbhvE4SOg91+xE1DWBwbkSw+cX9gcSYEKsDI=; b=ttZPEJ1IkexlpnGHZgq9pUeINnOts8FIFGIr6AjCls4w7fel+j6gEv8yNOZ3OnLMms1o4bSqSxo9m3ffKdqMvYna65wJaTKgfY2slhqK1EI/AvvtuPdZGVvlEcahzBRuBkrWlPI2lpfR7CJNrSrFSHHzedXOOkWnfF9WVfoWRB8= Received: from AM5PR0602CA0007.eurprd06.prod.outlook.com (2603:10a6:203:a3::17) by VI1PR08MB5343.eurprd08.prod.outlook.com (2603:10a6:803:12d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.25; Thu, 5 Aug 2021 16:26:00 +0000 Received: from AM5EUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:a3:cafe::fd) by AM5PR0602CA0007.outlook.office365.com (2603:10a6:203:a3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.16 via Frontend Transport; Thu, 5 Aug 2021 16:26:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT005.mail.protection.outlook.com (10.152.16.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4394.16 via Frontend Transport; Thu, 5 Aug 2021 16:26:00 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Thu, 5 Aug 2021 16:25:34 +0000 Received: from e125153.arm.com (10.57.67.54) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.14 via Frontend Transport; Thu, 5 Aug 2021 16:25:33 +0000 From: "Chris Jones" To: CC: Sami Mujawar , Akanksha Jain , Ben Adderson , Michael Kinney , , , Leif Lindholm , "Matteo Carlini" , Subject: [PATCH v2 13/13] MdePkg: Fix broken coding style in Acpi64.h Date: Thu, 5 Aug 2021 17:25:22 +0100 Message-ID: <20210805162522.13201-14-christopher.jones@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210805162522.13201-1-christopher.jones@arm.com> References: <20210805162522.13201-1-christopher.jones@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 251ad67a-78d5-42d7-0a96-08d9582dbd6c X-MS-TrafficTypeDiagnostic: VI1PR08MB5343:|AM6PR08MB4087: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:4125;OLM:4125; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: vRNG/Xf0fs2yoaf5TxPju604PNQyGr1EPUnpxZ0+EssO9rg5UvGn0bQ/eIAYNlgCSUjRTr5o/hnhhF2zwSzjKP3o/hKsCxZ78OVU4ZDCoDCuYmCfyuBpvzrdPrFSa/f1rzEpQC24vPr9TKxIo3QM6ZQVq00k5Fe2c1lKQijQ9XSZ9VQLUP9jvruftlWbhfWlF+2ogKoaELr8SQRT0eBt2arFOxkT3fN/6qv9RvcKVxLljwSiU3mT+1m8+ij23LRKLhpvytlYzMDGFH4ln1xZ45+Vuj6N9r2TYBeYv/5JAE2j3PGYhL7RtP8F7BUPtgSKBVQmVD9TSF1Th9ODrKMjClAPZjypSNecsn8mkJsxFuS9m6l1AN1nvPCTCKIeLlJkcXpzpSIMpoV1nqYAHIB7QoBPhGGPl/eNrBMmYjBUwcNYzVShzQTk2R19tyaVBdqNcn473ptQ6/O14HSWSG3eOwC3bVXxN7CWOLc/YxYWhSkwY27iiR3gcK4+ZE5sjz+GCkque5CLjotbpZSC4WtqRIas63rn4DwABmzhkH9E0oNg0JYYC/LRYjfFms3YaY/lM2pgqacfp/inFxuYsI7Z2VaU3xXW7MZ2O7mmsIxfcdK4k2aj/mQf3R6yWxsXbj5wF2Y/Sn7b2gPyroXKeEKX0nQuCApL1hIg1bJ8XaZk7N4Trjufi/CKNO4Z+D8kdwrnSlFHXb1KDK9HqOgmPbYZ/JEbdrslUO4k/lBQOvk+R0BM1BEcdNh0Bc9ZltRI3I7rJq1L5kgAw/Xp/JM3nxXvGmNRMsOSGhzV0k8ju8M1nXp31S3Izoyf9pLUg5BhgGoq X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(396003)(39850400004)(136003)(346002)(376002)(36840700001)(46966006)(45080400002)(186003)(70206006)(82740400003)(26005)(82310400003)(336012)(5660300002)(6916009)(81166007)(2616005)(8676002)(19627235002)(70586007)(83380400001)(316002)(478600001)(54906003)(2906002)(7696005)(4326008)(426003)(1076003)(356005)(47076005)(8936002)(86362001)(36756003)(36860700001)(6666004)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5343 Return-Path: Christopher.Jones@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 001263aa-71f6-47a1-3595-08d9582db638 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JwHHoNKSUWPpkGpxv8uxzWpngJ+hh+83dTHvFH018ZZhutuZNx+eJ7VOAqTzvVkCr07aLrD1dV7srrVbJJg8b1ikL5jgF+dHKNl27yc0TCl78J6D+nmXjwXGh3XltmLJ6Y1SAU8Dq3EwKIRU+CvUkbds/bvgCV3D/39heoJpwXLxIqijYIR9+CU0D9hUIeVgx4R+9nNLYsPoksYRXIrenSQDUGno/7C34NVx3EEoRqLYef9jTwlvVra79obB6dNJbsV6GP4hHOO7VLgG6S2ybvX8J9FFgnJ8zOT9jgAWstBmy7HeOe42Kca1lxqw8NVzyoHsCpjvTmWWAqtFr16DQLIghiLKgqYRLb8lTvqaUKc7SdXKtvHV8QmAzVfDUa04+uPv5TyeIPXyJjEA2KHwk1xHrcbH+rSSn4i4lNVgT52Risi/mBJDEM/Ytbz61rr1xKdC3Ad1qPKu3NEH+QkwpI6ME7xrUFraN6A9ZMCY8JsIFe18aVA4wNC3sMfhqq95kb1X/nEEFVlalBtJ1E4QP2u/WirbhmH/8ZgWA7ttOid4KX9uwvvflPMym2X9kjjapCMruoij4+ZYQuLhMKV+c73vOu8L/QBi4LSmEOzhQx1nS6VVmSAthBWzb3HHvAdrIsi/jot0QlKuzSffh7Dp44lNLUbEyo+meRFYAKOmoP4Uuj3I2UnCLijiHbdNk0MpXw0tV7flcUVqk8cUC82TJgTmqFh59jQdx+ykik/Zmaue+f1H38/TYQ2y1b+QKB9iDOYhsIQaBDOFLPmI2M61MtZC3QXHk/VqAQi+T6IRYIA= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(316002)(6916009)(186003)(82310400003)(36860700001)(81166007)(336012)(83380400001)(36756003)(45080400002)(508600001)(47076005)(70586007)(4326008)(54906003)(5660300002)(70206006)(426003)(26005)(8936002)(2906002)(2616005)(1076003)(8676002)(7696005)(6666004)(86362001)(19627235002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2021 16:26:12.4312 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 251ad67a-78d5-42d7-0a96-08d9582dbd6c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4087 Content-Type: text/plain Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516) Fix a coding style issue raised by EccCheck. This issue (error code 7008) has been fixed by moving a nested union out of its structure. Also add Acpi64.h to the "IgnoreFiles" list to stop the CI flagging naming errors present prior to ACPI 64. Signed-off-by: Chris Jones --- Notes: v2: - Remove EFI_ACPI_6_4_GIC_STRUCTURE field name changes. [Liming] - Add Acpi64.h to IgnoreFiles list in MdePkg.ci.yaml. [Liming] MdePkg/Include/IndustryStandard/Acpi64.h | 27 +++++++++++--------- MdePkg/MdePkg.ci.yaml | 2 ++ 2 files changed, 17 insertions(+), 12 deletions(-) diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h b/MdePkg/Include/IndustryStandard/Acpi64.h index c905db93fabb6faa553dd49a9fed886437dd4daf..3a91302f8c0e71d4951d27aac35322073219c836 100644 --- a/MdePkg/Include/IndustryStandard/Acpi64.h +++ b/MdePkg/Include/IndustryStandard/Acpi64.h @@ -788,22 +788,25 @@ typedef struct { } EFI_ACPI_6_4_DEVICE_HANDLE_PCI; /// -/// Generic Initiator Affinity Structure +/// Device Handle /// -typedef struct { - UINT8 Type; - UINT8 Length; - UINT8 Reserved1; - UINT8 DeviceHandleType; - UINT32 ProximityDomain; - - union { +typedef union { EFI_ACPI_6_4_DEVICE_HANDLE_ACPI Acpi; EFI_ACPI_6_4_DEVICE_HANDLE_PCI Pci; - } DeviceHandle; +} EFI_ACPI_6_4_DEVICE_HANDLE; - UINT32 Flags; - UINT8 Reserved2[4]; +/// +/// Generic Initiator Affinity Structure +/// +typedef struct { + UINT8 Type; + UINT8 Length; + UINT8 Reserved1; + UINT8 DeviceHandleType; + UINT32 ProximityDomain; + EFI_ACPI_6_4_DEVICE_HANDLE DeviceHandle; + UINT32 Flags; + UINT8 Reserved2[4]; } EFI_ACPI_6_4_GENERIC_INITIATOR_AFFINITY_STRUCTURE; /// diff --git a/MdePkg/MdePkg.ci.yaml b/MdePkg/MdePkg.ci.yaml index 15931eaccabff7334a8b839c438d4d9a907b4194..98eaea1c824863a89bf2e73b8312fe89881fb3c1 100644 --- a/MdePkg/MdePkg.ci.yaml +++ b/MdePkg/MdePkg.ci.yaml @@ -3,6 +3,7 @@ # # Copyright (c) Microsoft Corporation # Copyright (c) 2020, Intel Corporation. All rights reserved.
+# Copyright (c) 2021, Arm Limited. All rights reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent ## { @@ -19,6 +20,7 @@ ], ## Both file path and directory path are accepted. "IgnoreFiles": [ + "Include/IndustryStandard/Acpi64.h" ] }, ## options defined ci/Plugin/CompilerPlugin -- Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")