public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io
Cc: Chasel Chiu <chasel.chiu@intel.com>,
	Nate DeSimone <nathaniel.l.desimone@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Eric Dong <eric.dong@intel.com>
Subject: [edk2-platforms][PATCH v1 3/4] MinPlatformPkg/AcpiPlatform: Set X_GPE1_BLK GAS structure to zeroes
Date: Thu,  5 Aug 2021 12:38:15 -0400	[thread overview]
Message-ID: <20210805163816.2757-4-mikuback@linux.microsoft.com> (raw)
In-Reply-To: <20210805163816.2757-1-mikuback@linux.microsoft.com>

From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3534

Updates the code to be compatible with a recent Firmware Test Suite
(FWTS) fix that improves adherence to the ACPI Specification.

Relevant FWTS commit:
https://git.launchpad.net/fwts/commit/?
id=4ad3e374bf98931c84adcf6e523982b5ebb83748

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
index 6919e3196143..fe57ec4f7bb7 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
+++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
@@ -1321,7 +1321,8 @@ PlatformUpdateTables (
     FadtHeader->XGpe0Blk.Address    = PcdGet16 (PcdAcpiGpe0BlockAddress);
     FadtHeader->XGpe1Blk.Address    = PcdGet16 (PcdAcpiGpe1BlockAddress);
     if (FadtHeader->XGpe1Blk.Address == 0) {
-      FadtHeader->XGpe1Blk.AccessSize = 0;
+      FadtHeader->XGpe1Blk.AddressSpaceId = 0;
+      FadtHeader->XGpe1Blk.AccessSize     = 0;
     }
 
     DEBUG(( EFI_D_ERROR, "ACPI FADT table @ address 0x%x\n", Table ));
-- 
2.28.0.windows.1


  parent reply	other threads:[~2021-08-05 16:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05 16:38 [edk2-platforms][PATCH v1 0/4] MinPlatformPkg: AcpiPlatform bug fixes and improvements Michael Kubacki
2021-08-05 16:38 ` [edk2-platforms][PATCH v1 1/4] MinPlatformPkg/AcpiPlatform: Use PCD for WSMT OEM revision Michael Kubacki
2021-08-05 16:38 ` [edk2-platforms][PATCH v1 2/4] MinPlatformPkg/AcpiPlatform: Use CreatorId and CreatorRevision in headers Michael Kubacki
2021-08-05 16:38 ` Michael Kubacki [this message]
2021-08-05 16:38 ` [edk2-platforms][PATCH v1 4/4] MinPlatformPkg/AcpiPlatform: Remove unused BoardAcpiTableLib Michael Kubacki
2021-08-20  0:58 ` [edk2-devel] [edk2-platforms][PATCH v1 0/4] MinPlatformPkg: AcpiPlatform bug fixes and improvements Michael D Kinney
2021-09-15  1:39 ` Nate DeSimone
2021-09-15  1:43 ` Nate DeSimone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210805163816.2757-4-mikuback@linux.microsoft.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox