From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: devel@edk2.groups.io, jiewen.yao@intel.com
Cc: marcandre.lureau@redhat.com, lersek@redhat.com,
dick_wilkins@phoenix.com,
Stefan Berger <stefanb@linux.vnet.ibm.com>,
Stefan Berger <stefanb@linux.ibm.com>
Subject: [RFC PATCH 3/7] SecurityPkg/TPM: Disable PcdGetBool (PcdRandomizePlatformHierarchy)
Date: Fri, 6 Aug 2021 11:33:22 -0400 [thread overview]
Message-ID: <20210806153326.990749-4-stefanb@linux.vnet.ibm.com> (raw)
In-Reply-To: <20210806153326.990749-1-stefanb@linux.vnet.ibm.com>
To avoid this type of build errors, disable
'PcdGetBool (PcdRandomizePlatformHierarchy)'.
Building ... /home/stefanb/dev/edk2/SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf [X64]
In file included from /home/stefanb/dev/edk2/Build/OvmfX64/DEBUG_GCC5/X64/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib/DEBUG/AutoGen.h:17,
from <command-line>:
/home/stefanb/dev/edk2/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.c: In function ‘ConfigureTpmPlatformHierarchy’:
/home/stefanb/dev/edk2/MdePkg/Include/Library/PcdLib.h:424:45: error: ‘_PCD_GET_MODE_BOOL_PcdRandomizePlatformHierarchy’ undeclared (first use in this function)
424 | #define PcdGetBool(TokenName) _PCD_GET_MODE_BOOL_##TokenName
| ^~~~~~~~~~~~~~~~~~~
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
---
.../PeiDxeTpmPlatformHierarchyLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.c b/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.c
index 9812ab99ab..bea10d37a4 100644
--- a/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.c
+++ b/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.c
@@ -252,7 +252,7 @@ EFIAPI
ConfigureTpmPlatformHierarchy (
)
{
- if (PcdGetBool (PcdRandomizePlatformHierarchy)) {
+ if (1 /*PcdGetBool (PcdRandomizePlatformHierarchy)*/) {
//
// Send Tpm2HierarchyChange Auth with random value to avoid PlatformAuth being null
//
--
2.31.1
next prev parent reply other threads:[~2021-08-06 15:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 15:33 [RFC PATCH 0/7] OVMF: Disable the TPM2 platform hierarchy Stefan Berger
2021-08-06 15:33 ` [RFC PATCH 1/7] SecurityPkg/TPM: Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms Stefan Berger
2021-08-06 15:33 ` [RFC PATCH 2/7] SecruityPkg/TPM: Disable dependency on MinPlatformPkg Stefan Berger
2021-08-06 15:33 ` Stefan Berger [this message]
2021-08-07 5:38 ` [RFC PATCH 3/7] SecurityPkg/TPM: Disable PcdGetBool (PcdRandomizePlatformHierarchy) Yao, Jiewen
2021-08-06 15:33 ` [RFC PATCH 4/7] SecurityPkg/TPM: Disable a Pcd Stefan Berger
2021-08-06 15:33 ` [RFC PATCH 5/7] SecurityPkg/TPM: Add a NULL implementation of PeiDxeTpmPlatformHierarchyLib Stefan Berger
2021-08-06 15:33 ` [RFC PATCH 6/7] OVMF: Reference new classes in the build system for compilation Stefan Berger
2021-08-06 15:33 ` [RFC PATCH 7/7] OVMF: Disable the TPM2 platform hierarchy Stefan Berger
2021-08-07 6:00 ` [RFC PATCH 0/7] " Yao, Jiewen
2021-08-07 10:22 ` [edk2-devel] " Marvin Häuser
2021-08-08 0:31 ` Yao, Jiewen
2021-08-07 15:03 ` Stefan Berger
2021-08-08 0:54 ` Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210806153326.990749-4-stefanb@linux.vnet.ibm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox