From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.158.5]) by mx.groups.io with SMTP id smtpd.web11.6474.1628264093431102181 for ; Fri, 06 Aug 2021 08:34:53 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ibm.com header.s=pp1 header.b=SbRFsuoT; spf=none, err=permanent DNS error (domain: linux.vnet.ibm.com, ip: 148.163.158.5, mailfrom: stefanb@linux.vnet.ibm.com) Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 176FYBt1015531; Fri, 6 Aug 2021 11:34:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=pp1; bh=nSHVnVOrWCEB3GdWi1ANs/xNOsUUxo3Y4bFPJ/gP27Q=; b=SbRFsuoTZtDowcbDgvCoKNXUmnhb78iqPgDP+1myxPK1QGtWhD9x4lgREeaqWzKUT2OS SioNr4U2T12F4dZEDg8J+/k0G1DuY8OK+8nR5RCoo4umJMfr4kwUWOsglk+VYh70yfkO NVuUgEp+ivCylX3QkyiD/kGEZB//0R/mo56dg1BFnX8hdeNvt9+amNqRjHo7BldYAXrx p5mExd40X/q0Xnc5lBXsODVXHDYIJGtYZLVwPxtLiOWTuEAqUJFuG4WRWIhZlbehLFNV vsBbwWRwnKDW/vOm4tftKnz7joXFTbRDiT/aWQQ6/Bjsj56McuS7vyr+AxsLX2JmcSwy uQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 3a89prvcs5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 06 Aug 2021 11:34:52 -0400 Received: from m0098413.ppops.net (m0098413.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 176FYWdA017074; Fri, 6 Aug 2021 11:34:51 -0400 Received: from ppma05wdc.us.ibm.com (1b.90.2fa9.ip4.static.sl-reverse.com [169.47.144.27]) by mx0b-001b2d01.pphosted.com with ESMTP id 3a89prvcrm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 06 Aug 2021 11:34:51 -0400 Received: from pps.filterd (ppma05wdc.us.ibm.com [127.0.0.1]) by ppma05wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 176FOVd2010564; Fri, 6 Aug 2021 15:34:51 GMT Received: from b03cxnp08027.gho.boulder.ibm.com (b03cxnp08027.gho.boulder.ibm.com [9.17.130.19]) by ppma05wdc.us.ibm.com with ESMTP id 3a8mq9v69a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 06 Aug 2021 15:34:50 +0000 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 176FXnPw13762890 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 6 Aug 2021 15:33:49 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9565CBE059; Fri, 6 Aug 2021 15:33:49 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 25785BE054; Fri, 6 Aug 2021 15:33:49 +0000 (GMT) Received: from sbct-2.. (unknown [9.47.158.152]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP; Fri, 6 Aug 2021 15:33:49 +0000 (GMT) From: Stefan Berger To: devel@edk2.groups.io, jiewen.yao@intel.com Cc: marcandre.lureau@redhat.com, lersek@redhat.com, dick_wilkins@phoenix.com, Stefan Berger , Stefan Berger Subject: [RFC PATCH 3/7] SecurityPkg/TPM: Disable PcdGetBool (PcdRandomizePlatformHierarchy) Date: Fri, 6 Aug 2021 11:33:22 -0400 Message-Id: <20210806153326.990749-4-stefanb@linux.vnet.ibm.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210806153326.990749-1-stefanb@linux.vnet.ibm.com> References: <20210806153326.990749-1-stefanb@linux.vnet.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: d0YbCn_FzLpOoNx3PZpYsSBxrqAEOGeh X-Proofpoint-ORIG-GUID: UeuIdX-1OyP60zs7XIIstxUOf_glenR6 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-08-06_05:2021-08-05,2021-08-06 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 adultscore=0 mlxlogscore=999 impostorscore=0 lowpriorityscore=0 clxscore=1015 mlxscore=0 spamscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2108060107 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable To avoid this type of build errors, disable 'PcdGetBool (PcdRandomizePlatformHierarchy)'. Building ... /home/stefanb/dev/edk2/SecurityPkg/Library/SecureBootVariableP= rovisionLib/SecureBootVariableProvisionLib.inf [X64] In file included from /home/stefanb/dev/edk2/Build/OvmfX64/DEBUG_GCC5/X64/S= ecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchy= Lib/DEBUG/AutoGen.h:17, from : /home/stefanb/dev/edk2/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib/Pe= iDxeTpmPlatformHierarchyLib.c: In function =E2=80=98ConfigureTpmPlatformHie= rarchy=E2=80=99: /home/stefanb/dev/edk2/MdePkg/Include/Library/PcdLib.h:424:45: error: =E2= =80=98_PCD_GET_MODE_BOOL_PcdRandomizePlatformHierarchy=E2=80=99 undeclared = (first use in this function) 424 | #define PcdGetBool(TokenName) _PCD_GET_MODE_BOOL_##To= kenName | ^~~~~~~~~~~~~~~~~~~ Signed-off-by: Stefan Berger --- .../PeiDxeTpmPlatformHierarchyLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPla= tformHierarchyLib.c b/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib/Pei= DxeTpmPlatformHierarchyLib.c index 9812ab99ab..bea10d37a4 100644 --- a/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHi= erarchyLib.c +++ b/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHi= erarchyLib.c @@ -252,7 +252,7 @@ EFIAPI ConfigureTpmPlatformHierarchy (=0D )=0D {=0D - if (PcdGetBool (PcdRandomizePlatformHierarchy)) {=0D + if (1 /*PcdGetBool (PcdRandomizePlatformHierarchy)*/) {=0D //=0D // Send Tpm2HierarchyChange Auth with random value to avoid PlatformAu= th being null=0D //=0D --=20 2.31.1