public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] [edk2-staging] BaseTools/FMMT: Change Fv Header to FileSystemGuid3.
@ 2021-08-14  8:03 Bob Feng
  0 siblings, 0 replies; only message in thread
From: Bob Feng @ 2021-08-14  8:03 UTC (permalink / raw)
  To: devel; +Cc: Yuwei Chen, Liming Gao

From: Yuwei Chen <yuwei.chen@intel.com>

From: Yuwei Chen <yuwei.chen@intel.com>

Following PI spec: when there has Ffs with EFI_FFS_FILE_HEADER2,
the Parent Fv of the Ffs need set to FileSystemGuid3; when all
the Ffs with EFI_FFS_FILE_HEADER, the Parent Fv of the Ffs need
set to FileSystemGuid2.
Currently, when changing the Ffs in Fv from EFI_FFS_FILE_HEADER
to EFI_FFS_FILE_HEADER2, the Fv FileSystemGuid does not changed
consistent with Ffs type.That caused build issue.

As FileSystemGuid3 is compatible with FileSystemGuid2, change all
the Fv header to FileSystemGuid3. This patch modify the FMMT Add/
Replace function, when adding/replacing a new Ffs, set the Parent
Fv header to FileSystemGuid3 directly, do not double check size.

Signed-off-by: Yuwei Chen <yuwei.chen@intel.com>
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
---
 BaseTools/Source/C/FMMT/FmmtLib.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/BaseTools/Source/C/FMMT/FmmtLib.c b/BaseTools/Source/C/FMMT/FmmtLib.c
index 4f6056edba..e1436112ca 100644
--- a/BaseTools/Source/C/FMMT/FmmtLib.c
+++ b/BaseTools/Source/C/FMMT/FmmtLib.c
@@ -3198,11 +3198,7 @@ LibEncapsulateFfsToFv (
 
   CHAR8*                 SystemCommandFormatString;
   CHAR8*                 SystemCommand;
-  CHAR8*                 FfsGuid = "8c8ce578-8a3d-4f1c-9935-896185c32dd3";
-
-  if (IsLargeFile == TRUE) {
-    FfsGuid = "5473c07a-3dcb-4dca-bd6f-1e9689e7349a";
-  }
+  CHAR8*                 FfsGuid = "5473c07a-3dcb-4dca-bd6f-1e9689e7349a";
 
   SystemCommandFormatString = NULL;
   SystemCommand             = NULL;
-- 
2.27.0.windows.1
GitPatchExtractor 1.1

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2021-08-14  8:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-14  8:03 [PATCH] [edk2-staging] BaseTools/FMMT: Change Fv Header to FileSystemGuid3 Bob Feng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox