public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, brijesh.singh@amd.com
Cc: Min Xu <min.m.xu@intel.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [edk2-devel] [PATCH V4 3/3] OvmfPkg/ResetVector: Enable Intel TDX in ResetVector of Ovmf
Date: Mon, 16 Aug 2021 11:34:25 +0200	[thread overview]
Message-ID: <20210816093425.fa4wnoqqwjvxgan7@sirius.home.kraxel.org> (raw)
In-Reply-To: <7e431397-1478-e511-fbe8-ba530065de9e@amd.com>

  Hi,
 
> This patch need to be broken into multiple sub patches for the easy to
> review and keeping the code bisectable. The first thing we need to do is
> introduce the new CCWorkArea concept and update the existing Sev support to
> use the new CCWorkArea.

Fully agree.  Also moving around code without functional change (i.e.
move the SEV bits to a new asm file) should go to a separate patch(es).
That way the patches actually adding new functionality are smaller and
easier to review.

thanks,
  Gerd


  reply	other threads:[~2021-08-16 10:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-03  1:18 [PATCH V4 0/3] Add Intel TDX support in OvmfPkg/ResetVector Min Xu
2021-08-03  1:18 ` [PATCH V4 1/3] OvmfPkg: Add Tdx BFV/CFV PCDs and PcdOvmfImageSizeInKb Min Xu
2021-08-04  9:25   ` Erdem Aktas
2021-08-03  1:18 ` [PATCH V4 2/3] OvmfPkg/Sec: Update the check logic in SevEsIsEnabled Min Xu
2021-08-03 19:23   ` Brijesh Singh
2021-08-03 23:54     ` Min Xu
2021-08-03  1:18 ` [PATCH V4 3/3] OvmfPkg/ResetVector: Enable Intel TDX in ResetVector of Ovmf Min Xu
2021-08-03 19:30   ` Brijesh Singh
2021-08-16  9:34     ` Gerd Hoffmann [this message]
2021-08-04 10:01   ` Erdem Aktas
2021-08-04 12:50     ` Min Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210816093425.fa4wnoqqwjvxgan7@sirius.home.kraxel.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox