From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web10.22069.1629108832737880897
 for <devel@edk2.groups.io>;
 Mon, 16 Aug 2021 03:13:53 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=E2uAeQl7;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1629108831;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=0ru3RMP0kCoflDHS8CHpao+TkfwnTP8qImeGhehD3c0=;
	b=E2uAeQl7DEp52KgTMgi04tuWV0DevIafNlILWE1wo8sFZPL4S7bjhqFl5Jz3L0nqAnkfoL
	i5jnRmMuxOb0HZ8zZYbu1PLEAzEj+G8bp28lQcFgvdVWJRmMGvCr/XuPf1tNoLx9t4AYg8
	t8kwy2x37k0mYK3LmvlTn/rDhNBobQY=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-551-deDQGLZoPdu9kQOyMBJy1Q-1; Mon, 16 Aug 2021 06:13:48 -0400
X-MC-Unique: deDQGLZoPdu9kQOyMBJy1Q-1
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E3C7A1008060;
	Mon, 16 Aug 2021 10:13:46 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.193.216])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 9043C5FC23;
	Mon, 16 Aug 2021 10:13:46 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 1F40518007AE; Mon, 16 Aug 2021 11:34:25 +0200 (CEST)
Date: Mon, 16 Aug 2021 11:34:25 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, brijesh.singh@amd.com
Cc: Min Xu <min.m.xu@intel.com>, Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [edk2-devel] [PATCH V4 3/3] OvmfPkg/ResetVector: Enable Intel TDX in ResetVector of Ovmf
Message-ID: <20210816093425.fa4wnoqqwjvxgan7@sirius.home.kraxel.org>
References: <cover.1627951562.git.min.m.xu@intel.com>
 <7c60ce224e671dbca27f6dcc6c04e33ecd32ab33.1627951562.git.min.m.xu@intel.com>
 <7e431397-1478-e511-fbe8-ba530065de9e@amd.com>
MIME-Version: 1.0
In-Reply-To: <7e431397-1478-e511-fbe8-ba530065de9e@amd.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,
 
> This patch need to be broken into multiple sub patches for the easy to
> review and keeping the code bisectable. The first thing we need to do is
> introduce the new CCWorkArea concept and update the existing Sev support to
> use the new CCWorkArea.

Fully agree.  Also moving around code without functional change (i.e.
move the SEV bits to a new asm file) should go to a separate patch(es).
That way the patches actually adding new functionality are smaller and
easier to review.

thanks,
  Gerd