From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web09.21929.1629107933211966271
 for <devel@edk2.groups.io>;
 Mon, 16 Aug 2021 02:58:53 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SNXuIIiL;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1629107932;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=Cjdn4I+fAYDiTAP160Is7oVz/2ULl+8JMeLyi3qT6Fc=;
	b=SNXuIIiLeudOH7MaBjN8F2Xu7WgonlrlNOsxubn0rh2LR14j/Fgy3+uvyhRWpkW/zI9zWz
	7WvcGjNhOsPpofEXcsEO2gxVrfa1iruk95XUeSz5YXrrzA63ICBpi9demeGrLAjekXWrMK
	X1VzwSR6CBK7IJwN2d8xkF16iGPrIEU=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-197-5pyoASCLP--CI2ySCNgksw-1; Mon, 16 Aug 2021 05:58:48 -0400
X-MC-Unique: 5pyoASCLP--CI2ySCNgksw-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9B71C107ACF5;
	Mon, 16 Aug 2021 09:58:46 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.193.216])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 0F89366FFF;
	Mon, 16 Aug 2021 09:58:46 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 42D141800906; Mon, 16 Aug 2021 11:43:01 +0200 (CEST)
Date: Mon, 16 Aug 2021 11:43:01 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, min.m.xu@intel.com
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Zhiguang Liu <zhiguang.liu@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [edk2-devel] [PATCH 05/23] MdePkg: Add TdxProbeLib to probe Intel Tdx
Message-ID: <20210816094301.2h3e4d747ig6eyrm@sirius.home.kraxel.org>
References: <cover.1628767741.git.min.m.xu@intel.com>
 <c574d1e106a9b10d99b0d294891a32ee2b0c414a.1628767741.git.min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <c574d1e106a9b10d99b0d294891a32ee2b0c414a.1628767741.git.min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

> +++ b/MdePkg/Library/TdxProbeLib/X64/TdProbe.nasm

Any specific reason why you code up your own instead of using the
existing cpuid functions in BaseLib ?

take care,
  Gerd