From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web11.36096.1629188439829774990
 for <devel@edk2.groups.io>;
 Tue, 17 Aug 2021 01:20:40 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=K6lYtyTT;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1629188438;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=XEr4W0WOd6/QSV3mJ2n9H3LfQ171HjAs9Zu9vPWDQs4=;
	b=K6lYtyTTaD3PUppqBxE/V/ZWkLATOqIM7W9QEyNXxbr1JOFbpyUBXaSfWQ6GehqIyMqjgw
	pUIGgJkn5BAHg2/OrsnHSSsNe1cC60TBRYyhhoFVfcGsHifW8jAM6e26Y+O+QhTa8YfdmE
	hgmoN2u8daadgcR8W8OiTSjYOflvKqU=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-354-QRM0_OaYN2OpfqXI6FfiVw-1; Tue, 17 Aug 2021 04:20:35 -0400
X-MC-Unique: QRM0_OaYN2OpfqXI6FfiVw-1
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8FDDDC73A3;
	Tue, 17 Aug 2021 08:20:33 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.193.216])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 949665C1D5;
	Tue, 17 Aug 2021 08:20:32 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 0234D1800385; Tue, 17 Aug 2021 10:20:30 +0200 (CEST)
Date: Tue, 17 Aug 2021 10:20:30 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, min.m.xu@intel.com
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	"Liu, Zhiguang" <zhiguang.liu@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	"Yao, Jiewen" <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [edk2-devel] [PATCH 05/23] MdePkg: Add TdxProbeLib to probe Intel Tdx
Message-ID: <20210817082030.gu5ae7sjjdyyawi5@sirius.home.kraxel.org>
References: <cover.1628767741.git.min.m.xu@intel.com>
 <c574d1e106a9b10d99b0d294891a32ee2b0c414a.1628767741.git.min.m.xu@intel.com>
 <20210816094301.2h3e4d747ig6eyrm@sirius.home.kraxel.org>
 <PH0PR11MB5064B3E8179B8BC37527AA99C5FE9@PH0PR11MB5064.namprd11.prod.outlook.com>
MIME-Version: 1.0
In-Reply-To: <PH0PR11MB5064B3E8179B8BC37527AA99C5FE9@PH0PR11MB5064.namprd11.prod.outlook.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Aug 17, 2021 at 12:14:44AM +0000, Min Xu wrote:
> On Monday, August 16, 2021 5:43 PM, Gerd Hoffmann wrote:
> > > +++ b/MdePkg/Library/TdxProbeLib/X64/TdProbe.nasm
> > 
> > Any specific reason why you code up your own instead of using the existing
> > cpuid functions in BaseLib ?
> Actually there is no specific reason. I am not sure if AsmCpuid is a preferred way
> in this situation?

I'm pretty sure it is preferred over duplicating code.

Early setup code (before stack setup where you can't do calls)
is a different story.

Also: Why there are separate TdxProbeLib + TdxLib libs?

take care,
  Gerd