From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web11.36336.1629190706396096979
 for <devel@edk2.groups.io>;
 Tue, 17 Aug 2021 01:58:26 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=EXhwYO0Z;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1629190705;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=8EwjeAwPDHGDrSazM1+uyYJkfu0HoAhVN8CKZDqHy10=;
	b=EXhwYO0ZY4qdND+cFLkH7zMJSazw1j+aNEOajoBLoe3rFzOobnAN1N7kIKi53hQ9I7stEj
	/NVuwVb/PaU/FWhcWD8jkbjgpkB9n5/mERTz6MGjZnLLRLeJ0OzLJ+whIr9tJBvrp275xh
	HZHydl+fZBYJinD35NQ2cK1VDM8IwE8=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-531-IqIYAFoaN5SHN9tbl0wDBg-1; Tue, 17 Aug 2021 04:58:22 -0400
X-MC-Unique: IqIYAFoaN5SHN9tbl0wDBg-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 91F74106B779;
	Tue, 17 Aug 2021 08:58:16 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.193.216])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 0FD303A47;
	Tue, 17 Aug 2021 08:58:16 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 6CF881800385; Tue, 17 Aug 2021 10:58:14 +0200 (CEST)
Date: Tue, 17 Aug 2021 10:58:14 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Xu, Min M" <min.m.xu@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	"Liu, Zhiguang" <zhiguang.liu@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	"Yao, Jiewen" <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [edk2-devel] [PATCH 05/23] MdePkg: Add TdxProbeLib to probe Intel Tdx
Message-ID: <20210817085814.pn4t7bcdsh4dqjgs@sirius.home.kraxel.org>
References: <cover.1628767741.git.min.m.xu@intel.com>
 <c574d1e106a9b10d99b0d294891a32ee2b0c414a.1628767741.git.min.m.xu@intel.com>
 <20210816094301.2h3e4d747ig6eyrm@sirius.home.kraxel.org>
 <PH0PR11MB5064B3E8179B8BC37527AA99C5FE9@PH0PR11MB5064.namprd11.prod.outlook.com>
 <20210817082030.gu5ae7sjjdyyawi5@sirius.home.kraxel.org>
 <PH0PR11MB5064D48F97036AA217B7DD6AC5FE9@PH0PR11MB5064.namprd11.prod.outlook.com>
MIME-Version: 1.0
In-Reply-To: <PH0PR11MB5064D48F97036AA217B7DD6AC5FE9@PH0PR11MB5064.namprd11.prod.outlook.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> > Also: Why there are separate TdxProbeLib + TdxLib libs?
> This is because TdxLib wrap the operations of TdCall and TdVmcall. While TdxProbeLib
> is a library to probe (call CPUID(0x21)) if it is td guest or not. I am open to merge these 2
> libs into one if the community think it is a right way.

My expectation is that you would need either none (build without tdx
support) or both (build with tdx support).  If that is correct I don't
see the point in splitting this into two libs.

take care,
  Gerd