From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.54]) by mx.groups.io with SMTP id smtpd.web09.39334.1629208030070082466 for ; Tue, 17 Aug 2021 06:47:10 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amd.com header.s=selector1 header.b=ih+e2Xsv; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.243.54, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jRACe2AnikcuqF/67cOOpQvU3fBmIBZZONqXQQHMgbdzXS3SV/pFhtzml5H/kvYrQqQ/Hz7Ms8r+ACixCxxVdVfWA8WYHNv3e3v7idAEQKb2Ghn7GT8RxUvZb46+Pr9foOpPPs8rSbMdtxV367/ZiK7pR9MiMXIhKdhXUDRQHWROD/ErxOTQUFSmTy7DzyD2Yo0f1atFdjz9fq/39PSrxGsUbzjgr9f7JuS1fnfxgBrvuNKS7zqGKOG5C0OxmnfgKlFpQnFpMVh+9PvQjpqO5cnC97c5gp+PYAtKMzqbd8ksdg6DWqlycHegR8v8z1L/fNKA1SBfJqVnFdzMaIlF+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8w+CHyTSUl+fCqZ6qjRSVpmyyCHis0uY9FjtsgcAuIo=; b=mZwQ1v2kRM6BgXMSIyAhzjyrV9O80CuG5Q4dkIHyDGmYy4eBMElBMf2ZKVWl/yukKzDRoc/GERoM+3LRjMwGp9GA3aZeJZZGB86rrF6HPZLM8cdTXJkuu4XVOGvRPj4OaHkWVYOFAhKRf3pss0eHyu2S61KGr7Nslm1Mywdurmtzm59dK+aWLeuLqaDi/sDdMNdwJAOKtaVdFERS3m57/nI62HiCKDhQGW+b+SlLsByppOX8tpq1il6ce2qyWaY6f+dENk6YoISdr7mDXHqrKMBHCh68kBbnTUbTEZykecBLaPviXT/t9fph7WHarwa1CMs11PM8J5wWqRsdJWLx6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8w+CHyTSUl+fCqZ6qjRSVpmyyCHis0uY9FjtsgcAuIo=; b=ih+e2XsveFJI/Nuk6U4+nEeY/JCXtK5RGAtinPWQGg+GK2WS0ZV+PpSHvI0M9ygcMo+NZIbzeAX7BBRP4V4plLXrhWVdZEkoOMec+DHBLxfAbgmtUOzV91dK99viVharIC15iA4V0VioYW4NZhxUbyxlvyUxtS7nJFnyxdGrHB8= Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=amd.com; Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SN1PR12MB2541.namprd12.prod.outlook.com (2603:10b6:802:24::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.18; Tue, 17 Aug 2021 13:47:07 +0000 Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::78b7:7336:d363:9be3]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::78b7:7336:d363:9be3%6]) with mapi id 15.20.4415.024; Tue, 17 Aug 2021 13:47:07 +0000 From: "Brijesh Singh" To: devel@edk2.groups.io CC: James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Erdem Aktas , Michael Roth , Brijesh Singh Subject: [PATCH v3 0/3] reuse the SevEsWork area Date: Tue, 17 Aug 2021 08:46:48 -0500 Message-ID: <20210817134651.20444-1-brijesh.singh@amd.com> X-Mailer: git-send-email 2.17.1 X-ClientProxiedBy: SA0PR11CA0165.namprd11.prod.outlook.com (2603:10b6:806:1bb::20) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) Return-Path: brijesh.singh@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sbrijesh-desktop.amd.com (165.204.77.1) by SA0PR11CA0165.namprd11.prod.outlook.com (2603:10b6:806:1bb::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.16 via Frontend Transport; Tue, 17 Aug 2021 13:47:06 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: baf071ee-ca02-4161-4d83-08d9618580fc X-MS-TrafficTypeDiagnostic: SN1PR12MB2541: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xBJTLJsX/a6I1rwyNSbV7my69uVCMUgq2acjAtDosDRnqlC99yJAU3BWwLOYtI0oDn0CK/qOFwtQjdlj6N4Vps4QAwK0j2bMxXhRXcWtudbpx/vDEXITDs2xulUF42Gjon169wBIYPGA5SV0I+Sr6hV3Jje1F3YcJeEFoU3M0YhBjD911RT6V3ZYUuaW8ZqsG9/VYcfCZfeteHjYHtKYxOVlgnPjSkGlJG+4FjpDevZ95g5N0oBtCenQHTZF5wXzTiuaVCuQduTG3nHPpqKq3rK1iCWATiSWsGnfuCUsQgr+aKrAbajcm6I+PyF9PmZnzdMOmB6rMesmRGzj0ij73UsVBNztnnZjh9nAr1BejU9ds+V67MeJKeG5iYPSYDFmpWEP3jjq2f00vZaupVZX5+07LVhTPdtGGdTjp3LstT2/XK/NclLDrXf7+jFGth0s33LeDftcPObvol8J8h3iVpWfFgDvgeFmRbmMFn1B2p6rSRP01pBSEVJ82epg5Q6YqNKC3d164PBix5U6XRPjLzs5mG4Vcwz0xS6WZWOGliwTE/ER25aS6c9MFklRdeY5c6WjqAdOgsERSxIYPrsNsel+er7qHvSe4DKczhoTGW6Wt7+PZDx/iR4Tuf47k0QYo3U4eYN0SrTu79UZfZlqzg+tKdYHDrhcJgc4O+rfGDjuuTfSP3TimYU12hLHAaIuiGVsLw6rXzeKAJi9a7EqOmxMmzT6DzSB9OOK6y5KuT7x0tHNzjuek/QMcK9emRikPZ4ndnOPsq+1LcYmByd8UArIq4SBTc2DYaPmLaFELNo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2718.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(376002)(396003)(346002)(136003)(39860400002)(366004)(316002)(52116002)(7696005)(8936002)(66556008)(4326008)(186003)(83380400001)(86362001)(19627235002)(66476007)(966005)(6486002)(2616005)(8676002)(478600001)(54906003)(956004)(66946007)(6666004)(5660300002)(44832011)(26005)(1076003)(38100700002)(38350700002)(6916009)(36756003)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2WMUId6Mgyf4TV0zrNyYjR8kMAWYnIhUcTN28saP7szmM1Gjl+Hg+ejF6Hmo?= =?us-ascii?Q?SA7qG7hRNyTA9PYC5/C9EvdejXgjLStpeuGBhFzztfz34vKfzCXKt/8KRiQu?= =?us-ascii?Q?yqV5ZYw1heGqimOaTz78/7olRpOje13EVy44MxBXM5JHs5J7qAAl5p+KJJMy?= =?us-ascii?Q?BV5JmvCzXx1BwupPlOoDcstN0hjJ8cWiAC+HzkUR2n8J1IRcKsX7oDweidfc?= =?us-ascii?Q?RhCeUEG34VBS9Cia1xTHHhGVS3K2gks0XrkaNTZyvgHdGtA2e15TsGSSvKNd?= =?us-ascii?Q?E1VN67A0xqvMRABl9kG8L8F0Q7P8z+IlKVp0abcyg3zp36Fj5DdEtsYl4q9E?= =?us-ascii?Q?R/CesPJzJ2TTEBmvIER9iUqQ+53MmuUceKDiJUfl8YSyG6l9WfrYmqEfZJB7?= =?us-ascii?Q?JGuKCfC0WP6VATn0EP2wN6zlok2QR1jtjKlPjDLKdI8R4iy03BCBRvAm/Mkt?= =?us-ascii?Q?0ePekaYytpLBTZQPND3wAbqebPL/IB/8utt1blDWF4AaShBV972IoqwT0DJD?= =?us-ascii?Q?It2bukMSrtJmSktAALvtaRzCwwHtJ6SWTQXlRimFuQl/iSh2v5e1qOQiNF0j?= =?us-ascii?Q?JTQabzAP9GM2Gv+U29ZWC8UN413JIFBWNYNM2RnQ4+mjyhWJo5Y3FVBUbocS?= =?us-ascii?Q?xzgNV0MUZBktqO+l9fmetSWva/z7ohD7WJV1R1shQzzHx/zfGDtp0aMy0Ay5?= =?us-ascii?Q?5516CS6IrXQ9kl7t44Y2WxoxWwPIGSZ7K6A4KQ63fcgJ0reaG0vZqeLCI/Ur?= =?us-ascii?Q?mRcanu/HIdumiO0P5DCeMOohCtj+2bsd7TGXY4YowtbThn7W8N6H9VQm9Voy?= =?us-ascii?Q?K5zNniM+y1KHc/X1X+VW0U3dsBWIobrR4PAp91hLWEY5+ZSyIBdhwswaGXQD?= =?us-ascii?Q?fKngahBiuqoTZ9m6tsKSKpu6Yvve0+LGaxWdtcGmNXo6lNoQdbPF+1saKBup?= =?us-ascii?Q?1c4Kj07T0yTyYvSDkbvCJi4VvdZERNAZh252JXTb245DW2psMR7TcSxg8t+H?= =?us-ascii?Q?wfbnBxrzD8elTKKZDG43KYGKCxnNGCzjaiaTJgHngaeM6Ta2sy7mjL0UF3hO?= =?us-ascii?Q?qDIXekQbun2dZMlh6dIe42aEtf9jBoIOQIuW+EoOOdi04TAjUSDAvf+FtQSp?= =?us-ascii?Q?S2BrQcN1c562XGC508ods6p+SeJPXS5jJONAm4yQOUDrgshguqTO55fTzh47?= =?us-ascii?Q?DNzZpFaJsL9GG9eH8tHG5oZNRN0Lc1zoPNPydxdamPf55eb4ZUxfAbLdlnUQ?= =?us-ascii?Q?mXgMnpqvPN48JQEq+1Cm2erKBFEBcnluRFGM6zGk21NAG1zeaF9P2T9ZL1zs?= =?us-ascii?Q?4Y29xToSXP7vO7YJkKGEyRz2?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: baf071ee-ca02-4161-4d83-08d9618580fc X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2021 13:47:07.4197 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4CVdB+mxSikkczFBDnEj0s0s6GkExH4/BYOI3+52AiXY6DqeJnhP2sgvT4vF8U87eVkREz8TMzBOhPLJVlWSfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2541 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain Based on the discussion on the mailing list, we agreed that instead of wasting extra page in the MEMFD, we can reuse the SevEsWorkArea buffer for the TDX. To avoid any confusion, lets introduce a OvmfWorkArea that will contains 32 bytes of header followed by the actual workarea. While at it, move the code to clear the GHCB page from PageTable build to AmdSev.asm. I have used the existing TDX BZ for it because the request came during the TDX patch review. if anyone have concern please let me know and I will happily create a new BZ. Full tree is at: https://github.com/AMDESE/ovmf/tree/sev-new-work-area Brijesh Singh (3): OvmfPkg: introduce a common work area OvmfPkg/ResetVector: update SEV support to use new work area format OvmfPkg/ResetVector: move the GHCB page setup in AmdSev.asm Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Erdem Aktas Changes since v2: - address Tom's feedback Changes since v1: - address Jiewen's feedback. Brijesh Singh (3): OvmfPkg: introduce a common work area OvmfPkg/ResetVector: update SEV support to use new work area format OvmfPkg/ResetVector: move the GHCB page setup in AmdSev.asm OvmfPkg/OvmfPkg.dec | 12 +++ OvmfPkg/OvmfPkgX64.fdf | 9 +- OvmfPkg/PlatformPei/PlatformPei.inf | 4 +- OvmfPkg/ResetVector/ResetVector.inf | 1 + OvmfPkg/Sec/SecMain.inf | 2 + OvmfPkg/Include/Library/MemEncryptSevLib.h | 21 +--- OvmfPkg/Include/WorkArea.h | 67 +++++++++++++ OvmfPkg/PlatformPei/MemDetect.c | 8 +- OvmfPkg/Sec/SecMain.c | 36 ++++++- OvmfPkg/OvmfPkgDefines.fdf.inc | 6 ++ OvmfPkg/ResetVector/Ia32/AmdSev.asm | 109 +++++++++++++++++---- OvmfPkg/ResetVector/Ia32/PageTables64.asm | 57 +++-------- OvmfPkg/ResetVector/ResetVector.nasmb | 1 + 13 files changed, 238 insertions(+), 95 deletions(-) create mode 100644 OvmfPkg/Include/WorkArea.h --=20 2.17.1