public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: devel@edk2.groups.io
Cc: Rebecca Cran <rebecca@nuviainc.com>
Subject: [edk2-libc Patch 9/9] AppPkg/Applications/Python/Python-2.7.10: Update INF lib classes
Date: Tue, 17 Aug 2021 22:42:06 -0700	[thread overview]
Message-ID: <20210818054206.1223-10-michael.d.kinney@intel.com> (raw)
In-Reply-To: <20210818054206.1223-1-michael.d.kinney@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549

Add BsdSocketLib and EfiSocketLib to [LibraryClasses] section
of Python-2.7.10.inf.  Even if sockets are disabled in Python
config, with the /WHOLEARCHIVE linker option, there are still
references to the socket related functions.  Add these lib
classes so the link can pass for both sockets enabled and sockets
disabled builds.

Cc: Rebecca Cran <rebecca@nuviainc.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 AppPkg/Applications/Python/Python-2.7.10/Python2710.inf | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/AppPkg/Applications/Python/Python-2.7.10/Python2710.inf b/AppPkg/Applications/Python/Python-2.7.10/Python2710.inf
index 2675630..ccf0c60 100644
--- a/AppPkg/Applications/Python/Python-2.7.10/Python2710.inf
+++ b/AppPkg/Applications/Python/Python-2.7.10/Python2710.inf
@@ -43,11 +43,8 @@
   LibGen
   LibNetUtil
   DevMedia
-  #
-# Comment out the following two library classes if socket support is
-# NOT being built in to Python.
-  #BsdSocketLib
-  #EfiSocketLib
+  BsdSocketLib
+  EfiSocketLib
 
 [FixedPcd]
   gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x0F
-- 
2.32.0.windows.1


  parent reply	other threads:[~2021-08-18  5:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-18  5:41 [edk2-libc Patch 0/9] Update for edk2/master and VS2017/VS2019 Michael D Kinney
2021-08-18  5:41 ` [edk2-libc Patch 1/9] StdLib: Add /Wv:11 to VS2017/VS2019 CC_FLAGS Michael D Kinney
2021-08-18  5:41 ` [edk2-libc Patch 2/9] StdLib: Add MdeLibs.dsc.inc to StdLib.dsc Michael D Kinney
2021-08-18  5:42 ` [edk2-libc Patch 3/9] StdLib: Remove SocketDxe from build Michael D Kinney
2021-08-18 18:31   ` Rebecca Cran
2021-08-18 19:00     ` [edk2-devel] " Michael D Kinney
2021-08-18  5:42 ` [edk2-libc Patch 4/9] StdLib/LibC/gdtoa: Remove source file with unused ldtoa() function Michael D Kinney
2021-08-18  5:42 ` [edk2-libc Patch 5/9] StdLib/BsdSocketLib: Add missing LibNetUtil dependency to INF Michael D Kinney
2021-08-18  5:42 ` [edk2-libc Patch 6/9] StdLib/BsdSocketLib: Add /wd4706 to CC_FLAGS Michael D Kinney
2021-08-18  5:42 ` [edk2-libc Patch 7/9] AppPkg: Add MdeLibs.dsc.inc to AppPkg.dsc Michael D Kinney
2021-08-18  5:42 ` [edk2-libc Patch 8/9] AppPkg/Applications/Python: Enable HAVE_COPYSIGN define Michael D Kinney
2021-08-18  5:42 ` Michael D Kinney [this message]
2021-08-18 18:37 ` [edk2-libc Patch 0/9] Update for edk2/master and VS2017/VS2019 Rebecca Cran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210818054206.1223-10-michael.d.kinney@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox