* [edk2-libc Patch V2 0/9] Update for edk2/master and VS2017/VS2019
@ 2021-08-18 21:28 Michael D Kinney
2021-08-18 21:28 ` [edk2-libc Patch V2 1/9] StdLib: Add /Wv:11 to VS2017/VS2019 CC_FLAGS Michael D Kinney
` (9 more replies)
0 siblings, 10 replies; 11+ messages in thread
From: Michael D Kinney @ 2021-08-18 21:28 UTC (permalink / raw)
To: devel; +Cc: Rebecca Cran
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549
New in V2
=========
* Add LibNetUtil to StdLib/BsdSocketLib in alphebetic order
* Add comments explaining why SocketDxe is removed from the build.
New TianoCore Bugzilla with more details on this issue:
https://bugzilla.tianocore.org/show_bug.cgi?id=3572
Add BsdSocketLib and EfiSocketLib to [LibraryClasses] section
of Python-2.7.10.inf. Even if sockets are disabled in Python
config, with the /WHOLEARCHIVE linker option, there are still
references to the socket related functions. Add these lib
classes so the link can pass for both sockets enabled and sockets
disabled builds.
Cc: Rebecca Cran <rebecca@nuviainc.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Michael D Kinney (9):
StdLib: Add /Wv:11 to VS2017/VS2019 CC_FLAGS
StdLib: Add MdeLibs.dsc.inc to StdLib.dsc
StdLib: Remove SocketDxe from build
StdLib/LibC/gdtoa: Remove source file with unused ldtoa() function.
StdLib/BsdSocketLib: Add missing LibNetUtil dependency to INF
StdLib/BsdSocketLib: Add /wd4706 to CC_FLAGS
AppPkg: Add MdeLibs.dsc.inc to AppPkg.dsc
AppPkg/Applications/Python: Enable HAVE_COPYSIGN define
AppPkg/Applications/Python/Python-2.7.10: Update INF lib classes
AppPkg/AppPkg.dsc | 2 ++
AppPkg/Applications/Python/Ia32/pyconfig.h | 2 +-
AppPkg/Applications/Python/Python-2.7.10/Ia32/pyconfig.h | 2 +-
AppPkg/Applications/Python/Python-2.7.10/Python2710.inf | 7 ++-----
AppPkg/Applications/Python/Python-2.7.10/X64/pyconfig.h | 2 +-
AppPkg/Applications/Python/X64/pyconfig.h | 3 +--
StdLib/BsdSocketLib/BsdSocketLib.inf | 4 ++++
StdLib/LibC/gdtoa/gdtoa.inf | 1 -
StdLib/StdLib.dsc | 2 ++
StdLib/StdLib.inc | 8 +++++++-
10 files changed, 21 insertions(+), 12 deletions(-)
--
2.32.0.windows.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* [edk2-libc Patch V2 1/9] StdLib: Add /Wv:11 to VS2017/VS2019 CC_FLAGS
2021-08-18 21:28 [edk2-libc Patch V2 0/9] Update for edk2/master and VS2017/VS2019 Michael D Kinney
@ 2021-08-18 21:28 ` Michael D Kinney
2021-08-18 21:28 ` [edk2-libc Patch V2 2/9] StdLib: Add MdeLibs.dsc.inc to StdLib.dsc Michael D Kinney
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Michael D Kinney @ 2021-08-18 21:28 UTC (permalink / raw)
To: devel; +Cc: Rebecca Cran
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549
Add /Wv:11 to VS2017/VS2017 CC_FLAGS to match the warning level
used by VS2015.
Cc: Rebecca Cran <rebecca@nuviainc.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
StdLib/StdLib.inc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/StdLib/StdLib.inc b/StdLib/StdLib.inc
index 32e1ae0..d0a0c8a 100644
--- a/StdLib/StdLib.inc
+++ b/StdLib/StdLib.inc
@@ -137,3 +137,5 @@
MSFT:*_VS2015x86_*_CC_FLAGS = /Wv:11
MSFT:*_VS2015xASL_*_CC_FLAGS = /Wv:11
MSFT:*_VS2015x86xASL_*_CC_FLAGS = /Wv:11
+ MSFT:*_VS2017_*_CC_FLAGS = /Wv:11
+ MSFT:*_VS2019_*_CC_FLAGS = /Wv:11
--
2.32.0.windows.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [edk2-libc Patch V2 2/9] StdLib: Add MdeLibs.dsc.inc to StdLib.dsc
2021-08-18 21:28 [edk2-libc Patch V2 0/9] Update for edk2/master and VS2017/VS2019 Michael D Kinney
2021-08-18 21:28 ` [edk2-libc Patch V2 1/9] StdLib: Add /Wv:11 to VS2017/VS2019 CC_FLAGS Michael D Kinney
@ 2021-08-18 21:28 ` Michael D Kinney
2021-08-18 21:28 ` [edk2-libc Patch V2 3/9] StdLib: Remove SocketDxe from build Michael D Kinney
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Michael D Kinney @ 2021-08-18 21:28 UTC (permalink / raw)
To: devel; +Cc: Rebecca Cran
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549
Fix missing RegisterFilterLib build failure by adding MdeLibs.dsc.inc
after the [Defines] section of StdLib.dsc.
Cc: Rebecca Cran <rebecca@nuviainc.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
StdLib/StdLib.dsc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/StdLib/StdLib.dsc b/StdLib/StdLib.dsc
index 535f16a..d064a1e 100644
--- a/StdLib/StdLib.dsc
+++ b/StdLib/StdLib.dsc
@@ -32,6 +32,8 @@
DEFINE DEBUG_PRINT_ERROR_LEVEL = 0x80000000 # Flags to control amount of debug output
DEFINE DEBUG_PROPERTY_MASK = 0x0f
+!include MdePkg/MdeLibs.dsc.inc
+
[PcdsFeatureFlag]
[PcdsFixedAtBuild]
--
2.32.0.windows.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [edk2-libc Patch V2 3/9] StdLib: Remove SocketDxe from build
2021-08-18 21:28 [edk2-libc Patch V2 0/9] Update for edk2/master and VS2017/VS2019 Michael D Kinney
2021-08-18 21:28 ` [edk2-libc Patch V2 1/9] StdLib: Add /Wv:11 to VS2017/VS2019 CC_FLAGS Michael D Kinney
2021-08-18 21:28 ` [edk2-libc Patch V2 2/9] StdLib: Add MdeLibs.dsc.inc to StdLib.dsc Michael D Kinney
@ 2021-08-18 21:28 ` Michael D Kinney
2021-08-18 21:28 ` [edk2-libc Patch V2 4/9] StdLib/LibC/gdtoa: Remove source file with unused ldtoa() function Michael D Kinney
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Michael D Kinney @ 2021-08-18 21:28 UTC (permalink / raw)
To: devel; +Cc: Rebecca Cran
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549
SocketDxe generates build failures with VS2017 and VS2019 due to
use of weak references and /WHOLEARCHIVE. Disable SocketDxe until
weak references can be removed.
Cc: Rebecca Cran <rebecca@nuviainc.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
StdLib/StdLib.inc | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/StdLib/StdLib.inc b/StdLib/StdLib.inc
index d0a0c8a..814bdbc 100644
--- a/StdLib/StdLib.inc
+++ b/StdLib/StdLib.inc
@@ -99,7 +99,11 @@
##########
# Socket Layer
##########
- StdLib/SocketDxe/SocketDxe.inf
+#
+# Disable SocketDxe.inf due to conflict between use of weak symbols
+# and /WHOLEARCHIVE linker option.
+#
+# StdLib/SocketDxe/SocketDxe.inf
##############################################################################
--
2.32.0.windows.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [edk2-libc Patch V2 4/9] StdLib/LibC/gdtoa: Remove source file with unused ldtoa() function.
2021-08-18 21:28 [edk2-libc Patch V2 0/9] Update for edk2/master and VS2017/VS2019 Michael D Kinney
` (2 preceding siblings ...)
2021-08-18 21:28 ` [edk2-libc Patch V2 3/9] StdLib: Remove SocketDxe from build Michael D Kinney
@ 2021-08-18 21:28 ` Michael D Kinney
2021-08-18 21:28 ` [edk2-libc Patch V2 5/9] StdLib/BsdSocketLib: Add missing LibNetUtil dependency to INF Michael D Kinney
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Michael D Kinney @ 2021-08-18 21:28 UTC (permalink / raw)
To: devel; +Cc: Rebecca Cran
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549
Removing the ldtoa.c file from the INF removes the ldtoa()
function from this library. The ldtoa() function is not used
and when /WHOLEARCHIVE linker flag is enabled this unused
function makes references to other functions that are not
implemented and that generates a link failure. Removing the
unused source file resolves the link failure.
Cc: Rebecca Cran <rebecca@nuviainc.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
StdLib/LibC/gdtoa/gdtoa.inf | 1 -
1 file changed, 1 deletion(-)
diff --git a/StdLib/LibC/gdtoa/gdtoa.inf b/StdLib/LibC/gdtoa/gdtoa.inf
index 08ef5e0..51def1c 100644
--- a/StdLib/LibC/gdtoa/gdtoa.inf
+++ b/StdLib/LibC/gdtoa/gdtoa.inf
@@ -52,7 +52,6 @@
# Private interfaces interfacing to libc
dtoa.c
- ldtoa.c
gdtoa.c
# private interfaces
--
2.32.0.windows.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [edk2-libc Patch V2 5/9] StdLib/BsdSocketLib: Add missing LibNetUtil dependency to INF
2021-08-18 21:28 [edk2-libc Patch V2 0/9] Update for edk2/master and VS2017/VS2019 Michael D Kinney
` (3 preceding siblings ...)
2021-08-18 21:28 ` [edk2-libc Patch V2 4/9] StdLib/LibC/gdtoa: Remove source file with unused ldtoa() function Michael D Kinney
@ 2021-08-18 21:28 ` Michael D Kinney
2021-08-18 21:28 ` [edk2-libc Patch V2 6/9] StdLib/BsdSocketLib: Add /wd4706 to CC_FLAGS Michael D Kinney
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Michael D Kinney @ 2021-08-18 21:28 UTC (permalink / raw)
To: devel; +Cc: Rebecca Cran
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549
Add LibNetUtil to BsdSocketLib INF file that fails with missing
symbols for inet_ntoa(), inet_aton(), inet_ntop(), inet_network()
when BsdSocketLib is linked to another component.
Cc: Rebecca Cran <rebecca@nuviainc.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
StdLib/BsdSocketLib/BsdSocketLib.inf | 1 +
1 file changed, 1 insertion(+)
diff --git a/StdLib/BsdSocketLib/BsdSocketLib.inf b/StdLib/BsdSocketLib/BsdSocketLib.inf
index 238b709..522d6e0 100644
--- a/StdLib/BsdSocketLib/BsdSocketLib.inf
+++ b/StdLib/BsdSocketLib/BsdSocketLib.inf
@@ -106,6 +106,7 @@
BaseMemoryLib
DebugLib
DevUtility
+ LibNetUtil
UefiBootServicesTableLib
UefiLib
--
2.32.0.windows.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [edk2-libc Patch V2 6/9] StdLib/BsdSocketLib: Add /wd4706 to CC_FLAGS
2021-08-18 21:28 [edk2-libc Patch V2 0/9] Update for edk2/master and VS2017/VS2019 Michael D Kinney
` (4 preceding siblings ...)
2021-08-18 21:28 ` [edk2-libc Patch V2 5/9] StdLib/BsdSocketLib: Add missing LibNetUtil dependency to INF Michael D Kinney
@ 2021-08-18 21:28 ` Michael D Kinney
2021-08-18 21:28 ` [edk2-libc Patch V2 7/9] AppPkg: Add MdeLibs.dsc.inc to AppPkg.dsc Michael D Kinney
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Michael D Kinney @ 2021-08-18 21:28 UTC (permalink / raw)
To: devel; +Cc: Rebecca Cran
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549
Disable warning 4706 to allow assignments in conditional
statements.
Cc: Rebecca Cran <rebecca@nuviainc.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
StdLib/BsdSocketLib/BsdSocketLib.inf | 3 +++
1 file changed, 3 insertions(+)
diff --git a/StdLib/BsdSocketLib/BsdSocketLib.inf b/StdLib/BsdSocketLib/BsdSocketLib.inf
index 522d6e0..e74dd39 100644
--- a/StdLib/BsdSocketLib/BsdSocketLib.inf
+++ b/StdLib/BsdSocketLib/BsdSocketLib.inf
@@ -113,3 +113,6 @@
[Protocols]
gEfiSocketServiceBindingProtocolGuid
gEfiSocketProtocolGuid
+
+[BuildOptions]
+ MSFT:*_*_*_CC_FLAGS = /wd4706
--
2.32.0.windows.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [edk2-libc Patch V2 7/9] AppPkg: Add MdeLibs.dsc.inc to AppPkg.dsc
2021-08-18 21:28 [edk2-libc Patch V2 0/9] Update for edk2/master and VS2017/VS2019 Michael D Kinney
` (5 preceding siblings ...)
2021-08-18 21:28 ` [edk2-libc Patch V2 6/9] StdLib/BsdSocketLib: Add /wd4706 to CC_FLAGS Michael D Kinney
@ 2021-08-18 21:28 ` Michael D Kinney
2021-08-18 21:28 ` [edk2-libc Patch V2 8/9] AppPkg/Applications/Python: Enable HAVE_COPYSIGN define Michael D Kinney
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Michael D Kinney @ 2021-08-18 21:28 UTC (permalink / raw)
To: devel; +Cc: Rebecca Cran
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549
Fix missing RegisterFilterLib build failure by adding MdeLibs.dsc.inc
after the [Defines] section of AppPkg.dsc.
Cc: Rebecca Cran <rebecca@nuviainc.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
AppPkg/AppPkg.dsc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/AppPkg/AppPkg.dsc b/AppPkg/AppPkg.dsc
index 42af080..c2305d7 100644
--- a/AppPkg/AppPkg.dsc
+++ b/AppPkg/AppPkg.dsc
@@ -28,6 +28,8 @@
DEFINE DEBUG_PRINT_ERROR_LEVEL = 0x80000040 # Flags to control amount of debug output
DEFINE DEBUG_PROPERTY_MASK = 0
+!include MdePkg/MdeLibs.dsc.inc
+
[PcdsFeatureFlag]
[PcdsFixedAtBuild]
--
2.32.0.windows.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [edk2-libc Patch V2 8/9] AppPkg/Applications/Python: Enable HAVE_COPYSIGN define
2021-08-18 21:28 [edk2-libc Patch V2 0/9] Update for edk2/master and VS2017/VS2019 Michael D Kinney
` (6 preceding siblings ...)
2021-08-18 21:28 ` [edk2-libc Patch V2 7/9] AppPkg: Add MdeLibs.dsc.inc to AppPkg.dsc Michael D Kinney
@ 2021-08-18 21:28 ` Michael D Kinney
2021-08-18 21:28 ` [edk2-libc Patch V2 9/9] AppPkg/Applications/Python/Python-2.7.10: Update INF lib classes Michael D Kinney
2021-08-18 21:48 ` [edk2-libc Patch V2 0/9] Update for edk2/master and VS2017/VS2019 Rebecca Cran
9 siblings, 0 replies; 11+ messages in thread
From: Michael D Kinney @ 2021-08-18 21:28 UTC (permalink / raw)
To: devel; +Cc: Rebecca Cran
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549
Update Python configuration to enable the HAVE_COPYSIGN define
to prevent multiple defined symbols link failure for copysign().
Cc: Rebecca Cran <rebecca@nuviainc.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
AppPkg/Applications/Python/Ia32/pyconfig.h | 2 +-
AppPkg/Applications/Python/Python-2.7.10/Ia32/pyconfig.h | 2 +-
AppPkg/Applications/Python/Python-2.7.10/X64/pyconfig.h | 2 +-
AppPkg/Applications/Python/X64/pyconfig.h | 3 +--
4 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/AppPkg/Applications/Python/Ia32/pyconfig.h b/AppPkg/Applications/Python/Ia32/pyconfig.h
index ef241a9..2d73346 100644
--- a/AppPkg/Applications/Python/Ia32/pyconfig.h
+++ b/AppPkg/Applications/Python/Ia32/pyconfig.h
@@ -125,7 +125,7 @@
#undef HAVE_CONIO_H
/* Define to 1 if you have the 'copysign' function. */
-#undef HAVE_COPYSIGN
+#define HAVE_COPYSIGN 1
/* Define to 1 if you have the 'ctermid' function. */
#undef HAVE_CTERMID
diff --git a/AppPkg/Applications/Python/Python-2.7.10/Ia32/pyconfig.h b/AppPkg/Applications/Python/Python-2.7.10/Ia32/pyconfig.h
index 5aa936c..5a86ec3 100644
--- a/AppPkg/Applications/Python/Python-2.7.10/Ia32/pyconfig.h
+++ b/AppPkg/Applications/Python/Python-2.7.10/Ia32/pyconfig.h
@@ -138,7 +138,7 @@
#undef HAVE_CONIO_H
/* Define to 1 if you have the 'copysign' function. */
-#undef HAVE_COPYSIGN
+#define HAVE_COPYSIGN 1
/* Define to 1 if you have the 'ctermid' function. */
#undef HAVE_CTERMID
diff --git a/AppPkg/Applications/Python/Python-2.7.10/X64/pyconfig.h b/AppPkg/Applications/Python/Python-2.7.10/X64/pyconfig.h
index 92731f7..f07db09 100644
--- a/AppPkg/Applications/Python/Python-2.7.10/X64/pyconfig.h
+++ b/AppPkg/Applications/Python/Python-2.7.10/X64/pyconfig.h
@@ -138,7 +138,7 @@
#undef HAVE_CONIO_H
/* Define to 1 if you have the 'copysign' function. */
-#undef HAVE_COPYSIGN
+#define HAVE_COPYSIGN 1
/* Define to 1 if you have the 'ctermid' function. */
#undef HAVE_CTERMID
diff --git a/AppPkg/Applications/Python/X64/pyconfig.h b/AppPkg/Applications/Python/X64/pyconfig.h
index 81dbada..00ff4f9 100644
--- a/AppPkg/Applications/Python/X64/pyconfig.h
+++ b/AppPkg/Applications/Python/X64/pyconfig.h
@@ -132,7 +132,7 @@
#undef HAVE_CONIO_H
/* Define to 1 if you have the 'copysign' function. */
-#undef HAVE_COPYSIGN
+#define HAVE_COPYSIGN 1
/* Define to 1 if you have the 'ctermid' function. */
#undef HAVE_CTERMID
@@ -1299,4 +1299,3 @@
//#undef volatile
#endif /*Py_PYCONFIG_H*/
-
--
2.32.0.windows.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [edk2-libc Patch V2 9/9] AppPkg/Applications/Python/Python-2.7.10: Update INF lib classes
2021-08-18 21:28 [edk2-libc Patch V2 0/9] Update for edk2/master and VS2017/VS2019 Michael D Kinney
` (7 preceding siblings ...)
2021-08-18 21:28 ` [edk2-libc Patch V2 8/9] AppPkg/Applications/Python: Enable HAVE_COPYSIGN define Michael D Kinney
@ 2021-08-18 21:28 ` Michael D Kinney
2021-08-18 21:48 ` [edk2-libc Patch V2 0/9] Update for edk2/master and VS2017/VS2019 Rebecca Cran
9 siblings, 0 replies; 11+ messages in thread
From: Michael D Kinney @ 2021-08-18 21:28 UTC (permalink / raw)
To: devel; +Cc: Rebecca Cran
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549
Add BsdSocketLib and EfiSocketLib to [LibraryClasses] section
of Python-2.7.10.inf. Even if sockets are disabled in Python
config, with the /WHOLEARCHIVE linker option, there are still
references to the socket related functions. Add these lib
classes so the link can pass for both sockets enabled and sockets
disabled builds.
Cc: Rebecca Cran <rebecca@nuviainc.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
AppPkg/Applications/Python/Python-2.7.10/Python2710.inf | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/AppPkg/Applications/Python/Python-2.7.10/Python2710.inf b/AppPkg/Applications/Python/Python-2.7.10/Python2710.inf
index 2675630..ccf0c60 100644
--- a/AppPkg/Applications/Python/Python-2.7.10/Python2710.inf
+++ b/AppPkg/Applications/Python/Python-2.7.10/Python2710.inf
@@ -43,11 +43,8 @@
LibGen
LibNetUtil
DevMedia
- #
-# Comment out the following two library classes if socket support is
-# NOT being built in to Python.
- #BsdSocketLib
- #EfiSocketLib
+ BsdSocketLib
+ EfiSocketLib
[FixedPcd]
gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x0F
--
2.32.0.windows.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [edk2-libc Patch V2 0/9] Update for edk2/master and VS2017/VS2019
2021-08-18 21:28 [edk2-libc Patch V2 0/9] Update for edk2/master and VS2017/VS2019 Michael D Kinney
` (8 preceding siblings ...)
2021-08-18 21:28 ` [edk2-libc Patch V2 9/9] AppPkg/Applications/Python/Python-2.7.10: Update INF lib classes Michael D Kinney
@ 2021-08-18 21:48 ` Rebecca Cran
9 siblings, 0 replies; 11+ messages in thread
From: Rebecca Cran @ 2021-08-18 21:48 UTC (permalink / raw)
To: Michael D Kinney, devel
For the entire series:
Reviewed-by: Rebecca Cran <rebecca@nuviainc.com>
--
Rebecca Cran
On 8/18/21 3:28 PM, Michael D Kinney wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549
>
> New in V2
> =========
> * Add LibNetUtil to StdLib/BsdSocketLib in alphebetic order
> * Add comments explaining why SocketDxe is removed from the build.
> New TianoCore Bugzilla with more details on this issue:
> https://bugzilla.tianocore.org/show_bug.cgi?id=3572
>
> Add BsdSocketLib and EfiSocketLib to [LibraryClasses] section
> of Python-2.7.10.inf. Even if sockets are disabled in Python
> config, with the /WHOLEARCHIVE linker option, there are still
> references to the socket related functions. Add these lib
> classes so the link can pass for both sockets enabled and sockets
> disabled builds.
>
> Cc: Rebecca Cran <rebecca@nuviainc.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
>
> Michael D Kinney (9):
> StdLib: Add /Wv:11 to VS2017/VS2019 CC_FLAGS
> StdLib: Add MdeLibs.dsc.inc to StdLib.dsc
> StdLib: Remove SocketDxe from build
> StdLib/LibC/gdtoa: Remove source file with unused ldtoa() function.
> StdLib/BsdSocketLib: Add missing LibNetUtil dependency to INF
> StdLib/BsdSocketLib: Add /wd4706 to CC_FLAGS
> AppPkg: Add MdeLibs.dsc.inc to AppPkg.dsc
> AppPkg/Applications/Python: Enable HAVE_COPYSIGN define
> AppPkg/Applications/Python/Python-2.7.10: Update INF lib classes
>
> AppPkg/AppPkg.dsc | 2 ++
> AppPkg/Applications/Python/Ia32/pyconfig.h | 2 +-
> AppPkg/Applications/Python/Python-2.7.10/Ia32/pyconfig.h | 2 +-
> AppPkg/Applications/Python/Python-2.7.10/Python2710.inf | 7 ++-----
> AppPkg/Applications/Python/Python-2.7.10/X64/pyconfig.h | 2 +-
> AppPkg/Applications/Python/X64/pyconfig.h | 3 +--
> StdLib/BsdSocketLib/BsdSocketLib.inf | 4 ++++
> StdLib/LibC/gdtoa/gdtoa.inf | 1 -
> StdLib/StdLib.dsc | 2 ++
> StdLib/StdLib.inc | 8 +++++++-
> 10 files changed, 21 insertions(+), 12 deletions(-)
>
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-08-18 21:48 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-18 21:28 [edk2-libc Patch V2 0/9] Update for edk2/master and VS2017/VS2019 Michael D Kinney
2021-08-18 21:28 ` [edk2-libc Patch V2 1/9] StdLib: Add /Wv:11 to VS2017/VS2019 CC_FLAGS Michael D Kinney
2021-08-18 21:28 ` [edk2-libc Patch V2 2/9] StdLib: Add MdeLibs.dsc.inc to StdLib.dsc Michael D Kinney
2021-08-18 21:28 ` [edk2-libc Patch V2 3/9] StdLib: Remove SocketDxe from build Michael D Kinney
2021-08-18 21:28 ` [edk2-libc Patch V2 4/9] StdLib/LibC/gdtoa: Remove source file with unused ldtoa() function Michael D Kinney
2021-08-18 21:28 ` [edk2-libc Patch V2 5/9] StdLib/BsdSocketLib: Add missing LibNetUtil dependency to INF Michael D Kinney
2021-08-18 21:28 ` [edk2-libc Patch V2 6/9] StdLib/BsdSocketLib: Add /wd4706 to CC_FLAGS Michael D Kinney
2021-08-18 21:28 ` [edk2-libc Patch V2 7/9] AppPkg: Add MdeLibs.dsc.inc to AppPkg.dsc Michael D Kinney
2021-08-18 21:28 ` [edk2-libc Patch V2 8/9] AppPkg/Applications/Python: Enable HAVE_COPYSIGN define Michael D Kinney
2021-08-18 21:28 ` [edk2-libc Patch V2 9/9] AppPkg/Applications/Python/Python-2.7.10: Update INF lib classes Michael D Kinney
2021-08-18 21:48 ` [edk2-libc Patch V2 0/9] Update for edk2/master and VS2017/VS2019 Rebecca Cran
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox