From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web08.61188.1629322153682894042 for ; Wed, 18 Aug 2021 14:29:14 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: michael.d.kinney@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10080"; a="277454602" X-IronPort-AV: E=Sophos;i="5.84,332,1620716400"; d="scan'208";a="277454602" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2021 14:29:12 -0700 X-IronPort-AV: E=Sophos;i="5.84,332,1620716400"; d="scan'208";a="521240169" Received: from nsin-mobl.amr.corp.intel.com (HELO mdkinney-MOBL2.amr.corp.intel.com) ([10.212.191.175]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2021 14:29:12 -0700 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Rebecca Cran Subject: [edk2-libc Patch V2 4/9] StdLib/LibC/gdtoa: Remove source file with unused ldtoa() function. Date: Wed, 18 Aug 2021 14:28:54 -0700 Message-Id: <20210818212859.260-5-michael.d.kinney@intel.com> X-Mailer: git-send-email 2.32.0.windows.1 In-Reply-To: <20210818212859.260-1-michael.d.kinney@intel.com> References: <20210818212859.260-1-michael.d.kinney@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549 Removing the ldtoa.c file from the INF removes the ldtoa() function from this library. The ldtoa() function is not used and when /WHOLEARCHIVE linker flag is enabled this unused function makes references to other functions that are not implemented and that generates a link failure. Removing the unused source file resolves the link failure. Cc: Rebecca Cran Signed-off-by: Michael D Kinney --- StdLib/LibC/gdtoa/gdtoa.inf | 1 - 1 file changed, 1 deletion(-) diff --git a/StdLib/LibC/gdtoa/gdtoa.inf b/StdLib/LibC/gdtoa/gdtoa.inf index 08ef5e0..51def1c 100644 --- a/StdLib/LibC/gdtoa/gdtoa.inf +++ b/StdLib/LibC/gdtoa/gdtoa.inf @@ -52,7 +52,6 @@ # Private interfaces interfacing to libc dtoa.c - ldtoa.c gdtoa.c # private interfaces -- 2.32.0.windows.1