* [PATCH 0/2] Enable Core ci for UefiPayloadPkg. @ 2021-08-20 6:43 duntan 2021-08-20 6:43 ` [PATCH 1/2] UefiPayloadPkg: Create .yaml file in UefiPayloadPkg duntan 2021-08-20 6:43 ` [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py duntan 0 siblings, 2 replies; 13+ messages in thread From: duntan @ 2021-08-20 6:43 UTC (permalink / raw) To: devel Create configuration .yaml file in UefiPayloadPkg. Add UefiPayloadPkg in gate-build-job.yml and CISetting.py. duntan (2): UefiPayloadPkg: Create .yaml file in UefiPayloadPkg .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py .azurepipelines/templates/pr-gate-build-job.yml | 3 +++ .pytool/CISettings.py | 3 ++- UefiPayloadPkg/UefiPayloadPkg.ci.yaml | 90 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 95 insertions(+), 1 deletion(-) create mode 100644 UefiPayloadPkg/UefiPayloadPkg.ci.yaml -- 2.31.1.windows.1 ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 1/2] UefiPayloadPkg: Create .yaml file in UefiPayloadPkg 2021-08-20 6:43 [PATCH 0/2] Enable Core ci for UefiPayloadPkg duntan @ 2021-08-20 6:43 ` duntan 2021-08-20 8:12 ` Ni, Ray 2021-08-20 6:43 ` [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py duntan 1 sibling, 1 reply; 13+ messages in thread From: duntan @ 2021-08-20 6:43 UTC (permalink / raw) To: devel; +Cc: Guo Dong, Ray Ni, Maurice Ma, Benjamin You, DunTan Create .yaml file in UefiPayloadPkg to enable Core ci for UefiPayloadPkg Cc: Guo Dong <guo.dong@intel.com> Cc: Ray Ni <ray.ni@intel.com> Cc: Maurice Ma <maurice.ma@intel.com> Cc: Benjamin You <benjamin.you@intel.com> Signed-off-by: DunTan <dun.tan@intel.com> --- UefiPayloadPkg/UefiPayloadPkg.ci.yaml | 90 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 90 insertions(+) diff --git a/UefiPayloadPkg/UefiPayloadPkg.ci.yaml b/UefiPayloadPkg/UefiPayloadPkg.ci.yaml new file mode 100644 index 0000000000..35e6fb3540 --- /dev/null +++ b/UefiPayloadPkg/UefiPayloadPkg.ci.yaml @@ -0,0 +1,90 @@ +## @file +# Core CI configuration for UefiPayloadPkg +# +# Copyright (c) 2021, Intel Corporation. All rights reserved.<BR> +# SPDX-License-Identifier: BSD-2-Clause-Patent +## +{ + ## options defined .pytool/Plugin/LicenseCheck + "LicenseCheck": { + "IgnoreFiles": [] + }, + "EccCheck": { + ## Exception sample looks like below: + ## "ExceptionList": [ + ## "<ErrorID>", "<KeyWord>" + ## ] + "ExceptionList": [ + ], + ## Both file path and directory path are accepted. + "IgnoreFiles": [ + ] + }, + ## options defined .pytool/Plugin/CompilerPlugin + "CompilerPlugin": { + "DscPath": "UefiPayloadPkg.dsc" + }, + + ## options defined .pytool/Plugin/HostUnitTestCompilerPlugin + "HostUnitTestCompilerPlugin": { + "DscPath": "" # Don't support this test + }, + + ## options defined .pytool/Plugin/CharEncodingCheck + "CharEncodingCheck": { + "IgnoreFiles": [] + }, + + ## options defined .pytool/Plugin/DependencyCheck + "DependencyCheck": { + "AcceptableDependencies": [], + # For host based unit tests + "AcceptableDependencies-HOST_APPLICATION":[], + # For UEFI shell based apps + "AcceptableDependencies-UEFI_APPLICATION":[], + "IgnoreInf": [], + "skip": True + }, + + ## options defined .pytool/Plugin/DscCompleteCheck + "DscCompleteCheck": { + "IgnoreInf": [""], + "DscPath": "" # Don't support this test + }, + + ## options defined .pytool/Plugin/HostUnitTestDscCompleteCheck + "HostUnitTestDscCompleteCheck": { + "IgnoreInf": [""], + "DscPath": "" # Don't support this test + }, + + ## options defined .pytool/Plugin/GuidCheck + "GuidCheck": { + "IgnoreGuidName": [], + "IgnoreGuidValue": [], + "IgnoreFoldersAndFiles": [], + "IgnoreDuplicates": [], + }, + + ## options defined .pytool/Plugin/LibraryClassCheck + "LibraryClassCheck": { + "IgnoreHeaderFile": [], + "skip": True + }, + + ## options defined .pytool/Plugin/SpellCheck + "SpellCheck": { + "AuditOnly": True, # Fails right now with over 270 errors + "IgnoreFiles": [], # use gitignore syntax to ignore errors in matching files + "ExtendWords": [], # words to extend to the dictionary for this package + "IgnoreStandardPaths": [], # Standard Plugin defined paths that should be ignore + "AdditionalIncludePaths": [] # Additional paths to spell check (wildcards supported) + }, + + "Defines": { + "BLD_*_UNIVERSAL_PAYLOAD": "TRUE", + "BLD_*_EMU_VARIABLE_ENABLE": "FALSE", + "BLD_*_DISABLE_RESET_SYSTEM": "TRUE", + "BLD_*_SERIAL_DRIVER_ENABLE": "FALSE", + } +} -- 2.31.1.windows.1 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] UefiPayloadPkg: Create .yaml file in UefiPayloadPkg 2021-08-20 6:43 ` [PATCH 1/2] UefiPayloadPkg: Create .yaml file in UefiPayloadPkg duntan @ 2021-08-20 8:12 ` Ni, Ray 0 siblings, 0 replies; 13+ messages in thread From: Ni, Ray @ 2021-08-20 8:12 UTC (permalink / raw) To: Tan, Dun, devel@edk2.groups.io; +Cc: Dong, Guo, Ma, Maurice, You, Benjamin Reviewed-by: Ray Ni <ray.ni@intel.com> > -----Original Message----- > From: Tan, Dun <dun.tan@intel.com> > Sent: Friday, August 20, 2021 2:44 PM > To: devel@edk2.groups.io > Cc: Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Ma, Maurice <maurice.ma@intel.com>; You, Benjamin > <benjamin.you@intel.com>; Tan, Dun <dun.tan@intel.com> > Subject: [PATCH 1/2] UefiPayloadPkg: Create .yaml file in UefiPayloadPkg > > Create .yaml file in UefiPayloadPkg to enable Core ci for UefiPayloadPkg > > Cc: Guo Dong <guo.dong@intel.com> > Cc: Ray Ni <ray.ni@intel.com> > Cc: Maurice Ma <maurice.ma@intel.com> > Cc: Benjamin You <benjamin.you@intel.com> > Signed-off-by: DunTan <dun.tan@intel.com> > --- > UefiPayloadPkg/UefiPayloadPkg.ci.yaml | 90 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 90 insertions(+) > > diff --git a/UefiPayloadPkg/UefiPayloadPkg.ci.yaml b/UefiPayloadPkg/UefiPayloadPkg.ci.yaml > new file mode 100644 > index 0000000000..35e6fb3540 > --- /dev/null > +++ b/UefiPayloadPkg/UefiPayloadPkg.ci.yaml > @@ -0,0 +1,90 @@ > +## @file > +# Core CI configuration for UefiPayloadPkg > +# > +# Copyright (c) 2021, Intel Corporation. All rights reserved.<BR> > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +## > +{ > + ## options defined .pytool/Plugin/LicenseCheck > + "LicenseCheck": { > + "IgnoreFiles": [] > + }, > + "EccCheck": { > + ## Exception sample looks like below: > + ## "ExceptionList": [ > + ## "<ErrorID>", "<KeyWord>" > + ## ] > + "ExceptionList": [ > + ], > + ## Both file path and directory path are accepted. > + "IgnoreFiles": [ > + ] > + }, > + ## options defined .pytool/Plugin/CompilerPlugin > + "CompilerPlugin": { > + "DscPath": "UefiPayloadPkg.dsc" > + }, > + > + ## options defined .pytool/Plugin/HostUnitTestCompilerPlugin > + "HostUnitTestCompilerPlugin": { > + "DscPath": "" # Don't support this test > + }, > + > + ## options defined .pytool/Plugin/CharEncodingCheck > + "CharEncodingCheck": { > + "IgnoreFiles": [] > + }, > + > + ## options defined .pytool/Plugin/DependencyCheck > + "DependencyCheck": { > + "AcceptableDependencies": [], > + # For host based unit tests > + "AcceptableDependencies-HOST_APPLICATION":[], > + # For UEFI shell based apps > + "AcceptableDependencies-UEFI_APPLICATION":[], > + "IgnoreInf": [], > + "skip": True > + }, > + > + ## options defined .pytool/Plugin/DscCompleteCheck > + "DscCompleteCheck": { > + "IgnoreInf": [""], > + "DscPath": "" # Don't support this test > + }, > + > + ## options defined .pytool/Plugin/HostUnitTestDscCompleteCheck > + "HostUnitTestDscCompleteCheck": { > + "IgnoreInf": [""], > + "DscPath": "" # Don't support this test > + }, > + > + ## options defined .pytool/Plugin/GuidCheck > + "GuidCheck": { > + "IgnoreGuidName": [], > + "IgnoreGuidValue": [], > + "IgnoreFoldersAndFiles": [], > + "IgnoreDuplicates": [], > + }, > + > + ## options defined .pytool/Plugin/LibraryClassCheck > + "LibraryClassCheck": { > + "IgnoreHeaderFile": [], > + "skip": True > + }, > + > + ## options defined .pytool/Plugin/SpellCheck > + "SpellCheck": { > + "AuditOnly": True, # Fails right now with over 270 errors > + "IgnoreFiles": [], # use gitignore syntax to ignore errors in matching files > + "ExtendWords": [], # words to extend to the dictionary for this package > + "IgnoreStandardPaths": [], # Standard Plugin defined paths that should be ignore > + "AdditionalIncludePaths": [] # Additional paths to spell check (wildcards supported) > + }, > + > + "Defines": { > + "BLD_*_UNIVERSAL_PAYLOAD": "TRUE", > + "BLD_*_EMU_VARIABLE_ENABLE": "FALSE", > + "BLD_*_DISABLE_RESET_SYSTEM": "TRUE", > + "BLD_*_SERIAL_DRIVER_ENABLE": "FALSE", > + } > +} > -- > 2.31.1.windows.1 ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py 2021-08-20 6:43 [PATCH 0/2] Enable Core ci for UefiPayloadPkg duntan 2021-08-20 6:43 ` [PATCH 1/2] UefiPayloadPkg: Create .yaml file in UefiPayloadPkg duntan @ 2021-08-20 6:43 ` duntan 2021-08-24 9:23 ` duntan 1 sibling, 1 reply; 13+ messages in thread From: duntan @ 2021-08-20 6:43 UTC (permalink / raw) To: devel; +Cc: Sean Brogan, Bret Barkelew, Michael D Kinney, Liming Gao, DunTan Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for UefiPayloadPkg. Add UefiPayloadPkg to supported Packages in CISettings. Cc: Sean Brogan <sean.brogan@microsoft.com> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Signed-off-by: DunTan <dun.tan@intel.com> --- .azurepipelines/templates/pr-gate-build-job.yml | 3 +++ .pytool/CISettings.py | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml index 207acc7631..d5b16c127f 100644 --- a/.azurepipelines/templates/pr-gate-build-job.yml +++ b/.azurepipelines/templates/pr-gate-build-job.yml @@ -48,6 +48,9 @@ jobs: TARGET_SECURITY: Build.Pkgs: 'SecurityPkg' Build.Targets: 'DEBUG,RELEASE,NO-TARGET' + TARGET_UEFIPAYLOAD: + Build.Pkgs: 'UefiPayloadPkg' + Build.Targets: 'DEBUG,RELEASE,NO-TARGET' TARGET_PLATFORMS: # For Platforms only check code. Leave it to Platform CI # to build them. diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index 96e6baa519..ce330e2c73 100644 --- a/.pytool/CISettings.py +++ b/.pytool/CISettings.py @@ -67,7 +67,8 @@ class Settings(CiBuildSettingsManager, UpdateSettingsManager, SetupSettingsManag "CryptoPkg", "UnitTestFrameworkPkg", "OvmfPkg", - "RedfishPkg" + "RedfishPkg", + "UefiPayloadPkg" ) def GetArchitecturesSupported(self): -- 2.31.1.windows.1 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py 2021-08-20 6:43 ` [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py duntan @ 2021-08-24 9:23 ` duntan 2021-08-30 3:26 ` 回复: [edk2-devel] " gaoliming 0 siblings, 1 reply; 13+ messages in thread From: duntan @ 2021-08-24 9:23 UTC (permalink / raw) To: devel@edk2.groups.io Cc: Sean Brogan, Bret Barkelew, Kinney, Michael D, Liming Gao Hi all, Since the CI for UefiPayloadPkg is important to our develop progress, would you please speed up the review process? Thanks a lot! Thanks, Dun Tan -----Original Message----- From: Tan, Dun <dun.tan@intel.com> Sent: Friday, August 20, 2021 2:44 PM To: devel@edk2.groups.io Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Tan, Dun <dun.tan@intel.com> Subject: [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for UefiPayloadPkg. Add UefiPayloadPkg to supported Packages in CISettings. Cc: Sean Brogan <sean.brogan@microsoft.com> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Signed-off-by: DunTan <dun.tan@intel.com> --- .azurepipelines/templates/pr-gate-build-job.yml | 3 +++ .pytool/CISettings.py | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml index 207acc7631..d5b16c127f 100644 --- a/.azurepipelines/templates/pr-gate-build-job.yml +++ b/.azurepipelines/templates/pr-gate-build-job.yml @@ -48,6 +48,9 @@ jobs: TARGET_SECURITY: Build.Pkgs: 'SecurityPkg' Build.Targets: 'DEBUG,RELEASE,NO-TARGET' + TARGET_UEFIPAYLOAD: + Build.Pkgs: 'UefiPayloadPkg' + Build.Targets: 'DEBUG,RELEASE,NO-TARGET' TARGET_PLATFORMS: # For Platforms only check code. Leave it to Platform CI # to build them. diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index 96e6baa519..ce330e2c73 100644 --- a/.pytool/CISettings.py +++ b/.pytool/CISettings.py @@ -67,7 +67,8 @@ class Settings(CiBuildSettingsManager, UpdateSettingsManager, SetupSettingsManag "CryptoPkg", "UnitTestFrameworkPkg", "OvmfPkg", - "RedfishPkg" + "RedfishPkg", + "UefiPayloadPkg" ) def GetArchitecturesSupported(self): -- 2.31.1.windows.1 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py 2021-08-24 9:23 ` duntan @ 2021-08-30 3:26 ` gaoliming 2021-08-30 8:31 ` duntan 0 siblings, 1 reply; 13+ messages in thread From: gaoliming @ 2021-08-30 3:26 UTC (permalink / raw) To: devel, dun.tan Cc: 'Sean Brogan', 'Bret Barkelew', 'Kinney, Michael D' Dun: I don't see the issues to enable UefiPayloadPkg in CI. Have you created the private PR to verify this change? Thanks Liming > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 duntan > 发送时间: 2021年8月24日 17:24 > 收件人: devel@edk2.groups.io > 抄送: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn> > 主题: Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in > gate-build-job.yml and CISetting.py > > Hi all, > Since the CI for UefiPayloadPkg is important to our develop progress, > would you please speed up the review process? Thanks a lot! > > Thanks, > Dun Tan > -----Original Message----- > From: Tan, Dun <dun.tan@intel.com> > Sent: Friday, August 20, 2021 2:44 PM > To: devel@edk2.groups.io > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; > Tan, Dun <dun.tan@intel.com> > Subject: [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in > gate-build-job.yml and CISetting.py > > Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for > UefiPayloadPkg. > Add UefiPayloadPkg to supported Packages in CISettings. > > Cc: Sean Brogan <sean.brogan@microsoft.com> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com> > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Signed-off-by: DunTan <dun.tan@intel.com> > --- > .azurepipelines/templates/pr-gate-build-job.yml | 3 +++ > .pytool/CISettings.py | 3 ++- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/.azurepipelines/templates/pr-gate-build-job.yml > b/.azurepipelines/templates/pr-gate-build-job.yml > index 207acc7631..d5b16c127f 100644 > --- a/.azurepipelines/templates/pr-gate-build-job.yml > +++ b/.azurepipelines/templates/pr-gate-build-job.yml > @@ -48,6 +48,9 @@ jobs: > TARGET_SECURITY: > Build.Pkgs: 'SecurityPkg' > Build.Targets: 'DEBUG,RELEASE,NO-TARGET' > + TARGET_UEFIPAYLOAD: > + Build.Pkgs: 'UefiPayloadPkg' > + Build.Targets: 'DEBUG,RELEASE,NO-TARGET' > TARGET_PLATFORMS: > # For Platforms only check code. Leave it to Platform CI > # to build them. > diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index > 96e6baa519..ce330e2c73 100644 > --- a/.pytool/CISettings.py > +++ b/.pytool/CISettings.py > @@ -67,7 +67,8 @@ class Settings(CiBuildSettingsManager, > UpdateSettingsManager, SetupSettingsManag > "CryptoPkg", > "UnitTestFrameworkPkg", > "OvmfPkg", > - "RedfishPkg" > + "RedfishPkg", > + "UefiPayloadPkg" > ) > > def GetArchitecturesSupported(self): > -- > 2.31.1.windows.1 > > > > > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py 2021-08-30 3:26 ` 回复: [edk2-devel] " gaoliming @ 2021-08-30 8:31 ` duntan 2021-08-31 1:04 ` 回复: " gaoliming 0 siblings, 1 reply; 13+ messages in thread From: duntan @ 2021-08-30 8:31 UTC (permalink / raw) To: gaoliming, devel@edk2.groups.io Cc: 'Sean Brogan', 'Bret Barkelew', Kinney, Michael D Hi Liming, Here is the link of the PR to verify the change in Tiano EDKII. It passed the CI by GCC and VS both. https://github.com/tianocore/edk2/pull/1931 Thanks, Dun -----Original Message----- From: gaoliming <gaoliming@byosoft.com.cn> Sent: Monday, August 30, 2021 11:26 AM To: devel@edk2.groups.io; Tan, Dun <dun.tan@intel.com> Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com> Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py Dun: I don't see the issues to enable UefiPayloadPkg in CI. Have you created the private PR to verify this change? Thanks Liming > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 duntan > 发送时间: 2021年8月24日 17:24 > 收件人: devel@edk2.groups.io > 抄送: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn> > 主题: Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg > in gate-build-job.yml and CISetting.py > > Hi all, > Since the CI for UefiPayloadPkg is important to our develop > progress, would you please speed up the review process? Thanks a lot! > > Thanks, > Dun Tan > -----Original Message----- > From: Tan, Dun <dun.tan@intel.com> > Sent: Friday, August 20, 2021 2:44 PM > To: devel@edk2.groups.io > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; > Tan, Dun <dun.tan@intel.com> > Subject: [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in > gate-build-job.yml and CISetting.py > > Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for > UefiPayloadPkg. > Add UefiPayloadPkg to supported Packages in CISettings. > > Cc: Sean Brogan <sean.brogan@microsoft.com> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com> > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Signed-off-by: DunTan <dun.tan@intel.com> > --- > .azurepipelines/templates/pr-gate-build-job.yml | 3 +++ > .pytool/CISettings.py | 3 ++- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/.azurepipelines/templates/pr-gate-build-job.yml > b/.azurepipelines/templates/pr-gate-build-job.yml > index 207acc7631..d5b16c127f 100644 > --- a/.azurepipelines/templates/pr-gate-build-job.yml > +++ b/.azurepipelines/templates/pr-gate-build-job.yml > @@ -48,6 +48,9 @@ jobs: > TARGET_SECURITY: > Build.Pkgs: 'SecurityPkg' > Build.Targets: 'DEBUG,RELEASE,NO-TARGET' > + TARGET_UEFIPAYLOAD: > + Build.Pkgs: 'UefiPayloadPkg' > + Build.Targets: 'DEBUG,RELEASE,NO-TARGET' > TARGET_PLATFORMS: > # For Platforms only check code. Leave it to Platform CI > # to build them. > diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index > 96e6baa519..ce330e2c73 100644 > --- a/.pytool/CISettings.py > +++ b/.pytool/CISettings.py > @@ -67,7 +67,8 @@ class Settings(CiBuildSettingsManager, > UpdateSettingsManager, SetupSettingsManag > "CryptoPkg", > "UnitTestFrameworkPkg", > "OvmfPkg", > - "RedfishPkg" > + "RedfishPkg", > + "UefiPayloadPkg" > ) > > def GetArchitecturesSupported(self): > -- > 2.31.1.windows.1 > > > > > ^ permalink raw reply [flat|nested] 13+ messages in thread
* 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py 2021-08-30 8:31 ` duntan @ 2021-08-31 1:04 ` gaoliming 2021-09-01 3:32 ` duntan 0 siblings, 1 reply; 13+ messages in thread From: gaoliming @ 2021-08-31 1:04 UTC (permalink / raw) To: 'Tan, Dun', devel Cc: 'Sean Brogan', 'Bret Barkelew', 'Kinney, Michael D' Dun: This PR also includes one additional commit to fix the build issue. Have you send the patch for it? For this patch set, Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>. It will be merged after the build issue has been fixed. Thanks Liming > -----邮件原件----- > 发件人: Tan, Dun <dun.tan@intel.com> > 发送时间: 2021年8月30日 16:31 > 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io > 抄送: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > <michael.d.kinney@intel.com> > 主题: RE: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in > gate-build-job.yml and CISetting.py > > Hi Liming, > > Here is the link of the PR to verify the change in Tiano EDKII. It passed the CI > by GCC and VS both. > https://github.com/tianocore/edk2/pull/1931 > > Thanks, > Dun > -----Original Message----- > From: gaoliming <gaoliming@byosoft.com.cn> > Sent: Monday, August 30, 2021 11:26 AM > To: devel@edk2.groups.io; Tan, Dun <dun.tan@intel.com> > Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > <michael.d.kinney@intel.com> > Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg > in gate-build-job.yml and CISetting.py > > Dun: > I don't see the issues to enable UefiPayloadPkg in CI. Have you created the > private PR to verify this change? > > Thanks > Liming > > -----邮件原件----- > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 duntan > > 发送时间: 2021年8月24日 17:24 > > 收件人: devel@edk2.groups.io > > 抄送: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew > > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn> > > 主题: Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg > > in gate-build-job.yml and CISetting.py > > > > Hi all, > > Since the CI for UefiPayloadPkg is important to our develop > > progress, would you please speed up the review process? Thanks a lot! > > > > Thanks, > > Dun Tan > > -----Original Message----- > > From: Tan, Dun <dun.tan@intel.com> > > Sent: Friday, August 20, 2021 2:44 PM > > To: devel@edk2.groups.io > > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew > > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; > > Tan, Dun <dun.tan@intel.com> > > Subject: [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in > > gate-build-job.yml and CISetting.py > > > > Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for > > UefiPayloadPkg. > > Add UefiPayloadPkg to supported Packages in CISettings. > > > > Cc: Sean Brogan <sean.brogan@microsoft.com> > > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com> > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > > Cc: Liming Gao <gaoliming@byosoft.com.cn> > > Signed-off-by: DunTan <dun.tan@intel.com> > > --- > > .azurepipelines/templates/pr-gate-build-job.yml | 3 +++ > > .pytool/CISettings.py | 3 ++- > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/.azurepipelines/templates/pr-gate-build-job.yml > > b/.azurepipelines/templates/pr-gate-build-job.yml > > index 207acc7631..d5b16c127f 100644 > > --- a/.azurepipelines/templates/pr-gate-build-job.yml > > +++ b/.azurepipelines/templates/pr-gate-build-job.yml > > @@ -48,6 +48,9 @@ jobs: > > TARGET_SECURITY: > > Build.Pkgs: 'SecurityPkg' > > Build.Targets: 'DEBUG,RELEASE,NO-TARGET' > > + TARGET_UEFIPAYLOAD: > > + Build.Pkgs: 'UefiPayloadPkg' > > + Build.Targets: 'DEBUG,RELEASE,NO-TARGET' > > TARGET_PLATFORMS: > > # For Platforms only check code. Leave it to Platform CI > > # to build them. > > diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index > > 96e6baa519..ce330e2c73 100644 > > --- a/.pytool/CISettings.py > > +++ b/.pytool/CISettings.py > > @@ -67,7 +67,8 @@ class Settings(CiBuildSettingsManager, > > UpdateSettingsManager, SetupSettingsManag > > "CryptoPkg", > > "UnitTestFrameworkPkg", > > "OvmfPkg", > > - "RedfishPkg" > > + "RedfishPkg", > > + "UefiPayloadPkg" > > ) > > > > def GetArchitecturesSupported(self): > > -- > > 2.31.1.windows.1 > > > > > > > > > > > > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py 2021-08-31 1:04 ` 回复: " gaoliming @ 2021-09-01 3:32 ` duntan 2021-09-01 6:05 ` 回复: " gaoliming 2021-09-02 1:24 ` duntan 0 siblings, 2 replies; 13+ messages in thread From: duntan @ 2021-09-01 3:32 UTC (permalink / raw) To: gaoliming, devel@edk2.groups.io Cc: 'Sean Brogan', 'Bret Barkelew', Kinney, Michael D Hi Liming, The patch to fix the build issue has been merged this morning. Would you please help to merge the two patches to enable core CI for UefiPayloadPkg? Thanks, Dun -----Original Message----- From: gaoliming <gaoliming@byosoft.com.cn> Sent: Tuesday, August 31, 2021 9:05 AM To: Tan, Dun <dun.tan@intel.com>; devel@edk2.groups.io Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com> Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py Dun: This PR also includes one additional commit to fix the build issue. Have you send the patch for it? For this patch set, Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>. It will be merged after the build issue has been fixed. Thanks Liming > -----邮件原件----- > 发件人: Tan, Dun <dun.tan@intel.com> > 发送时间: 2021年8月30日 16:31 > 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io > 抄送: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > <michael.d.kinney@intel.com> > 主题: RE: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg > in gate-build-job.yml and CISetting.py > > Hi Liming, > > Here is the link of the PR to verify the change in Tiano EDKII. It > passed the CI by GCC and VS both. > https://github.com/tianocore/edk2/pull/1931 > > Thanks, > Dun > -----Original Message----- > From: gaoliming <gaoliming@byosoft.com.cn> > Sent: Monday, August 30, 2021 11:26 AM > To: devel@edk2.groups.io; Tan, Dun <dun.tan@intel.com> > Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > <michael.d.kinney@intel.com> > Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add > UefiPayloadPkg in gate-build-job.yml and CISetting.py > > Dun: > I don't see the issues to enable UefiPayloadPkg in CI. Have you > created the private PR to verify this change? > > Thanks > Liming > > -----邮件原件----- > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 duntan > > 发送时间: 2021年8月24日 17:24 > > 收件人: devel@edk2.groups.io > > 抄送: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew > > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn> > > 主题: Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg > > in gate-build-job.yml and CISetting.py > > > > Hi all, > > Since the CI for UefiPayloadPkg is important to our develop > > progress, would you please speed up the review process? Thanks a lot! > > > > Thanks, > > Dun Tan > > -----Original Message----- > > From: Tan, Dun <dun.tan@intel.com> > > Sent: Friday, August 20, 2021 2:44 PM > > To: devel@edk2.groups.io > > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew > > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; > > Tan, Dun <dun.tan@intel.com> > > Subject: [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in > > gate-build-job.yml and CISetting.py > > > > Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for > > UefiPayloadPkg. > > Add UefiPayloadPkg to supported Packages in CISettings. > > > > Cc: Sean Brogan <sean.brogan@microsoft.com> > > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com> > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > > Cc: Liming Gao <gaoliming@byosoft.com.cn> > > Signed-off-by: DunTan <dun.tan@intel.com> > > --- > > .azurepipelines/templates/pr-gate-build-job.yml | 3 +++ > > .pytool/CISettings.py | 3 ++- > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/.azurepipelines/templates/pr-gate-build-job.yml > > b/.azurepipelines/templates/pr-gate-build-job.yml > > index 207acc7631..d5b16c127f 100644 > > --- a/.azurepipelines/templates/pr-gate-build-job.yml > > +++ b/.azurepipelines/templates/pr-gate-build-job.yml > > @@ -48,6 +48,9 @@ jobs: > > TARGET_SECURITY: > > Build.Pkgs: 'SecurityPkg' > > Build.Targets: 'DEBUG,RELEASE,NO-TARGET' > > + TARGET_UEFIPAYLOAD: > > + Build.Pkgs: 'UefiPayloadPkg' > > + Build.Targets: 'DEBUG,RELEASE,NO-TARGET' > > TARGET_PLATFORMS: > > # For Platforms only check code. Leave it to Platform CI > > # to build them. > > diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index > > 96e6baa519..ce330e2c73 100644 > > --- a/.pytool/CISettings.py > > +++ b/.pytool/CISettings.py > > @@ -67,7 +67,8 @@ class Settings(CiBuildSettingsManager, > > UpdateSettingsManager, SetupSettingsManag > > "CryptoPkg", > > "UnitTestFrameworkPkg", > > "OvmfPkg", > > - "RedfishPkg" > > + "RedfishPkg", > > + "UefiPayloadPkg" > > ) > > > > def GetArchitecturesSupported(self): > > -- > > 2.31.1.windows.1 > > > > > > > > > > > > ^ permalink raw reply [flat|nested] 13+ messages in thread
* 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py 2021-09-01 3:32 ` duntan @ 2021-09-01 6:05 ` gaoliming 2021-09-02 1:24 ` duntan 1 sibling, 0 replies; 13+ messages in thread From: gaoliming @ 2021-09-01 6:05 UTC (permalink / raw) To: devel, dun.tan Cc: 'Sean Brogan', 'Bret Barkelew', 'Kinney, Michael D' Create PR https://github.com/tianocore/edk2/pull/1940 for this patch set. > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 duntan > 发送时间: 2021年9月1日 11:32 > 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io > 抄送: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > <michael.d.kinney@intel.com> > 主题: Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in > gate-build-job.yml and CISetting.py > > Hi Liming, > > The patch to fix the build issue has been merged this morning. > Would you please help to merge the two patches to enable core CI for > UefiPayloadPkg? > > Thanks, > Dun > -----Original Message----- > From: gaoliming <gaoliming@byosoft.com.cn> > Sent: Tuesday, August 31, 2021 9:05 AM > To: Tan, Dun <dun.tan@intel.com>; devel@edk2.groups.io > Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > <michael.d.kinney@intel.com> > Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg > in gate-build-job.yml and CISetting.py > > Dun: > This PR also includes one additional commit to fix the build issue. Have you > send the patch for it? > > For this patch set, Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>. > It will be merged after the build issue has been fixed. > > Thanks > Liming > > -----邮件原件----- > > 发件人: Tan, Dun <dun.tan@intel.com> > > 发送时间: 2021年8月30日 16:31 > > 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io > > 抄送: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' > > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > > <michael.d.kinney@intel.com> > > 主题: RE: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg > > in gate-build-job.yml and CISetting.py > > > > Hi Liming, > > > > Here is the link of the PR to verify the change in Tiano EDKII. It > > passed the CI by GCC and VS both. > > https://github.com/tianocore/edk2/pull/1931 > > > > Thanks, > > Dun > > -----Original Message----- > > From: gaoliming <gaoliming@byosoft.com.cn> > > Sent: Monday, August 30, 2021 11:26 AM > > To: devel@edk2.groups.io; Tan, Dun <dun.tan@intel.com> > > Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' > > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > > <michael.d.kinney@intel.com> > > Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add > > UefiPayloadPkg in gate-build-job.yml and CISetting.py > > > > Dun: > > I don't see the issues to enable UefiPayloadPkg in CI. Have you > > created the private PR to verify this change? > > > > Thanks > > Liming > > > -----邮件原件----- > > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 duntan > > > 发送时间: 2021年8月24日 17:24 > > > 收件人: devel@edk2.groups.io > > > 抄送: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew > > > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > > > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn> > > > 主题: Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg > > > in gate-build-job.yml and CISetting.py > > > > > > Hi all, > > > Since the CI for UefiPayloadPkg is important to our develop > > > progress, would you please speed up the review process? Thanks a lot! > > > > > > Thanks, > > > Dun Tan > > > -----Original Message----- > > > From: Tan, Dun <dun.tan@intel.com> > > > Sent: Friday, August 20, 2021 2:44 PM > > > To: devel@edk2.groups.io > > > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew > > > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > > > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; > > > Tan, Dun <dun.tan@intel.com> > > > Subject: [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in > > > gate-build-job.yml and CISetting.py > > > > > > Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for > > > UefiPayloadPkg. > > > Add UefiPayloadPkg to supported Packages in CISettings. > > > > > > Cc: Sean Brogan <sean.brogan@microsoft.com> > > > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com> > > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > > > Cc: Liming Gao <gaoliming@byosoft.com.cn> > > > Signed-off-by: DunTan <dun.tan@intel.com> > > > --- > > > .azurepipelines/templates/pr-gate-build-job.yml | 3 +++ > > > .pytool/CISettings.py | 3 ++- > > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > > > diff --git a/.azurepipelines/templates/pr-gate-build-job.yml > > > b/.azurepipelines/templates/pr-gate-build-job.yml > > > index 207acc7631..d5b16c127f 100644 > > > --- a/.azurepipelines/templates/pr-gate-build-job.yml > > > +++ b/.azurepipelines/templates/pr-gate-build-job.yml > > > @@ -48,6 +48,9 @@ jobs: > > > TARGET_SECURITY: > > > Build.Pkgs: 'SecurityPkg' > > > Build.Targets: 'DEBUG,RELEASE,NO-TARGET' > > > + TARGET_UEFIPAYLOAD: > > > + Build.Pkgs: 'UefiPayloadPkg' > > > + Build.Targets: 'DEBUG,RELEASE,NO-TARGET' > > > TARGET_PLATFORMS: > > > # For Platforms only check code. Leave it to Platform CI > > > # to build them. > > > diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index > > > 96e6baa519..ce330e2c73 100644 > > > --- a/.pytool/CISettings.py > > > +++ b/.pytool/CISettings.py > > > @@ -67,7 +67,8 @@ class Settings(CiBuildSettingsManager, > > > UpdateSettingsManager, SetupSettingsManag > > > "CryptoPkg", > > > "UnitTestFrameworkPkg", > > > "OvmfPkg", > > > - "RedfishPkg" > > > + "RedfishPkg", > > > + "UefiPayloadPkg" > > > ) > > > > > > def GetArchitecturesSupported(self): > > > -- > > > 2.31.1.windows.1 > > > > > > > > > > > > > > > > > > > > > > > > > > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py 2021-09-01 3:32 ` duntan 2021-09-01 6:05 ` 回复: " gaoliming @ 2021-09-02 1:24 ` duntan 2021-09-02 2:09 ` 回复: " gaoliming 1 sibling, 1 reply; 13+ messages in thread From: duntan @ 2021-09-02 1:24 UTC (permalink / raw) To: gaoliming, devel@edk2.groups.io Cc: 'Sean Brogan', 'Bret Barkelew', Kinney, Michael D Hi Liming, I have seen the link to push my commits to master of edk2. The result shows that the Ci test failed in ArmPlatformPkg. But I think my commits will not affect the ArmPlatformPkg. Here is the link. https://github.com/tianocore/edk2/pull/1940the So is there anything I need to do? Thanks, Dun -----Original Message----- From: Tan, Dun Sent: Wednesday, September 1, 2021 11:32 AM To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com> Subject: RE: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py Hi Liming, The patch to fix the build issue has been merged this morning. Would you please help to merge the two patches to enable core CI for UefiPayloadPkg? Thanks, Dun -----Original Message----- From: gaoliming <gaoliming@byosoft.com.cn> Sent: Tuesday, August 31, 2021 9:05 AM To: Tan, Dun <dun.tan@intel.com>; devel@edk2.groups.io Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com> Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py Dun: This PR also includes one additional commit to fix the build issue. Have you send the patch for it? For this patch set, Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>. It will be merged after the build issue has been fixed. Thanks Liming > -----邮件原件----- > 发件人: Tan, Dun <dun.tan@intel.com> > 发送时间: 2021年8月30日 16:31 > 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io > 抄送: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > <michael.d.kinney@intel.com> > 主题: RE: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg > in gate-build-job.yml and CISetting.py > > Hi Liming, > > Here is the link of the PR to verify the change in Tiano EDKII. It > passed the CI by GCC and VS both. > https://github.com/tianocore/edk2/pull/1931 > > Thanks, > Dun > -----Original Message----- > From: gaoliming <gaoliming@byosoft.com.cn> > Sent: Monday, August 30, 2021 11:26 AM > To: devel@edk2.groups.io; Tan, Dun <dun.tan@intel.com> > Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > <michael.d.kinney@intel.com> > Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add > UefiPayloadPkg in gate-build-job.yml and CISetting.py > > Dun: > I don't see the issues to enable UefiPayloadPkg in CI. Have you > created the private PR to verify this change? > > Thanks > Liming > > -----邮件原件----- > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 duntan > > 发送时间: 2021年8月24日 17:24 > > 收件人: devel@edk2.groups.io > > 抄送: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew > > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn> > > 主题: Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg > > in gate-build-job.yml and CISetting.py > > > > Hi all, > > Since the CI for UefiPayloadPkg is important to our develop > > progress, would you please speed up the review process? Thanks a lot! > > > > Thanks, > > Dun Tan > > -----Original Message----- > > From: Tan, Dun <dun.tan@intel.com> > > Sent: Friday, August 20, 2021 2:44 PM > > To: devel@edk2.groups.io > > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew > > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; > > Tan, Dun <dun.tan@intel.com> > > Subject: [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in > > gate-build-job.yml and CISetting.py > > > > Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for > > UefiPayloadPkg. > > Add UefiPayloadPkg to supported Packages in CISettings. > > > > Cc: Sean Brogan <sean.brogan@microsoft.com> > > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com> > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > > Cc: Liming Gao <gaoliming@byosoft.com.cn> > > Signed-off-by: DunTan <dun.tan@intel.com> > > --- > > .azurepipelines/templates/pr-gate-build-job.yml | 3 +++ > > .pytool/CISettings.py | 3 ++- > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/.azurepipelines/templates/pr-gate-build-job.yml > > b/.azurepipelines/templates/pr-gate-build-job.yml > > index 207acc7631..d5b16c127f 100644 > > --- a/.azurepipelines/templates/pr-gate-build-job.yml > > +++ b/.azurepipelines/templates/pr-gate-build-job.yml > > @@ -48,6 +48,9 @@ jobs: > > TARGET_SECURITY: > > Build.Pkgs: 'SecurityPkg' > > Build.Targets: 'DEBUG,RELEASE,NO-TARGET' > > + TARGET_UEFIPAYLOAD: > > + Build.Pkgs: 'UefiPayloadPkg' > > + Build.Targets: 'DEBUG,RELEASE,NO-TARGET' > > TARGET_PLATFORMS: > > # For Platforms only check code. Leave it to Platform CI > > # to build them. > > diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index > > 96e6baa519..ce330e2c73 100644 > > --- a/.pytool/CISettings.py > > +++ b/.pytool/CISettings.py > > @@ -67,7 +67,8 @@ class Settings(CiBuildSettingsManager, > > UpdateSettingsManager, SetupSettingsManag > > "CryptoPkg", > > "UnitTestFrameworkPkg", > > "OvmfPkg", > > - "RedfishPkg" > > + "RedfishPkg", > > + "UefiPayloadPkg" > > ) > > > > def GetArchitecturesSupported(self): > > -- > > 2.31.1.windows.1 > > > > > > > > > > > > ^ permalink raw reply [flat|nested] 13+ messages in thread
* 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py 2021-09-02 1:24 ` duntan @ 2021-09-02 2:09 ` gaoliming 2021-09-02 2:24 ` duntan 0 siblings, 1 reply; 13+ messages in thread From: gaoliming @ 2021-09-02 2:09 UTC (permalink / raw) To: devel, dun.tan Cc: 'Sean Brogan', 'Bret Barkelew', 'Kinney, Michael D' I upload it again. Now, it has been merged. Thanks Liming > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 duntan > 发送时间: 2021年9月2日 9:24 > 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io > 抄送: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > <michael.d.kinney@intel.com> > 主题: Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in > gate-build-job.yml and CISetting.py > > Hi Liming, > > I have seen the link to push my commits to master of edk2. The result shows > that the Ci test failed in ArmPlatformPkg. But I think my commits will not > affect the ArmPlatformPkg. Here is the link. > https://github.com/tianocore/edk2/pull/1940the > So is there anything I need to do? > > Thanks, > Dun > -----Original Message----- > From: Tan, Dun > Sent: Wednesday, September 1, 2021 11:32 AM > To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io > Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > <michael.d.kinney@intel.com> > Subject: RE: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in > gate-build-job.yml and CISetting.py > > Hi Liming, > > The patch to fix the build issue has been merged this morning. > Would you please help to merge the two patches to enable core CI for > UefiPayloadPkg? > > Thanks, > Dun > -----Original Message----- > From: gaoliming <gaoliming@byosoft.com.cn> > Sent: Tuesday, August 31, 2021 9:05 AM > To: Tan, Dun <dun.tan@intel.com>; devel@edk2.groups.io > Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > <michael.d.kinney@intel.com> > Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg > in gate-build-job.yml and CISetting.py > > Dun: > This PR also includes one additional commit to fix the build issue. Have you > send the patch for it? > > For this patch set, Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>. > It will be merged after the build issue has been fixed. > > Thanks > Liming > > -----邮件原件----- > > 发件人: Tan, Dun <dun.tan@intel.com> > > 发送时间: 2021年8月30日 16:31 > > 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io > > 抄送: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' > > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > > <michael.d.kinney@intel.com> > > 主题: RE: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg > > in gate-build-job.yml and CISetting.py > > > > Hi Liming, > > > > Here is the link of the PR to verify the change in Tiano EDKII. It > > passed the CI by GCC and VS both. > > https://github.com/tianocore/edk2/pull/1931 > > > > Thanks, > > Dun > > -----Original Message----- > > From: gaoliming <gaoliming@byosoft.com.cn> > > Sent: Monday, August 30, 2021 11:26 AM > > To: devel@edk2.groups.io; Tan, Dun <dun.tan@intel.com> > > Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' > > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > > <michael.d.kinney@intel.com> > > Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add > > UefiPayloadPkg in gate-build-job.yml and CISetting.py > > > > Dun: > > I don't see the issues to enable UefiPayloadPkg in CI. Have you > > created the private PR to verify this change? > > > > Thanks > > Liming > > > -----邮件原件----- > > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 duntan > > > 发送时间: 2021年8月24日 17:24 > > > 收件人: devel@edk2.groups.io > > > 抄送: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew > > > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > > > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn> > > > 主题: Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg > > > in gate-build-job.yml and CISetting.py > > > > > > Hi all, > > > Since the CI for UefiPayloadPkg is important to our develop > > > progress, would you please speed up the review process? Thanks a lot! > > > > > > Thanks, > > > Dun Tan > > > -----Original Message----- > > > From: Tan, Dun <dun.tan@intel.com> > > > Sent: Friday, August 20, 2021 2:44 PM > > > To: devel@edk2.groups.io > > > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew > > > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > > > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; > > > Tan, Dun <dun.tan@intel.com> > > > Subject: [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in > > > gate-build-job.yml and CISetting.py > > > > > > Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for > > > UefiPayloadPkg. > > > Add UefiPayloadPkg to supported Packages in CISettings. > > > > > > Cc: Sean Brogan <sean.brogan@microsoft.com> > > > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com> > > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > > > Cc: Liming Gao <gaoliming@byosoft.com.cn> > > > Signed-off-by: DunTan <dun.tan@intel.com> > > > --- > > > .azurepipelines/templates/pr-gate-build-job.yml | 3 +++ > > > .pytool/CISettings.py | 3 ++- > > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > > > diff --git a/.azurepipelines/templates/pr-gate-build-job.yml > > > b/.azurepipelines/templates/pr-gate-build-job.yml > > > index 207acc7631..d5b16c127f 100644 > > > --- a/.azurepipelines/templates/pr-gate-build-job.yml > > > +++ b/.azurepipelines/templates/pr-gate-build-job.yml > > > @@ -48,6 +48,9 @@ jobs: > > > TARGET_SECURITY: > > > Build.Pkgs: 'SecurityPkg' > > > Build.Targets: 'DEBUG,RELEASE,NO-TARGET' > > > + TARGET_UEFIPAYLOAD: > > > + Build.Pkgs: 'UefiPayloadPkg' > > > + Build.Targets: 'DEBUG,RELEASE,NO-TARGET' > > > TARGET_PLATFORMS: > > > # For Platforms only check code. Leave it to Platform CI > > > # to build them. > > > diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index > > > 96e6baa519..ce330e2c73 100644 > > > --- a/.pytool/CISettings.py > > > +++ b/.pytool/CISettings.py > > > @@ -67,7 +67,8 @@ class Settings(CiBuildSettingsManager, > > > UpdateSettingsManager, SetupSettingsManag > > > "CryptoPkg", > > > "UnitTestFrameworkPkg", > > > "OvmfPkg", > > > - "RedfishPkg" > > > + "RedfishPkg", > > > + "UefiPayloadPkg" > > > ) > > > > > > def GetArchitecturesSupported(self): > > > -- > > > 2.31.1.windows.1 > > > > > > > > > > > > > > > > > > > > > > > > > > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py 2021-09-02 2:09 ` 回复: " gaoliming @ 2021-09-02 2:24 ` duntan 0 siblings, 0 replies; 13+ messages in thread From: duntan @ 2021-09-02 2:24 UTC (permalink / raw) To: gaoliming, devel@edk2.groups.io Cc: 'Sean Brogan', 'Bret Barkelew', Kinney, Michael D Thanks a lot! Thanks, Dun -----Original Message----- From: gaoliming <gaoliming@byosoft.com.cn> Sent: Thursday, September 2, 2021 10:10 AM To: devel@edk2.groups.io; Tan, Dun <dun.tan@intel.com> Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com> Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py I upload it again. Now, it has been merged. Thanks Liming > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 duntan > 发送时间: 2021年9月2日 9:24 > 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io > 抄送: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > <michael.d.kinney@intel.com> > 主题: Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg > in gate-build-job.yml and CISetting.py > > Hi Liming, > > I have seen the link to push my commits to master of edk2. The result > shows that the Ci test failed in ArmPlatformPkg. But I think my > commits will not affect the ArmPlatformPkg. Here is the link. > https://github.com/tianocore/edk2/pull/1940the > So is there anything I need to do? > > Thanks, > Dun > -----Original Message----- > From: Tan, Dun > Sent: Wednesday, September 1, 2021 11:32 AM > To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io > Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > <michael.d.kinney@intel.com> > Subject: RE: [edk2-devel] [PATCH 2/2] .azurepipelines: Add > UefiPayloadPkg in gate-build-job.yml and CISetting.py > > Hi Liming, > > The patch to fix the build issue has been merged this morning. > Would you please help to merge the two patches to enable core CI for > UefiPayloadPkg? > > Thanks, > Dun > -----Original Message----- > From: gaoliming <gaoliming@byosoft.com.cn> > Sent: Tuesday, August 31, 2021 9:05 AM > To: Tan, Dun <dun.tan@intel.com>; devel@edk2.groups.io > Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > <michael.d.kinney@intel.com> > Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add > UefiPayloadPkg in gate-build-job.yml and CISetting.py > > Dun: > This PR also includes one additional commit to fix the build issue. > Have you send the patch for it? > > For this patch set, Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>. > It will be merged after the build issue has been fixed. > > Thanks > Liming > > -----邮件原件----- > > 发件人: Tan, Dun <dun.tan@intel.com> > > 发送时间: 2021年8月30日 16:31 > > 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io > > 抄送: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' > > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > > <michael.d.kinney@intel.com> > > 主题: RE: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg > > in gate-build-job.yml and CISetting.py > > > > Hi Liming, > > > > Here is the link of the PR to verify the change in Tiano EDKII. It > > passed the CI by GCC and VS both. > > https://github.com/tianocore/edk2/pull/1931 > > > > Thanks, > > Dun > > -----Original Message----- > > From: gaoliming <gaoliming@byosoft.com.cn> > > Sent: Monday, August 30, 2021 11:26 AM > > To: devel@edk2.groups.io; Tan, Dun <dun.tan@intel.com> > > Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' > > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > > <michael.d.kinney@intel.com> > > Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add > > UefiPayloadPkg in gate-build-job.yml and CISetting.py > > > > Dun: > > I don't see the issues to enable UefiPayloadPkg in CI. Have you > > created the private PR to verify this change? > > > > Thanks > > Liming > > > -----邮件原件----- > > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 duntan > > > 发送时间: 2021年8月24日 17:24 > > > 收件人: devel@edk2.groups.io > > > 抄送: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew > > > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > > > <michael.d.kinney@intel.com>; Liming Gao > > > <gaoliming@byosoft.com.cn> > > > 主题: Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add > > > UefiPayloadPkg in gate-build-job.yml and CISetting.py > > > > > > Hi all, > > > Since the CI for UefiPayloadPkg is important to our develop > > > progress, would you please speed up the review process? Thanks a lot! > > > > > > Thanks, > > > Dun Tan > > > -----Original Message----- > > > From: Tan, Dun <dun.tan@intel.com> > > > Sent: Friday, August 20, 2021 2:44 PM > > > To: devel@edk2.groups.io > > > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew > > > <Bret.Barkelew@microsoft.com>; Kinney, Michael D > > > <michael.d.kinney@intel.com>; Liming Gao > > > <gaoliming@byosoft.com.cn>; Tan, Dun <dun.tan@intel.com> > > > Subject: [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in > > > gate-build-job.yml and CISetting.py > > > > > > Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for > > > UefiPayloadPkg. > > > Add UefiPayloadPkg to supported Packages in CISettings. > > > > > > Cc: Sean Brogan <sean.brogan@microsoft.com> > > > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com> > > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > > > Cc: Liming Gao <gaoliming@byosoft.com.cn> > > > Signed-off-by: DunTan <dun.tan@intel.com> > > > --- > > > .azurepipelines/templates/pr-gate-build-job.yml | 3 +++ > > > .pytool/CISettings.py | 3 ++- > > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > > > diff --git a/.azurepipelines/templates/pr-gate-build-job.yml > > > b/.azurepipelines/templates/pr-gate-build-job.yml > > > index 207acc7631..d5b16c127f 100644 > > > --- a/.azurepipelines/templates/pr-gate-build-job.yml > > > +++ b/.azurepipelines/templates/pr-gate-build-job.yml > > > @@ -48,6 +48,9 @@ jobs: > > > TARGET_SECURITY: > > > Build.Pkgs: 'SecurityPkg' > > > Build.Targets: 'DEBUG,RELEASE,NO-TARGET' > > > + TARGET_UEFIPAYLOAD: > > > + Build.Pkgs: 'UefiPayloadPkg' > > > + Build.Targets: 'DEBUG,RELEASE,NO-TARGET' > > > TARGET_PLATFORMS: > > > # For Platforms only check code. Leave it to Platform CI > > > # to build them. > > > diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index > > > 96e6baa519..ce330e2c73 100644 > > > --- a/.pytool/CISettings.py > > > +++ b/.pytool/CISettings.py > > > @@ -67,7 +67,8 @@ class Settings(CiBuildSettingsManager, > > > UpdateSettingsManager, SetupSettingsManag > > > "CryptoPkg", > > > "UnitTestFrameworkPkg", > > > "OvmfPkg", > > > - "RedfishPkg" > > > + "RedfishPkg", > > > + "UefiPayloadPkg" > > > ) > > > > > > def GetArchitecturesSupported(self): > > > -- > > > 2.31.1.windows.1 > > > > > > > > > > > > > > > > > > > > > > > > > > ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2021-09-02 2:24 UTC | newest] Thread overview: 13+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-08-20 6:43 [PATCH 0/2] Enable Core ci for UefiPayloadPkg duntan 2021-08-20 6:43 ` [PATCH 1/2] UefiPayloadPkg: Create .yaml file in UefiPayloadPkg duntan 2021-08-20 8:12 ` Ni, Ray 2021-08-20 6:43 ` [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py duntan 2021-08-24 9:23 ` duntan 2021-08-30 3:26 ` 回复: [edk2-devel] " gaoliming 2021-08-30 8:31 ` duntan 2021-08-31 1:04 ` 回复: " gaoliming 2021-09-01 3:32 ` duntan 2021-09-01 6:05 ` 回复: " gaoliming 2021-09-02 1:24 ` duntan 2021-09-02 2:09 ` 回复: " gaoliming 2021-09-02 2:24 ` duntan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox