* [edk2-platforms PATCH 0/1] Fix the AMD/OverdriveBoard and @ 2021-08-21 2:00 Rebecca Cran 2021-08-21 2:00 ` [edk2-platforms PATCH 1/1] Fix AMD/OverdriveBoard and SoftIron/Overdrive1000Board builds Rebecca Cran 0 siblings, 1 reply; 3+ messages in thread From: Rebecca Cran @ 2021-08-21 2:00 UTC (permalink / raw) To: Leif Lindholm, Michael D Kinney, Ard Biesheuvel; +Cc: Rebecca Cran, devel This patch fixes the AMD/OverdriveBoard and AMD/Overdrive1000Board builds. I don't have an AMD Overdrive, but I tested the Overdrive1000Board changes on my Overdrive 1000 system by booting openSUSE Leap 15.3 and FreeBSD 12. Rebecca Cran (1): Fix AMD/OverdriveBoard and SoftIron/Overdrive1000Board builds Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 3 ++- Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) -- 2.31.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
* [edk2-platforms PATCH 1/1] Fix AMD/OverdriveBoard and SoftIron/Overdrive1000Board builds 2021-08-21 2:00 [edk2-platforms PATCH 0/1] Fix the AMD/OverdriveBoard and Rebecca Cran @ 2021-08-21 2:00 ` Rebecca Cran 2021-08-22 13:25 ` Ard Biesheuvel 0 siblings, 1 reply; 3+ messages in thread From: Rebecca Cran @ 2021-08-21 2:00 UTC (permalink / raw) To: Leif Lindholm, Michael D Kinney, Ard Biesheuvel; +Cc: Rebecca Cran, devel BdsDxe depends on VariablePolicyHelperLib, so move it out from VariableRuntimeDxe.inf and add it to LibraryClasses.DXE_DRIVER and LibraryClasses.DXE_RUNTIMER_DRIVER. This fixes the build of AMD/OverdriveBoard and SoftIron/Overdrive1000Board. Signed-off-by: Rebecca Cran <rebecca@bsdio.com> --- Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 3 ++- Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc index bc8d8e37d6c1..31be381cf7f6 100644 --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc @@ -209,6 +209,7 @@ DEFINE X64EMU_ENABLE = FALSE PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf + VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf [LibraryClasses.common.DXE_RUNTIME_DRIVER] HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf @@ -218,6 +219,7 @@ DEFINE X64EMU_ENABLE = FALSE DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf !endif VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf + VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf [LibraryClasses.common.UEFI_APPLICATION] PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf @@ -578,7 +580,6 @@ DEFINE X64EMU_ENABLE = FALSE TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf - VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf } Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc index 38620b3e4d3b..7211f3e5629e 100644 --- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc +++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc @@ -203,6 +203,7 @@ DEFINE NUM_CORES = 4 PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf + VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf [LibraryClasses.common.DXE_RUNTIME_DRIVER] HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf @@ -212,6 +213,7 @@ DEFINE NUM_CORES = 4 DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf !endif VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf + VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf [LibraryClasses.common.UEFI_APPLICATION] PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf @@ -513,7 +515,6 @@ DEFINE NUM_CORES = 4 TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf - VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf } Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf -- 2.31.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-platforms PATCH 1/1] Fix AMD/OverdriveBoard and SoftIron/Overdrive1000Board builds 2021-08-21 2:00 ` [edk2-platforms PATCH 1/1] Fix AMD/OverdriveBoard and SoftIron/Overdrive1000Board builds Rebecca Cran @ 2021-08-22 13:25 ` Ard Biesheuvel 0 siblings, 0 replies; 3+ messages in thread From: Ard Biesheuvel @ 2021-08-22 13:25 UTC (permalink / raw) To: Rebecca Cran Cc: Leif Lindholm, Michael D Kinney, Ard Biesheuvel, edk2-devel-groups-io On Sat, 21 Aug 2021 at 04:00, Rebecca Cran <rebecca@bsdio.com> wrote: > > BdsDxe depends on VariablePolicyHelperLib, so move it out from > VariableRuntimeDxe.inf and add it to LibraryClasses.DXE_DRIVER and > LibraryClasses.DXE_RUNTIMER_DRIVER. > > This fixes the build of AMD/OverdriveBoard and > SoftIron/Overdrive1000Board. > > Signed-off-by: Rebecca Cran <rebecca@bsdio.com> Thanks for the fix Pushed as a47606201fed..0efab5febe78 > --- > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 3 ++- > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > index bc8d8e37d6c1..31be381cf7f6 100644 > --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > @@ -209,6 +209,7 @@ DEFINE X64EMU_ENABLE = FALSE > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf > + VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > > [LibraryClasses.common.DXE_RUNTIME_DRIVER] > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > @@ -218,6 +219,7 @@ DEFINE X64EMU_ENABLE = FALSE > DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > !endif > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf > + VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > > [LibraryClasses.common.UEFI_APPLICATION] > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > @@ -578,7 +580,6 @@ DEFINE X64EMU_ENABLE = FALSE > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf > VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf > - VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > } > Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf > > diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > index 38620b3e4d3b..7211f3e5629e 100644 > --- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > +++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > @@ -203,6 +203,7 @@ DEFINE NUM_CORES = 4 > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf > + VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > > [LibraryClasses.common.DXE_RUNTIME_DRIVER] > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > @@ -212,6 +213,7 @@ DEFINE NUM_CORES = 4 > DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > !endif > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf > + VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > > [LibraryClasses.common.UEFI_APPLICATION] > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > @@ -513,7 +515,6 @@ DEFINE NUM_CORES = 4 > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf > VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf > - VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > } > Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf > > -- > 2.31.1 > > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-22 13:26 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-08-21 2:00 [edk2-platforms PATCH 0/1] Fix the AMD/OverdriveBoard and Rebecca Cran 2021-08-21 2:00 ` [edk2-platforms PATCH 1/1] Fix AMD/OverdriveBoard and SoftIron/Overdrive1000Board builds Rebecca Cran 2021-08-22 13:25 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox