From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web10.20548.1629702591636811692 for ; Mon, 23 Aug 2021 00:09:59 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=YvIOtKDt; spf=temperror, err=temporary DNS error (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=0869c54ae3=gary.lin@hpe.com) Received: from pps.filterd (m0134420.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 17N73DkC017369; Mon, 23 Aug 2021 07:09:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=DO+a8+w/dtL2rsJCSvVAYTeuNHY5QathJF/gEavntJM=; b=YvIOtKDtYiEucJ52e2ZgBqrlRPiJs/p2nEvOEn/rvfRxlcBf2DHhtX6lGTYOOmgUthpc 1LEcHYXdlRpbNNI+6RokeZeOrHulFwopCYSVdxoqabJlRxm/CDLlYgw4CvZQAN4Wf8LZ /A1Fu7A/JUA32rCWA2h8NFHnkkI1vSP7fOkJlwaE4Gl6kW6kfrf80b6FJfB6KJby423z Vol/SqIdsdH5i2sIus+ovJZWGm4h8Ls7/K5L8Af1TATTg1dHJKm8gHkyT8VSv/woWV7w /RgbTMxop91cdL0qTt9EH2lGcY+th1mqk2WNVeWHF+0zpm3jp4AF0b5TIj1YLWtraYsV 5g== Received: from g4t3427.houston.hpe.com (g4t3427.houston.hpe.com [15.241.140.73]) by mx0b-002e3701.pphosted.com with ESMTP id 3ajpv6nnrk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Aug 2021 07:09:40 +0000 Received: from G9W8455.americas.hpqcorp.net (g9w8455.houston.hp.com [16.216.161.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3427.houston.hpe.com (Postfix) with ESMTPS id CF4997E; Mon, 23 Aug 2021 07:09:39 +0000 (UTC) Received: from G9W8455.americas.hpqcorp.net (2002:10d8:a15e::10d8:a15e) by G9W8455.americas.hpqcorp.net (2002:10d8:a15e::10d8:a15e) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 23 Aug 2021 07:09:39 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (15.241.52.11) by G9W8455.americas.hpqcorp.net (16.216.161.94) with Microsoft SMTP Server (TLS) id 15.0.1497.18 via Frontend Transport; Mon, 23 Aug 2021 07:09:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gZGwk3oC7V7bykMwEgKkZ2krNU2oc40GEES0/ACPmXg1Bek+eIHPnoxkeAnZe7NO4JjYLrSIw7/iyIzrhA/4TFM5YIXVjr4kGLP0stLC8WFeoePaeeJq14x+GCXXI34bn5FplGS56HzHw1KEJdvv/QzxYtRLarNqgz3rMKBu0pJKJnQtD3tn2Vqup1QIZ5DfR3iO670cFIGY/oDvU+NUmdhlaHIQCPZHpyCQD9i5geW2Ppm4EwoSt0fpvw2CtMqTl6BaoiUwWuEKC9w4JJ46+OtJGZxazoRuZd4PCJfc+n/ixupx4rJCTMhiIck6TRZpmkVjK0WrGx7u7BN/fqvj5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DO+a8+w/dtL2rsJCSvVAYTeuNHY5QathJF/gEavntJM=; b=V19Ub8KniyUWMhF0vmT3rXR9MYHccTL9zmNroHDwrf75ggHmKyIqE2/CsqZKBwNYeLwq59do3xSZhJuhyeCZhXd7Ohm70ULNGPDvJN57sk9QvkfNHbOG4/AgrHKYgIgNaa/3UVL4dT0kkO07fFKJRB7W6PerbpiIanNrYa8fjcoYk4lz8aT0VWkdBTXOmuxxqW0cgWj09uyXVFuTAMALxFdfkXL+Uj8cJAI2qQM4VnpB+PBxT8DOogxkdybwHxLdPCQ3JXs+Ej90gYZQQPtZ3bH3rhqt4UctiwoehrUvxH0OkT8S/NDh/rty35L0RX6TKdz+E19zXeUfZ4LPUh2Hyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=hpe.com; Received: from AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:741f::21) by AT5PR8401MB0611.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7426::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.21; Mon, 23 Aug 2021 07:09:38 +0000 Received: from AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM ([fe80::106b:abb8:386b:a2db]) by AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM ([fe80::106b:abb8:386b:a2db%9]) with mapi id 15.20.4436.019; Mon, 23 Aug 2021 07:09:38 +0000 From: "Lin, Gary (HPS OE-Linux)" To: CC: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Anthony Perard , Julien Grall , Jim Fehlig , Joey Li Subject: [PATCH v3 0/4] Fix OvmfXen boot failure due to s3 support state Date: Mon, 23 Aug 2021 15:09:21 +0800 Message-ID: <20210823070925.10095-1-gary.lin@hpe.com> X-Mailer: git-send-email 2.31.1 X-ClientProxiedBy: HK2PR03CA0045.apcprd03.prod.outlook.com (2603:1096:202:17::15) To AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:741f::21) X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost (111.240.132.81) by HK2PR03CA0045.apcprd03.prod.outlook.com (2603:1096:202:17::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.6 via Frontend Transport; Mon, 23 Aug 2021 07:09:37 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 21aa6725-9201-4797-e82c-08d96604f84e X-MS-TrafficTypeDiagnostic: AT5PR8401MB0611: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /sWgDPECWrFYtPBaD0wgfG/NjSNCeaZ4NRaeba+mlfDVKcbMdCtUQJTouVEAW0gAOQ8bNwaV53X1zT4/mXKkeZrWzj6jSdWy0RJV5lLj0WK43yLjVdMqE68sEQQnmov7U6PyMU2E7Qsi9BnJtc99r2YC9le1Ll0bZfSEvdWLoSCmnoRDfSQlj9GDxUP86GKq4QgqlpC7vj/aYSizwY+KLaMkx4F5bv3dIEIdZqd4shBvdsjsVkeWq2et83Mpp84mUdEIWZDqI9Gl4j4lCQt5xBTIQ1RPOWgPVAigafcmNG6pKkuyZcWZTuQ0MT8DfIj1Vwl72MUGcgAHJnqjdqxvY4kBDh6NwbU80tIG6Q826HiPwEB4bwfEE/8MorbzcPvnR1fj+YZEtnihTbdPrxEpxtAomn1rly1KmcZHxWQCYaVBo8SQLueRwJl/piCtVeZYaCfzJUyKrBPv1vGWmGOgedSmAOZVz7kvpQYPcdfYmALzAvkA97+4a/nxzuO3Kxl/En1BZYrEPIP1UC4/LL6meJZR173hSY3moMzpxYtJ6dUtDBScvcBEVnZclUGRqo9SbygAkytWNDwoZJDMTTDG1u5PPC/5994Pn8eI7PIPYQyFCev0AzWH7qFibJCrVw8i5Ehi4CuOfqf1+hJwdpxmw5JFJL4q+srB/qZ2ru6ARGoUQccSR/9YitoDXLcHEg6Ka/kcfWFd8BRlu23uBqEJXKj1mo9u5zjyi0cSv+93e/8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(346002)(136003)(376002)(366004)(396003)(39860400002)(66946007)(4326008)(966005)(66556008)(6496006)(66476007)(6916009)(186003)(478600001)(86362001)(5660300002)(26005)(19627235002)(44832011)(316002)(956004)(2906002)(54906003)(8676002)(1076003)(83380400001)(8936002)(38100700002)(36756003)(2616005)(6666004)(6486002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BHrUF99gt0SHNsK0yCawXEYxPFc6a55+DEsCp9jbchPAjq0OG7FmbTA71LEC?= =?us-ascii?Q?mDL341LYVKZKlEr/Wyq+8g2BgzTmt5J9U/ly4lntidaHiIBzQUZHNbUcRe24?= =?us-ascii?Q?tvl+FtKdhhwxwf1Zokccgt0mXLASzrIzNAMfEvGoWMHc53hTY8aYL3XuZ/Lh?= =?us-ascii?Q?nPTHSltdOBrf+a+1Bn+3yT1lTswSW57sHlA/KA10jsfYHnrTetXQAUUW1IlG?= =?us-ascii?Q?CnW90Om0lVlH18yhnyhU7rY7umCjw6QRdDC/n/8F6f7o8Ryn2C1cyHYa9wmt?= =?us-ascii?Q?lLdBDRlfcyfC05cMh8iGV0K+lWotrQWAW+nZta8dCMwAE6Zr1XKFNaGWeoW3?= =?us-ascii?Q?ZX52MlVdHyW3ky4D/+dDkevq8ieuLMtaWlmRxKkc1zhScKYGHdfkAJnDZOT7?= =?us-ascii?Q?9KXkcpKw50mxKl5VIUTxycl3zMnGY6n1dpu3wclFRVs4fuC+NdzOle9dJU/I?= =?us-ascii?Q?H38JbVB3H6MV2g21yOayojfhXMfzUl9ENbg/MG/Trw3IdepDw99sK45qzZ7G?= =?us-ascii?Q?T5MvJHE3IaInFAIDfM238FN+ciyVQNzz2BiU416VsZvypWMOLizOxoPh1A/j?= =?us-ascii?Q?DtXlZe3D+5Nsvv/p/4JvwVlcK2xVdAPY+LBmrqVG1SaYf3sH+bKNBCUo3AOC?= =?us-ascii?Q?Qo8wDsiEy8Sg4QUBBJKHvmbh0H/J2ucUI4sAEKYL6xI2URQBPKGkDpmiUcbi?= =?us-ascii?Q?KYtfRAa9OJ6iMyy96skSFV/lk/7MGLANysxJdlXP2UJ6gdIxXPsLeGSNzEXf?= =?us-ascii?Q?C+s5W25TNdsfNBwAawo/hTSHMwPCD7fmdkxoBIMlJu92LOslAQaC8zaqgVIs?= =?us-ascii?Q?HcErcoykYDmK17Nwxy1qA8MM/L0oGVKVg1bmBkOQVX4qtIuKoPpGX+S+QiQ+?= =?us-ascii?Q?EUoedglw9zyBmLXkkI6i5EBlIWhbaSv7OKCBphyp1nL8eKrO3FtjDX3LO7a5?= =?us-ascii?Q?V1bhRMhO3DTEEZkUjZ5KUy9S+h04ZeAVT7z4eLRYsK41eAyGh0tWCf+oYNEB?= =?us-ascii?Q?4O86VJ634B7UvkBpuj0JW4ZI6TvkTS4Xy4pXNypd4ORbus3r9eB9lKarHpKf?= =?us-ascii?Q?/9nKZMhRctOk0MJo8S5sgscEvR0c4aaumkNbt3WVp6zEp/f0yX3F20cRwuta?= =?us-ascii?Q?9lN5OH7a2NOG86zi2efprybfq9lzouXfEC8pXl/1PLI7m73+SMM5vdp/fy91?= =?us-ascii?Q?T778Tk18ASErJmrT6DYA/WCZUqI3VtFI183Zv2jTsokQRIANmFo3kexZu0Ol?= =?us-ascii?Q?KfoOeNtP6QtWvZFnI5yT3DHxRwZM70CwIGpR++g3zWOVDuMyRAFqs57IU1TA?= =?us-ascii?Q?W3FPVn3p1FAZtXUyqgoyPps/?= X-MS-Exchange-CrossTenant-Network-Message-Id: 21aa6725-9201-4797-e82c-08d96604f84e X-MS-Exchange-CrossTenant-AuthSource: AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2021 07:09:38.2488 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: c/01z8GtjSzd6uSS+740VmYRfXdRthrrmL8AHmfflq4ZiRx82XZ9r9vH1l0X4FlRV6jAzjuSuXTrWoeS0woBBg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AT5PR8401MB0611 X-OriginatorOrg: hpe.com X-Proofpoint-ORIG-GUID: duisijOszmzReSa0AxS3n4H43uzJXkUb X-Proofpoint-GUID: duisijOszmzReSa0AxS3n4H43uzJXkUb X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-08-23_02:2021-08-20,2021-08-23 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 spamscore=0 malwarescore=0 mlxlogscore=982 suspectscore=0 phishscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2108230047 Content-Type: text/plain Content-Transfer-Encoding: 8bit When using HVM Direct kernel boot with OvmfXen, it could fail at the S3BootScript due to the inconsistency between QemuFwCfgS3Enabled() and PcdAcpiS3Enable. This patch series initializes PcdAcpiS3Enable in . Besides, QemuFwCfgS3Enabled() is replaced with PcdAcpiS3Enable in several OVMF libraries to avoid the potential inconsistency. Bugzilla links: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 v3: - Update the description per Anthony's suggestion - Add the bugzilla links - Move the QemuKernelLoaderFsDxe patch out of this patch series and make it an independent patch v2: - Amend the description and address "HVM Direct Kernel Boot" - Add the comment for the conditional test of QemuFwCfgS3Enabled() - Remove unused QemuFwCfgLib - Update my email address Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Anthony Perard Cc: Julien Grall Cc: Jim Fehlig Cc: Joey Li Gary Lin (4): OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support OvmfPkg/Library/LockBoxLib/LockBoxDxeLib.inf | 3 +-- .../PlatformBootManagerLib.inf | 1 + OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.inf | 2 ++ OvmfPkg/XenPlatformPei/XenPlatformPei.inf | 2 ++ OvmfPkg/Library/LockBoxLib/LockBoxDxe.c | 4 +--- .../Library/PlatformBootManagerLib/BdsPlatform.c | 2 +- OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.c | 4 +--- OvmfPkg/XenPlatformPei/Platform.c | 13 +++++++++++++ 8 files changed, 22 insertions(+), 9 deletions(-) -- 2.31.1