From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, gary.lin@hpe.com
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Anthony Perard <anthony.perard@citrix.com>,
Julien Grall <julien@xen.org>, Jim Fehlig <jfehlig@suse.com>,
Joey Li <jlee@suse.com>
Subject: Re: [edk2-devel] [PATCH v3 1/4] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization
Date: Tue, 24 Aug 2021 08:45:03 +0200 [thread overview]
Message-ID: <20210824064503.ijzoosjqua27jgge@sirius.home.kraxel.org> (raw)
In-Reply-To: <20210823070925.10095-2-gary.lin@hpe.com>
> +++ b/OvmfPkg/XenPlatformPei/Platform.c
> + //
> + // This S3 conditional test is mainly for HVM Direct Kernel Boot since
> + // QEMU fwcfg isn't really supported other than that.
> + //
> + if (QemuFwCfgS3Enabled ()) {
> + DEBUG ((DEBUG_INFO, "S3 support was detected on QEMU\n"));
> + Status = PcdSetBoolS (PcdAcpiS3Enable, TRUE);
> + ASSERT_EFI_ERROR (Status);
> + }
OvmfPkg/PlatformPei/Platform.c already does that, so this makes kvm and
xen more consistent.
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
take care,
Gerd
next prev parent reply other threads:[~2021-08-24 6:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 7:09 [PATCH v3 0/4] Fix OvmfXen boot failure due to s3 support state Lin, Gary (HPS OE-Linux)
2021-08-23 7:09 ` [PATCH v3 1/4] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization Lin, Gary (HPS OE-Linux)
2021-08-23 9:35 ` Anthony PERARD
2021-08-24 6:45 ` Gerd Hoffmann [this message]
2021-08-23 7:09 ` [PATCH v3 2/4] OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support Lin, Gary (HPS OE-Linux)
2021-08-23 12:57 ` [edk2-devel] " Philippe Mathieu-Daudé
2021-08-24 6:46 ` Gerd Hoffmann
2021-08-23 7:09 ` [PATCH v3 3/4] OvmfPkg/PlatformBootManagerLib: " Lin, Gary (HPS OE-Linux)
2021-08-24 6:46 ` [edk2-devel] " Gerd Hoffmann
2021-08-23 7:09 ` [PATCH v3 4/4] OvmfPkg/SmmControl2Dxe: " Lin, Gary (HPS OE-Linux)
2021-08-24 6:46 ` [edk2-devel] " Gerd Hoffmann
2021-08-23 13:16 ` [edk2-devel] [PATCH v3 0/4] Fix OvmfXen boot failure due to s3 support state Yao, Jiewen
2021-08-24 17:21 ` Jim Fehlig
2021-08-27 13:16 ` Ard Biesheuvel
2021-08-30 3:08 ` Lin, Gary (HPS OE-Linux)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210824064503.ijzoosjqua27jgge@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox