From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web11.36030.1629787512784327188 for ; Mon, 23 Aug 2021 23:45:13 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=B/B/IjWX; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629787512; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zTHlygXUBz06a/zq2g5iAHs2NFF35lpbC1nqaABoN9Q=; b=B/B/IjWX+PUtMuTrQc0Gu+Huqc5cvhjKGabC2Gv/IyWmxu6MovvVnYjsMI1GORoup4dHbp 2H5r+VRhtmo24OhHFF17rVnc2QYrkUR/D4T2QFFn2O8bFbXdMgZX1fcSRbN8tQXWP6Cwtq 9CwNLtXs4nylkKrxYF6oyBp2RaMEZro= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-527-whUqvgrLMr6tdnhfQ4hI6Q-1; Tue, 24 Aug 2021 02:45:08 -0400 X-MC-Unique: whUqvgrLMr6tdnhfQ4hI6Q-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9E20B108088C; Tue, 24 Aug 2021 06:45:06 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.193.216]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2061817D4E; Tue, 24 Aug 2021 06:45:06 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 1BFA018000A3; Tue, 24 Aug 2021 08:45:03 +0200 (CEST) Date: Tue, 24 Aug 2021 08:45:03 +0200 From: "Gerd Hoffmann" To: devel@edk2.groups.io, gary.lin@hpe.com Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Anthony Perard , Julien Grall , Jim Fehlig , Joey Li Subject: Re: [edk2-devel] [PATCH v3 1/4] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization Message-ID: <20210824064503.ijzoosjqua27jgge@sirius.home.kraxel.org> References: <20210823070925.10095-1-gary.lin@hpe.com> <20210823070925.10095-2-gary.lin@hpe.com> MIME-Version: 1.0 In-Reply-To: <20210823070925.10095-2-gary.lin@hpe.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > +++ b/OvmfPkg/XenPlatformPei/Platform.c > + // > + // This S3 conditional test is mainly for HVM Direct Kernel Boot since > + // QEMU fwcfg isn't really supported other than that. > + // > + if (QemuFwCfgS3Enabled ()) { > + DEBUG ((DEBUG_INFO, "S3 support was detected on QEMU\n")); > + Status = PcdSetBoolS (PcdAcpiS3Enable, TRUE); > + ASSERT_EFI_ERROR (Status); > + } OvmfPkg/PlatformPei/Platform.c already does that, so this makes kvm and xen more consistent. Reviewed-by: Gerd Hoffmann take care, Gerd