From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web12.35821.1629787600465280254 for ; Mon, 23 Aug 2021 23:46:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=RNhifw0V; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629787599; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jdAX1peQ91L97+LOESJw2YG805oQ8UP17VKtI54qWnk=; b=RNhifw0VdM66jjzUE+QGwGi4H14AYjkU6+QEa//eGcePmeSiBhjeQrmEdrwxHlZxI95iO4 yNNZzSh1dRXGDhdMiRsTH+12AQhCUFfDgH+qU75Ij0ubVNWy7QjVWV+kNc0a0+/TOXUiJf pzwFoZBBMXwLw/nwsj3d1UZ4y9Pvl4c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-405-R_nkmUkaP7-EhME94n-6tQ-1; Tue, 24 Aug 2021 02:46:34 -0400 X-MC-Unique: R_nkmUkaP7-EhME94n-6tQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 49CFC1082929; Tue, 24 Aug 2021 06:46:33 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.193.216]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E670F19C44; Tue, 24 Aug 2021 06:46:32 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id EA48518000A3; Tue, 24 Aug 2021 08:46:27 +0200 (CEST) Date: Tue, 24 Aug 2021 08:46:27 +0200 From: "Gerd Hoffmann" To: devel@edk2.groups.io, gary.lin@hpe.com Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Jim Fehlig , Joey Li Subject: Re: [edk2-devel] [PATCH v3 2/4] OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support Message-ID: <20210824064627.5qgxvu6rjdlqaclx@sirius.home.kraxel.org> References: <20210823070925.10095-1-gary.lin@hpe.com> <20210823070925.10095-3-gary.lin@hpe.com> MIME-Version: 1.0 In-Reply-To: <20210823070925.10095-3-gary.lin@hpe.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Aug 23, 2021 at 03:09:23PM +0800, Lin, Gary (HPS OE-Linux) wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=3573 > > To avoid the potential inconsistency between PcdAcpiS3Enable and > QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect > S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Reviewed-by: Gerd Hoffmann