From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web09.35939.1629787615810867044 for ; Mon, 23 Aug 2021 23:46:56 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MOO+TU8a; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629787615; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UH5HVNGfx6BU0quSWZYAQyVPhbKswBi76JLqHar7mj4=; b=MOO+TU8aKE1dhv998kURoNVUDI0XeN97gn1LRzNQlEUuRVhaVt4M3iN/F2lUTwXgjVrLR/ Vq4E5LZ9SnCvPYAaL+zqu7FW+XwygMbv4EC3zYghNsk6WuGZdW1qnviobocOe9QmQE7quG 5v9ZsJax6S/uo8LTS5tGi00ZjSwcFBE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-56-jEl1L53gPdCaLT8_wJglVg-1; Tue, 24 Aug 2021 02:46:53 -0400 X-MC-Unique: jEl1L53gPdCaLT8_wJglVg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E292B10082E7; Tue, 24 Aug 2021 06:46:48 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.193.216]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A0D585DEFA; Tue, 24 Aug 2021 06:46:48 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id A7E8A18000A3; Tue, 24 Aug 2021 08:46:41 +0200 (CEST) Date: Tue, 24 Aug 2021 08:46:41 +0200 From: "Gerd Hoffmann" To: devel@edk2.groups.io, gary.lin@hpe.com Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Jim Fehlig , Joey Li Subject: Re: [edk2-devel] [PATCH v3 3/4] OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support Message-ID: <20210824064641.5vj2adpfxgiu6ykz@sirius.home.kraxel.org> References: <20210823070925.10095-1-gary.lin@hpe.com> <20210823070925.10095-4-gary.lin@hpe.com> MIME-Version: 1.0 In-Reply-To: <20210823070925.10095-4-gary.lin@hpe.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Aug 23, 2021 at 03:09:24PM +0800, Lin, Gary (HPS OE-Linux) wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=3573 > > To avoid the potential inconsistency between PcdAcpiS3Enable and > QemuFwCfgS3Enabled(), this commit modifies PlatformBootManagerLib to > detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Reviewed-by: Gerd Hoffmann