* [edk2-platforms][PATCH v2 1/4] KabylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile
@ 2021-08-28 20:37 Benjamin Doron
2021-08-28 20:37 ` [edk2-platforms][PATCH v2 2/4] CometlakeOpenBoardPkg/Acpi: " Benjamin Doron
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Benjamin Doron @ 2021-08-28 20:37 UTC (permalink / raw)
To: devel; +Cc: Chasel Chiu, Nate DeSimone
Follow AcpiPlatformDxe (from which this module is derived) and install
all ACPI tables added by board.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com>
---
Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c | 15 ++++++++++++++-
Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf | 2 ++
2 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c
index 0361ffc2fbf9..c6df1714af9a 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c
+++ b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c
@@ -288,7 +288,20 @@ InstallAcpiBoard (
//
// Platform ACPI Tables
//
- PublishAcpiTablesFromFv (&gEfiCallerIdGuid);
+ Status = PublishAcpiTablesFromFv (&gEfiCallerIdGuid);
+ if (EFI_ERROR (Status)) {
+ DEBUG ((DEBUG_ERROR, "Error: PublishAcpiTablesFromFv[%g] - %r", &gEfiCallerIdGuid, Status));
+ }
+ Status = PublishAcpiTablesFromFv (PcdGetPtr (PcdAcpiTableStorageFile));
+ if (EFI_ERROR (Status)) {
+ DEBUG ((
+ DEBUG_ERROR,
+ "Error: PublishAcpiTablesFromFv[%g] - %r",
+ PcdGetPtr (PcdAcpiTableStorageFile),
+ Status
+ ));
+ DEBUG ((DEBUG_INFO, "Does board contain ACPI tables?\n"));
+ }
//
// This protocol publish must be done after PublishAcpiTablesFromFv.
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf
index 5d3d4c3a2b33..7b400cf967f3 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf
+++ b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf
@@ -67,6 +67,8 @@
gKabylakeOpenBoardPkgTokenSpaceGuid.PcdDisablePassiveTripPoints
gKabylakeOpenBoardPkgTokenSpaceGuid.PcdDisableCriticalTripPoints
+ gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiTableStorageFile
+
[Depex]
gEfiAcpiTableProtocolGuid AND
gEfiFirmwareVolume2ProtocolGuid AND
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [edk2-platforms][PATCH v2 2/4] CometlakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile
2021-08-28 20:37 [edk2-platforms][PATCH v2 1/4] KabylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile Benjamin Doron
@ 2021-08-28 20:37 ` Benjamin Doron
2021-08-28 20:37 ` [edk2-platforms][PATCH v2 3/4] MinPlatformPkg/Acpi: MinDsdt " Benjamin Doron
2021-08-28 20:37 ` [edk2-platforms][PATCH v2 4/4] WhiskeylakeOpenBoardPkg/Acpi: BoardAcpiDxe " Benjamin Doron
2 siblings, 0 replies; 4+ messages in thread
From: Benjamin Doron @ 2021-08-28 20:37 UTC (permalink / raw)
To: devel
Cc: Chasel Chiu, Nate DeSimone, Rangasai V Chaganty,
Deepika Kethi Reddy, Kathappan Esakkithevar
Follow AcpiPlatformDxe (from which this module is derived) and install
all ACPI tables added by board.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com>
---
Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c | 15 ++++++++++++++-
Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf | 2 ++
2 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c b/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c
index 7fc71bca644a..ba59c84fd4ba 100644
--- a/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c
+++ b/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c
@@ -270,7 +270,20 @@ InstallAcpiBoard (
//
// Platform ACPI Tables
//
- PublishAcpiTablesFromFv (&gEfiCallerIdGuid);
+ Status = PublishAcpiTablesFromFv (&gEfiCallerIdGuid);
+ if (EFI_ERROR (Status)) {
+ DEBUG ((DEBUG_ERROR, "Error: PublishAcpiTablesFromFv[%g] - %r", &gEfiCallerIdGuid, Status));
+ }
+ Status = PublishAcpiTablesFromFv (PcdGetPtr (PcdAcpiTableStorageFile));
+ if (EFI_ERROR (Status)) {
+ DEBUG ((
+ DEBUG_ERROR,
+ "Error: PublishAcpiTablesFromFv[%g] - %r",
+ PcdGetPtr (PcdAcpiTableStorageFile),
+ Status
+ ));
+ DEBUG ((DEBUG_INFO, "Does board contain ACPI tables?\n"));
+ }
//
// This protocol publish must be done after PublishAcpiTablesFromFv.
diff --git a/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf b/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf
index 09b67376fbc1..e201964a6896 100644
--- a/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf
+++ b/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf
@@ -62,6 +62,8 @@
gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemBase
gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemLimit
+ gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiTableStorageFile
+
[Depex]
gEfiAcpiTableProtocolGuid AND
gEfiFirmwareVolume2ProtocolGuid AND
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [edk2-platforms][PATCH v2 3/4] MinPlatformPkg/Acpi: MinDsdt also installs all PcdAcpiTableStorageFile
2021-08-28 20:37 [edk2-platforms][PATCH v2 1/4] KabylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile Benjamin Doron
2021-08-28 20:37 ` [edk2-platforms][PATCH v2 2/4] CometlakeOpenBoardPkg/Acpi: " Benjamin Doron
@ 2021-08-28 20:37 ` Benjamin Doron
2021-08-28 20:37 ` [edk2-platforms][PATCH v2 4/4] WhiskeylakeOpenBoardPkg/Acpi: BoardAcpiDxe " Benjamin Doron
2 siblings, 0 replies; 4+ messages in thread
From: Benjamin Doron @ 2021-08-28 20:37 UTC (permalink / raw)
To: devel; +Cc: Chasel Chiu, Nate DeSimone, Liming Gao, Eric Dong
Follow AcpiPlatformDxe (from which this module is derived) and install
all ACPI tables added by board.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com>
---
Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c | 10 ++++++++++
Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf | 3 +++
2 files changed, 13 insertions(+)
diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c
index 9bc222453857..ac343afca7d4 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c
+++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c
@@ -227,6 +227,16 @@ InstallMinDsdt (
Status = PublishAcpiTablesFromFv (&gEfiCallerIdGuid);
ASSERT_EFI_ERROR (Status);
+ Status = PublishAcpiTablesFromFv (PcdGetPtr (PcdAcpiTableStorageFile));
+ if (EFI_ERROR (Status)) {
+ DEBUG ((
+ DEBUG_ERROR,
+ "Error: PublishAcpiTablesFromFv[%g] - %r",
+ PcdGetPtr (PcdAcpiTableStorageFile),
+ Status
+ ));
+ DEBUG ((DEBUG_INFO, "Does board contain ACPI tables?\n"));
+ }
return EFI_SUCCESS;
}
diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
index 3437bc489cd3..dc32186eb361 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
+++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
@@ -21,6 +21,7 @@
[Packages]
MdePkg/MdePkg.dec
+ MdeModulePkg/MdeModulePkg.dec
MinPlatformPkg/MinPlatformPkg.dec
[LibraryClasses]
@@ -41,6 +42,8 @@
gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemBase
gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemLimit
+ gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiTableStorageFile
+
[Depex]
gEfiAcpiTableProtocolGuid AND
gEfiFirmwareVolume2ProtocolGuid
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [edk2-platforms][PATCH v2 4/4] WhiskeylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile
2021-08-28 20:37 [edk2-platforms][PATCH v2 1/4] KabylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile Benjamin Doron
2021-08-28 20:37 ` [edk2-platforms][PATCH v2 2/4] CometlakeOpenBoardPkg/Acpi: " Benjamin Doron
2021-08-28 20:37 ` [edk2-platforms][PATCH v2 3/4] MinPlatformPkg/Acpi: MinDsdt " Benjamin Doron
@ 2021-08-28 20:37 ` Benjamin Doron
2 siblings, 0 replies; 4+ messages in thread
From: Benjamin Doron @ 2021-08-28 20:37 UTC (permalink / raw)
To: devel; +Cc: Chasel Chiu, Nate DeSimone
Follow AcpiPlatformDxe (from which this module is derived) and install
all ACPI tables added by board.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com>
---
Platform/Intel/WhiskeylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c | 15 ++++++++++++++-
Platform/Intel/WhiskeylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf | 2 ++
2 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c b/Platform/Intel/WhiskeylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c
index cb5f328a3909..c8c1e0cc2cf2 100644
--- a/Platform/Intel/WhiskeylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c
+++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c
@@ -270,7 +270,20 @@ InstallAcpiBoard (
//
// Platform ACPI Tables
//
- PublishAcpiTablesFromFv (&gEfiCallerIdGuid);
+ Status = PublishAcpiTablesFromFv (&gEfiCallerIdGuid);
+ if (EFI_ERROR (Status)) {
+ DEBUG ((DEBUG_ERROR, "Error: PublishAcpiTablesFromFv[%g] - %r", &gEfiCallerIdGuid, Status));
+ }
+ Status = PublishAcpiTablesFromFv (PcdGetPtr (PcdAcpiTableStorageFile));
+ if (EFI_ERROR (Status)) {
+ DEBUG ((
+ DEBUG_ERROR,
+ "Error: PublishAcpiTablesFromFv[%g] - %r",
+ PcdGetPtr (PcdAcpiTableStorageFile),
+ Status
+ ));
+ DEBUG ((DEBUG_INFO, "Does board contain ACPI tables?\n"));
+ }
//
// This protocol publish must be done after PublishAcpiTablesFromFv.
diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf b/Platform/Intel/WhiskeylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf
index af5c8f1c0609..f17fb588ddb8 100644
--- a/Platform/Intel/WhiskeylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf
+++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf
@@ -60,6 +60,8 @@
gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdDisablePassiveTripPoints
gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdDisableCriticalTripPoints
+ gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiTableStorageFile
+
[Depex]
gEfiAcpiTableProtocolGuid AND
gEfiFirmwareVolume2ProtocolGuid AND
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-28 20:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-28 20:37 [edk2-platforms][PATCH v2 1/4] KabylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile Benjamin Doron
2021-08-28 20:37 ` [edk2-platforms][PATCH v2 2/4] CometlakeOpenBoardPkg/Acpi: " Benjamin Doron
2021-08-28 20:37 ` [edk2-platforms][PATCH v2 3/4] MinPlatformPkg/Acpi: MinDsdt " Benjamin Doron
2021-08-28 20:37 ` [edk2-platforms][PATCH v2 4/4] WhiskeylakeOpenBoardPkg/Acpi: BoardAcpiDxe " Benjamin Doron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox