From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web08.14058.1630309265217218422
 for <devel@edk2.groups.io>;
 Mon, 30 Aug 2021 00:41:05 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gua458Vr;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1630309264;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=khUw8B815Ee8wU9LL4xvnUnDEJresfb+f/CqqZx8vME=;
	b=gua458VrfZ7fEfmK4Hs3CIfxL336T1hvm41xyJF/bfa3Qb59q2L2UO09Vh5G8vRiauxfcs
	tZTs9b8MLdutXe5+RiRM6XWpGBHRFxWSOUuuIE1QBwf3NX8J/DNXpPw76QRSKMWeUIFrRz
	kOPee5zwCq8M6JrByEqWrB0FMIRyb2s=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-487-kzLBBxO1NQCGzdgEFvFc2w-1; Mon, 30 Aug 2021 03:41:02 -0400
X-MC-Unique: kzLBBxO1NQCGzdgEFvFc2w-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C6EAF1018F72;
	Mon, 30 Aug 2021 07:41:00 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.91])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 173725D9CA;
	Mon, 30 Aug 2021 07:41:00 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 6B39F18007A8; Mon, 30 Aug 2021 09:40:58 +0200 (CEST)
Date: Mon, 30 Aug 2021 09:40:58 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V5 2/2] OvmfPkg/ResetVector: Enable Intel TDX in ResetVector of Ovmf
Message-ID: <20210830074058.22gfqmzrha4su6fh@sirius.home.kraxel.org>
References: <cover.1630289827.git.min.m.xu@intel.com>
 <81c97a782bbbf83043854ad8a86d14604918d788.1630289827.git.min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <81c97a782bbbf83043854ad8a86d14604918d788.1630289827.git.min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

>  _TdxPageTable:
>     If 5-level page table is supported (GPAW is 52), a top level page
>     directory pointers (1 * 256TB entry) is generated in this page.
>  _OvmfPageTable:
>     Initial page table for standard Ovmf.

Hmm, isn't 5-level paging independent from TDX?  Why mix the two?

I think a top level page directory should be added to the standard ovmf
initial page tables instead, and setting up 5-level paging should not
happen in tdx-specific code.

take care,
  Gerd