From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web08.6528.1630373499178350452 for ; Mon, 30 Aug 2021 18:31:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=Pab5cjzn; spf=temperror, err=temporary DNS error (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=087783c359=gary.lin@hpe.com) Received: from pps.filterd (m0148664.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 17V1IsP2003365; Tue, 31 Aug 2021 01:31:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=1Z1Lnr9BvI3VWNqh4X+i4uPYIMiDpss6kHxKrjRF1To=; b=Pab5cjznl+uZtP48I1iPMRPv2hLfxfuREBuw458VLXZ3cIjr/OyQnVeSzMgLnWjw1sce bRvr8k3I2w08aMrLW9m7JvQyz4hS2ucALVfdEo8F0so6GKeuDQKw1z7QS1hhTmw8GQtn dT+zkI/DXgH6iAsMGoyX3fu4FbsWMI/AiWV2g0fGhxvjZCnpghfAn8nxUbsqTtkLYW89 3foNV/R0OReFFhFV7wqB5e1TRHg2xD8Y1IwUNyVTQ77h+LgmLxfw8jcK12TdV9swYkCa iOf2Vm2g6W/qs0RxTAtryUaxDJwUF7fSADN9xXLc3FiXDXr58TLfyChGrC1a/PfTTWwa 8w== Received: from g9t5008.houston.hpe.com (g9t5008.houston.hpe.com [15.241.48.72]) by mx0b-002e3701.pphosted.com with ESMTP id 3arpqs8jmj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 31 Aug 2021 01:31:26 +0000 Received: from G1W8106.americas.hpqcorp.net (g1w8106.austin.hp.com [16.193.72.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g9t5008.houston.hpe.com (Postfix) with ESMTPS id 0124960; Tue, 31 Aug 2021 01:31:25 +0000 (UTC) Received: from G9W9209.americas.hpqcorp.net (16.220.66.156) by G1W8106.americas.hpqcorp.net (16.193.72.61) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 31 Aug 2021 01:31:22 +0000 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (15.241.52.10) by G9W9209.americas.hpqcorp.net (16.220.66.156) with Microsoft SMTP Server (TLS) id 15.0.1497.18 via Frontend Transport; Tue, 31 Aug 2021 01:31:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZpngLXqdasamE224O4YXTPd6BkKurTpOnoerZGWtQrnvlimPh6hxrzKpoLCUvShYA5OdO+bhXHeTRG9pORzJOS4mGwnAcef7JScSTb1pUswVipKLTfuq9QkegAoGXXOflVKdl4wmsRdqiZaduqCVQce6UE2H6wPKQX7dhA/ubfhdnEEd437oG1WLadB/SI4vStRh/GjYeXTeDs9GFxIVot+hAO8rls0hPI0az2WDNY0V/cZQ1Vc/QW9xzQFnsRe60Y0uE9VUc2O+DqphAmj0c9ucQ25n3F5LkGeF5YzIZQThQZxf5PBbNqumANmUqYFQblyR26RGPJj3uZlXTc9GRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1Z1Lnr9BvI3VWNqh4X+i4uPYIMiDpss6kHxKrjRF1To=; b=hNXAunG8dXiW10lqM/EEV86gXOad+waDnCS4Yh4nTMGqU2q/hZKPU5O0Sg5wvwyZ4GxQzQyb6Ro8cw6AomrsWZcpxpJpFdggHjyMUI1a6Yocy0xIbW1q2FOiixZxXv+8TYHFEdPizTnzhliJI8I+Q2Zc6FZGf/2XkPMlL3zTI9oFbtNT/KlqNLlWnGrJLowTOYG/EC5HzDt/kSvOMTQj2fvErkfxSDV6JRsGYOjOCGjd4hB0ADToHruSRrITlm6pf8eMzpRLbioz0ffOBaqqlzb1ie01VyPNzhK53v7h4WN6OHgfNUr7/J2Jqp4alVFCpUsFfoAZY8pcxKVCeS1VAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=hpe.com; Received: from AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:741f::21) by AT5PR8401MB0355.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7425::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.24; Tue, 31 Aug 2021 01:31:22 +0000 Received: from AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM ([fe80::106b:abb8:386b:a2db]) by AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM ([fe80::106b:abb8:386b:a2db%9]) with mapi id 15.20.4436.019; Tue, 31 Aug 2021 01:31:22 +0000 From: "Lin, Gary (HPS OE-Linux)" To: CC: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann , Anthony Perard , Julien Grall , Jim Fehlig , Joey Li Subject: [RESEND PATCH v3 0/4] Fix OvmfXen boot failure due to s3 support state Date: Tue, 31 Aug 2021 09:31:11 +0800 Message-ID: <20210831013115.23110-1-gary.lin@hpe.com> X-Mailer: git-send-email 2.31.1 X-ClientProxiedBy: HK2PR04CA0065.apcprd04.prod.outlook.com (2603:1096:202:14::33) To AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:741f::21) X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost (111.240.119.140) by HK2PR04CA0065.apcprd04.prod.outlook.com (2603:1096:202:14::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17 via Frontend Transport; Tue, 31 Aug 2021 01:31:21 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5fd46fa1-9899-4eda-2fb4-08d96c1f0a12 X-MS-TrafficTypeDiagnostic: AT5PR8401MB0355: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: H89OqE32VB7RJWJJ6U4KEKHqbJ5x8JkXtQix2Jz7whT5D22xMDfBiipTLezkrt4s7A0mhBr3MP04LByHH0L6gfFO2wchY57b3qKYCGMkExhBh3jRP32FLNrEPzu8+nqYA24mYc//CavhH/hV00cgzb6oQgxkjOW5vn4sZhhSZJSONfTyPJ6jT7ioZNS6nAcClcHR1dLcy89Z+WJOsSNbAfWRusYtgbQEzcA0TUpefxKsvFgVZw7asAYtE8JvDKkQJ3j9zjt/FsQodCQ1VS4ufxNWfEKq2WVc0mag7HNl7zoEsIw99q2jHFGISVchohQU4cayGCpthb9IFpXOUPjmgvX6b++btB3GCyVl5fLf9proSQEDlZKuQfGxavh2SoamwsQa5TpIuL4ZksQDzwawibBqquFTOapxeNu5V+2lhDx9G+39ano5NxZvrf16p8kIjiwl0uMRo5zXbTbspknNEykyVXe5VJ/wn6x+Tz1d7mLW7NOksqqrW5T9loT9+Qr9uYuV1HxPRmx+GGwJvjdauCC5TdqDhji5cqBgqAwzQVvnv15jv6s9Y3RDKrXs+clihqC9zc5H3ubLG8wpyaJuiYElFi92PlBjU7BT1a+dEc/RcOp5taBmcTqr9lOLFKAFn0ssGd6NUvHZlhP0/qkuZLC/wdHRUjY79XChlFkgEZt+ToOQBhJzqc9ymAY/dDeXkxLzodFkQeKMTflVTbx4X37n3QYiOx7lol1HZWP27vw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(136003)(376002)(396003)(39860400002)(346002)(366004)(66946007)(83380400001)(2906002)(2616005)(66556008)(86362001)(8676002)(956004)(6666004)(186003)(19627235002)(8936002)(4326008)(66476007)(36756003)(6496006)(44832011)(6486002)(1076003)(54906003)(966005)(5660300002)(6916009)(316002)(478600001)(26005)(38100700002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ztyy6HIXAuN5Wim/b3aWhioxWNoO1TJLmnH5qmNm5Tg4uBUKHGgt+fGaw/Ez?= =?us-ascii?Q?PCBfTs9M6cuQFkn0Lc8AKVl93Kx88MhjwCB45fwd7D7hluOQ/RN8ldYQYTJ0?= =?us-ascii?Q?eQUhyuVnMO3g4wX1uFVOCScM11+FosI6jpjrTeomPzmvZyWU0i4f39Rfihlm?= =?us-ascii?Q?Ka14lHThQOsCyLmJ7RhI1ammhYgZ7gnweyzIX5USKeHsll/SYzqftYg8Z8dj?= =?us-ascii?Q?pXbgS7FzwmY1mpazbwD2RMLRl2k8N9M4jug8myXEY6MztGz8cz2XjaTIFQpG?= =?us-ascii?Q?j6zTD6enFwE1FGZG1vle2TSeSURO1FMsjdII3koR/qyuyeAKADVHyoHN28qa?= =?us-ascii?Q?38tdEfo6L70o0OqF/Gf1L7g3/uDASFGL7LfiYfVxpLEkZ8iPfLSXgQOwegwB?= =?us-ascii?Q?r3aYihJPz2Ap7G6H1JLQfHu8eFw1WhC4JBbw7YTKDSlx2babHxF66NaQCu0C?= =?us-ascii?Q?9XDRI879AdR6TUeDw9Y7akq1HVjAPusE/4rceCQt8XBY2evU440ob60BNupx?= =?us-ascii?Q?ZpNU0uI71uCSVBRyZZOYGjW5TF2WtLx65fk2XmkWV8JBcWKxLcgg2+lGuOpI?= =?us-ascii?Q?3AkzT+pLxNGYMug9ksrCXhYeOQzQGGOjTqpMLBHpYWo3Bn5J1rVyx+mo2B7h?= =?us-ascii?Q?yrtSTt20jnAO2+XhiVQ30p8XcS7jaY9urZ0NAHnGrEtD3EEnCIDwFkvJBHCl?= =?us-ascii?Q?pb2xZc5FhUdk7Vyt6svk58t2nDngjATJsvW3CxMgyjXhYKkCj9HfRWDAw0+U?= =?us-ascii?Q?MCJD2dsSXhNrnTDk4SGjncQH0Bb5ye7zOgkIr8mUNRvIN96r4vMLwhR/sgZ7?= =?us-ascii?Q?r4bKYCDf1MfTdpA8CaQZfd4fnFJ9ECh6GCE/MdP8jiOn4LnqphW/+sDM+FGM?= =?us-ascii?Q?wWwAm6Ff7bpQWmFlB09DWYR937u++qlX17Tgzo69ssZfVYuldA0QlB8+rAJd?= =?us-ascii?Q?EeCl0AL8K8dteOrTp2TjjxdRvKfJSqcB6sQrf1jUpXQMUMl9I0arzC5TWtfI?= =?us-ascii?Q?HFnPAbiesRKvHkQYve2tc4uAkebub9oBM1dJ4RqjGIQ/kjGk/33ogZdk+VRp?= =?us-ascii?Q?JUko+4L+nmwuVHEJccSgT+5x53Fj7Qkf2V8Wx40pRq8zhw/kzO+NeIuPQ68D?= =?us-ascii?Q?MIalyPRoW/JhvZt0doKoZryoVR7wiVv6Xt1q5gbjUhkFnTRKhavtwQM8BSr6?= =?us-ascii?Q?EwEy6u1PVebYAa6UTYXgbmdGGqcxrS0mtpLork4tL10628F2iouwOpmNJXl+?= =?us-ascii?Q?YGWgx+t2nE40cNkgQBRjEuOi8OgqncqBxea72GfZNr6tlmZfFl/5qRFJbJsi?= =?us-ascii?Q?ct/JZKo0Cq4MIARzSFMSSbm7?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5fd46fa1-9899-4eda-2fb4-08d96c1f0a12 X-MS-Exchange-CrossTenant-AuthSource: AT5PR8401MB0387.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2021 01:31:21.9575 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YrJwpYEVfX/wNcWCJ52eZIuWKLQPh5Jr0rv/6JZHaLo/vgtVaQSsQaZ1I9SKCvbkPSuO9KmR8VVWV6U6qCaEdA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AT5PR8401MB0355 X-OriginatorOrg: hpe.com X-Proofpoint-GUID: o4jMJzhH9ng7pDIznw74A8CiHUon_S1A X-Proofpoint-ORIG-GUID: o4jMJzhH9ng7pDIznw74A8CiHUon_S1A X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-08-30_06:2021-08-30,2021-08-30 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 mlxlogscore=999 adultscore=0 phishscore=0 suspectscore=0 mlxscore=0 malwarescore=0 bulkscore=0 clxscore=1015 impostorscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2108310006 Content-Type: text/plain Content-Transfer-Encoding: 8bit When using HVM Direct kernel boot with OvmfXen, it could fail at the S3BootScript due to the inconsistency between QemuFwCfgS3Enabled() and PcdAcpiS3Enable. This patch series initializes PcdAcpiS3Enable in . Besides, QemuFwCfgS3Enabled() is replaced with PcdAcpiS3Enable in several OVMF libraries to avoid the potential inconsistency. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 v3: - Update the description per Anthony's suggestion - Add the bugzilla links - Move the QemuKernelLoaderFsDxe patch out of this patch series and make it an independent patch v2: - Amend the description and address "HVM Direct Kernel Boot" - Add the comment for the conditional test of QemuFwCfgS3Enabled() - Remove unused QemuFwCfgLib - Update my email address Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Anthony Perard Cc: Julien Grall Cc: Jim Fehlig Cc: Joey Li Gary Lin (4): OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support OvmfPkg/Library/LockBoxLib/LockBoxDxeLib.inf | 3 +-- .../PlatformBootManagerLib.inf | 1 + OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.inf | 2 ++ OvmfPkg/XenPlatformPei/XenPlatformPei.inf | 2 ++ OvmfPkg/Library/LockBoxLib/LockBoxDxe.c | 4 +--- .../Library/PlatformBootManagerLib/BdsPlatform.c | 2 +- OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.c | 4 +--- OvmfPkg/XenPlatformPei/Platform.c | 13 +++++++++++++ 8 files changed, 22 insertions(+), 9 deletions(-) -- 2.31.1