* [edk2-platforms] [PATCH V1] SimicsOpenBoardPkg: Fix GCC Build
@ 2021-08-31 23:40 Nate DeSimone
2021-09-01 6:34 ` Michael D Kinney
0 siblings, 1 reply; 2+ messages in thread
From: Nate DeSimone @ 2021-08-31 23:40 UTC (permalink / raw)
To: devel; +Cc: Agyeman Prince, Michael D Kinney
Cc: Agyeman Prince <prince.agyeman@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
.../SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc
index 251f46f812..88009b8f10 100644
--- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc
+++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc
@@ -221,8 +221,6 @@
gEfiMdeModulePkgTokenSpaceGuid.PcdSmiHandlerProfilePropertyMask|0x1
!endif
gEfiMdeModulePkgTokenSpaceGuid.PcdUse1GPageTable|TRUE
- gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|1024
- gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|600
gPcAtChipsetPkgTokenSpaceGuid.PcdHpetBaseAddress|0xFED00000
######################################
@@ -238,6 +236,8 @@
gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiS3Enable|FALSE
gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvStoreReserved|0
gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase64|0
+ gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|1024
+ gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|600
######################################
# Board Configuration
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [edk2-platforms] [PATCH V1] SimicsOpenBoardPkg: Fix GCC Build
2021-08-31 23:40 [edk2-platforms] [PATCH V1] SimicsOpenBoardPkg: Fix GCC Build Nate DeSimone
@ 2021-09-01 6:34 ` Michael D Kinney
0 siblings, 0 replies; 2+ messages in thread
From: Michael D Kinney @ 2021-09-01 6:34 UTC (permalink / raw)
To: Desimone, Nathaniel L, devel@edk2.groups.io, Kinney, Michael D
Cc: Agyeman, Prince
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Sent: Tuesday, August 31, 2021 4:40 PM
> To: devel@edk2.groups.io
> Cc: Agyeman, Prince <prince.agyeman@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [edk2-platforms] [PATCH V1] SimicsOpenBoardPkg: Fix GCC Build
>
> Cc: Agyeman Prince <prince.agyeman@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
> .../SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc
> b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc
> index 251f46f812..88009b8f10 100644
> --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc
> +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc
> @@ -221,8 +221,6 @@
> gEfiMdeModulePkgTokenSpaceGuid.PcdSmiHandlerProfilePropertyMask|0x1
> !endif
> gEfiMdeModulePkgTokenSpaceGuid.PcdUse1GPageTable|TRUE
> - gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|1024
> - gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|600
> gPcAtChipsetPkgTokenSpaceGuid.PcdHpetBaseAddress|0xFED00000
>
> ######################################
> @@ -238,6 +236,8 @@
> gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiS3Enable|FALSE
> gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvStoreReserved|0
> gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase64|0
> + gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|1024
> + gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|600
>
> ######################################
> # Board Configuration
> --
> 2.27.0.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-01 6:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-31 23:40 [edk2-platforms] [PATCH V1] SimicsOpenBoardPkg: Fix GCC Build Nate DeSimone
2021-09-01 6:34 ` Michael D Kinney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox