From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web12.4323.1630477533063981282 for ; Tue, 31 Aug 2021 23:25:33 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=B8izvZjY; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630477532; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xbH3n84BhA5lT7daxU70NmS1h/2DGIQzh/lTgTM//TM=; b=B8izvZjYB9faYwjpaM4NreRS2a0c5ihVS8RfZJ3xMbV2BwVAEQKE7KWxxrOtuYSi4gM8gX +9IjHeIoni/ij6NyCj9e9PmFzoh9E38oB77f8QHeb8yWLsBs5+gU5zB/gw7LpiAVNLhK1o HQGoceUUbabRpPp6AvD0joZq68R3x2Y= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-495-9gLJTLZZNtC_7sy8gp-HTw-1; Wed, 01 Sep 2021 02:25:29 -0400 X-MC-Unique: 9gLJTLZZNtC_7sy8gp-HTw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E6E23760C1; Wed, 1 Sep 2021 06:25:25 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.91]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 23C4A5C1A1; Wed, 1 Sep 2021 06:25:25 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 82E4B180038E; Wed, 1 Sep 2021 08:25:23 +0200 (CEST) Date: Wed, 1 Sep 2021 08:25:23 +0200 From: "Gerd Hoffmann" To: "Xu, Min M" Cc: "devel@edk2.groups.io" , Brijesh Singh , "Dong, Eric" , Erdem Aktas , "Wu, Hao A" , "Wang, Jian J" , James Bottomley , "Yao, Jiewen" , Liming Gao , "Kinney, Michael D" , "Ni, Ray" , "Kumar, Rahul1" , Tom Lendacky , "Liu, Zhiguang" Subject: Re: [edk2-devel] [PATCH 00/23] Enable Intel TDX in OvmfPkg (SEC/PEI) Message-ID: <20210901062523.gkmkqmoxjgusaapj@sirius.home.kraxel.org> References: <20210831104540.4um7x5zz4aq3oaq6@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, > Because the total patch-sets for TDVF upstreaming is too big and there are 2 configurations. > So we split the upstreaming into below waves. > Config-A Config-B Phase > Wave-1 Y Y ResetVector > Wave-2 Y N SEC/PEI > Wave-3 Y N DXE > Wave-4 N Y SEC (PEI is skipped) > Wave-5 N Y DXE > > So this patch-set is wave-2 and for Config-A (SEC/PEI). Thanks (please add that info to the cover letter in the future). > > Apparently some of the additional features supported by config-b are either > > more difficult or impossible to implement in config-a. > > Is that correct? Is that explained in more detail somewhere? > It's correct. Some additional features are not supported in Config-A. For example the TD > RTMR based measured boot. Why is TD RTMR based measured boot not supported in Config-A? I'm trying to understand why we need Config-B. Having two variants with completely different initialization code paths (with/without PEI) doesn't look like a good plan to me. I'd rather support everything in Config-A if possible. take care, Gerd