public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>
Cc: "Gao, Jiaqi" <jiaqi.gao@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Wang, Jian J" <jian.j.wang@intel.com>,
	"Wu, Hao A" <hao.a.wu@intel.com>,
	"Bi, Dandan" <dandan.bi@intel.com>,
	"gaoliming@byosoft.com.cn" <gaoliming@byosoft.com.cn>,
	"Ni, Ray" <ray.ni@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Zimmer, Vincent" <vincent.zimmer@intel.com>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>,
	"Xu, Min M" <min.m.xu@intel.com>
Subject: Re: [edk2-devel] [RFC] Design review for Lazy Page Accept in TDVF
Date: Fri, 3 Sep 2021 07:56:49 +0200	[thread overview]
Message-ID: <20210903055649.jsjh4giqphpggktp@sirius.home.kraxel.org> (raw)
In-Reply-To: <PH0PR11MB4885055865FF4BA383F8D6078CCF9@PH0PR11MB4885.namprd11.prod.outlook.com>

On Fri, Sep 03, 2021 at 12:31:57AM +0000, Yao, Jiewen wrote:
> Hi
> It is good idea to have a protocol to abstract TDX and SEV.
> 
> I think we need clearly document what service can be used in EFI_ACCEPT_MEMORY.
> For example, can we use memory allocation service, GCD service, or MP service?

Likewise the expected behavior.  For example whenever the protocol
driver or the memory core should update the GCD maps.

> Couple of dependency issue:
> If EFI_ACCEPT_MEMORY cannot use MP service, then there might be performance concern.
> If it uses MP service, then we need ensure MP service is installed earlier and before memory accept request.
> I think we need a way to ensure there is enough memory *before* the protocol is installed, right?

Yes.  Same for booting the OS, the kernel must have enough memory so it
can boot up to the point where the driver handling the lazy page accept
loads.

We should also define how we hand over memory range state from one stage
to the other (see also my reply to the sev-snp series posted yesterday)
so ovmf knows which ranges are accepted/validated already.

take care,
  Gerd


  reply	other threads:[~2021-09-03  5:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30  7:49 [edk2-devel] [RFC] Design review for Lazy Page Accept in TDVF jiaqi.gao
2021-08-31  6:10 ` Gerd Hoffmann
2021-09-01  7:23   ` Gao, Jiaqi
2021-09-03  0:31     ` Yao, Jiewen
2021-09-03  5:56       ` Gerd Hoffmann [this message]
2021-09-03 12:34         ` Gao, Jiaqi
2021-09-03 12:34       ` Gao, Jiaqi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210903055649.jsjh4giqphpggktp@sirius.home.kraxel.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox