From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web09.1166.1630653449465190299
 for <devel@edk2.groups.io>;
 Fri, 03 Sep 2021 00:17:29 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=KGQeimB6;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1630653448;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=W4lkzUcEO4gVnomHfWfDxKsOBXOR0TvUnSjf0QIN9wA=;
	b=KGQeimB6vtNowjbqDq+PqmC7L3Qlkz/GMO1WEpechETs2pVruA1bY0ilrnuQuI22ivq6VO
	anJyT54maVPSm7aT+4s7L4E2tefsCJk61CtPwyve2QisU0HM5+8K0KJctADgC1G5vyAlgY
	nJwWXTLaDuSt1+2TOT6/K4IVLP7jW+4=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-314-M3ezQ-2dNG67RmuyicZwKg-1; Fri, 03 Sep 2021 03:17:25 -0400
X-MC-Unique: M3ezQ-2dNG67RmuyicZwKg-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5DD795180;
	Fri,  3 Sep 2021 07:17:24 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.91])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id B76E610016F5;
	Fri,  3 Sep 2021 07:17:23 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 193AD1800931; Fri,  3 Sep 2021 09:17:22 +0200 (CEST)
Date: Fri, 3 Sep 2021 09:17:22 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Devon Bautista <dbautista@newmexicoconsortium.org>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>
Subject: Re: [PATCH v2 1/1] OvmfPkg: Introduce 16MiB flash size for (primarily) Linuxboot
Message-ID: <20210903071722.ebm4vc4tzsa3sdlu@sirius.home.kraxel.org>
References: <20210903052620.30638-1-dbautista@newmexicoconsortium.org>
 <20210903052620.30638-2-dbautista@newmexicoconsortium.org>
MIME-Version: 1.0
In-Reply-To: <20210903052620.30638-2-dbautista@newmexicoconsortium.org>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Sep 03, 2021 at 05:26:20AM +0000, Devon Bautista wrote:
> The largest size flash image currently available for OVMF builds, 4MiB,
> is too small to insert a Linux kernel and initramfs into the DXEFV, and
> is thus insufficient for testing Linuxboot builds via OVMF.

>   FVMAIN_COMPACT             uncompressed        3360 -> 15648 (+12288)
>     FV FFS file              LZMA compressed
>       PEIFV                  uncompressed         896 ->   896 (    +0)
>         individual PEI       uncompressed
>           modules
>       DXEFV                  uncompressed       12288 -> 12288 (    +0)
>         individual DXE       uncompressed
>           modules

Patch looks sane to me.

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>

How you are going to use the extra space you got?
Do you add kernel + initrd as ffs files to FVMAIN_COMPACT?

take care,
  Gerd