[RFC] RISC-V QEMU virtual package

public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed

* [RFC] RISC-V QEMU virtual package
@ 2021-09-05  3:15 Abner Chang
  2021-09-06  1:06 ` 回复: [edk2-devel] " gaoliming
  0 siblings, 1 reply; 24+ messages in thread
From: Abner Chang @ 2021-09-05  3:15 UTC (permalink / raw)
  To: devel@edk2.groups.io
  Cc: Ard Biesheuvel, Michael D Kinney, Leif Lindholm, ray.ni@intel.com,
	Liming Gao, Schaefer, Daniel, Sunil V L

[-- Attachment #1: Type: text/plain, Size: 679 bytes --]

Hi all,
We currently have RISC-V edk2 OVMF package that can boot to Linux kernel on QEMU RISC-V virt platform.
First at all, we would like to create a folder RiscvVirtPkg under edk2 repo and integrated in the Platform CI build.

Second, RISC-V edk2 OVMF package leverages some edk2 libraries and drivers from ArmVirtPkg, such as FDT related modules for PCI bus, host bridge and etc. We would like to move those generic virtual drivers to
a common folder for ARM and RISC-V (I don't think this way is necessary though). Or can we move those to just under OvmfPkg because OvmfPkg also provides some common drivers for the processor architectures.
Thoughts?

Thanks
Abner

[-- Attachment #2: Type: text/html, Size: 2818 bytes --]

^ permalink raw reply	[flat|nested] 24+ messages in thread

* 回复: [edk2-devel] [RFC] RISC-V QEMU virtual package
  2021-09-05  3:15 [RFC] RISC-V QEMU virtual package Abner Chang
@ 2021-09-06  1:06 ` gaoliming
  2021-09-06  4:16   ` Abner Chang
  0 siblings, 1 reply; 24+ messages in thread
From: gaoliming @ 2021-09-06  1:06 UTC (permalink / raw)
  To: devel, abner.chang
  Cc: 'Ard Biesheuvel', 'Michael D Kinney',
	'Leif Lindholm', ray.ni, 'Schaefer, Daniel',
	'Sunil V L', jiewen.yao, 'Ard Biesheuvel',
	'Gerd Hoffmann'

[-- Attachment #1: Type: text/plain, Size: 1467 bytes --]

Abner:

 If these modules are shared by ARM and RISC-V, they should not be ARM
specific modules. I prefer to move them into OvmfPkg. Now, ArmVirtPkg also
includes the modules from OvmfPkg. 

 I also include OVMF package maintainers for this discussion. 

Thanks

Liming

发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Abner Chang
发送时间: 2021年9月5日 11:15
收件人: devel@edk2.groups.io
抄送: Ard Biesheuvel <ard.biesheuvel@arm.com>; Michael D Kinney
<michael.d.kinney@intel.com>; Leif Lindholm <leif@nuviainc.com>;
ray.ni@intel.com; Liming Gao <gaoliming@byosoft.com.cn>; Schaefer, Daniel
<daniel.schaefer@hpe.com>; Sunil V L <sunilvl@ventanamicro.com>
主题: [edk2-devel] [RFC] RISC-V QEMU virtual package

Hi all,

We currently have RISC-V edk2 OVMF package that can boot to Linux kernel on
QEMU RISC-V virt platform.

First at all, we would like to create a folder RiscvVirtPkg under edk2 repo
and integrated in the Platform CI build.

Second, RISC-V edk2 OVMF package leverages some edk2 libraries and drivers
from ArmVirtPkg, such as FDT related modules for PCI bus, host bridge and
etc. We would like to move those generic virtual drivers to

a common folder for ARM and RISC-V (I don’t think this way is necessary
though). Or can we move those to just under OvmfPkg because OvmfPkg also
provides some common drivers for the processor architectures.

Thoughts?

Thanks

Abner

[-- Attachment #2: Type: text/html, Size: 5521 bytes --]

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
  2021-09-06  1:06 ` 回复: [edk2-devel] " gaoliming
@ 2021-09-06  4:16   ` Abner Chang
  2021-09-06  6:16     ` Yao, Jiewen
  0 siblings, 1 reply; 24+ messages in thread
From: Abner Chang @ 2021-09-06  4:16 UTC (permalink / raw)
  To: gaoliming, devel@edk2.groups.io
  Cc: 'Ard Biesheuvel', 'Michael D Kinney',
	'Leif Lindholm', ray.ni@intel.com, Schaefer, Daniel,
	'Sunil V L', jiewen.yao@intel.com,
	'Ard Biesheuvel', 'Gerd Hoffmann'

[-- Attachment #1: Type: text/plain, Size: 2412 bytes --]

Thanks Liming. To have those modules under OvmfPkg also makes sense to me. See how others think of this.

Abner

From: gaoliming [mailto:gaoliming@byosoft.com.cn]
Sent: Monday, September 6, 2021 9:07 AM
To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
Cc: 'Ard Biesheuvel' <ard.biesheuvel@arm.com>; 'Michael D Kinney' <michael.d.kinney@intel.com>; 'Leif Lindholm' <leif@nuviainc.com>; ray.ni@intel.com; Schaefer, Daniel <daniel.schaefer@hpe.com>; 'Sunil V L' <sunilvl@ventanamicro.com>; jiewen.yao@intel.com; 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Gerd Hoffmann' <kraxel@redhat.com>
Subject: 回复: [edk2-devel] [RFC] RISC-V QEMU virtual package

Abner:
 If these modules are shared by ARM and RISC-V, they should not be ARM specific modules. I prefer to move them into OvmfPkg. Now, ArmVirtPkg also includes the modules from OvmfPkg.

 I also include OVMF package maintainers for this discussion.

Thanks
Liming
发件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> 代表 Abner Chang
发送时间: 2021年9月5日 11:15
收件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
抄送: Ard Biesheuvel <ard.biesheuvel@arm.com<mailto:ard.biesheuvel@arm.com>>; Michael D Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Leif Lindholm <leif@nuviainc.com<mailto:leif@nuviainc.com>>; ray.ni@intel.com<mailto:ray.ni@intel.com>; Liming Gao <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Schaefer, Daniel <daniel.schaefer@hpe.com<mailto:daniel.schaefer@hpe.com>>; Sunil V L <sunilvl@ventanamicro.com<mailto:sunilvl@ventanamicro.com>>
主题: [edk2-devel] [RFC] RISC-V QEMU virtual package

Hi all,
We currently have RISC-V edk2 OVMF package that can boot to Linux kernel on QEMU RISC-V virt platform.
First at all, we would like to create a folder RiscvVirtPkg under edk2 repo and integrated in the Platform CI build.

Second, RISC-V edk2 OVMF package leverages some edk2 libraries and drivers from ArmVirtPkg, such as FDT related modules for PCI bus, host bridge and etc. We would like to move those generic virtual drivers to
a common folder for ARM and RISC-V (I don’t think this way is necessary though). Or can we move those to just under OvmfPkg because OvmfPkg also provides some common drivers for the processor architectures.
Thoughts?

Thanks
Abner

[-- Attachment #2: Type: text/html, Size: 8432 bytes --]

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
  2021-09-06  4:16   ` Abner Chang
@ 2021-09-06  6:16     ` Yao, Jiewen
  2021-09-06 11:08       ` Abner Chang
  0 siblings, 1 reply; 24+ messages in thread
From: Yao, Jiewen @ 2021-09-06  6:16 UTC (permalink / raw)
  To: devel@edk2.groups.io, Chang, Abner, gaoliming
  Cc: 'Ard Biesheuvel', Kinney, Michael D,
	'Leif Lindholm', Ni, Ray, Schaefer, Daniel,
	'Sunil V L', 'Ard Biesheuvel',
	'Gerd Hoffmann'

[-- Attachment #1: Type: text/plain, Size: 3474 bytes --]

Do you have a list of which module you want to move to Ovmf?

I think we can discuss case by case.

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abner Chang
Sent: Monday, September 6, 2021 12:16 PM
To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
Cc: 'Ard Biesheuvel' <ard.biesheuvel@arm.com>; Kinney, Michael D <michael.d.kinney@intel.com>; 'Leif Lindholm' <leif@nuviainc.com>; Ni, Ray <ray.ni@intel.com>; Schaefer, Daniel <daniel.schaefer@hpe.com>; 'Sunil V L' <sunilvl@ventanamicro.com>; Yao, Jiewen <jiewen.yao@intel.com>; 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Gerd Hoffmann' <kraxel@redhat.com>
Subject: Re: [edk2-devel] [RFC] RISC-V QEMU virtual package

Thanks Liming. To have those modules under OvmfPkg also makes sense to me. See how others think of this.

Abner

From: gaoliming [mailto:gaoliming@byosoft.com.cn]
Sent: Monday, September 6, 2021 9:07 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com<mailto:abner.chang@hpe.com>>
Cc: 'Ard Biesheuvel' <ard.biesheuvel@arm.com<mailto:ard.biesheuvel@arm.com>>; 'Michael D Kinney' <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; 'Leif Lindholm' <leif@nuviainc.com<mailto:leif@nuviainc.com>>; ray.ni@intel.com<mailto:ray.ni@intel.com>; Schaefer, Daniel <daniel.schaefer@hpe.com<mailto:daniel.schaefer@hpe.com>>; 'Sunil V L' <sunilvl@ventanamicro.com<mailto:sunilvl@ventanamicro.com>>; jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>; 'Ard Biesheuvel' <ardb+tianocore@kernel.org<mailto:ardb+tianocore@kernel.org>>; 'Gerd Hoffmann' <kraxel@redhat.com<mailto:kraxel@redhat.com>>
Subject: 回复: [edk2-devel] [RFC] RISC-V QEMU virtual package

Abner:
 If these modules are shared by ARM and RISC-V, they should not be ARM specific modules. I prefer to move them into OvmfPkg. Now, ArmVirtPkg also includes the modules from OvmfPkg.

 I also include OVMF package maintainers for this discussion.

Thanks
Liming
发件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> 代表 Abner Chang
发送时间: 2021年9月5日 11:15
收件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
抄送: Ard Biesheuvel <ard.biesheuvel@arm.com<mailto:ard.biesheuvel@arm.com>>; Michael D Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Leif Lindholm <leif@nuviainc.com<mailto:leif@nuviainc.com>>; ray.ni@intel.com<mailto:ray.ni@intel.com>; Liming Gao <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Schaefer, Daniel <daniel.schaefer@hpe.com<mailto:daniel.schaefer@hpe.com>>; Sunil V L <sunilvl@ventanamicro.com<mailto:sunilvl@ventanamicro.com>>
主题: [edk2-devel] [RFC] RISC-V QEMU virtual package

Hi all,
We currently have RISC-V edk2 OVMF package that can boot to Linux kernel on QEMU RISC-V virt platform.
First at all, we would like to create a folder RiscvVirtPkg under edk2 repo and integrated in the Platform CI build.

Second, RISC-V edk2 OVMF package leverages some edk2 libraries and drivers from ArmVirtPkg, such as FDT related modules for PCI bus, host bridge and etc. We would like to move those generic virtual drivers to
a common folder for ARM and RISC-V (I don’t think this way is necessary though). Or can we move those to just under OvmfPkg because OvmfPkg also provides some common drivers for the processor architectures.
Thoughts?

Thanks
Abner


[-- Attachment #2: Type: text/html, Size: 9689 bytes --]

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
  2021-09-06  6:16     ` Yao, Jiewen
@ 2021-09-06 11:08       ` Abner Chang
  2021-09-06 11:44         ` Yao, Jiewen
  2021-09-07 17:22         ` Leif Lindholm
  0 siblings, 2 replies; 24+ messages in thread
From: Abner Chang @ 2021-09-06 11:08 UTC (permalink / raw)
  To: Yao, Jiewen, devel@edk2.groups.io, gaoliming
  Cc: 'Ard Biesheuvel', Kinney, Michael D,
	'Leif Lindholm', Ni, Ray, Schaefer, Daniel,
	'Sunil V L', 'Ard Biesheuvel',
	'Gerd Hoffmann'

[-- Attachment #1: Type: text/plain, Size: 5106 bytes --]

Hi Jiewen,
We currently only use below modules from ArmVirtPkg,

-          ArmVirtPkg/Library

o   FdtPciPcdProducerLib

o   FdtPciHostBridgeLib

-          ArmVirtPkg/

o   VirtioFdtDxe

o   FdtClientDxe

o   HighMemDxe
Above modules are related to the extraction of the platform configuration from FDT. We also use ArmPkg/DriverArmPciCpuIoDxe,  we can have RISC-V instance of CpuIoDxe but still leverage PCD produced by FdtPciPcdProducerLib.
Another library is QemuFwCfgLib from ArmVirtPkg/Library, I think we can have RISC-V own instance because there is a one instance under OvmfPkg already.

Thanks
Abner


From: Yao, Jiewen [mailto:jiewen.yao@intel.com]
Sent: Monday, September 6, 2021 2:16 PM
To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; gaoliming <gaoliming@byosoft.com.cn>
Cc: 'Ard Biesheuvel' <ard.biesheuvel@arm.com>; Kinney, Michael D <michael.d.kinney@intel.com>; 'Leif Lindholm' <leif@nuviainc.com>; Ni, Ray <ray.ni@intel.com>; Schaefer, Daniel <daniel.schaefer@hpe.com>; 'Sunil V L' <sunilvl@ventanamicro.com>; 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Gerd Hoffmann' <kraxel@redhat.com>
Subject: RE: [edk2-devel] [RFC] RISC-V QEMU virtual package

Do you have a list of which module you want to move to Ovmf?

I think we can discuss case by case.

From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Abner Chang
Sent: Monday, September 6, 2021 12:16 PM
To: gaoliming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: 'Ard Biesheuvel' <ard.biesheuvel@arm.com<mailto:ard.biesheuvel@arm.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; 'Leif Lindholm' <leif@nuviainc.com<mailto:leif@nuviainc.com>>; Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; Schaefer, Daniel <daniel.schaefer@hpe.com<mailto:daniel.schaefer@hpe.com>>; 'Sunil V L' <sunilvl@ventanamicro.com<mailto:sunilvl@ventanamicro.com>>; Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; 'Ard Biesheuvel' <ardb+tianocore@kernel.org<mailto:ardb+tianocore@kernel.org>>; 'Gerd Hoffmann' <kraxel@redhat.com<mailto:kraxel@redhat.com>>
Subject: Re: [edk2-devel] [RFC] RISC-V QEMU virtual package

Thanks Liming. To have those modules under OvmfPkg also makes sense to me. See how others think of this.

Abner

From: gaoliming [mailto:gaoliming@byosoft.com.cn]
Sent: Monday, September 6, 2021 9:07 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com<mailto:abner.chang@hpe.com>>
Cc: 'Ard Biesheuvel' <ard.biesheuvel@arm.com<mailto:ard.biesheuvel@arm.com>>; 'Michael D Kinney' <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; 'Leif Lindholm' <leif@nuviainc.com<mailto:leif@nuviainc.com>>; ray.ni@intel.com<mailto:ray.ni@intel.com>; Schaefer, Daniel <daniel.schaefer@hpe.com<mailto:daniel.schaefer@hpe.com>>; 'Sunil V L' <sunilvl@ventanamicro.com<mailto:sunilvl@ventanamicro.com>>; jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>; 'Ard Biesheuvel' <ardb+tianocore@kernel.org<mailto:ardb+tianocore@kernel.org>>; 'Gerd Hoffmann' <kraxel@redhat.com<mailto:kraxel@redhat.com>>
Subject: 回复: [edk2-devel] [RFC] RISC-V QEMU virtual package

Abner:
 If these modules are shared by ARM and RISC-V, they should not be ARM specific modules. I prefer to move them into OvmfPkg. Now, ArmVirtPkg also includes the modules from OvmfPkg.

 I also include OVMF package maintainers for this discussion.

Thanks
Liming
发件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> 代表 Abner Chang
发送时间: 2021年9月5日 11:15
收件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
抄送: Ard Biesheuvel <ard.biesheuvel@arm.com<mailto:ard.biesheuvel@arm.com>>; Michael D Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Leif Lindholm <leif@nuviainc.com<mailto:leif@nuviainc.com>>; ray.ni@intel.com<mailto:ray.ni@intel.com>; Liming Gao <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Schaefer, Daniel <daniel.schaefer@hpe.com<mailto:daniel.schaefer@hpe.com>>; Sunil V L <sunilvl@ventanamicro.com<mailto:sunilvl@ventanamicro.com>>
主题: [edk2-devel] [RFC] RISC-V QEMU virtual package

Hi all,
We currently have RISC-V edk2 OVMF package that can boot to Linux kernel on QEMU RISC-V virt platform.
First at all, we would like to create a folder RiscvVirtPkg under edk2 repo and integrated in the Platform CI build.

Second, RISC-V edk2 OVMF package leverages some edk2 libraries and drivers from ArmVirtPkg, such as FDT related modules for PCI bus, host bridge and etc. We would like to move those generic virtual drivers to
a common folder for ARM and RISC-V (I don’t think this way is necessary though). Or can we move those to just under OvmfPkg because OvmfPkg also provides some common drivers for the processor architectures.
Thoughts?

Thanks
Abner


[-- Attachment #2: Type: text/html, Size: 19866 bytes --]

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
  2021-09-06 11:08       ` Abner Chang
@ 2021-09-06 11:44         ` Yao, Jiewen
  2021-09-06 12:04           ` Ard Biesheuvel
  2021-09-07 17:22         ` Leif Lindholm
  1 sibling, 1 reply; 24+ messages in thread
From: Yao, Jiewen @ 2021-09-06 11:44 UTC (permalink / raw)
  To: Chang, Abner, devel@edk2.groups.io, gaoliming
  Cc: 'Ard Biesheuvel', Kinney, Michael D,
	'Leif Lindholm', Ni, Ray, Schaefer, Daniel,
	'Sunil V L', 'Ard Biesheuvel',
	'Gerd Hoffmann'

[-- Attachment #1: Type: text/plain, Size: 6321 bytes --]

I think it makes sense to put Fdt to OvmfPkg. I suggest an Fdt folder and put all things there.

I also think we define Fdt feature in https://github.com/tianocore/edk2/blob/master/Maintainers.txt to add reviewer there to help review the code.

Thank you
Yao Jiewen


From: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
Sent: Monday, September 6, 2021 7:09 PM
To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io; gaoliming <gaoliming@byosoft.com.cn>
Cc: 'Ard Biesheuvel' <ard.biesheuvel@arm.com>; Kinney, Michael D <michael.d.kinney@intel.com>; 'Leif Lindholm' <leif@nuviainc.com>; Ni, Ray <ray.ni@intel.com>; Schaefer, Daniel <daniel.schaefer@hpe.com>; 'Sunil V L' <sunilvl@ventanamicro.com>; 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Gerd Hoffmann' <kraxel@redhat.com>
Subject: RE: [edk2-devel] [RFC] RISC-V QEMU virtual package

Hi Jiewen,
We currently only use below modules from ArmVirtPkg,

  *   ArmVirtPkg/Library

     *   FdtPciPcdProducerLib
     *   FdtPciHostBridgeLib

  *   ArmVirtPkg/

     *   VirtioFdtDxe
     *   FdtClientDxe
     *   HighMemDxe
Above modules are related to the extraction of the platform configuration from FDT. We also use ArmPkg/DriverArmPciCpuIoDxe,  we can have RISC-V instance of CpuIoDxe but still leverage PCD produced by FdtPciPcdProducerLib.
Another library is QemuFwCfgLib from ArmVirtPkg/Library, I think we can have RISC-V own instance because there is a one instance under OvmfPkg already.

Thanks
Abner


From: Yao, Jiewen [mailto:jiewen.yao@intel.com]
Sent: Monday, September 6, 2021 2:16 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com<mailto:abner.chang@hpe.com>>; gaoliming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>
Cc: 'Ard Biesheuvel' <ard.biesheuvel@arm.com<mailto:ard.biesheuvel@arm.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; 'Leif Lindholm' <leif@nuviainc.com<mailto:leif@nuviainc.com>>; Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; Schaefer, Daniel <daniel.schaefer@hpe.com<mailto:daniel.schaefer@hpe.com>>; 'Sunil V L' <sunilvl@ventanamicro.com<mailto:sunilvl@ventanamicro.com>>; 'Ard Biesheuvel' <ardb+tianocore@kernel.org<mailto:ardb+tianocore@kernel.org>>; 'Gerd Hoffmann' <kraxel@redhat.com<mailto:kraxel@redhat.com>>
Subject: RE: [edk2-devel] [RFC] RISC-V QEMU virtual package

Do you have a list of which module you want to move to Ovmf?

I think we can discuss case by case.

From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Abner Chang
Sent: Monday, September 6, 2021 12:16 PM
To: gaoliming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: 'Ard Biesheuvel' <ard.biesheuvel@arm.com<mailto:ard.biesheuvel@arm.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; 'Leif Lindholm' <leif@nuviainc.com<mailto:leif@nuviainc.com>>; Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; Schaefer, Daniel <daniel.schaefer@hpe.com<mailto:daniel.schaefer@hpe.com>>; 'Sunil V L' <sunilvl@ventanamicro.com<mailto:sunilvl@ventanamicro.com>>; Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; 'Ard Biesheuvel' <ardb+tianocore@kernel.org<mailto:ardb+tianocore@kernel.org>>; 'Gerd Hoffmann' <kraxel@redhat.com<mailto:kraxel@redhat.com>>
Subject: Re: [edk2-devel] [RFC] RISC-V QEMU virtual package

Thanks Liming. To have those modules under OvmfPkg also makes sense to me. See how others think of this.

Abner

From: gaoliming [mailto:gaoliming@byosoft.com.cn]
Sent: Monday, September 6, 2021 9:07 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com<mailto:abner.chang@hpe.com>>
Cc: 'Ard Biesheuvel' <ard.biesheuvel@arm.com<mailto:ard.biesheuvel@arm.com>>; 'Michael D Kinney' <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; 'Leif Lindholm' <leif@nuviainc.com<mailto:leif@nuviainc.com>>; ray.ni@intel.com<mailto:ray.ni@intel.com>; Schaefer, Daniel <daniel.schaefer@hpe.com<mailto:daniel.schaefer@hpe.com>>; 'Sunil V L' <sunilvl@ventanamicro.com<mailto:sunilvl@ventanamicro.com>>; jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>; 'Ard Biesheuvel' <ardb+tianocore@kernel.org<mailto:ardb+tianocore@kernel.org>>; 'Gerd Hoffmann' <kraxel@redhat.com<mailto:kraxel@redhat.com>>
Subject: 回复: [edk2-devel] [RFC] RISC-V QEMU virtual package

Abner:
 If these modules are shared by ARM and RISC-V, they should not be ARM specific modules. I prefer to move them into OvmfPkg. Now, ArmVirtPkg also includes the modules from OvmfPkg.

 I also include OVMF package maintainers for this discussion.

Thanks
Liming
发件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> 代表 Abner Chang
发送时间: 2021年9月5日 11:15
收件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
抄送: Ard Biesheuvel <ard.biesheuvel@arm.com<mailto:ard.biesheuvel@arm.com>>; Michael D Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Leif Lindholm <leif@nuviainc.com<mailto:leif@nuviainc.com>>; ray.ni@intel.com<mailto:ray.ni@intel.com>; Liming Gao <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Schaefer, Daniel <daniel.schaefer@hpe.com<mailto:daniel.schaefer@hpe.com>>; Sunil V L <sunilvl@ventanamicro.com<mailto:sunilvl@ventanamicro.com>>
主题: [edk2-devel] [RFC] RISC-V QEMU virtual package

Hi all,
We currently have RISC-V edk2 OVMF package that can boot to Linux kernel on QEMU RISC-V virt platform.
First at all, we would like to create a folder RiscvVirtPkg under edk2 repo and integrated in the Platform CI build.

Second, RISC-V edk2 OVMF package leverages some edk2 libraries and drivers from ArmVirtPkg, such as FDT related modules for PCI bus, host bridge and etc. We would like to move those generic virtual drivers to
a common folder for ARM and RISC-V (I don’t think this way is necessary though). Or can we move those to just under OvmfPkg because OvmfPkg also provides some common drivers for the processor architectures.
Thoughts?

Thanks
Abner


[-- Attachment #2: Type: text/html, Size: 18014 bytes --]

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
  2021-09-06 11:44         ` Yao, Jiewen
@ 2021-09-06 12:04           ` Ard Biesheuvel
  2021-09-06 12:19             ` Gerd Hoffmann
  0 siblings, 1 reply; 24+ messages in thread
From: Ard Biesheuvel @ 2021-09-06 12:04 UTC (permalink / raw)
  To: Yao, Jiewen
  Cc: Chang, Abner, devel@edk2.groups.io, gaoliming, Ard Biesheuvel,
	Kinney, Michael D, Leif Lindholm, Ni, Ray, Schaefer, Daniel,
	Sunil V L, Ard Biesheuvel, Gerd Hoffmann

On Mon, 6 Sept 2021 at 13:44, Yao, Jiewen <jiewen.yao@intel.com> wrote:
>
> I think it makes sense to put Fdt to OvmfPkg. I suggest an Fdt folder and put all things there.
>
>
>
> I also think we define Fdt feature in https://github.com/tianocore/edk2/blob/master/Maintainers.txt to add reviewer there to help review the code.
>
>

Agreed.

>
>
>
>
>
> From: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
> Sent: Monday, September 6, 2021 7:09 PM
> To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io; gaoliming <gaoliming@byosoft.com.cn>
> Cc: 'Ard Biesheuvel' <ard.biesheuvel@arm.com>; Kinney, Michael D <michael.d.kinney@intel.com>; 'Leif Lindholm' <leif@nuviainc.com>; Ni, Ray <ray.ni@intel.com>; Schaefer, Daniel <daniel.schaefer@hpe.com>; 'Sunil V L' <sunilvl@ventanamicro.com>; 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Gerd Hoffmann' <kraxel@redhat.com>
> Subject: RE: [edk2-devel] [RFC] RISC-V QEMU virtual package
>
>
>
> Hi Jiewen,
>
> We currently only use below modules from ArmVirtPkg,
>
> ArmVirtPkg/Library
>
> FdtPciPcdProducerLib
> FdtPciHostBridgeLib
>
> ArmVirtPkg/
>
> VirtioFdtDxe
> FdtClientDxe
> HighMemDxe
>
> Above modules are related to the extraction of the platform configuration from FDT. We also use ArmPkg/DriverArmPciCpuIoDxe,  we can have RISC-V instance of CpuIoDxe but still leverage PCD produced by FdtPciPcdProducerLib.
>
> Another library is QemuFwCfgLib from ArmVirtPkg/Library, I think we can have RISC-V own instance because there is a one instance under OvmfPkg already.
>
>
>
> Thanks
>
> Abner
>
>
>
>
>
> From: Yao, Jiewen [mailto:jiewen.yao@intel.com]
> Sent: Monday, September 6, 2021 2:16 PM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; gaoliming <gaoliming@byosoft.com.cn>
> Cc: 'Ard Biesheuvel' <ard.biesheuvel@arm.com>; Kinney, Michael D <michael.d.kinney@intel.com>; 'Leif Lindholm' <leif@nuviainc.com>; Ni, Ray <ray.ni@intel.com>; Schaefer, Daniel <daniel.schaefer@hpe.com>; 'Sunil V L' <sunilvl@ventanamicro.com>; 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Gerd Hoffmann' <kraxel@redhat.com>
> Subject: RE: [edk2-devel] [RFC] RISC-V QEMU virtual package
>
>
>
> Do you have a list of which module you want to move to Ovmf?
>
>
>
> I think we can discuss case by case.
>
>
>
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abner Chang
> Sent: Monday, September 6, 2021 12:16 PM
> To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> Cc: 'Ard Biesheuvel' <ard.biesheuvel@arm.com>; Kinney, Michael D <michael.d.kinney@intel.com>; 'Leif Lindholm' <leif@nuviainc.com>; Ni, Ray <ray.ni@intel.com>; Schaefer, Daniel <daniel.schaefer@hpe.com>; 'Sunil V L' <sunilvl@ventanamicro.com>; Yao, Jiewen <jiewen.yao@intel.com>; 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Gerd Hoffmann' <kraxel@redhat.com>
> Subject: Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
>
>
>
> Thanks Liming. To have those modules under OvmfPkg also makes sense to me. See how others think of this.
>
>
>
> Abner
>
>
>
> From: gaoliming [mailto:gaoliming@byosoft.com.cn]
> Sent: Monday, September 6, 2021 9:07 AM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
> Cc: 'Ard Biesheuvel' <ard.biesheuvel@arm.com>; 'Michael D Kinney' <michael.d.kinney@intel.com>; 'Leif Lindholm' <leif@nuviainc.com>; ray.ni@intel.com; Schaefer, Daniel <daniel.schaefer@hpe.com>; 'Sunil V L' <sunilvl@ventanamicro.com>; jiewen.yao@intel.com; 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Gerd Hoffmann' <kraxel@redhat.com>
> Subject: 回复: [edk2-devel] [RFC] RISC-V QEMU virtual package
>
>
>
> Abner:
>
>  If these modules are shared by ARM and RISC-V, they should not be ARM specific modules. I prefer to move them into OvmfPkg. Now, ArmVirtPkg also includes the modules from OvmfPkg.
>
>
>
>  I also include OVMF package maintainers for this discussion.
>
>
>
> Thanks
>
> Liming
>
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Abner Chang
> 发送时间: 2021年9月5日 11:15
> 收件人: devel@edk2.groups.io
> 抄送: Ard Biesheuvel <ard.biesheuvel@arm.com>; Michael D Kinney <michael.d.kinney@intel.com>; Leif Lindholm <leif@nuviainc.com>; ray.ni@intel.com; Liming Gao <gaoliming@byosoft.com.cn>; Schaefer, Daniel <daniel.schaefer@hpe.com>; Sunil V L <sunilvl@ventanamicro.com>
> 主题: [edk2-devel] [RFC] RISC-V QEMU virtual package
>
>
>
> Hi all,
>
> We currently have RISC-V edk2 OVMF package that can boot to Linux kernel on QEMU RISC-V virt platform.
>
> First at all, we would like to create a folder RiscvVirtPkg under edk2 repo and integrated in the Platform CI build.
>
>
>
> Second, RISC-V edk2 OVMF package leverages some edk2 libraries and drivers from ArmVirtPkg, such as FDT related modules for PCI bus, host bridge and etc. We would like to move those generic virtual drivers to
>
> a common folder for ARM and RISC-V (I don’t think this way is necessary though). Or can we move those to just under OvmfPkg because OvmfPkg also provides some common drivers for the processor architectures.
>
> Thoughts?
>
>
>
> Thanks
>
> Abner
>
> 

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
  2021-09-06 12:04           ` Ard Biesheuvel
@ 2021-09-06 12:19             ` Gerd Hoffmann
  2021-09-06 13:04               ` Abner Chang
  0 siblings, 1 reply; 24+ messages in thread
From: Gerd Hoffmann @ 2021-09-06 12:19 UTC (permalink / raw)
  To: Ard Biesheuvel
  Cc: Yao, Jiewen, Chang, Abner, devel@edk2.groups.io, gaoliming,
	Ard Biesheuvel, Kinney, Michael D, Leif Lindholm, Ni, Ray,
	Schaefer, Daniel, Sunil V L, Ard Biesheuvel

  Hi,

On Mon, Sep 06, 2021 at 02:04:48PM +0200, Ard Biesheuvel wrote:
> On Mon, 6 Sept 2021 at 13:44, Yao, Jiewen <jiewen.yao@intel.com> wrote:
> >
> > I think it makes sense to put Fdt to OvmfPkg. I suggest an Fdt folder and put all things there.
> >
> > I also think we define Fdt feature in https://github.com/tianocore/edk2/blob/master/Maintainers.txt to add reviewer there to help review the code.
> >
> 
> Agreed.

Agreeing too.

take care,
  Gerd


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
  2021-09-06 12:19             ` Gerd Hoffmann
@ 2021-09-06 13:04               ` Abner Chang
  2021-09-07  1:09                 ` 回复: " gaoliming
  2021-09-07  7:18                 ` Gerd Hoffmann
  0 siblings, 2 replies; 24+ messages in thread
From: Abner Chang @ 2021-09-06 13:04 UTC (permalink / raw)
  To: Gerd Hoffmann, Ard Biesheuvel
  Cc: Yao, Jiewen, devel@edk2.groups.io, gaoliming, Ard Biesheuvel,
	Kinney, Michael D, Leif Lindholm, Ni, Ray, Schaefer, Daniel,
	Sunil V L, Ard Biesheuvel

Ok thanks, do we need the two steps to migrate FDT modules under OvmfPkg/?
1. One patch set to clone  those modules under OvmfPkg/
2. One patch set of ArmVirtPkg change to use those modules and deletes the ones under ArmVirtPkg/.

Or we just do all at once? I prefer to have two steps. How do you think?

Another question, who would like to be the reviewers of OvmfPkg/Fdt/*? Any volunteers from CC list?

Thanks
Abner

> -----Original Message-----
> From: Gerd Hoffmann [mailto:kraxel@redhat.com]
> Sent: Monday, September 6, 2021 8:19 PM
> To: Ard Biesheuvel <ardb@kernel.org>
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Chang, Abner (HPS SW/FW
> Technologist) <abner.chang@hpe.com>; devel@edk2.groups.io; gaoliming
> <gaoliming@byosoft.com.cn>; Ard Biesheuvel <ard.biesheuvel@arm.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Leif Lindholm
> <leif@nuviainc.com>; Ni, Ray <ray.ni@intel.com>; Schaefer, Daniel
> <daniel.schaefer@hpe.com>; Sunil V L <sunilvl@ventanamicro.com>; Ard
> Biesheuvel <ardb+tianocore@kernel.org>
> Subject: Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
> 
>   Hi,
> 
> On Mon, Sep 06, 2021 at 02:04:48PM +0200, Ard Biesheuvel wrote:
> > On Mon, 6 Sept 2021 at 13:44, Yao, Jiewen <jiewen.yao@intel.com> wrote:
> > >
> > > I think it makes sense to put Fdt to OvmfPkg. I suggest an Fdt folder and
> put all things there.
> > >
> > > I also think we define Fdt feature in
> https://github.com/tianocore/edk2/blob/master/Maintainers.txt to add
> reviewer there to help review the code.
> > >
> >
> > Agreed.
> 
> Agreeing too.
> 
> take care,
>   Gerd


^ permalink raw reply	[flat|nested] 24+ messages in thread

* 回复: [edk2-devel] [RFC] RISC-V QEMU virtual package
  2021-09-06 13:04               ` Abner Chang
@ 2021-09-07  1:09                 ` gaoliming
  2021-09-07  2:31                   ` Abner Chang
  2021-09-07  7:18                 ` Gerd Hoffmann
  1 sibling, 1 reply; 24+ messages in thread
From: gaoliming @ 2021-09-07  1:09 UTC (permalink / raw)
  To: devel, abner.chang, 'Gerd Hoffmann',
	'Ard Biesheuvel'
  Cc: 'Yao, Jiewen', 'Ard Biesheuvel',
	'Kinney, Michael D', 'Leif Lindholm',
	'Ni, Ray', 'Schaefer, Daniel',
	'Sunil V L', 'Ard Biesheuvel'

Abner:
  I prefer to use git mv command to move those modules from ArmVirtPkg to
OvmfPkg. This way can still keep git history for those modules. 
  
  You can create the second patch to update ArmVirtPkg DSC/FDF, or combine
this change into the first patch. 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Abner Chang
> 发送时间: 2021年9月6日 21:05
> 收件人: Gerd Hoffmann <kraxel@redhat.com>; Ard Biesheuvel
> <ardb@kernel.org>
> 抄送: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io; gaoliming
> <gaoliming@byosoft.com.cn>; Ard Biesheuvel <ard.biesheuvel@arm.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Leif Lindholm
> <leif@nuviainc.com>; Ni, Ray <ray.ni@intel.com>; Schaefer, Daniel
> <daniel.schaefer@hpe.com>; Sunil V L <sunilvl@ventanamicro.com>; Ard
> Biesheuvel <ardb+tianocore@kernel.org>
> 主题: Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
> 
> Ok thanks, do we need the two steps to migrate FDT modules under
> OvmfPkg/?
> 1. One patch set to clone  those modules under OvmfPkg/
> 2. One patch set of ArmVirtPkg change to use those modules and deletes the
> ones under ArmVirtPkg/.
> 
> Or we just do all at once? I prefer to have two steps. How do you think?
> 
> Another question, who would like to be the reviewers of OvmfPkg/Fdt/*? Any
> volunteers from CC list?
> 
> Thanks
> Abner
> 
> > -----Original Message-----
> > From: Gerd Hoffmann [mailto:kraxel@redhat.com]
> > Sent: Monday, September 6, 2021 8:19 PM
> > To: Ard Biesheuvel <ardb@kernel.org>
> > Cc: Yao, Jiewen <jiewen.yao@intel.com>; Chang, Abner (HPS SW/FW
> > Technologist) <abner.chang@hpe.com>; devel@edk2.groups.io; gaoliming
> > <gaoliming@byosoft.com.cn>; Ard Biesheuvel <ard.biesheuvel@arm.com>;
> > Kinney, Michael D <michael.d.kinney@intel.com>; Leif Lindholm
> > <leif@nuviainc.com>; Ni, Ray <ray.ni@intel.com>; Schaefer, Daniel
> > <daniel.schaefer@hpe.com>; Sunil V L <sunilvl@ventanamicro.com>; Ard
> > Biesheuvel <ardb+tianocore@kernel.org>
> > Subject: Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
> >
> >   Hi,
> >
> > On Mon, Sep 06, 2021 at 02:04:48PM +0200, Ard Biesheuvel wrote:
> > > On Mon, 6 Sept 2021 at 13:44, Yao, Jiewen <jiewen.yao@intel.com>
> wrote:
> > > >
> > > > I think it makes sense to put Fdt to OvmfPkg. I suggest an Fdt
folder and
> > put all things there.
> > > >
> > > > I also think we define Fdt feature in
> > https://github.com/tianocore/edk2/blob/master/Maintainers.txt to add
> > reviewer there to help review the code.
> > > >
> > >
> > > Agreed.
> >
> > Agreeing too.
> >
> > take care,
> >   Gerd
> 
> 
> 
> 
> 






^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
  2021-09-07  1:09                 ` 回复: " gaoliming
@ 2021-09-07  2:31                   ` Abner Chang
  0 siblings, 0 replies; 24+ messages in thread
From: Abner Chang @ 2021-09-07  2:31 UTC (permalink / raw)
  To: gaoliming, devel@edk2.groups.io, 'Gerd Hoffmann',
	'Ard Biesheuvel'
  Cc: 'Yao, Jiewen', 'Ard Biesheuvel',
	'Kinney, Michael D', 'Leif Lindholm',
	'Ni, Ray', Schaefer, Daniel, 'Sunil V L',
	'Ard Biesheuvel'


> -----Original Message-----
> From: gaoliming [mailto:gaoliming@byosoft.com.cn]
> Sent: Tuesday, September 7, 2021 9:09 AM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>; 'Gerd Hoffmann' <kraxel@redhat.com>; 'Ard
> Biesheuvel' <ardb@kernel.org>
> Cc: 'Yao, Jiewen' <jiewen.yao@intel.com>; 'Ard Biesheuvel'
> <ard.biesheuvel@arm.com>; 'Kinney, Michael D'
> <michael.d.kinney@intel.com>; 'Leif Lindholm' <leif@nuviainc.com>; 'Ni, Ray'
> <ray.ni@intel.com>; Schaefer, Daniel <daniel.schaefer@hpe.com>; 'Sunil V L'
> <sunilvl@ventanamicro.com>; 'Ard Biesheuvel' <ardb+tianocore@kernel.org>
> Subject: 回复: [edk2-devel] [RFC] RISC-V QEMU virtual package
> 
> Abner:
>   I prefer to use git mv command to move those modules from ArmVirtPkg to
> OvmfPkg. This way can still keep git history for those modules.
Yeah sure, this is much better. 
> 
>   You can create the second patch to update ArmVirtPkg DSC/FDF, or
> combine
> this change into the first patch.
I will just send two patches for ArmVirtPkg changes, then have the separate patch set for RiscvVirtPkg.

Thanks
Abner

> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Abner
> Chang
> > 发送时间: 2021年9月6日 21:05
> > 收件人: Gerd Hoffmann <kraxel@redhat.com>; Ard Biesheuvel
> > <ardb@kernel.org>
> > 抄送: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io;
> gaoliming
> > <gaoliming@byosoft.com.cn>; Ard Biesheuvel <ard.biesheuvel@arm.com>;
> > Kinney, Michael D <michael.d.kinney@intel.com>; Leif Lindholm
> > <leif@nuviainc.com>; Ni, Ray <ray.ni@intel.com>; Schaefer, Daniel
> > <daniel.schaefer@hpe.com>; Sunil V L <sunilvl@ventanamicro.com>; Ard
> > Biesheuvel <ardb+tianocore@kernel.org>
> > 主题: Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
> >
> > Ok thanks, do we need the two steps to migrate FDT modules under
> > OvmfPkg/?
> > 1. One patch set to clone  those modules under OvmfPkg/
> > 2. One patch set of ArmVirtPkg change to use those modules and deletes
> the
> > ones under ArmVirtPkg/.
> >
> > Or we just do all at once? I prefer to have two steps. How do you think?
> >
> > Another question, who would like to be the reviewers of OvmfPkg/Fdt/*?
> Any
> > volunteers from CC list?
> >
> > Thanks
> > Abner
> >
> > > -----Original Message-----
> > > From: Gerd Hoffmann [mailto:kraxel@redhat.com]
> > > Sent: Monday, September 6, 2021 8:19 PM
> > > To: Ard Biesheuvel <ardb@kernel.org>
> > > Cc: Yao, Jiewen <jiewen.yao@intel.com>; Chang, Abner (HPS SW/FW
> > > Technologist) <abner.chang@hpe.com>; devel@edk2.groups.io;
> gaoliming
> > > <gaoliming@byosoft.com.cn>; Ard Biesheuvel
> <ard.biesheuvel@arm.com>;
> > > Kinney, Michael D <michael.d.kinney@intel.com>; Leif Lindholm
> > > <leif@nuviainc.com>; Ni, Ray <ray.ni@intel.com>; Schaefer, Daniel
> > > <daniel.schaefer@hpe.com>; Sunil V L <sunilvl@ventanamicro.com>; Ard
> > > Biesheuvel <ardb+tianocore@kernel.org>
> > > Subject: Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
> > >
> > >   Hi,
> > >
> > > On Mon, Sep 06, 2021 at 02:04:48PM +0200, Ard Biesheuvel wrote:
> > > > On Mon, 6 Sept 2021 at 13:44, Yao, Jiewen <jiewen.yao@intel.com>
> > wrote:
> > > > >
> > > > > I think it makes sense to put Fdt to OvmfPkg. I suggest an Fdt
> folder and
> > > put all things there.
> > > > >
> > > > > I also think we define Fdt feature in
> > > https://github.com/tianocore/edk2/blob/master/Maintainers.txt to add
> > > reviewer there to help review the code.
> > > > >
> > > >
> > > > Agreed.
> > >
> > > Agreeing too.
> > >
> > > take care,
> > >   Gerd
> >
> >
> >
> > 
> >
> 
> 


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
  2021-09-06 13:04               ` Abner Chang
  2021-09-07  1:09                 ` 回复: " gaoliming
@ 2021-09-07  7:18                 ` Gerd Hoffmann
  1 sibling, 0 replies; 24+ messages in thread
From: Gerd Hoffmann @ 2021-09-07  7:18 UTC (permalink / raw)
  To: Chang, Abner (HPS SW/FW Technologist)
  Cc: Ard Biesheuvel, Yao, Jiewen, devel@edk2.groups.io, gaoliming,
	Ard Biesheuvel, Kinney, Michael D, Leif Lindholm, Ni, Ray,
	Schaefer, Daniel, Sunil V L, Ard Biesheuvel

On Mon, Sep 06, 2021 at 01:04:56PM +0000, Chang, Abner (HPS SW/FW Technologist) wrote:
> Ok thanks, do we need the two steps to migrate FDT modules under OvmfPkg/?
> 1. One patch set to clone  those modules under OvmfPkg/
> 2. One patch set of ArmVirtPkg change to use those modules and deletes the ones under ArmVirtPkg/.

Clearly "git mv" the files to keep git history.

Also update the references in the dsc and fdf files in the same patch
to avoid breaking the build.

I'd suggest to have one patch per module you are moving over.

> Another question, who would like to be the reviewers of OvmfPkg/Fdt/*? Any volunteers from CC list?

I'm already R: for all of OvmfPkg ;)

take care,
  Gerd


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
  2021-09-06 11:08       ` Abner Chang
  2021-09-06 11:44         ` Yao, Jiewen
@ 2021-09-07 17:22         ` Leif Lindholm
  2021-09-08 12:31           ` Abner Chang
  1 sibling, 1 reply; 24+ messages in thread
From: Leif Lindholm @ 2021-09-07 17:22 UTC (permalink / raw)
  To: Chang, Abner (HPS SW/FW Technologist)
  Cc: Yao, Jiewen, devel@edk2.groups.io, gaoliming,
	'Ard Biesheuvel', Kinney, Michael D, Ni, Ray,
	Schaefer, Daniel, 'Sunil V L', 'Ard Biesheuvel',
	'Gerd Hoffmann'

Hi Abner,

Happy to see this happening.

I think the capitalisation should be
RiscVVirtPkg rather than
RiscvVirtPkg though.

More comments below.

On Mon, Sep 06, 2021 at 11:08:47 +0000, Chang, Abner (HPS SW/FW Technologist) wrote:
> We currently only use below modules from ArmVirtPkg,
> 
> - ArmVirtPkg/Library
>   o   FdtPciPcdProducerLib
>   o   FdtPciHostBridgeLib
>
> - ArmVirtPkg/
>   o   VirtioFdtDxe
>   o   FdtClientDxe
>   o   HighMemDxe
>
> Above modules are related to the extraction of the platform
> configuration from FDT. We also use ArmPkg/DriverArmPciCpuIoDxe,  we
> can have RISC-V instance of CpuIoDxe but still leverage PCD produced
> by FdtPciPcdProducerLib.
>
> Another library is QemuFwCfgLib from ArmVirtPkg/Library, I think we
> can have RISC-V own instance because there is a one instance under
> OvmfPkg already.

Are you expecting to need different functionality from the ArmVirtPkg
one? If not, you could move that one to
  OvmfPkg/Library/QemuFwCfgCommonLib
or something.

Note that there are also a couple of platforms in edk2-platforms that
reference ArmVirtPkg code. Those would need to be fixed up as well, if
anything they depend on moves.

Agree with comments others made regarding use of git mv of single
module at a time.

I wouldn't mind being a reviewer for the FDT-related common modules.

Regards,

Leif

> 发件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> 代表 Abner Chang
> 发送时间: 2021年9月5日 11:15
> 收件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> 抄送: Ard Biesheuvel <ard.biesheuvel@arm.com<mailto:ard.biesheuvel@arm.com>>; Michael D Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Leif Lindholm <leif@nuviainc.com<mailto:leif@nuviainc.com>>; ray.ni@intel.com<mailto:ray.ni@intel.com>; Liming Gao <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Schaefer, Daniel <daniel.schaefer@hpe.com<mailto:daniel.schaefer@hpe.com>>; Sunil V L <sunilvl@ventanamicro.com<mailto:sunilvl@ventanamicro.com>>
> 主题: [edk2-devel] [RFC] RISC-V QEMU virtual package
> 
> Hi all,
> We currently have RISC-V edk2 OVMF package that can boot to Linux kernel on QEMU RISC-V virt platform.
> First at all, we would like to create a folder RiscvVirtPkg under edk2 repo and integrated in the Platform CI build.
> 
> Second, RISC-V edk2 OVMF package leverages some edk2 libraries and drivers from ArmVirtPkg, such as FDT related modules for PCI bus, host bridge and etc. We would like to move those generic virtual drivers to
> a common folder for ARM and RISC-V (I don’t think this way is necessary though). Or can we move those to just under OvmfPkg because OvmfPkg also provides some common drivers for the processor architectures.
> Thoughts?
> 
> Thanks
> Abner
> 

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
  2021-09-07 17:22         ` Leif Lindholm
@ 2021-09-08 12:31           ` Abner Chang
  2021-09-08 13:37             ` Gerd Hoffmann
  0 siblings, 1 reply; 24+ messages in thread
From: Abner Chang @ 2021-09-08 12:31 UTC (permalink / raw)
  To: Leif Lindholm
  Cc: Yao, Jiewen, devel@edk2.groups.io, gaoliming,
	'Ard Biesheuvel', Kinney, Michael D, Ni, Ray,
	Schaefer, Daniel, 'Sunil V L', 'Ard Biesheuvel',
	'Gerd Hoffmann'



> -----Original Message-----
> From: Leif Lindholm [mailto:leif@nuviainc.com]
> Sent: Wednesday, September 8, 2021 1:22 AM
> To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io; gaoliming
> <gaoliming@byosoft.com.cn>; 'Ard Biesheuvel' <ard.biesheuvel@arm.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Ni, Ray
> <ray.ni@intel.com>; Schaefer, Daniel <daniel.schaefer@hpe.com>; 'Sunil V L'
> <sunilvl@ventanamicro.com>; 'Ard Biesheuvel'
> <ardb+tianocore@kernel.org>; 'Gerd Hoffmann' <kraxel@redhat.com>
> Subject: Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
> 
> Hi Abner,
> 
> Happy to see this happening.
> 
> I think the capitalisation should be
> RiscVVirtPkg rather than
> RiscvVirtPkg though.
NP.
> 
> More comments below.
> 
> On Mon, Sep 06, 2021 at 11:08:47 +0000, Chang, Abner (HPS SW/FW
> Technologist) wrote:
> > We currently only use below modules from ArmVirtPkg,
> >
> > - ArmVirtPkg/Library
> >   o   FdtPciPcdProducerLib
> >   o   FdtPciHostBridgeLib
> >
> > - ArmVirtPkg/
> >   o   VirtioFdtDxe
> >   o   FdtClientDxe
> >   o   HighMemDxe
> >
> > Above modules are related to the extraction of the platform
> > configuration from FDT. We also use ArmPkg/DriverArmPciCpuIoDxe,  we
> > can have RISC-V instance of CpuIoDxe but still leverage PCD produced
> > by FdtPciPcdProducerLib.
> >
> > Another library is QemuFwCfgLib from ArmVirtPkg/Library, I think we
> > can have RISC-V own instance because there is a one instance under
> > OvmfPkg already.
> 
> Are you expecting to need different functionality from the ArmVirtPkg
> one? If not, you could move that one to
>   OvmfPkg/Library/QemuFwCfgCommonLib
> or something.
The interfaces provided by ARM QemuFwLib seems works fine with RISC-V OVMF, however the build fail with the recent change of adding "#if defined(MDE_CPU_AARCH64)". I prefer to have RISC-V instance because I am not sure if any fw_cfg interface changes would be made on RISC-V QEMU.

> 
> Note that there are also a couple of platforms in edk2-platforms that
> reference ArmVirtPkg code. Those would need to be fixed up as well, if
> anything they depend on moves.
Thanks for this  information.
Abner
> 
> Agree with comments others made regarding use of git mv of single
> module at a time.
> 
> I wouldn't mind being a reviewer for the FDT-related common modules.
Nice :)
Abner
> 
> Regards,
> 
> Leif
> 
> > 发件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> 代表 Abner Chang
> > 发送时间: 2021年9月5日 11:15
> > 收件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> > 抄送: Ard Biesheuvel
> <ard.biesheuvel@arm.com<mailto:ard.biesheuvel@arm.com>>; Michael D
> Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>;
> Leif Lindholm <leif@nuviainc.com<mailto:leif@nuviainc.com>>;
> ray.ni@intel.com<mailto:ray.ni@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Schaefer,
> Daniel <daniel.schaefer@hpe.com<mailto:daniel.schaefer@hpe.com>>;
> Sunil V L <sunilvl@ventanamicro.com<mailto:sunilvl@ventanamicro.com>>
> > 主题: [edk2-devel] [RFC] RISC-V QEMU virtual package
> >
> > Hi all,
> > We currently have RISC-V edk2 OVMF package that can boot to Linux
> kernel on QEMU RISC-V virt platform.
> > First at all, we would like to create a folder RiscvVirtPkg under edk2 repo
> and integrated in the Platform CI build.
> >
> > Second, RISC-V edk2 OVMF package leverages some edk2 libraries and
> drivers from ArmVirtPkg, such as FDT related modules for PCI bus, host
> bridge and etc. We would like to move those generic virtual drivers to
> > a common folder for ARM and RISC-V (I don’t think this way is necessary
> though). Or can we move those to just under OvmfPkg because OvmfPkg
> also provides some common drivers for the processor architectures.
> > Thoughts?
> >
> > Thanks
> > Abner
> > 

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
  2021-09-08 12:31           ` Abner Chang
@ 2021-09-08 13:37             ` Gerd Hoffmann
  2021-09-08 15:33               ` Abner Chang
  0 siblings, 1 reply; 24+ messages in thread
From: Gerd Hoffmann @ 2021-09-08 13:37 UTC (permalink / raw)
  To: Chang, Abner (HPS SW/FW Technologist)
  Cc: Leif Lindholm, Yao, Jiewen, devel@edk2.groups.io, gaoliming,
	'Ard Biesheuvel', Kinney, Michael D, Ni, Ray,
	Schaefer, Daniel, 'Sunil V L', 'Ard Biesheuvel'

  Hi,

> > Are you expecting to need different functionality from the ArmVirtPkg
> > one? If not, you could move that one to
> >   OvmfPkg/Library/QemuFwCfgCommonLib
> > or something.

> The interfaces provided by ARM QemuFwLib seems works fine with RISC-V
> OVMF, however the build fail with the recent change of adding "#if
> defined(MDE_CPU_AARCH64)".

How does that fail to build?

The #ifdef looks like a performance optimization, doing 64bit mmio
access on 64bit platforms to reduce the number of traps.  Even without
fixing that up for RISCV64 so it gets the same treatment everything
should work fine, just a little slower than it could.

> I prefer to have RISC-V instance because I
> am not sure if any fw_cfg interface changes would be made on RISC-V
> QEMU.

The fw_cfg interface should not diverge.  ia32/x64 works a bit different
because there is a separate io address space on that architecture and
fw_cfg uses that for historical reasons.  All platforms using the mmio
variant of the fw_cfg interface should work alike though.

take care,
  Gerd

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
  2021-09-08 13:37             ` Gerd Hoffmann
@ 2021-09-08 15:33               ` Abner Chang
  2021-09-08 15:53                 ` Leif Lindholm
  2021-09-09  5:23                 ` Gerd Hoffmann
  0 siblings, 2 replies; 24+ messages in thread
From: Abner Chang @ 2021-09-08 15:33 UTC (permalink / raw)
  To: 'Gerd Hoffmann'
  Cc: Leif Lindholm, Yao, Jiewen, devel@edk2.groups.io, gaoliming,
	'Ard Biesheuvel', Kinney, Michael D, Ni, Ray,
	Schaefer, Daniel, 'Sunil V L', 'Ard Biesheuvel'



> -----Original Message-----
> From: 'Gerd Hoffmann' [mailto:kraxel@redhat.com]
> Sent: Wednesday, September 8, 2021 9:37 PM
> To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
> Cc: Leif Lindholm <leif@nuviainc.com>; Yao, Jiewen <jiewen.yao@intel.com>;
> devel@edk2.groups.io; gaoliming <gaoliming@byosoft.com.cn>; 'Ard
> Biesheuvel' <ard.biesheuvel@arm.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Ni, Ray <ray.ni@intel.com>; Schaefer, Daniel
> <daniel.schaefer@hpe.com>; 'Sunil V L' <sunilvl@ventanamicro.com>; 'Ard
> Biesheuvel' <ardb+tianocore@kernel.org>
> Subject: Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
> 
>   Hi,
> 
> > > Are you expecting to need different functionality from the ArmVirtPkg
> > > one? If not, you could move that one to
> > >   OvmfPkg/Library/QemuFwCfgCommonLib
> > > or something.
> 
> > The interfaces provided by ARM QemuFwLib seems works fine with RISC-V
> > OVMF, however the build fail with the recent change of adding "#if
> > defined(MDE_CPU_AARCH64)".
> 
> How does that fail to build?
That is the cast from pointer to integer on (UINT32)&Access). The build error could be fixed by adding (UINTN) before casting to UINT32 though.
> 
> The #ifdef looks like a performance optimization, doing 64bit mmio
> access on 64bit platforms to reduce the number of traps.  Even without
> fixing that up for RISCV64 so it gets the same treatment everything
> should work fine, just a little slower than it could.
> 
> > I prefer to have RISC-V instance because I
> > am not sure if any fw_cfg interface changes would be made on RISC-V
> > QEMU.
> 
> The fw_cfg interface should not diverge.  ia32/x64 works a bit different
> because there is a separate io address space on that architecture and
> fw_cfg uses that for historical reasons.  All platforms using the mmio
> variant of the fw_cfg interface should work alike though.
Hmm, ok. 
We can have the common one for both ARM and RISC-V if there is no potential issues in the future as you mentioned. We can also add #defined (MDE_CPU_RISCV64) to avoid the build error as ARM and RISC-V share the same code.
One more question, there is already a QemuFwCfgLib library for ia32/x64. The naming of QemuFwCfgCommonLib under Library seems confusing. How about we  put this library under /FDT and also name it as QemuFwCfgLib? Because ARM/RISC-V fw_cfg also depends on FDT.

Abner


> 
> take care,
>   Gerd


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
  2021-09-08 15:33               ` Abner Chang
@ 2021-09-08 15:53                 ` Leif Lindholm
  2021-09-09  5:23                 ` Gerd Hoffmann
  1 sibling, 0 replies; 24+ messages in thread
From: Leif Lindholm @ 2021-09-08 15:53 UTC (permalink / raw)
  To: devel, abner.chang
  Cc: 'Gerd Hoffmann', Yao, Jiewen, gaoliming,
	'Ard Biesheuvel', Kinney, Michael D, Ni, Ray,
	Schaefer, Daniel, 'Sunil V L', 'Ard Biesheuvel'

On Wed, Sep 08, 2021 at 15:33:34 +0000, Abner Chang wrote:
> > > I prefer to have RISC-V instance because I
> > > am not sure if any fw_cfg interface changes would be made on RISC-V
> > > QEMU.
> > 
> > The fw_cfg interface should not diverge.  ia32/x64 works a bit different
> > because there is a separate io address space on that architecture and
> > fw_cfg uses that for historical reasons.  All platforms using the mmio
> > variant of the fw_cfg interface should work alike though.
>
> Hmm, ok. 
> We can have the common one for both ARM and RISC-V if there is no
> potential issues in the future as you mentioned. We can also add
> #defined (MDE_CPU_RISCV64) to avoid the build error as ARM and
> RISC-V share the same code.

Well, if it's a single file, we can easily make sure it doesn't break.
And we help improving the code quality. It's very easy for code that
gets shoved into architecture-specific subtrees to start growing
architecture-specific statements that don't actually describe anything
architecture-specific - because that sets the stage for how the code
is interpreted.

> One more question, there is already a QemuFwCfgLib library for
> ia32/x64. The naming of QemuFwCfgCommonLib under Library seems
> confusing. How about we  put this library under /FDT and also name
> it as QemuFwCfgLib? Because ARM/RISC-V fw_cfg also depends on FDT.

I mean, I would more prefer to rename the x86 one, since that one
becomes the special case. Dependency isn't what should dictate
hierarchy. The FwCfg interface is about a lot more than FDT.

/
    Leif


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
  2021-09-08 15:33               ` Abner Chang
  2021-09-08 15:53                 ` Leif Lindholm
@ 2021-09-09  5:23                 ` Gerd Hoffmann
  2021-09-10  0:08                   ` Abner Chang
  1 sibling, 1 reply; 24+ messages in thread
From: Gerd Hoffmann @ 2021-09-09  5:23 UTC (permalink / raw)
  To: Chang, Abner (HPS SW/FW Technologist)
  Cc: Leif Lindholm, Yao, Jiewen, devel@edk2.groups.io, gaoliming,
	'Ard Biesheuvel', Kinney, Michael D, Ni, Ray,
	Schaefer, Daniel, 'Sunil V L', 'Ard Biesheuvel'

  Hi,

> One more question, there is already a
> QemuFwCfgLib library for ia32/x64. The naming of QemuFwCfgCommonLib
> under Library seems confusing. How about we  put this library under
> /FDT and also name it as QemuFwCfgLib? Because ARM/RISC-V fw_cfg also
> depends on FDT.

Move it to OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibMMIO.{c,inf} ?

take care,
  Gerd


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
  2021-09-09  5:23                 ` Gerd Hoffmann
@ 2021-09-10  0:08                   ` Abner Chang
  2021-09-10  9:54                     ` Leif Lindholm
  0 siblings, 1 reply; 24+ messages in thread
From: Abner Chang @ 2021-09-10  0:08 UTC (permalink / raw)
  To: devel@edk2.groups.io, kraxel@redhat.com
  Cc: Leif Lindholm, Yao, Jiewen, gaoliming, 'Ard Biesheuvel',
	Kinney, Michael D, Ni, Ray, Schaefer, Daniel, 'Sunil V L',
	'Ard Biesheuvel'



> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Gerd Hoffmann
> Sent: Thursday, September 9, 2021 1:23 PM
> To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
> Cc: Leif Lindholm <leif@nuviainc.com>; Yao, Jiewen <jiewen.yao@intel.com>;
> devel@edk2.groups.io; gaoliming <gaoliming@byosoft.com.cn>; 'Ard
> Biesheuvel' <ard.biesheuvel@arm.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Ni, Ray <ray.ni@intel.com>; Schaefer, Daniel
> <daniel.schaefer@hpe.com>; 'Sunil V L' <sunilvl@ventanamicro.com>; 'Ard
> Biesheuvel' <ardb+tianocore@kernel.org>
> Subject: Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
> 
>   Hi,
> 
> > One more question, there is already a
> > QemuFwCfgLib library for ia32/x64. The naming of QemuFwCfgCommonLib
> > under Library seems confusing. How about we  put this library under
> > /FDT and also name it as QemuFwCfgLib? Because ARM/RISC-V fw_cfg also
> > depends on FDT.
> 
> Move it to OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibMMIO.{c,inf} ?
The naming sounds good to me.

Another question, 
Can CI build the package with dependency of edk2-platform? Currently RiscVPkg in under edk2-platform and the modules provided by RiscVPkg are referred by RiscVVirPkg.

Abner
> 
> take care,
>   Gerd
> 
> 
> 
> 
> 


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
  2021-09-10  0:08                   ` Abner Chang
@ 2021-09-10  9:54                     ` Leif Lindholm
  2021-09-10 10:06                       ` Ni, Ray
  0 siblings, 1 reply; 24+ messages in thread
From: Leif Lindholm @ 2021-09-10  9:54 UTC (permalink / raw)
  To: Chang, Abner (HPS SW/FW Technologist)
  Cc: devel@edk2.groups.io, kraxel@redhat.com, Yao, Jiewen, gaoliming,
	'Ard Biesheuvel', Kinney, Michael D, Ni, Ray,
	Schaefer, Daniel, 'Sunil V L', 'Ard Biesheuvel'

On Fri, Sep 10, 2021 at 00:08:12 +0000, Chang, Abner (HPS SW/FW Technologist) wrote:
> > Move it to OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibMMIO.{c,inf} ?
> The naming sounds good to me.
> 
> Another question, 
> Can CI build the package with dependency of edk2-platform? Currently
> RiscVPkg in under edk2-platform and the modules provided by RiscVPkg
> are referred by RiscVVirPkg.

Ideally not.

I think this serves as a reminder that RISC-V/ProcessorPkg should move
over to edk2.

/
    Leif

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
  2021-09-10  9:54                     ` Leif Lindholm
@ 2021-09-10 10:06                       ` Ni, Ray
  2021-09-11  0:52                         ` Abner Chang
       [not found]                         ` <16A39EA413775DFC.29279@groups.io>
  0 siblings, 2 replies; 24+ messages in thread
From: Ni, Ray @ 2021-09-10 10:06 UTC (permalink / raw)
  To: devel@edk2.groups.io, leif@nuviainc.com, Chang, Abner
  Cc: kraxel@redhat.com, Yao, Jiewen, gaoliming,
	'Ard Biesheuvel', Kinney, Michael D, Schaefer, Daniel,
	'Sunil V L', 'Ard Biesheuvel'

I asked similar question to Mike who initially set up the CI.
The answer was: it's ok to pull a edk2-platform code in CI process to verify edk2 code change.

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Leif Lindholm
> Sent: Friday, September 10, 2021 5:55 PM
> To: Chang, Abner <abner.chang@hpe.com>
> Cc: devel@edk2.groups.io; kraxel@redhat.com; Yao, Jiewen <jiewen.yao@intel.com>; gaoliming <gaoliming@byosoft.com.cn>;
> 'Ard Biesheuvel' <ard.biesheuvel@arm.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Ni, Ray <ray.ni@intel.com>;
> Schaefer, Daniel <daniel.schaefer@hpe.com>; 'Sunil V L' <sunilvl@ventanamicro.com>; 'Ard Biesheuvel'
> <ardb+tianocore@kernel.org>
> Subject: Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
> 
> On Fri, Sep 10, 2021 at 00:08:12 +0000, Chang, Abner (HPS SW/FW Technologist) wrote:
> > > Move it to OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibMMIO.{c,inf} ?
> > The naming sounds good to me.
> >
> > Another question,
> > Can CI build the package with dependency of edk2-platform? Currently
> > RiscVPkg in under edk2-platform and the modules provided by RiscVPkg
> > are referred by RiscVVirPkg.
> 
> Ideally not.
> 
> I think this serves as a reminder that RISC-V/ProcessorPkg should move
> over to edk2.
> 
> /
>     Leif
> 
> 
> 
> 


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
  2021-09-10 10:06                       ` Ni, Ray
@ 2021-09-11  0:52                         ` Abner Chang
       [not found]                         ` <16A39EA413775DFC.29279@groups.io>
  1 sibling, 0 replies; 24+ messages in thread
From: Abner Chang @ 2021-09-11  0:52 UTC (permalink / raw)
  To: Ni, Ray, devel@edk2.groups.io, leif@nuviainc.com
  Cc: kraxel@redhat.com, Yao, Jiewen, gaoliming,
	'Ard Biesheuvel', Kinney, Michael D, Schaefer, Daniel,
	'Sunil V L', 'Ard Biesheuvel'



> -----Original Message-----
> From: Ni, Ray [mailto:ray.ni@intel.com]
> Sent: Friday, September 10, 2021 6:07 PM
> To: devel@edk2.groups.io; leif@nuviainc.com; Chang, Abner (HPS SW/FW
> Technologist) <abner.chang@hpe.com>
> Cc: kraxel@redhat.com; Yao, Jiewen <jiewen.yao@intel.com>; gaoliming
> <gaoliming@byosoft.com.cn>; 'Ard Biesheuvel' <ard.biesheuvel@arm.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Schaefer, Daniel
> <daniel.schaefer@hpe.com>; 'Sunil V L' <sunilvl@ventanamicro.com>; 'Ard
> Biesheuvel' <ardb+tianocore@kernel.org>
> Subject: RE: [edk2-devel] [RFC] RISC-V QEMU virtual package
> 
> I asked similar question to Mike who initially set up the CI.
> The answer was: it's ok to pull a edk2-platform code in CI process to verify
> edk2 code change.
Move RiscVPkg/RiscVPlatformPkg to under edk2 rather than have it under edk2-platforms makes more sense to me, and just leave RISC-V platform code under edk2-platforms.
(Or we can merge RiscVPlatformPkg into RiscVPkg and put RiscVPkg under edk2 because it seems not necessary to have the common platform code in the separate package.)
 This is not only the matter of RISC-V packages location, CI for any RISC-V change is also required.

Abner

> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Leif
> Lindholm
> > Sent: Friday, September 10, 2021 5:55 PM
> > To: Chang, Abner <abner.chang@hpe.com>
> > Cc: devel@edk2.groups.io; kraxel@redhat.com; Yao, Jiewen
> <jiewen.yao@intel.com>; gaoliming <gaoliming@byosoft.com.cn>;
> > 'Ard Biesheuvel' <ard.biesheuvel@arm.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Ni, Ray <ray.ni@intel.com>;
> > Schaefer, Daniel <daniel.schaefer@hpe.com>; 'Sunil V L'
> <sunilvl@ventanamicro.com>; 'Ard Biesheuvel'
> > <ardb+tianocore@kernel.org>
> > Subject: Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
> >
> > On Fri, Sep 10, 2021 at 00:08:12 +0000, Chang, Abner (HPS SW/FW
> Technologist) wrote:
> > > > Move it to
> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibMMIO.{c,inf} ?
> > > The naming sounds good to me.
> > >
> > > Another question,
> > > Can CI build the package with dependency of edk2-platform? Currently
> > > RiscVPkg in under edk2-platform and the modules provided by RiscVPkg
> > > are referred by RiscVVirPkg.
> >
> > Ideally not.
> >
> > I think this serves as a reminder that RISC-V/ProcessorPkg should move
> > over to edk2.
> >
> > /
> >     Leif
> >
> >
> > 
> >


^ permalink raw reply	[flat|nested] 24+ messages in thread

[parent not found: <16A39EA413775DFC.29279@groups.io>]

* Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
       [not found]                         ` <16A39EA413775DFC.29279@groups.io>
@ 2021-09-18  6:46                           ` Abner Chang
       [not found]                           ` <16A5D7B7D6218B9A.31588@groups.io>
  1 sibling, 0 replies; 24+ messages in thread
From: Abner Chang @ 2021-09-18  6:46 UTC (permalink / raw)
  To: devel@edk2.groups.io, Chang, Abner (HPS SW/FW Technologist),
	Ni, Ray, leif@nuviainc.com
  Cc: kraxel@redhat.com, Yao, Jiewen, gaoliming,
	'Ard Biesheuvel', Kinney, Michael D, Schaefer, Daniel,
	'Sunil V L', 'Ard Biesheuvel'

Hi all, below is the plan to move some module/libraries from Arm*Pkg to other packages for RiscVVirtPkg and RiscVPkg.

1. FdtClientDxe - which is a useful protocol for parsing FDT nodes. Move to stay with FdtLib under EmbeddedPkg. gFdtClientProtocolGuid will be also moved to under EmbeddedPkg.
2. HighMemDxe - Move to under OvmfPkg/Fdt
3. FdtPciHostBridgeLib and FdtPciPcdProducerLib - Move to under OvmfPkg/Fdt
     The PCD PcdPciIoTranslation is used by above two libraries and ArmPciCpuIo2Dxe, RiscVVirtPkg will use that PCD as well. RiscVPkg may provide its own CPU_IO2 protocol and use this PCD as ARM does.
     The definition of PcdPciIoTranslation will be moved to under MdeModulePkg for ARM and RISC-V.
4. VirtioFdtDxe - Will be moved to under OvmfPkg/Fdt
Let me know if you have any opinions.

Regards,
Abner

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Abner Chang
> Sent: Saturday, September 11, 2021 8:52 AM
> To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io; leif@nuviainc.com
> Cc: kraxel@redhat.com; Yao, Jiewen <jiewen.yao@intel.com>; gaoliming
> <gaoliming@byosoft.com.cn>; 'Ard Biesheuvel' <ard.biesheuvel@arm.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Schaefer, Daniel
> <daniel.schaefer@hpe.com>; 'Sunil V L' <sunilvl@ventanamicro.com>; 'Ard
> Biesheuvel' <ardb+tianocore@kernel.org>
> Subject: Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
> 
> 
> 
> > -----Original Message-----
> > From: Ni, Ray [mailto:ray.ni@intel.com]
> > Sent: Friday, September 10, 2021 6:07 PM
> > To: devel@edk2.groups.io; leif@nuviainc.com; Chang, Abner (HPS SW/FW
> > Technologist) <abner.chang@hpe.com>
> > Cc: kraxel@redhat.com; Yao, Jiewen <jiewen.yao@intel.com>; gaoliming
> > <gaoliming@byosoft.com.cn>; 'Ard Biesheuvel'
> <ard.biesheuvel@arm.com>;
> > Kinney, Michael D <michael.d.kinney@intel.com>; Schaefer, Daniel
> > <daniel.schaefer@hpe.com>; 'Sunil V L' <sunilvl@ventanamicro.com>; 'Ard
> > Biesheuvel' <ardb+tianocore@kernel.org>
> > Subject: RE: [edk2-devel] [RFC] RISC-V QEMU virtual package
> >
> > I asked similar question to Mike who initially set up the CI.
> > The answer was: it's ok to pull a edk2-platform code in CI process to verify
> > edk2 code change.
> Move RiscVPkg/RiscVPlatformPkg to under edk2 rather than have it under
> edk2-platforms makes more sense to me, and just leave RISC-V platform
> code under edk2-platforms.
> (Or we can merge RiscVPlatformPkg into RiscVPkg and put RiscVPkg under
> edk2 because it seems not necessary to have the common platform code in
> the separate package.)
>  This is not only the matter of RISC-V packages location, CI for any RISC-V
> change is also required.
> 
> Abner
> 
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Leif
> > Lindholm
> > > Sent: Friday, September 10, 2021 5:55 PM
> > > To: Chang, Abner <abner.chang@hpe.com>
> > > Cc: devel@edk2.groups.io; kraxel@redhat.com; Yao, Jiewen
> > <jiewen.yao@intel.com>; gaoliming <gaoliming@byosoft.com.cn>;
> > > 'Ard Biesheuvel' <ard.biesheuvel@arm.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>; Ni, Ray <ray.ni@intel.com>;
> > > Schaefer, Daniel <daniel.schaefer@hpe.com>; 'Sunil V L'
> > <sunilvl@ventanamicro.com>; 'Ard Biesheuvel'
> > > <ardb+tianocore@kernel.org>
> > > Subject: Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
> > >
> > > On Fri, Sep 10, 2021 at 00:08:12 +0000, Chang, Abner (HPS SW/FW
> > Technologist) wrote:
> > > > > Move it to
> > OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibMMIO.{c,inf} ?
> > > > The naming sounds good to me.
> > > >
> > > > Another question,
> > > > Can CI build the package with dependency of edk2-platform? Currently
> > > > RiscVPkg in under edk2-platform and the modules provided by
> RiscVPkg
> > > > are referred by RiscVVirPkg.
> > >
> > > Ideally not.
> > >
> > > I think this serves as a reminder that RISC-V/ProcessorPkg should move
> > > over to edk2.
> > >
> > > /
> > >     Leif
> > >
> > >
> > >
> > >
> 
> 
> 
> 
> 


^ permalink raw reply	[flat|nested] 24+ messages in thread

[parent not found: <16A5D7B7D6218B9A.31588@groups.io>]

* Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
       [not found]                           ` <16A5D7B7D6218B9A.31588@groups.io>
@ 2021-09-18  7:00                             ` Abner Chang
  0 siblings, 0 replies; 24+ messages in thread
From: Abner Chang @ 2021-09-18  7:00 UTC (permalink / raw)
  To: devel@edk2.groups.io, Chang, Abner (HPS SW/FW Technologist),
	Ni, Ray, leif@nuviainc.com
  Cc: kraxel@redhat.com, Yao, Jiewen, gaoliming,
	'Ard Biesheuvel', Kinney, Michael D, Schaefer, Daniel,
	'Sunil V L', 'Ard Biesheuvel'

One corection.

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Abner Chang
> Sent: Saturday, September 18, 2021 2:46 PM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>; Ni, Ray <ray.ni@intel.com>; leif@nuviainc.com
> Cc: kraxel@redhat.com; Yao, Jiewen <jiewen.yao@intel.com>; gaoliming
> <gaoliming@byosoft.com.cn>; 'Ard Biesheuvel' <ard.biesheuvel@arm.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Schaefer, Daniel
> <daniel.schaefer@hpe.com>; 'Sunil V L' <sunilvl@ventanamicro.com>; 'Ard
> Biesheuvel' <ardb+tianocore@kernel.org>
> Subject: Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
> 
> Hi all, below is the plan to move some module/libraries from Arm*Pkg to
> other packages for RiscVVirtPkg and RiscVPkg.
> 
> 1. FdtClientDxe - which is a useful protocol for parsing FDT nodes. Move to
> stay with FdtLib under EmbeddedPkg. gFdtClientProtocolGuid will be also
> moved to under EmbeddedPkg.
> 2. HighMemDxe - Move to under OvmfPkg/Fdt
> 3. FdtPciHostBridgeLib and FdtPciPcdProducerLib - Move to under
> OvmfPkg/Fdt
>      The PCD PcdPciIoTranslation is used by above two libraries and
> ArmPciCpuIo2Dxe, RiscVVirtPkg will use that PCD as well. RiscVPkg may
> provide its own CPU_IO2 protocol and use this PCD as ARM does.
>      The definition of PcdPciIoTranslation will be moved to under
> MdeModulePkg for ARM and RISC-V.
PcdPciIoTranslation will be moved to under MdePkg/

Abner

> 4. VirtioFdtDxe - Will be moved to under OvmfPkg/Fdt
> Let me know if you have any opinions.
> 
> Regards,
> Abner
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Abner Chang
> > Sent: Saturday, September 11, 2021 8:52 AM
> > To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io; leif@nuviainc.com
> > Cc: kraxel@redhat.com; Yao, Jiewen <jiewen.yao@intel.com>; gaoliming
> > <gaoliming@byosoft.com.cn>; 'Ard Biesheuvel'
> <ard.biesheuvel@arm.com>;
> > Kinney, Michael D <michael.d.kinney@intel.com>; Schaefer, Daniel
> > <daniel.schaefer@hpe.com>; 'Sunil V L' <sunilvl@ventanamicro.com>; 'Ard
> > Biesheuvel' <ardb+tianocore@kernel.org>
> > Subject: Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
> >
> >
> >
> > > -----Original Message-----
> > > From: Ni, Ray [mailto:ray.ni@intel.com]
> > > Sent: Friday, September 10, 2021 6:07 PM
> > > To: devel@edk2.groups.io; leif@nuviainc.com; Chang, Abner (HPS
> SW/FW
> > > Technologist) <abner.chang@hpe.com>
> > > Cc: kraxel@redhat.com; Yao, Jiewen <jiewen.yao@intel.com>; gaoliming
> > > <gaoliming@byosoft.com.cn>; 'Ard Biesheuvel'
> > <ard.biesheuvel@arm.com>;
> > > Kinney, Michael D <michael.d.kinney@intel.com>; Schaefer, Daniel
> > > <daniel.schaefer@hpe.com>; 'Sunil V L' <sunilvl@ventanamicro.com>;
> 'Ard
> > > Biesheuvel' <ardb+tianocore@kernel.org>
> > > Subject: RE: [edk2-devel] [RFC] RISC-V QEMU virtual package
> > >
> > > I asked similar question to Mike who initially set up the CI.
> > > The answer was: it's ok to pull a edk2-platform code in CI process to verify
> > > edk2 code change.
> > Move RiscVPkg/RiscVPlatformPkg to under edk2 rather than have it under
> > edk2-platforms makes more sense to me, and just leave RISC-V platform
> > code under edk2-platforms.
> > (Or we can merge RiscVPlatformPkg into RiscVPkg and put RiscVPkg under
> > edk2 because it seems not necessary to have the common platform code in
> > the separate package.)
> >  This is not only the matter of RISC-V packages location, CI for any RISC-V
> > change is also required.
> >
> > Abner
> >
> > >
> > > > -----Original Message-----
> > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Leif
> > > Lindholm
> > > > Sent: Friday, September 10, 2021 5:55 PM
> > > > To: Chang, Abner <abner.chang@hpe.com>
> > > > Cc: devel@edk2.groups.io; kraxel@redhat.com; Yao, Jiewen
> > > <jiewen.yao@intel.com>; gaoliming <gaoliming@byosoft.com.cn>;
> > > > 'Ard Biesheuvel' <ard.biesheuvel@arm.com>; Kinney, Michael D
> > > <michael.d.kinney@intel.com>; Ni, Ray <ray.ni@intel.com>;
> > > > Schaefer, Daniel <daniel.schaefer@hpe.com>; 'Sunil V L'
> > > <sunilvl@ventanamicro.com>; 'Ard Biesheuvel'
> > > > <ardb+tianocore@kernel.org>
> > > > Subject: Re: [edk2-devel] [RFC] RISC-V QEMU virtual package
> > > >
> > > > On Fri, Sep 10, 2021 at 00:08:12 +0000, Chang, Abner (HPS SW/FW
> > > Technologist) wrote:
> > > > > > Move it to
> > > OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibMMIO.{c,inf} ?
> > > > > The naming sounds good to me.
> > > > >
> > > > > Another question,
> > > > > Can CI build the package with dependency of edk2-platform?
> Currently
> > > > > RiscVPkg in under edk2-platform and the modules provided by
> > RiscVPkg
> > > > > are referred by RiscVVirPkg.
> > > >
> > > > Ideally not.
> > > >
> > > > I think this serves as a reminder that RISC-V/ProcessorPkg should move
> > > > over to edk2.
> > > >
> > > > /
> > > >     Leif
> > > >
> > > >
> > > >
> > > >
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 


^ permalink raw reply	[flat|nested] 24+ messages in thread

end of thread, other threads:[~2021-09-18  7:00 UTC | newest]

Thread overview: 24+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-05  3:15 [RFC] RISC-V QEMU virtual package Abner Chang
2021-09-06  1:06 ` 回复: [edk2-devel] " gaoliming
2021-09-06  4:16   ` Abner Chang
2021-09-06  6:16     ` Yao, Jiewen
2021-09-06 11:08       ` Abner Chang
2021-09-06 11:44         ` Yao, Jiewen
2021-09-06 12:04           ` Ard Biesheuvel
2021-09-06 12:19             ` Gerd Hoffmann
2021-09-06 13:04               ` Abner Chang
2021-09-07  1:09                 ` 回复: " gaoliming
2021-09-07  2:31                   ` Abner Chang
2021-09-07  7:18                 ` Gerd Hoffmann
2021-09-07 17:22         ` Leif Lindholm
2021-09-08 12:31           ` Abner Chang
2021-09-08 13:37             ` Gerd Hoffmann
2021-09-08 15:33               ` Abner Chang
2021-09-08 15:53                 ` Leif Lindholm
2021-09-09  5:23                 ` Gerd Hoffmann
2021-09-10  0:08                   ` Abner Chang
2021-09-10  9:54                     ` Leif Lindholm
2021-09-10 10:06                       ` Ni, Ray
2021-09-11  0:52                         ` Abner Chang
     [not found]                         ` <16A39EA413775DFC.29279@groups.io>
2021-09-18  6:46                           ` Abner Chang
     [not found]                           ` <16A5D7B7D6218B9A.31588@groups.io>
2021-09-18  7:00                             ` Abner Chang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox