From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by mx.groups.io with SMTP id smtpd.web09.11.1631035353167127452 for ; Tue, 07 Sep 2021 10:22:33 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=agqo2W/X; spf=pass (domain: nuviainc.com, ip: 209.85.221.51, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f51.google.com with SMTP id q26so14638968wrc.7 for ; Tue, 07 Sep 2021 10:22:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=cm8as1xHaPF8f0qkq8kznB9Dot/sPEcUX/qvlx5CdYg=; b=agqo2W/XdkilGZZEz3f1hARMnfP7ZV0OWaH4ghjoca48/ymokGBZd2vhSJJW3cN4t3 7/BeGXR3JzvEuTIFY3mZERpr9qkq1yTfB2fKq6Je3xtQ+3r53gqlYTsV77+GxJ1RqolQ cfFNxsBEE8gdpV/lfkdNShh+qVXQPFJ3f6jE14usdEQtx9JdGnFK9icaog0iQltcMgsa e2B5l+9Iuu1cUre2qTlQIcIIxgoZWRu3w3+ng8FiBiH7khdu/8cUkwLhBRoCeTNyYsA5 BRW9K27wthCGXLSOXcMfI6Qbn2aPElg4JmP+U08wYdh0f/ecQaUaVNDESQdDATFb7h9y r9gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=cm8as1xHaPF8f0qkq8kznB9Dot/sPEcUX/qvlx5CdYg=; b=cGqAQy2DQR5wY1WihzuAFbEKsXmH7zshtK0DuynzvXGqxzhHCTvvZSr9tFo9vVR1Ql mAreR76ON6d7BXNd7rMsJ1HHeLOjoKNHeHZWdeyCRfrPrX/qFc/z/1nP6ZCr3wKiBovD AiIt9zlHGG4C5mWCGGZZPn3ZSrb7RDQB4zrCzHtlOs7gIVIvS5yk44/DPm+2E32Ii8Gz RELdGuIoRhOgkgroHvV1Y5RWCaTexJZmgnqiyeH1SzywgzIIu4wojF11Ldmetv2AFhMc ttRDIp0QH/NZbnRt9oNwdYdBYTqhp/Aw1bOGQaiA4vN8GaJBroEz8kudSxO58IS3+BSZ prNQ== X-Gm-Message-State: AOAM533JGWSJ3KAHjryRLLPT8MQuSTKr4kKFmrC7x2H0sRK3S0FqzW3K 1duraQaNOxH6mEP7iBpKhg7fiQ== X-Google-Smtp-Source: ABdhPJwR4bloOMyTpn+lu5N1aBtSkhbo493S7kR8T1EUPvy3H/NDJfXaECRGM1qHmM70RQnfJkBbFQ== X-Received: by 2002:adf:916f:: with SMTP id j102mr20010977wrj.422.1631035351624; Tue, 07 Sep 2021 10:22:31 -0700 (PDT) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id q4sm11841731wra.43.2021.09.07.10.22.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Sep 2021 10:22:30 -0700 (PDT) Date: Tue, 7 Sep 2021 18:22:29 +0100 From: "Leif Lindholm" To: "Chang, Abner (HPS SW/FW Technologist)" Cc: "Yao, Jiewen" , "devel@edk2.groups.io" , gaoliming , 'Ard Biesheuvel' , "Kinney, Michael D" , "Ni, Ray" , "Schaefer, Daniel" , 'Sunil V L' , 'Ard Biesheuvel' , 'Gerd Hoffmann' Subject: Re: [edk2-devel] [RFC] RISC-V QEMU virtual package Message-ID: <20210907172229.geh4zcz7pvxoyyj6@leviathan> References: <005f01d7a2bb$6d8e5ef0$48ab1cd0$@byosoft.com.cn> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Hi Abner, Happy to see this happening. I think the capitalisation should be RiscVVirtPkg rather than RiscvVirtPkg though. More comments below. On Mon, Sep 06, 2021 at 11:08:47 +0000, Chang, Abner (HPS SW/FW Technologist) wrote: > We currently only use below modules from ArmVirtPkg, > > - ArmVirtPkg/Library > o FdtPciPcdProducerLib > o FdtPciHostBridgeLib > > - ArmVirtPkg/ > o VirtioFdtDxe > o FdtClientDxe > o HighMemDxe > > Above modules are related to the extraction of the platform > configuration from FDT. We also use ArmPkg/DriverArmPciCpuIoDxe, we > can have RISC-V instance of CpuIoDxe but still leverage PCD produced > by FdtPciPcdProducerLib. > > Another library is QemuFwCfgLib from ArmVirtPkg/Library, I think we > can have RISC-V own instance because there is a one instance under > OvmfPkg already. Are you expecting to need different functionality from the ArmVirtPkg one? If not, you could move that one to OvmfPkg/Library/QemuFwCfgCommonLib or something. Note that there are also a couple of platforms in edk2-platforms that reference ArmVirtPkg code. Those would need to be fixed up as well, if anything they depend on moves. Agree with comments others made regarding use of git mv of single module at a time. I wouldn't mind being a reviewer for the FDT-related common modules. Regards, Leif > 发件人: devel@edk2.groups.io > 代表 Abner Chang > 发送时间: 2021年9月5日 11:15 > 收件人: devel@edk2.groups.io > 抄送: Ard Biesheuvel >; Michael D Kinney >; Leif Lindholm >; ray.ni@intel.com; Liming Gao >; Schaefer, Daniel >; Sunil V L > > 主题: [edk2-devel] [RFC] RISC-V QEMU virtual package > > Hi all, > We currently have RISC-V edk2 OVMF package that can boot to Linux kernel on QEMU RISC-V virt platform. > First at all, we would like to create a folder RiscvVirtPkg under edk2 repo and integrated in the Platform CI build. > > Second, RISC-V edk2 OVMF package leverages some edk2 libraries and drivers from ArmVirtPkg, such as FDT related modules for PCI bus, host bridge and etc. We would like to move those generic virtual drivers to > a common folder for ARM and RISC-V (I don’t think this way is necessary though). Or can we move those to just under OvmfPkg because OvmfPkg also provides some common drivers for the processor architectures. > Thoughts? > > Thanks > Abner >