[PATCH v2 0/2] BaseTools: Switch to downloading the ARM/AARCH64 compiler from Arm's site

[PATCH v2 0/2] BaseTools: Switch to downloading the ARM/AARCH64 compiler from Arm's site

[Rebecca Cran]

Linaro no longer do gcc releases - Arm creates them now.

Update the gcc_[arm,aarch64]_linux_ext_dep.yaml files in BaseTools/Bin to
switch from Linaro's old release to the latest gcc 10.3-2021.07 release
from Arm and fix LinuxGcc5ToolChain.py with the new gcc prefix.


Rebecca Cran (2):
  BaseTools: Switch to downloading the ARM compiler from Arm's site
  BaseTools: Switch to downloading the AARCH64 compiler from Arm's site

 BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml              | 10 +++++-----
 BaseTools/Bin/gcc_arm_linux_ext_dep.yaml                  | 10 +++++-----
 BaseTools/Plugin/LinuxGcc5ToolChain/LinuxGcc5ToolChain.py |  4 ++--
 3 files changed, 12 insertions(+), 12 deletions(-)

-- 
2.31.1

[PATCH v2 1/2] BaseTools: Switch to downloading the ARM compiler from Arm's site

[Rebecca Cran]

Linaro no longer do gcc releases - they're done by Arm now.
Update gcc_arm_linux_ext_dep.yaml to fetch the latest ARM gcc release
(10.3-2021.07) from their site and fix LinuxGcc5ToolChain.py with the
new GCC_ARM_PREFIX.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
 BaseTools/Bin/gcc_arm_linux_ext_dep.yaml                  | 10 +++++-----
 BaseTools/Plugin/LinuxGcc5ToolChain/LinuxGcc5ToolChain.py |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/BaseTools/Bin/gcc_arm_linux_ext_dep.yaml b/BaseTools/Bin/gcc_arm_linux_ext_dep.yaml
index 09481ceae05f..9b3c4e394fa1 100644
--- a/BaseTools/Bin/gcc_arm_linux_ext_dep.yaml
+++ b/BaseTools/Bin/gcc_arm_linux_ext_dep.yaml
@@ -1,5 +1,5 @@
 ## @file
-# Download GCC ARM compiler from Linaro's release site
+# Download GCC ARM compiler from Arm's release site
 # Set shell variable GCC5_ARM_INSTALL to this folder
 #
 # This is only downloaded when a build activates scope gcc_arm_linux
@@ -11,11 +11,11 @@
   "scope": "gcc_arm_linux",
   "type": "web",
   "name": "gcc_arm_linux",
-  "source": "https://releases.linaro.org/components/toolchain/binaries/7.4-2019.02/arm-linux-gnueabihf/gcc-linaro-7.4.1-2019.02-x86_64_arm-linux-gnueabihf.tar.xz",
-  "version": "7.4.1",
-  "sha256": "3C951CF1941D0FA06D64CC0D5E88612B209D8123B273FA26C16D70BD7BC6B163",
+  "source": "https://developer.arm.com/-/media/Files/downloads/gnu-a/10.3-2021.07/binrel/gcc-arm-10.3-2021.07-x86_64-arm-none-linux-gnueabihf.tar.asc",
+  "version": "10.3-2021.07",
+  "sha256": "aa074fa8371a4f73fecbd16bd62c8b1945f23289e26414794f130d6ccdf8e39c",
   "compression_type": "tar",
-  "internal_path": "/gcc-linaro-7.4.1-2019.02-x86_64_arm-linux-gnueabihf/",
+  "internal_path": "/gcc-arm-10.3-2021.07-x86_64-arm-none-linux-gnueabihf/",
   "flags": ["set_shell_var", ],
   "var_name": "GCC5_ARM_INSTALL"
 }
diff --git a/BaseTools/Plugin/LinuxGcc5ToolChain/LinuxGcc5ToolChain.py b/BaseTools/Plugin/LinuxGcc5ToolChain/LinuxGcc5ToolChain.py
index 81075438d2e8..a695fc328565 100644
--- a/BaseTools/Plugin/LinuxGcc5ToolChain/LinuxGcc5ToolChain.py
+++ b/BaseTools/Plugin/LinuxGcc5ToolChain/LinuxGcc5ToolChain.py
@@ -57,7 +57,7 @@ class LinuxGcc5ToolChain(IUefiBuildPlugin):
                 return 0
 
             # make GCC5_ARM_PREFIX to align with tools_def.txt
-            prefix = os.path.join(install_path, "bin", "arm-linux-gnueabihf-")
+            prefix = os.path.join(install_path, "bin", "arm-none-linux-gnueabihf-")
             shell_environment.GetEnvironment().set_shell_var("GCC5_ARM_PREFIX", prefix)
 
         # now confirm it exists
-- 
2.31.1

[PATCH v2 2/2] BaseTools: Switch to downloading the AARCH64 compiler from Arm's site

[Rebecca Cran]

Linaro no longer do gcc releases - they're done by Arm now.

Update gcc_aarch64_linux_ext_dep.yaml to fetch the latest AARCH64 gcc
release (10.3-2021.07) from their site and fix LinuxGcc5ToolChain.py with the
new GCC_AARCH64_PREFIX.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
 BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml              | 10 +++++-----
 BaseTools/Plugin/LinuxGcc5ToolChain/LinuxGcc5ToolChain.py |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml b/BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml
index e81223fd9ad1..de7682b5521f 100644
--- a/BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml
+++ b/BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml
@@ -1,5 +1,5 @@
 ## @file
-# Download GCC AARCH64 compiler from Linaro's release site
+# Download GCC AARCH64 compiler from Arm's release site
 # Set shell variable GCC5_AARCH64_INSTALL to this folder
 #
 # This is only downloaded when a build activates scope gcc_aarch64_linux
@@ -11,11 +11,11 @@
   "scope": "gcc_aarch64_linux",
   "type": "web",
   "name": "gcc_aarch64_linux",
-  "source": "http://releases.linaro.org/components/toolchain/binaries/7.4-2019.02/aarch64-linux-gnu/gcc-linaro-7.4.1-2019.02-x86_64_aarch64-linux-gnu.tar.xz",
-  "version": "7.4.1",
-  "sha256": "27f1dc2c491ed61ae8f0d4b0c11de59cd2f7dd9c94761ee7153006fcac1bf9ab",
+  "source": "https://developer.arm.com/-/media/Files/downloads/gnu-a/10.3-2021.07/binrel/gcc-arm-10.3-2021.07-x86_64-aarch64-none-linux-gnu.tar.xz",
+  "version": "10.3-2021.07",
+  "sha256": "1e33d53dea59c8de823bbdfe0798280bdcd138636c7060da9d77a97ded095a84",
   "compression_type": "tar",
-  "internal_path": "/gcc-linaro-7.4.1-2019.02-x86_64_aarch64-linux-gnu/",
+  "internal_path": "/gcc-arm-10.3-2021.07-x86_64-aarch64-none-linux-gnu/",
   "flags": ["set_shell_var", ],
   "var_name": "GCC5_AARCH64_INSTALL"
 }
diff --git a/BaseTools/Plugin/LinuxGcc5ToolChain/LinuxGcc5ToolChain.py b/BaseTools/Plugin/LinuxGcc5ToolChain/LinuxGcc5ToolChain.py
index a695fc328565..f0685d804029 100644
--- a/BaseTools/Plugin/LinuxGcc5ToolChain/LinuxGcc5ToolChain.py
+++ b/BaseTools/Plugin/LinuxGcc5ToolChain/LinuxGcc5ToolChain.py
@@ -80,7 +80,7 @@ class LinuxGcc5ToolChain(IUefiBuildPlugin):
                 return 0
 
             # make GCC5_AARCH64_PREFIX to align with tools_def.txt
-            prefix = os.path.join(install_path, "bin", "aarch64-linux-gnu-")
+            prefix = os.path.join(install_path, "bin", "aarch64-none-linux-gnu-")
             shell_environment.GetEnvironment().set_shell_var("GCC5_AARCH64_PREFIX", prefix)
 
         # now confirm it exists
-- 
2.31.1

Re: [PATCH v2 0/2] BaseTools: Switch to downloading the ARM/AARCH64 compiler from Arm's site

[Ard Biesheuvel]

On Mon, 30 Aug 2021 at 07:15, Rebecca Cran <rebecca@bsdio.com> wrote:
>
> Linaro no longer do gcc releases - Arm creates them now.
>
> Update the gcc_[arm,aarch64]_linux_ext_dep.yaml files in BaseTools/Bin to
> switch from Linaro's old release to the latest gcc 10.3-2021.07 release
> from Arm and fix LinuxGcc5ToolChain.py with the new gcc prefix.
>
>
> Rebecca Cran (2):
>   BaseTools: Switch to downloading the ARM compiler from Arm's site
>   BaseTools: Switch to downloading the AARCH64 compiler from Arm's site
>

For the series,


Acked-by: Ard Biesheuvel <ardb@kernel.org>

>  BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml              | 10 +++++-----
>  BaseTools/Bin/gcc_arm_linux_ext_dep.yaml                  | 10 +++++-----
>  BaseTools/Plugin/LinuxGcc5ToolChain/LinuxGcc5ToolChain.py |  4 ++--
>  3 files changed, 12 insertions(+), 12 deletions(-)
>
> --
> 2.31.1
>
>

回复: [edk2-devel] [PATCH v2 0/2] BaseTools: Switch to downloading the ARM/AARCH64 compiler from Arm's site

[gaoliming]

Acked-by: Liming Gao <gaoliming@byosoft.com.cn> for this patch set. 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Ard
> Biesheuvel
> 发送时间: 2021年8月30日 21:46
> 收件人: Rebecca Cran <rebecca@bsdio.com>
> 抄送: Bob Feng <bob.c.feng@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Yuwei Chen <yuwei.chen@intel.com>; Sean
> Brogan <sean.brogan@microsoft.com>; Sami Mujawar
> <sami.mujawar@arm.com>; Leif Lindholm <leif@nuviainc.com>; Ard
> Biesheuvel <ardb+tianocore@kernel.org>; devel@edk2.groups.io
> 主题: Re: [edk2-devel] [PATCH v2 0/2] BaseTools: Switch to downloading the
> ARM/AARCH64 compiler from Arm's site
> 
> On Mon, 30 Aug 2021 at 07:15, Rebecca Cran <rebecca@bsdio.com> wrote:
> >
> > Linaro no longer do gcc releases - Arm creates them now.
> >
> > Update the gcc_[arm,aarch64]_linux_ext_dep.yaml files in BaseTools/Bin to
> > switch from Linaro's old release to the latest gcc 10.3-2021.07 release
> > from Arm and fix LinuxGcc5ToolChain.py with the new gcc prefix.
> >
> >
> > Rebecca Cran (2):
> >   BaseTools: Switch to downloading the ARM compiler from Arm's site
> >   BaseTools: Switch to downloading the AARCH64 compiler from Arm's site
> >
> 
> For the series,
> 
> 
> Acked-by: Ard Biesheuvel <ardb@kernel.org>
> 
> >  BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml              | 10
> +++++-----
> >  BaseTools/Bin/gcc_arm_linux_ext_dep.yaml                  | 10
> +++++-----
> >  BaseTools/Plugin/LinuxGcc5ToolChain/LinuxGcc5ToolChain.py |  4 ++--
> >  3 files changed, 12 insertions(+), 12 deletions(-)
> >
> > --
> > 2.31.1
> >
> >
> 
> 
> 
> 

Re: [PATCH v2 0/2] BaseTools: Switch to downloading the ARM/AARCH64 compiler from Arm's site

[Leif Lindholm]

On Sun, Aug 29, 2021 at 23:14:48 -0600, Rebecca Cran wrote:
> Linaro no longer do gcc releases - Arm creates them now.
> 
> Update the gcc_[arm,aarch64]_linux_ext_dep.yaml files in BaseTools/Bin to
> switch from Linaro's old release to the latest gcc 10.3-2021.07 release
> from Arm and fix LinuxGcc5ToolChain.py with the new gcc prefix.
> 

I don't know if anyone uses these files/tools to download toolchains
for downstream platforms. If they do, the upgrade from gcc7 to gcc10
may break their builds. But we're just after stable tag, so I have no
problem with that.

Acked-by: Leif Lindholm <leif@nuviainc.com>

> Rebecca Cran (2):
>   BaseTools: Switch to downloading the ARM compiler from Arm's site
>   BaseTools: Switch to downloading the AARCH64 compiler from Arm's site
> 
>  BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml              | 10 +++++-----
>  BaseTools/Bin/gcc_arm_linux_ext_dep.yaml                  | 10 +++++-----
>  BaseTools/Plugin/LinuxGcc5ToolChain/LinuxGcc5ToolChain.py |  4 ++--
>  3 files changed, 12 insertions(+), 12 deletions(-)
> 
> -- 
> 2.31.1
> 
> 

Re: [edk2-devel] [PATCH v2 0/2] BaseTools: Switch to downloading the ARM/AARCH64 compiler from Arm's site

[Gerd Hoffmann]

On Wed, Sep 08, 2021 at 12:13:12PM +0100, Leif Lindholm wrote:
> On Sun, Aug 29, 2021 at 23:14:48 -0600, Rebecca Cran wrote:
> > Linaro no longer do gcc releases - Arm creates them now.
> > 
> > Update the gcc_[arm,aarch64]_linux_ext_dep.yaml files in BaseTools/Bin to
> > switch from Linaro's old release to the latest gcc 10.3-2021.07 release
> > from Arm and fix LinuxGcc5ToolChain.py with the new gcc prefix.
> > 
> 
> I don't know if anyone uses these files/tools to download toolchains
> for downstream platforms. If they do, the upgrade from gcc7 to gcc10
> may break their builds. But we're just after stable tag, so I have no
> problem with that.

I'm wondering whenever this still makes sense.  I guess it was very
useful in the early arm days where you need a cutting-edge compiler with
the latest fixes applied to properly build edk2.  Meanwhile mainline gcc
should work without any problems.  I'm simply using the distro cross
compiler packages (gcc-arm-linux-gnu.rpm and gcc-aarch-linux-gnu.rpm on
fedora) with zero problems since years.  As far I know debian/ubuntu
have cross compiler packages too.

Fedora is at gcc11 meanwhile, so I don't expect the gcc7 -> gcc10 switch
will trouble.  I don't do platform builds though, only ArmVirt.

take care,
  Gerd

Re: [edk2-devel] [PATCH v2 0/2] BaseTools: Switch to downloading the ARM/AARCH64 compiler from Arm's site

[Leif Lindholm]

On Wed, Sep 08, 2021 at 13:46:43 +0200, Gerd Hoffmann wrote:
> On Wed, Sep 08, 2021 at 12:13:12PM +0100, Leif Lindholm wrote:
> > On Sun, Aug 29, 2021 at 23:14:48 -0600, Rebecca Cran wrote:
> > > Linaro no longer do gcc releases - Arm creates them now.
> > > 
> > > Update the gcc_[arm,aarch64]_linux_ext_dep.yaml files in BaseTools/Bin to
> > > switch from Linaro's old release to the latest gcc 10.3-2021.07 release
> > > from Arm and fix LinuxGcc5ToolChain.py with the new gcc prefix.
> > > 
> > 
> > I don't know if anyone uses these files/tools to download toolchains
> > for downstream platforms. If they do, the upgrade from gcc7 to gcc10
> > may break their builds. But we're just after stable tag, so I have no
> > problem with that.
> 
> I'm wondering whenever this still makes sense.  I guess it was very
> useful in the early arm days where you need a cutting-edge compiler with
> the latest fixes applied to properly build edk2.  Meanwhile mainline gcc
> should work without any problems.  I'm simply using the distro cross
> compiler packages (gcc-arm-linux-gnu.rpm and gcc-aarch-linux-gnu.rpm on
> fedora) with zero problems since years.  As far I know debian/ubuntu
> have cross compiler packages too.

Oh, I personally only ever use distro-provided toolchains (when they
exist). The ones the distros use to build themselves. And I'm still
annoyed by how we're treating ARM like some weird special case that
needs to be cross compiled by default.

But that seems to be a lost battle. And I'd rather have the people who
feel that way use toolchains that occasionally get updated rather than
lock down on a version that stopped being updated several years ago.

> Fedora is at gcc11 meanwhile, so I don't expect the gcc7 -> gcc10 switch
> will trouble.  I don't do platform builds though, only ArmVirt.

Yes, hence my reference to downstream platforms :)

/
    Leif

Re: [PATCH v2 0/2] BaseTools: Switch to downloading the ARM/AARCH64 compiler from Arm's site

[Bob Feng]

Acked-by: Bob Feng <bob.c.feng@intel.com>

Sorry for the late response.

-----Original Message-----
From: Rebecca Cran <rebecca@bsdio.com> 
Sent: Monday, August 30, 2021 1:15 PM
To: Feng, Bob C <bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; Sami Mujawar <sami.mujawar@arm.com>; Leif Lindholm <leif@nuviainc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Rebecca Cran <rebecca@bsdio.com>; devel@edk2.groups.io
Subject: [PATCH v2 0/2] BaseTools: Switch to downloading the ARM/AARCH64 compiler from Arm's site

Linaro no longer do gcc releases - Arm creates them now.

Update the gcc_[arm,aarch64]_linux_ext_dep.yaml files in BaseTools/Bin to switch from Linaro's old release to the latest gcc 10.3-2021.07 release from Arm and fix LinuxGcc5ToolChain.py with the new gcc prefix.


Rebecca Cran (2):
  BaseTools: Switch to downloading the ARM compiler from Arm's site
  BaseTools: Switch to downloading the AARCH64 compiler from Arm's site

 BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml              | 10 +++++-----
 BaseTools/Bin/gcc_arm_linux_ext_dep.yaml                  | 10 +++++-----
 BaseTools/Plugin/LinuxGcc5ToolChain/LinuxGcc5ToolChain.py |  4 ++--
 3 files changed, 12 insertions(+), 12 deletions(-)

--
2.31.1