From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by mx.groups.io with SMTP id smtpd.web12.5293.1631182937075431986 for ; Thu, 09 Sep 2021 03:22:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=x0Cmko+j; spf=pass (domain: nuviainc.com, ip: 209.85.221.51, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f51.google.com with SMTP id q11so1764936wrr.9 for ; Thu, 09 Sep 2021 03:22:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IQa8k1uCIEda1Nm7sWx2pOUiydvW6re5cIgXWkSZ01U=; b=x0Cmko+jIMTTOcArd6qi/xoLjV/CSjETqGW/voyzNhYwoAomwo0EXhQKNH5In1Mm20 lVf+XVVbtgmRSuU75hOC44zLk4bGgeA7jyTkcbZAkicXzQs5WK9TSGKMwZGRzcWsuz9v bcCm15ZW/hADgQyK0KC8UuuEgKq3Nvk4ltQ/CVs+O4aLhTkXQEa0KeOWCPdBnzvFovOO AAsOSJ6vWgiOAqz/35xnlv2+QW3TcrvEuQTZ7qwHOLFHmupfiqa+N2CRti3LneVh2Xg2 +QvN65Xu3cMBB7EPKZ86V34SnYYuOHIwJWNzIAO+4jTuI+/of488K7joYGp+nN4LInRz UNWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IQa8k1uCIEda1Nm7sWx2pOUiydvW6re5cIgXWkSZ01U=; b=tVKF97Tf6XncHLVBgChav6xomakQ6B1s0Re9vvZ+tz4BvYT/4jm2/LtrK6iktXXnlM aZ+T7H9GJicCCVm2sLo9w1S3cEQ4ev+Vivbld+TY923hHx02gu46FrhB5dAd3IPEihuP MKMnqZHYwyl9V3NrseezjV1+ZXgxL2c9zx7F0K3PREfpwTU1HtaxLjtCk3BD/APUahs3 DwQIsXkd0dwwuoYzxWiRcV810ktGhZeR7ynhOXZVsDzVrD3nLdrNda/smh+ZztbKAyQJ oR6x7v75d28qdboNmcg//VSZaod6Mk0jbevSqbVRphyKnqApS5kGvQMDGcrOO1t8N786 u6Zg== X-Gm-Message-State: AOAM5305Li0PGsQEMIKHD4on/EOzVjHh8fjgJNLBVwgUq0V+TR5wpFDM faRGslspub7AEWGYBlvXO3pVBkddnHvKEiMc X-Google-Smtp-Source: ABdhPJw6gorTnTaLYOZD0a2JOmyWpT++QTMRq8OWmuAaZ8aPi9mKWSxokoV0hm7paJGaMU/8kFcQgA== X-Received: by 2002:a5d:5610:: with SMTP id l16mr2199784wrv.102.1631182935310; Thu, 09 Sep 2021 03:22:15 -0700 (PDT) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id j18sm1399739wrd.56.2021.09.09.03.22.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Sep 2021 03:22:14 -0700 (PDT) Date: Thu, 9 Sep 2021 11:22:12 +0100 From: "Leif Lindholm" To: Ling Jia Cc: devel@edk2.groups.io Subject: Re: [PATCH v5 00/10] Added support for FT2000/4 chip Message-ID: <20210909102212.nqaatfaz6htvhaph@leviathan> References: <20210909094719.5911-1-jialing@phytium.com.cn> MIME-Version: 1.0 In-Reply-To: <20210909094719.5911-1-jialing@phytium.com.cn> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Ling, This set *still* does not contain the changes I included in my replies to v3 and v4 that let it build against current edk2 master. Please include those changes, verify the platform builds against current edk2 master, and resubmit a v6. Best Regards, Leif On Thu, Sep 09, 2021 at 17:47:09 +0800, Ling Jia wrote: > This series added packages to support FT2000/4 chip. > Platform/Phytium: Added DurianPkg, include DurianPkg.dsc and DurianPkg.fdf. > Silicon/Phytium: Added FT2000-4Pkg and PhytiumCommonPkg. > > The modules could be runed at the silicon of FT2000/4. > They supported Acpi parameter configuration, Pci bus scaning, > flash read-write and erase abd operating system boot function. > Maintainers.txt: Added maintainers and reviewers for the DurianPkg. > > The public git repository is : > https://github.com/jialing2020/edk2-platforms/tree/Phytium_Opensource_For_FT2000-4_v5 > > About patch 7: > This is a set of special communication protocol for > ft2000/4 chip QSPI controller. It has twoaccess modes: > direct address access and command port access. > At present, the read and write operations of flash > are completed through direct address access > (address mapping has been done on the hardware, > and the write access is configured to put the data > into the buffer first and merge and write multiple times). > The erase operation is completed through command port access. > Every time you operate norflash, you need to configure the > command code, command format and other information through > the command port register (such as erasing 0xd8), if the > command requires an address, fill in the address port register; > if the command requires data, access it in the order of high- > order data register and low-order data register. > Once the low-order data register is accessed, trigger > the controller to send a command to flash. > > Ling Jia (10): > Silicon/Phytium: Added PlatformLib to FT2000/4 > Silicon/Phytium: Added Acpi support to FT2000/4 > Silicon/Phytium: Added SMBIOS support to FT2000/4 > Silicon/Phytium: Added PciSegmentLib to FT2000/4 > Silicon/Phytium: Added PciHostBridgeLib to FT2000/4 > Silicon/Phytium: Added Spi driver support to FT2000/4 > Silicon/Phytium: Added flash driver support to Phytium Silicon > Silicon/Phytium: Added fvb driver for norflash > Silicon/Phytium: Added Rtc driver to FT2000/4 > Maintainers.txt: Added maintainers and reviewers for the DurianPkg > > Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dec | 52 + > Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc | 345 +++++ > Platform/Phytium/DurianPkg/DurianPkg.dsc | 331 +++++ > Platform/Phytium/DurianPkg/DurianPkg.fdf | 235 ++++ > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/AcpiTables.inf | 56 + > Silicon/Phytium/FT2000-4Pkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 47 + > Silicon/Phytium/FT2000-4Pkg/Drivers/SpiDxe/SpiDxe.inf | 44 + > Silicon/Phytium/FT2000-4Pkg/Drivers/SpiNorFlashDxe/SpiNorFlashDxe.inf | 48 + > Silicon/Phytium/FT2000-4Pkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 47 + > Silicon/Phytium/FT2000-4Pkg/Library/PciSegmentLib/PciSegmentLib.inf | 28 + > Silicon/Phytium/FT2000-4Pkg/Library/PlatformLib/PlatformLib.inf | 55 + > Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.inf | 39 + > Silicon/Phytium/PhytiumCommonPkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf | 53 + > Silicon/Phytium/PhytiumCommonPkg/Drivers/FlashFvbDxe/FlashFvbDxe.inf | 61 + > Silicon/Phytium/FT2000-4Pkg/Drivers/SpiDxe/SpiDxe.h | 59 + > Silicon/Phytium/FT2000-4Pkg/Drivers/SpiNorFlashDxe/SpiNorFlashDxe.h | 95 ++ > Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.h | 24 + > Silicon/Phytium/PhytiumCommonPkg/Drivers/FlashFvbDxe/FlashFvbDxe.h | 104 ++ > Silicon/Phytium/PhytiumCommonPkg/Include/Platform.h | 80 ++ > Silicon/Phytium/PhytiumCommonPkg/Include/Protocol/SpiNorFlashProtocol.h | 74 + > Silicon/Phytium/PhytiumCommonPkg/Include/Protocol/SpiProtocol.h | 51 + > Silicon/Phytium/PhytiumCommonPkg/Include/SystemServiceInterface.h | 112 ++ > Silicon/Phytium/FT2000-4Pkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 943 +++++++++++++ > Silicon/Phytium/FT2000-4Pkg/Drivers/SpiDxe/SpiDxe.c | 202 +++ > Silicon/Phytium/FT2000-4Pkg/Drivers/SpiNorFlashDxe/SpiNorFlashDxe.c | 412 ++++++ > Silicon/Phytium/FT2000-4Pkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 181 +++ > Silicon/Phytium/FT2000-4Pkg/Library/PciSegmentLib/PciSegmentLib.c | 1434 ++++++++++++++++++++ > Silicon/Phytium/FT2000-4Pkg/Library/PlatformLib/PlatformLib.c | 137 ++ > Silicon/Phytium/FT2000-4Pkg/Library/PlatformLib/PlatformLibMem.c | 156 +++ > Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.c | 462 +++++++ > Silicon/Phytium/PhytiumCommonPkg/Drivers/AcpiPlatformDxe/AcpiPlatform.c | 250 ++++ > Silicon/Phytium/PhytiumCommonPkg/Drivers/FlashFvbDxe/FlashFvbDxe.c | 1304 ++++++++++++++++++ > Maintainers.txt | 8 + > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/AcpiSsdtRootPci.asl | 209 +++ > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Dbg2.aslc | 80 ++ > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Dsdt/Cpu.asl | 85 ++ > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Dsdt/Dsdt.asl | 15 + > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Dsdt/Uart.asl | 65 + > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Fadt.aslc | 77 ++ > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Gtdt.aslc | 83 ++ > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc | 89 ++ > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Madt.aslc | 67 + > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Mcfg.aslc | 65 + > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Pptt.aslc | 219 +++ > Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Spcr.aslc | 73 + > Silicon/Phytium/FT2000-4Pkg/Library/PlatformLib/AArch64/PhytiumPlatformHelper.S | 76 ++ > Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.fdf.inc | 119 ++ > 47 files changed, 8851 insertions(+) > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dec > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc > create mode 100644 Platform/Phytium/DurianPkg/DurianPkg.dsc > create mode 100644 Platform/Phytium/DurianPkg/DurianPkg.fdf > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/AcpiTables.inf > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/SpiDxe/SpiDxe.inf > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/SpiNorFlashDxe/SpiNorFlashDxe.inf > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/PciSegmentLib/PciSegmentLib.inf > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/PlatformLib/PlatformLib.inf > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.inf > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/Drivers/FlashFvbDxe/FlashFvbDxe.inf > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/SpiDxe/SpiDxe.h > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/SpiNorFlashDxe/SpiNorFlashDxe.h > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.h > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/Drivers/FlashFvbDxe/FlashFvbDxe.h > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/Include/Platform.h > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/Include/Protocol/SpiNorFlashProtocol.h > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/Include/Protocol/SpiProtocol.h > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/Include/SystemServiceInterface.h > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/SpiDxe/SpiDxe.c > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/SpiNorFlashDxe/SpiNorFlashDxe.c > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/PciHostBridgeLib/PciHostBridgeLib.c > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/PciSegmentLib/PciSegmentLib.c > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/PlatformLib/PlatformLib.c > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/PlatformLib/PlatformLibMem.c > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.c > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/Drivers/AcpiPlatformDxe/AcpiPlatform.c > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/Drivers/FlashFvbDxe/FlashFvbDxe.c > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/AcpiSsdtRootPci.asl > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Dbg2.aslc > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Dsdt/Cpu.asl > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Dsdt/Dsdt.asl > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Dsdt/Uart.asl > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Fadt.aslc > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Gtdt.aslc > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Iort.aslc > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Madt.aslc > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Mcfg.aslc > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Pptt.aslc > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Spcr.aslc > create mode 100644 Silicon/Phytium/FT2000-4Pkg/Library/PlatformLib/AArch64/PhytiumPlatformHelper.S > create mode 100644 Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.fdf.inc > > -- > 2.25.1 >