From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by mx.groups.io with SMTP id smtpd.web08.12324.1631420593781064701 for ; Sat, 11 Sep 2021 21:23:14 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=PytesJFQ; spf=pass (domain: gmail.com, ip: 209.85.160.175, mailfrom: benjamin.doron00@gmail.com) Received: by mail-qt1-f175.google.com with SMTP id 2so5362879qtw.1 for ; Sat, 11 Sep 2021 21:23:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZH+SrUFbDW/Oa3oNaUqbTyhHQqLelF3QvOxAclzJhFY=; b=PytesJFQdyxbOL7ctdK4xASoEgF/uChMF7LpePK51GMuRAs+RWvEFdXx2+xOn0rfOo 5dkvfyvWOZiYTVNl/+VbApEHaKxuK/+Tz3VFsqwn8woStnJmW0vNUgy2UrpIJFILW8+R jog/NvckvwVbbxvA+PVOp9of9afJRfq+83cDDTPhUb1wsRWixj2m6YzP3fpVBxw+ZGC6 1jjBg0CrD7T3m+5MCn/QfYSPPyCnuK4mfpqDJlO7ESh/hQJBB27VI/Rl9ByRZ99xQU9U zZqnK7g0SYkiN4m/jfu2eJBDKcY8LDiWA9BX1CfCkDSiCU3zF/wZCJtnZQR2CP+horem K7Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZH+SrUFbDW/Oa3oNaUqbTyhHQqLelF3QvOxAclzJhFY=; b=KxYV20Cp/fNjAg7owHw4CT70/44Lu1v7iGCFl1RwwamY8S7v7k1cnRuppDfJ7mXtDN 3LbQZ05186x78uGRPtyFAHMfID1Ty4B8oYUr1Vetnud9UfAZyo2WLwiXKBISpEO3sARa OjSCsqFKQ6xo79hI/HTC7kgej2V4AAdmiz8HTDqthaFoJL4IEpvmUSuHdze0dczEn8eT Os7+Pqc/SksRF2/xwq3o97ITvVAEgj8ntiwGCUdHmybokttIoNo0VpGf70cy+Zz0Xeuf ZQNDVY3Cai2fupk5G8RvDhxmBc488c6S+pdXkCmXCd+inLWZVbbiqsIzRkQu53Mn8sp+ wtCQ== X-Gm-Message-State: AOAM533NkXNdS6nTiJXnSp7eNjiNL1tp2uS1jW2zdpcWh5dRyjkobcLJ FOCV/nPacNNxPVFwMAXabbVT5Jp+6Rk= X-Google-Smtp-Source: ABdhPJyC4XoJdtzqqPVVTHDePQOa4IbCsWc7Q5Z4Jf8R+dKimBpe6FBkjIhAk0EaeoUv8yh/XfANfw== X-Received: by 2002:ac8:7f12:: with SMTP id f18mr4412831qtk.258.1631420592587; Sat, 11 Sep 2021 21:23:12 -0700 (PDT) Return-Path: Received: from benjamind-benjamindomain.. ([2607:f2c0:e98c:24:a84f:66e9:b28b:eae6]) by smtp.gmail.com with ESMTPSA id p187sm2592909qkd.101.2021.09.11.21.23.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Sep 2021 21:23:12 -0700 (PDT) From: "Benjamin Doron" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone Subject: [edk2-platforms][PATCH v2 3/3] KabylakeOpenBoardPkg/AspireVn7Dash572G: Cleanup library includes Date: Sun, 12 Sep 2021 00:22:45 -0400 Message-Id: <20210912042245.9512-3-benjamin.doron00@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210912042245.9512-1-benjamin.doron00@gmail.com> References: <20210912042245.9512-1-benjamin.doron00@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Remove unused includes, LibraryClasses and update a comment or two. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Benjamin Doron --- Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/P= eiSiliconPolicyUpdateLibFsp/PcieDeviceTable.c | 1 - Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/P= eiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.h | 3 ++- Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/P= eiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdatePreMem.c | 1 - Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/P= eiSiliconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf | 5 +---- Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib= /DxeAspireVn7Dash572GAcpiTableLib.c | 2 ++ Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib= /DxeBoardAcpiTableLib.inf | 5 +---- Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib= /SmmAspireVn7Dash572GAcpiEnableLib.c | 5 +++-- Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib= /SmmBoardAcpiEnableLib.inf | 3 ++- Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardEcLib/E= cCommands.c | 16 ++++++++-= ------- Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib= /AspireVn7Dash572GHdaVerbTables.c | 3 ++- Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib= /PeiAspireVn7Dash572GInitLib.h | 3 +-- Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib= /PeiAspireVn7Dash572GInitPreMemLib.c | 3 ++- Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib= /PeiBoardInitPostMemLib.inf | 4 +--- Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib= /PeiBoardInitPreMemLib.inf | 4 +--- Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/DxeSi= liconPolicyUpdateLib/DxeGopPolicyInit.h | 3 --- Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/DxeSi= liconPolicyUpdateLib/DxeSaPolicyInit.h | 3 --- Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/DxeSi= liconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.c | 3 +-- Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/DxeSi= liconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.inf | 2 ++ 18 files changed, 29 insertions(+), 40 deletions(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapp= er/Library/PeiSiliconPolicyUpdateLibFsp/PcieDeviceTable.c b/Platform/Intel/= KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPolicyU= pdateLibFsp/PcieDeviceTable.c index 205ca581c6f3..537fb5c8e4f4 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Libr= ary/PeiSiliconPolicyUpdateLibFsp/PcieDeviceTable.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Libr= ary/PeiSiliconPolicyUpdateLibFsp/PcieDeviceTable.c @@ -7,7 +7,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent **/=0D =0D #include "PeiPchPolicyUpdate.h"=0D -#include =0D =0D #define PCI_CLASS_NETWORK 0x02=0D #define PCI_CLASS_NETWORK_ETHERNET 0x00=0D diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapp= er/Library/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.h b/Platform/Int= el/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPoli= cyUpdateLibFsp/PeiPchPolicyUpdate.h index 5e720b0041e8..134188698077 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Libr= ary/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.h +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Libr= ary/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.h @@ -17,10 +17,11 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include =0D #include =0D #include =0D -#include =0D =0D #include =0D #include =0D #include =0D =0D +#include =0D +=0D #endif=0D diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapp= er/Library/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdatePreMem.c b/Platfo= rm/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSilic= onPolicyUpdateLibFsp/PeiPchPolicyUpdatePreMem.c index 2bc142c0e5ff..28e4e45375c2 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Libr= ary/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdatePreMem.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Libr= ary/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdatePreMem.c @@ -9,7 +9,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include "PeiPchPolicyUpdate.h"=0D #include =0D #include =0D -#include =0D #include =0D #include =0D #include =0D diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapp= er/Library/PeiSiliconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf b/= Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/Pe= iSiliconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf index 323fa5d60e4e..d5f2992b0d6f 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Libr= ary/PeiSiliconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Libr= ary/PeiSiliconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf @@ -62,20 +62,17 @@ =0D [LibraryClasses.IA32]=0D FspWrapperApiLib=0D - FspWrapperPlatformLib=0D BaseMemoryLib=0D DebugLib=0D - HobLib=0D IoLib=0D PcdLib=0D MmPciLib=0D - ConfigBlockLib=0D + PciLib=0D PeiSaPolicyLib=0D PchInfoLib=0D PchHsioLib=0D PchPcieRpLib=0D MemoryAllocationLib=0D - SiPolicyLib=0D PeiLib=0D PeiServicesLib=0D =0D diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/= BoardAcpiLib/DxeAspireVn7Dash572GAcpiTableLib.c b/Platform/Intel/KabylakeOp= enBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib/DxeAspireVn7Dash572GAcpiT= ableLib.c index 131e6460279a..3261f0329661 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAc= piLib/DxeAspireVn7Dash572GAcpiTableLib.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAc= piLib/DxeAspireVn7Dash572GAcpiTableLib.c @@ -2,6 +2,7 @@ Aspire VN7-572G Board ACPI Library=0D =0D Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
=0D +Copyright (c) 2021, Baruch Binyamin Doron
=0D SPDX-License-Identifier: BSD-2-Clause-Patent=0D =0D **/=0D @@ -66,6 +67,7 @@ AspireVn7Dash572GBoardUpdateAcpiTable ( IN OUT EFI_ACPI_TABLE_VERSION *Version=0D )=0D {=0D + // NOTE: Can also patch board-specific SMI handler number=0D if (Table->Signature =3D=3D EFI_ACPI_2_0_DIFFERENTIATED_SYSTEM_DESCRIPTI= ON_TABLE_SIGNATURE) {=0D AspireVn7Dash572GUpdateGlobalNvs ();=0D }=0D diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/= BoardAcpiLib/DxeBoardAcpiTableLib.inf b/Platform/Intel/KabylakeOpenBoardPkg= /AspireVn7Dash572G/Library/BoardAcpiLib/DxeBoardAcpiTableLib.inf index 0d8264554734..660afe9292ec 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAc= piLib/DxeBoardAcpiTableLib.inf +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAc= piLib/DxeBoardAcpiTableLib.inf @@ -22,10 +22,7 @@ #=0D =0D [LibraryClasses]=0D - BaseLib=0D - IoLib=0D - PciLib=0D - AslUpdateLib=0D + PcdLib=0D EcLib=0D =0D [Packages]=0D diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/= BoardAcpiLib/SmmAspireVn7Dash572GAcpiEnableLib.c b/Platform/Intel/KabylakeO= penBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib/SmmAspireVn7Dash572GAcpi= EnableLib.c index 69e9c928ff69..c497399977d7 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAc= piLib/SmmAspireVn7Dash572GAcpiEnableLib.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAc= piLib/SmmAspireVn7Dash572GAcpiEnableLib.c @@ -2,6 +2,7 @@ Acer Aspire VN7-572G SMM Board ACPI Enable library=0D =0D Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
=0D +Copyright (c) 2021, Baruch Binyamin Doron
=0D SPDX-License-Identifier: BSD-2-Clause-Patent=0D =0D **/=0D @@ -20,7 +21,7 @@ AspireVn7Dash572GBoardEnableAcpi ( EFI_STATUS Status;=0D =0D /* Tests at runtime show this re-enables charging and battery reporting= =0D - * - Obtained somewhere from somewhere in vendor's SmmKbcDriver (or RtKb= cDriver).=0D + * - Obtained from somewhere in vendor's SmmKbcDriver.=0D * Further reversing will be performed */=0D Status =3D SendEcCommand (0xE9); /* Vendor implements using ACPI "CMDB"= register" */=0D if (EFI_ERROR (Status)) {=0D @@ -48,7 +49,7 @@ AspireVn7Dash572GBoardDisableAcpi ( EFI_STATUS Status;=0D =0D /* Tests at runtime show this disables charging and battery reporting=0D - * - Obtained somewhere from somewhere in vendor's SmmKbcDriver (or RtKb= cDriver).=0D + * - Obtained from somewhere in vendor's SmmKbcDriver.=0D * Further reversing will be performed */=0D Status =3D SendEcCommand (0xE9); /* Vendor implements using ACPI "CMDB"= register" */=0D if (EFI_ERROR (Status)) {=0D diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/= BoardAcpiLib/SmmBoardAcpiEnableLib.inf b/Platform/Intel/KabylakeOpenBoardPk= g/AspireVn7Dash572G/Library/BoardAcpiLib/SmmBoardAcpiEnableLib.inf index 63a54e1830a5..5db00224dfce 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAc= piLib/SmmBoardAcpiEnableLib.inf +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAc= piLib/SmmBoardAcpiEnableLib.inf @@ -23,9 +23,10 @@ =0D [LibraryClasses]=0D BaseLib=0D + DebugLib=0D EcLib=0D IoLib=0D - PciLib=0D + PcdLib=0D MmPciLib=0D PchCycleDecodingLib=0D =0D diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/= BoardEcLib/EcCommands.c b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash= 572G/Library/BoardEcLib/EcCommands.c index ea8a8ae11e4d..c88ca71242b2 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardEc= Lib/EcCommands.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardEc= Lib/EcCommands.c @@ -60,19 +60,19 @@ EcCmd90Read ( =0D Status =3D SendEcCommand (0x90);=0D if (EFI_ERROR (Status)) {=0D - DEBUG((DEBUG_ERROR, "%a(): SendEcCommand(0x90) failed!\n", __FUNCTION_= _));=0D + DEBUG ((DEBUG_ERROR, "%a(): SendEcCommand(0x90) failed!\n", __FUNCTION= __));=0D return Status;=0D }=0D =0D Status =3D SendEcData (Address);=0D if (EFI_ERROR (Status)) {=0D - DEBUG((DEBUG_ERROR, "%a(): SendEcData(Address) failed!\n", __FUNCTION_= _));=0D + DEBUG ((DEBUG_ERROR, "%a(): SendEcData(Address) failed!\n", __FUNCTION= __));=0D return Status;=0D }=0D =0D Status =3D ReceiveEcData (Data);=0D if (EFI_ERROR (Status)) {=0D - DEBUG((DEBUG_ERROR, "%a(): ReceiveEcData(Data) failed!\n", __FUNCTION_= _));=0D + DEBUG ((DEBUG_ERROR, "%a(): ReceiveEcData(Data) failed!\n", __FUNCTION= __));=0D return Status;=0D }=0D return EFI_SUCCESS;=0D @@ -98,19 +98,19 @@ EcCmd91Write ( =0D Status =3D SendEcCommand (0x91);=0D if (EFI_ERROR (Status)) {=0D - DEBUG((DEBUG_ERROR, "%a(): SendEcCommand(0x91) failed!\n", __FUNCTION_= _));=0D + DEBUG ((DEBUG_ERROR, "%a(): SendEcCommand(0x91) failed!\n", __FUNCTION= __));=0D return Status;=0D }=0D =0D Status =3D SendEcData (Address);=0D if (EFI_ERROR (Status)) {=0D - DEBUG((DEBUG_ERROR, "%a(): SendEcData(Address) failed!\n", __FUNCTION_= _));=0D + DEBUG ((DEBUG_ERROR, "%a(): SendEcData(Address) failed!\n", __FUNCTION= __));=0D return Status;=0D }=0D =0D Status =3D SendEcData (Data);=0D if (EFI_ERROR (Status)) {=0D - DEBUG((DEBUG_ERROR, "%a(): SendEcData(Data) failed!\n", __FUNCTION__))= ;=0D + DEBUG ((DEBUG_ERROR, "%a(): SendEcData(Data) failed!\n", __FUNCTION__)= );=0D return Status;=0D }=0D return EFI_SUCCESS;=0D @@ -139,13 +139,13 @@ EcCmd94Query ( =0D Status =3D SendEcCommand (0x94);=0D if (EFI_ERROR (Status)) {=0D - DEBUG((DEBUG_ERROR, "%a(): SendEcCommand(0x94) failed!\n", __FUNCTION_= _));=0D + DEBUG ((DEBUG_ERROR, "%a(): SendEcCommand(0x94) failed!\n", __FUNCTION= __));=0D return Status;=0D }=0D =0D Status =3D ReceiveEcData (Data);=0D if (EFI_ERROR (Status)) {=0D - DEBUG((DEBUG_ERROR, "%a(): ReceiveEcData(Data) failed!\n", __FUNCTION_= _));=0D + DEBUG ((DEBUG_ERROR, "%a(): ReceiveEcData(Data) failed!\n", __FUNCTION= __));=0D return Status;=0D }=0D return EFI_SUCCESS;=0D diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/= BoardInitLib/AspireVn7Dash572GHdaVerbTables.c b/Platform/Intel/KabylakeOpen= BoardPkg/AspireVn7Dash572G/Library/BoardInitLib/AspireVn7Dash572GHdaVerbTab= les.c index 0573736060fa..cc7369f3484c 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardIn= itLib/AspireVn7Dash572GHdaVerbTables.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardIn= itLib/AspireVn7Dash572GHdaVerbTables.c @@ -2,6 +2,7 @@ HDA Verb table for Acer Aspire VN7-572G=0D =0D Copyright (c) 2017, Intel Corporation. All rights reserved.
=0D +Copyright (c) 2021, Baruch Binyamin Doron
=0D SPDX-License-Identifier: BSD-2-Clause-Patent=0D =0D **/=0D @@ -9,7 +10,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #ifndef _ASPIRE_VN7_572G_HDA_VERB_TABLES_H_=0D #define _ASPIRE_VN7_572G_HDA_VERB_TABLES_H_=0D =0D -#include =0D +#include =0D =0D HDAUDIO_VERB_TABLE HdaVerbTableAlc255AspireVn7Dash572G =3D HDAUDIO_VERB_TA= BLE_INIT (=0D //=0D diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/= BoardInitLib/PeiAspireVn7Dash572GInitLib.h b/Platform/Intel/KabylakeOpenBoa= rdPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiAspireVn7Dash572GInitLib.h index 83789c90becf..51a7b714c463 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardIn= itLib/PeiAspireVn7Dash572GInitLib.h +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardIn= itLib/PeiAspireVn7Dash572GInitLib.h @@ -8,10 +8,9 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #ifndef _PEI_ASPIRE_VN7_572G_BOARD_INIT_LIB_H_=0D #define _PEI_ASPIRE_VN7_572G_BOARD_INIT_LIB_H_=0D =0D -#include =0D +#include =0D #include =0D #include =0D -#include =0D #include =0D #include =0D #include =0D diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/= BoardInitLib/PeiAspireVn7Dash572GInitPreMemLib.c b/Platform/Intel/KabylakeO= penBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiAspireVn7Dash572GInit= PreMemLib.c index d17685be824f..7d4294a71d84 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardIn= itLib/PeiAspireVn7Dash572GInitPreMemLib.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardIn= itLib/PeiAspireVn7Dash572GInitPreMemLib.c @@ -1,6 +1,7 @@ /** @file=0D =0D Copyright (c) 2017 - 2021, Intel Corporation. All rights reserved.
=0D +Copyright (c) 2021, Baruch Binyamin Doron
=0D SPDX-License-Identifier: BSD-2-Clause-Patent=0D =0D **/=0D @@ -8,7 +9,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include =0D #include =0D #include =0D -#include =0D #include =0D #include =0D #include =0D @@ -276,6 +276,7 @@ AspireVn7Dash572GBoardBootModeDetect ( // TODO: Perform advanced detection (recovery/capsule)=0D // FIXME: This violates PI specification? But BOOT_WITH* would always ta= ke precedence=0D // over BOOT_ON_S{4,5}...=0D + // - Use PchPmcLib GetSleepTypeAfterWakeup() instead=0D PchAcpiBaseGet (&ABase);=0D SleepType =3D IoRead32 (ABase + R_PCH_ACPI_PM1_CNT) & B_PCH_ACPI_PM1_CNT= _SLP_TYP;=0D =0D diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/= BoardInitLib/PeiBoardInitPostMemLib.inf b/Platform/Intel/KabylakeOpenBoardP= kg/AspireVn7Dash572G/Library/BoardInitLib/PeiBoardInitPostMemLib.inf index c8c49fa20dcc..7b68f66ac78b 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardIn= itLib/PeiBoardInitPostMemLib.inf +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardIn= itLib/PeiBoardInitPostMemLib.inf @@ -10,7 +10,7 @@ [Defines]=0D INF_VERSION =3D 0x00010005=0D BASE_NAME =3D PeiBoardPostMemInitLib=0D - FILE_GUID =3D 7fcc3900-d38d-419f-826b-72481e8b5509= =0D + FILE_GUID =3D 7FCC3900-D38D-419F-826B-72481E8B5509= =0D MODULE_TYPE =3D BASE=0D VERSION_STRING =3D 1.0=0D LIBRARY_CLASS =3D BoardInitLib=0D @@ -18,8 +18,6 @@ [LibraryClasses]=0D BaseLib=0D DebugLib=0D - BaseMemoryLib=0D - MemoryAllocationLib=0D PcdLib=0D SiliconInitLib=0D PchCycleDecodingLib=0D diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/= BoardInitLib/PeiBoardInitPreMemLib.inf b/Platform/Intel/KabylakeOpenBoardPk= g/AspireVn7Dash572G/Library/BoardInitLib/PeiBoardInitPreMemLib.inf index cd9f979d313c..4de6b7e1721e 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardIn= itLib/PeiBoardInitPreMemLib.inf +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardIn= itLib/PeiBoardInitPreMemLib.inf @@ -10,7 +10,7 @@ [Defines]=0D INF_VERSION =3D 0x00010005=0D BASE_NAME =3D PeiBoardInitPreMemLib=0D - FILE_GUID =3D ec3675bc-1470-417d-826e-37378140213d= =0D + FILE_GUID =3D EC3675BC-1470-417D-826E-37378140213D= =0D MODULE_TYPE =3D BASE=0D VERSION_STRING =3D 1.0=0D LIBRARY_CLASS =3D BoardInitLib=0D @@ -18,8 +18,6 @@ [LibraryClasses]=0D BaseLib=0D DebugLib=0D - BaseMemoryLib=0D - MemoryAllocationLib=0D PcdLib=0D SiliconInitLib=0D TimerLib=0D diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/L= ibrary/DxeSiliconPolicyUpdateLib/DxeGopPolicyInit.h b/Platform/Intel/Kabyla= keOpenBoardPkg/AspireVn7Dash572G/Policy/Library/DxeSiliconPolicyUpdateLib/D= xeGopPolicyInit.h index 63cad5e3753f..56cab1df9b1d 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/= DxeSiliconPolicyUpdateLib/DxeGopPolicyInit.h +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/= DxeSiliconPolicyUpdateLib/DxeGopPolicyInit.h @@ -9,11 +9,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #define _GOP_POLICY_INIT_DXE_H_=0D =0D #include =0D -#include =0D #include =0D -#include =0D #include =0D -#include =0D #include =0D #include =0D #include =0D diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/L= ibrary/DxeSiliconPolicyUpdateLib/DxeSaPolicyInit.h b/Platform/Intel/Kabylak= eOpenBoardPkg/AspireVn7Dash572G/Policy/Library/DxeSiliconPolicyUpdateLib/Dx= eSaPolicyInit.h index 801387b9476f..88a507547f69 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/= DxeSiliconPolicyUpdateLib/DxeSaPolicyInit.h +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/= DxeSiliconPolicyUpdateLib/DxeSaPolicyInit.h @@ -8,12 +8,9 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #ifndef _SA_POLICY_INIT_DXE_H_=0D #define _SA_POLICY_INIT_DXE_H_=0D =0D -#include =0D -#include =0D #include =0D #include =0D #include =0D -#include =0D =0D #include =0D =0D diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/L= ibrary/DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.c b/Platform/Int= el/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/DxeSiliconPolicyUp= dateLib/DxeSiliconPolicyUpdateLib.c index 6298bb53e65d..6840531da986 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/= DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/= DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.c @@ -1,14 +1,13 @@ /** @file=0D =0D Copyright (c) 2017, Intel Corporation. All rights reserved.
=0D +Copyright (c) 2021, Baruch Binyamin Doron
=0D SPDX-License-Identifier: BSD-2-Clause-Patent=0D =0D **/=0D =0D #include =0D #include =0D -#include =0D -#include =0D #include =0D #include =0D =0D diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/L= ibrary/DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.inf b/Platform/I= ntel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/DxeSiliconPolicy= UpdateLib/DxeSiliconPolicyUpdateLib.inf index 63ac194cd0d5..989796cf8244 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/= DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.inf +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/= DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.inf @@ -17,6 +17,8 @@ =0D [LibraryClasses]=0D BaseLib=0D + BaseMemoryLib=0D + UefiBootServicesTableLib=0D PcdLib=0D DebugLib=0D ConfigBlockLib=0D --=20 2.31.1