From: "Leif Lindholm" <leif@nuviainc.com>
To: 贾玲 <jialing@phytium.com.cn>
Cc: devel@edk2.groups.io
Subject: Re: [PATCH v6 04/10] Silicon/Phytium: Added PciSegmentLib to FT2000/4
Date: Tue, 14 Sep 2021 13:05:07 +0100 [thread overview]
Message-ID: <20210914120507.pjd3fmc5cr3bzcfx@leviathan> (raw)
In-Reply-To: <5980ff18.18e.17be34e3f62.Coremail.jialing@phytium.com.cn>
On Tue, Sep 14, 2021 at 15:56:01 +0800, 贾玲 wrote:
> Hi Leif,
>
> Thank you for your reply！
>
> I think your suggestion is very good. There is no dependency between
> patches 8 / 10 and 7 / 10.
Building with 8/10 but without 7/10 fails with
edk2-platforms/Silicon/Phytium/PhytiumCommonPkg/Drivers/FlashFvbDxe/FlashFvbDxe.inf(61):
error 4000: Value of [gSpiNorFlashProtocolGuid] is not found in
/work/git/edk2/EmbeddedPkg/EmbeddedPkg.dec
/work/git/edk2/MdePkg/MdePkg.dec
/work/git/edk2/MdeModulePkg/MdeModulePkg.dec
/work/git/edk2-platforms/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dec
So I have pushed 1-6,9-10/10 as 7872c983ed45..0d85d9ceb01c. Thanks!
> I think it would be great if we could merge. For patch 7, Please
> point out what can be changed better， I will modify it according to
> your suggestions.
Yes, I will have a think and re-read the code with your explanation
and get back to you.
Best Regards,
Leif
next prev parent reply other threads:[~2021-09-14 12:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 8:20 [PATCH v6 00/10] Added support for FT2000/4 chip Ling Jia
2021-09-10 8:20 ` [PATCH v6 01/10] Silicon/Phytium: Added PlatformLib to FT2000/4 Ling Jia
2021-09-10 8:20 ` [PATCH v6 02/10] Silicon/Phytium: Added Acpi support " Ling Jia
2021-09-10 8:20 ` [PATCH v6 03/10] Silicon/Phytium: Added SMBIOS " Ling Jia
2021-09-10 8:20 ` [PATCH v6 04/10] Silicon/Phytium: Added PciSegmentLib " Ling Jia
2021-09-13 12:42 ` Leif Lindholm
2021-09-14 7:56 ` Ling Jia
2021-09-14 12:05 ` Leif Lindholm [this message]
2021-09-10 8:20 ` [PATCH v6 05/10] Silicon/Phytium: Added PciHostBridgeLib " Ling Jia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210914120507.pjd3fmc5cr3bzcfx@leviathan \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox