From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mx.groups.io with SMTP id smtpd.web12.8890.1631621111164240748 for ; Tue, 14 Sep 2021 05:05:11 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=MxH65+wM; spf=pass (domain: nuviainc.com, ip: 209.85.128.53, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f53.google.com with SMTP id b21-20020a1c8015000000b003049690d882so1849107wmd.5 for ; Tue, 14 Sep 2021 05:05:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Tjm6K8W8CS0h3xh7SKgcgSYIFGfaOAOuxWw7yeXgtDQ=; b=MxH65+wM/UD1cysmLN+bEje1ZDyExhA2KwlxR6ytEREvQ6UOZZFfUK20c91wuWIWSg UAKhT4x6N5Li87x8CVkQNvOM3m9u6dfJAwX+Az1F1wMN3GP9PEIHlQJXBDu2AlnzLPGl rC5fRm3/gxZ7lbZAMLlFeSRt5S3oCtfGuiUDohPCiYAGZEO9rTifcJDIoUcuHu8us0MN e1HoiZkSp7Wqy57KlosleIITH/5bgfSoFEAonwmjJDs6B6LqXE8Us1HgWQNnsoogn3Xf uoUJ+efdCq/oIzL8WZD8RpX278l/odRcMhsjzr70Kqs/7xq/eGBpFmHZ0yEQulJoO4AH H4Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Tjm6K8W8CS0h3xh7SKgcgSYIFGfaOAOuxWw7yeXgtDQ=; b=xWeZ1Kw0GSpovUBa1+SaGGTgIaD9XDm2jlNaqTTMNWMxwM3p7WvM+rPoW+jFBgyWYQ KBygb2PUR8JJ083g8XWFhpyJNQfq3BFU4itpj3SuuDoqQR8gO81YoCQBXQZEK0HtuVMO toWNnuLnpkBTSrHlpd/BLjjhIpBHgD5na0WtfZ+yjB2jmDbgR8zc+lkMGGPUl5tufNXK qiKTDLlP+MTcJ5RxuwsS4yA4hVdjmL38Mgs7rSRov26jP/XNLCiKqXbSd0uRMVij+dDP opkhhCWGCOERNfIBJ5IjIIg7T8A1GVRndbLnpyWYwNlKCIzJgQ2wtQ2uM0v8JR3rFKoA dINw== X-Gm-Message-State: AOAM531JYhFN9iKcbMfTKLhBePsOhhnuvEpIp7rvj1K5q/Zqy0RxaVir W6UfjlYIUkmcdU7kxF47RNJ8tSMZF5T0Kh9y X-Google-Smtp-Source: ABdhPJyEZRskbM4u7UYbK4iwTQsMaZyskC/ie6+QajPqEWW9M5kTPD+t+0NeGtZU0SP9e1G5g1l2Pw== X-Received: by 2002:a7b:c104:: with SMTP id w4mr1765154wmi.160.1631621109563; Tue, 14 Sep 2021 05:05:09 -0700 (PDT) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id j19sm10007948wra.92.2021.09.14.05.05.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Sep 2021 05:05:09 -0700 (PDT) Date: Tue, 14 Sep 2021 13:05:07 +0100 From: "Leif Lindholm" To: =?utf-8?B?6LS+546y?= Cc: devel@edk2.groups.io Subject: Re: [PATCH v6 04/10] Silicon/Phytium: Added PciSegmentLib to FT2000/4 Message-ID: <20210914120507.pjd3fmc5cr3bzcfx@leviathan> References: <20210910082058.15194-1-jialing@phytium.com.cn> <20210910082058.15194-5-jialing@phytium.com.cn> <20210913124218.symintdoeeyejfzq@leviathan> <5980ff18.18e.17be34e3f62.Coremail.jialing@phytium.com.cn> MIME-Version: 1.0 In-Reply-To: <5980ff18.18e.17be34e3f62.Coremail.jialing@phytium.com.cn> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Tue, Sep 14, 2021 at 15:56:01 +0800, 贾玲 wrote: > Hi Leif, > > Thank you for your reply！ > > I think your suggestion is very good. There is no dependency between > patches 8 / 10 and 7 / 10. Building with 8/10 but without 7/10 fails with edk2-platforms/Silicon/Phytium/PhytiumCommonPkg/Drivers/FlashFvbDxe/FlashFvbDxe.inf(61): error 4000: Value of [gSpiNorFlashProtocolGuid] is not found in /work/git/edk2/EmbeddedPkg/EmbeddedPkg.dec /work/git/edk2/MdePkg/MdePkg.dec /work/git/edk2/MdeModulePkg/MdeModulePkg.dec /work/git/edk2-platforms/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dec So I have pushed 1-6,9-10/10 as 7872c983ed45..0d85d9ceb01c. Thanks! > I think it would be great if we could merge. For patch 7, Please > point out what can be changed better， I will modify it according to > your suggestions. Yes, I will have a think and re-read the code with your explanation and get back to you. Best Regards, Leif