From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by mx.groups.io with SMTP id smtpd.web11.10937.1631630346678371525 for ; Tue, 14 Sep 2021 07:39:07 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=0Yo1rEtz; spf=pass (domain: nuviainc.com, ip: 209.85.128.47, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f47.google.com with SMTP id l18-20020a05600c4f1200b002f8cf606262so2306829wmq.1 for ; Tue, 14 Sep 2021 07:39:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=KeTNvRrUDjac9fN1cgJwwJiy5arOzJOhJdSs5Vt/0TM=; b=0Yo1rEtzGmgaR8SF9S4+BYet0Ik/FoHQhH1k0PRnlyflwjOON6fbUsQmvxfAKKr74R jaHS+R/4CHq376ArsYrD0EJuG7H8Amu1nKsP/qC9aE6YadBhfODexhjCZocD25jcsV4H 8JJ44pxvQiu5OSSz8F54/lGSLVKwIenhlEsk5YwL+AgEr/h13hUdbZzfuYc3VoqEtEpF ezSlQD2q8fiF1E1h/nWlEdSenp/vS9lJR2rokYQUdRccbVOVYIDaYNr3S+5DjQCrKcd6 3b3gXK2KjZ6ivrt15EXDxNUXgSl8NZuyKWxNcIHc1Rb7e8RNoX8zOhthoOZj2r9R3utb hh2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KeTNvRrUDjac9fN1cgJwwJiy5arOzJOhJdSs5Vt/0TM=; b=j2OhoyHMeyDlboZLMZeNAgV0eqwdv34E+PxYG0gv9/EowwVqpQZbdkgzOFkxsFXoup iGTVZ8md4j6JdMph/NhUlWaBD6GQckXE0+9MQIw7eU/h2TAaEnkmR+hRX/bIypRnkQbo pN9tS0FSv9i4wlSobMeUz5y6Il3QPtYSQlIjMR/tGpE8CI6UzeDdzIsJZ/3knDDcFfos i2hJuk7Rp0v4HayBnKC+1AMDbVxKBwqq8WlI6tqBt2g7Gl4Ahaydvq1ov93HFqI4YENm 632eLasH8H7ZnpZZPSwXwQm5G2sz4El4TNI9tOoFl1mvQA00wNAbAmOcVKRBdfcB4rRs sKYw== X-Gm-Message-State: AOAM532VzrBdrzUybYsvexoCpbHGrPRGhSZczDs48VhZXRdvhAVMpJ/i sl097PvodhhmH3sd9mKmZ0VWhQ== X-Google-Smtp-Source: ABdhPJwJIl2FJIkt4lmfgWJkNQGM/+Ky8M1Y11pJjuZ4A24wtW/iY3wKHe5NcY076EOMl/nSbaUSSQ== X-Received: by 2002:a7b:c92b:: with SMTP id h11mr2633657wml.62.1631630345225; Tue, 14 Sep 2021 07:39:05 -0700 (PDT) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id m29sm11312404wrb.89.2021.09.14.07.39.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Sep 2021 07:39:04 -0700 (PDT) Date: Tue, 14 Sep 2021 15:39:03 +0100 From: "Leif Lindholm" To: Rebecca Cran , Ard Biesheuvel Cc: devel@edk2.groups.io Subject: Re: [edk2-platforms PATCH 1/4] BeagleBoardPkg: Remove the configuration and image headers from flash Message-ID: <20210914143903.ors7du74byx2zirx@leviathan> References: <20210911025714.26263-1-rebecca@bsdio.com> <20210911025714.26263-2-rebecca@bsdio.com> MIME-Version: 1.0 In-Reply-To: <20210911025714.26263-2-rebecca@bsdio.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Ard, I think you were the one who converted the old crazy header stuff to what we have now. Do you remember how this all fits together? For the *other* 3 patches, but not this one: Reviewed-by: Leif Lindholm On Fri, Sep 10, 2021 at 20:57:11 -0600, Rebecca Cran wrote: > Remove the configuration and image headers from the flash image. > This was likely intended for the UEFI firmware to be loaded by the ROM > code, but the BeagleBoard only has 64KB SRAM and so EDK2 needs to be > executed as a second stage loader. > > Signed-off-by: Rebecca Cran > --- > Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.fdf | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-) > > diff --git a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.fdf b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.fdf > index a2cfeb3bc27b..dbae015ff382 100644 > --- a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.fdf > +++ b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.fdf > @@ -23,7 +23,7 @@ > > > [FD.BeagleBoard_EFI] > -BaseAddress = 0x80007DF8|gArmTokenSpaceGuid.PcdFdBaseAddress #The base address of the FLASH Device. > +BaseAddress = 0x80008000|gArmTokenSpaceGuid.PcdFdBaseAddress #The base address of the FLASH Device. > Size = 0x000B0000|gArmTokenSpaceGuid.PcdFdSize #The size in bytes of the FLASH Device > ErasePolarity = 1 > BlockSize = 0x1 > @@ -44,16 +44,7 @@ NumBlocks = 0xB0000 > # RegionType > # > ################################################################################ > -0x00000000|0x00000200 > -FILE = Platform/BeagleBoard/BeagleBoardPkg/ConfigurationHeader.bin > - > -0x00000200|0x00000008 > -DATA = { > - 0xF8, 0xFD, 0x0A, 0x00, # image size: 0xB0000 - 0x208 == 0xAFDF8 > - 0x00, 0x80, 0x00, 0x80 # entry point: 0x80008000 > -} > - > -0x00000208|0x000AFDF8 > +0x00000000|0x000B0000 > gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize > FV = FVMAIN_COMPACT > > -- > 2.31.1 > >