From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mx.groups.io with SMTP id smtpd.web11.11303.1631631662551223465 for ; Tue, 14 Sep 2021 08:01:03 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=UWzj/6np; spf=pass (domain: nuviainc.com, ip: 209.85.221.49, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f49.google.com with SMTP id d6so20718392wrc.11 for ; Tue, 14 Sep 2021 08:01:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tQMTwKubdj8MndHL5z72jFuVkc5xRpPxpGXlSU3jrE4=; b=UWzj/6npzSOEBQk0OFJ/aOWFFHIjk6TG2PD08miRFe3omtfDwRKVji7HRyAnsdXtxC rH50sgQ5LzZtdcvASM+kqhbYujP7khc/knBVzZnNqr0tDnJ+jilDvd0ep9MWDMHDb5KM +kxyyShMx7V5I4jMWQtDNV4T2+jc0p84ls10RIbqhxKkbYh54yLPzAio4ZmE0FQu5OSm 8eBu5v1Z7KdI2fRad00tgFwh3aJIX/wSia8tf6p1Jt7Vj0sboLLPGTYCzSRf9jH2oT3n 1Iw5ypx2GN3f4JCEchpRd0s21KidyJ5wCDmUeylWtv2+qK7oIOT79XgDAtv/guPyRHx7 QezQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tQMTwKubdj8MndHL5z72jFuVkc5xRpPxpGXlSU3jrE4=; b=wmtckOalAaTLGXg8ir+I73YarhayD5c8mKGh4Uo8vy/y6SpSV0hnaPSdRyBHVdVB5B gp1TFbpXQkO2xNasgElcECMB4mkuOciTPHHRb5TGcpjUv2WxTuqtm2S49iwI/jFEh/RB Ne9XJGPCmsaeaZ6tWpBxWx+JD49/8dCFncW4Ma+GiamiSWRvtt17QvyRdSq5Fshijoea mMtc+0lFV7E4vfK3miY3yt6t5qE2l2CKfqUDyfORM4517c6KILwBwnU9FaHWmeni5pAb s/esZb8ri5urQcqIQ9TeoEaleaggKdb/aUihZaw0W+snGcpGnizje2um5WRRuChRSIiu bV2A== X-Gm-Message-State: AOAM530/NyZaM15EMlucksRgk1bnNrzaU2Enj/PdO/sBg7SSakKZ8jXv ZUnLN5ldpywxz96V0u1xSwN3wA== X-Google-Smtp-Source: ABdhPJyEkGAiowoPz7jKKYIDFMkhaeWo6Uqu/u0z429kF5DsLUD8fJPc2Vw74jKMDMFXyr1drtx4RA== X-Received: by 2002:adf:914a:: with SMTP id j68mr19669218wrj.73.1631631660878; Tue, 14 Sep 2021 08:01:00 -0700 (PDT) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id 10sm1391960wmi.1.2021.09.14.08.00.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Sep 2021 08:01:00 -0700 (PDT) Date: Tue, 14 Sep 2021 16:00:58 +0100 From: "Leif Lindholm" To: Jeff Brasen Cc: devel@edk2.groups.io, daniel.schaefer@hpe.com, abner.chang@hpe.com, ardb+tianocore@kernel.org, Jun Nie Subject: Re: [PATCH v3 0/4] AndroidBootImgLib improvements Message-ID: <20210914150058.nb5z4hz2a3e7ndts@leviathan> References: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Jeff, Thanks for this. This set looks good to me, with a slight question mark wrt behaviour compatibility with previous versions for 3/4. (I think it's fine, but I'm a bear of very little brain, and it's been several years since I reviewed this code, and even longer since I really interacted with Android. ^ | shameless plug for more EmbeddedPkg reviewer volunteers.) I've added Jun Nie, who wrote the original version of this code, to see if he has any comments. 1-2/4 are obviously unproblematic, and I could merge those ahead of time if preferred. You can add Reviewed-by: Leif Lindholm for those if there are any further revisions of the set. Best Regards, Leif On Mon, Sep 13, 2021 at 23:18:47 +0000, Jeff Brasen wrote: > Added support for using loadfile2 approach for passing ramdisk to linux. > Created patch series for general error handling improvments based on > review feedback. > If ACPI tables are in system table or PCD is defined the LoadFile2 method > of passing initrd will be used. > > [v3] > -Code review cleanup > -Removed duplicate header file > -Added change to allow FDT to install if UpdateDtb function is not defined > -Added specific ACPI check > -Moved install functions to subfunctions > > [v2] > -Added review feedback > -General improvements to error handling > > [v1] > - Intial revision > > > Jeff Brasen (4): > EmbeddedPkg: Remove duplicate libfdt.h include > EmbeddedPkg: AndroidBootImgBoot error handling updates > EmbeddedPkg: Install FDT if UpdateDtb is not present > EmbeddedPkg: Add LoadFile2 for linux initrd > > EmbeddedPkg/EmbeddedPkg.dec | 1 + > .../AndroidBootImgLib/AndroidBootImgLib.inf | 4 + > .../AndroidBootImgLib/AndroidBootImgLib.c | 275 +++++++++++++++--- > 3 files changed, 233 insertions(+), 47 deletions(-) > > -- > 2.17.1 >