From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web12.8363.1631780810844680582
 for <devel@edk2.groups.io>;
 Thu, 16 Sep 2021 01:26:51 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gbfXZo1P;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1631780808;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=UWP29nBJ3YFRYvwAsSPsXLdghtD5SJbaeHjhj63+4S4=;
	b=gbfXZo1PfSDz5d8zyvktaI58D9UOafhPrZeBvSZAEx4m7tb2hJ2+l8XR5dadZ1+kl9kcCq
	dFvUpEFvPvtdmlk/a6PPwIzEeKbHgrMXKzJKaBeJ9jRya7CW8jBEwFHPE2slP4VkWXu1+q
	kE8TsVGtOTCVj4zy1zgZNnIJLveMG8w=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-25-jeSWqIucP-2EUyTAE0my8A-1; Thu, 16 Sep 2021 04:26:47 -0400
X-MC-Unique: jeSWqIucP-2EUyTAE0my8A-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 042309126B;
	Thu, 16 Sep 2021 08:26:46 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.91])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id ABC8C5D6D5;
	Thu, 16 Sep 2021 08:26:45 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 167E218000A9; Thu, 16 Sep 2021 10:26:44 +0200 (CEST)
Date: Thu, 16 Sep 2021 10:26:44 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Brijesh Singh <brijesh.singh@amd.com>
Cc: devel@edk2.groups.io, James Bottomley <jejb@linux.ibm.com>,
	Min Xu <min.m.xu@intel.com>, Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Erdem Aktas <erdemaktas@google.com>,
	Michael Roth <Michael.Roth@amd.com>
Subject: Re: [PATCH v7 06/31] OvmfPkg/ResetVector: pre-validate the data pages used in SEC phase
Message-ID: <20210916082644.daoyd64fdewfikgz@sirius.home.kraxel.org>
References: <20210913181941.23405-1-brijesh.singh@amd.com>
 <20210913181941.23405-7-brijesh.singh@amd.com>
MIME-Version: 1.0
In-Reply-To: <20210913181941.23405-7-brijesh.singh@amd.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> +; GHCB page table
> +GhcbPageTable:
> +  DD  GHCB_PT_ADDR
> +  DD  GHCB_PT_SIZE
> +  DD  OVMF_SECTION_TYPE_SEC_MEM

Hmm, TDX will re-use those pages for something else.  So as long as TDX
is happy with OVMF_SECTION_TYPE_SEC_MEM everything should work fine and
just mentioning that in the comments will be ok.

If not we might need a SEV_SECTION_TYPE_SEC_MEM to indicate the entry is
valid for SEV only and Intel can add a separate
TDX_SECTION_TYPE_SOMETHING_ELSE entry for the same address range.

take care,
  Gerd