From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web12.8554.1631782736169069414
 for <devel@edk2.groups.io>;
 Thu, 16 Sep 2021 01:58:56 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OeQDSYeO;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1631782735;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=bhMv0/4D0dHrEFB42qI3NiU3w8Ho/SVUC+JKiSOM22c=;
	b=OeQDSYeOuOjtR7VViV/xIfJp2tw6mlxh4In0umTFu59A7RSTMUG8BRU/PvadqxmCF33zZr
	rDDblvJOodklPxTffETPiwoyzYEaD3qoQLWw0qdvwM2gVe6SQMjo+AwH30C/cTSchDfY/H
	WiklUmoQ/C7ooyZq167xUPzKJiNqOAc=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-166-amijS2Y3OsiwMy84tMM08g-1; Thu, 16 Sep 2021 04:58:52 -0400
X-MC-Unique: amijS2Y3OsiwMy84tMM08g-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 776FB100CCC1;
	Thu, 16 Sep 2021 08:58:50 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.91])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id BBC9610027C4;
	Thu, 16 Sep 2021 08:58:49 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 2253E18000A9; Thu, 16 Sep 2021 10:58:48 +0200 (CEST)
Date: Thu, 16 Sep 2021 10:58:48 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Brijesh Singh <brijesh.singh@amd.com>
Cc: devel@edk2.groups.io, James Bottomley <jejb@linux.ibm.com>,
	Min Xu <min.m.xu@intel.com>, Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Erdem Aktas <erdemaktas@google.com>,
	Michael Roth <Michael.Roth@amd.com>
Subject: Re: [PATCH v7 17/31] OvmfPkg/SecMain: pre-validate the memory used for decompressing Fv
Message-ID: <20210916085848.f6k4prprtw5jrrwy@sirius.home.kraxel.org>
References: <20210913181941.23405-1-brijesh.singh@amd.com>
 <20210913181941.23405-18-brijesh.singh@amd.com>
MIME-Version: 1.0
In-Reply-To: <20210913181941.23405-18-brijesh.singh@amd.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> +  ## The range of memory that need to be pre-validated in the SEC phase
> +  #  when SEV-SNP is active in the guest VM.
> +  gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSnpSecPreValidatedStart|0|UINT32|0x56
> +  gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSnpSecPreValidatedEnd|0|UINT32|0x57

I guess TDX needs to do that too?
Should we pick more generic names for the PCDs then?

take care,
  Gerd