From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web12.8697.1631783756091286805
 for <devel@edk2.groups.io>;
 Thu, 16 Sep 2021 02:15:56 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LOhobTFR;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1631783755;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=mksDkQLRAAe/KJegvTj5uAxJJas8D88V1PBnjT9dtdc=;
	b=LOhobTFRt9JllDxexDzbO5pPmPjZbqBC0zx17My3IzCZ300om6d6l5ocLlCYTv7/gqc3GG
	idez6TjIem+wksIMb/SFrURi99npXy9mxiau5GTXM8eHr2viSqkrTNyPgUQYybQpNjb3aS
	e+Ag9rPTADSA0LijS1rMf6DDcLKF3P0=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-579-Oz41gLI4PNiddNkJwBEm5Q-1; Thu, 16 Sep 2021 05:15:53 -0400
X-MC-Unique: Oz41gLI4PNiddNkJwBEm5Q-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C492F1030C20;
	Thu, 16 Sep 2021 09:15:51 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.91])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 6BCA35D9CA;
	Thu, 16 Sep 2021 09:15:51 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id CFDA618000A9; Thu, 16 Sep 2021 11:15:49 +0200 (CEST)
Date: Thu, 16 Sep 2021 11:15:49 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Brijesh Singh <brijesh.singh@amd.com>
Cc: devel@edk2.groups.io, ray.ni@intel.com,
	James Bottomley <jejb@linux.ibm.com>,
	"Xu, Min M" <min.m.xu@intel.com>,
	"Yao, Jiewen" <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Erdem Aktas <erdemaktas@google.com>,
	Michael Roth <Michael.Roth@amd.com>,
	"Dong, Eric" <eric.dong@intel.com>,
	"Kumar, Rahul1" <rahul1.kumar@intel.com>
Subject: Re: [edk2-devel] [PATCH v7 25/31] UefiCpuPkg/MpLib: add support to register GHCB GPA when SEV-SNP is enabled
Message-ID: <20210916091549.74j5lgjutdmz5xp2@sirius.home.kraxel.org>
References: <20210913181941.23405-1-brijesh.singh@amd.com>
 <20210913181941.23405-26-brijesh.singh@amd.com>
 <CO1PR11MB493052997016F0B5E9F2EFFF8CDA9@CO1PR11MB4930.namprd11.prod.outlook.com>
 <CO1PR11MB4930A5713B628D4BDB9A3B9F8CDA9@CO1PR11MB4930.namprd11.prod.outlook.com>
 <c0adab50-6921-3522-80f0-21f810a9ab14@amd.com>
MIME-Version: 1.0
In-Reply-To: <c0adab50-6921-3522-80f0-21f810a9ab14@amd.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Sep 14, 2021 at 09:21:50AM -0500, Brijesh Singh wrote:
> Hi Ray,
> 
> I was hoping that refactor can be done later but sounds like we want to
> do it before the SNP. Let me look into it.

Well, the problem with the "do it later" approach is that these tasks
then tend to fall down to the bottom of the TODO list ...

take care,
  Gerd