From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by mx.groups.io with SMTP id smtpd.web09.9154.1631789217758972733 for ; Thu, 16 Sep 2021 03:46:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=ou0YF6EV; spf=pass (domain: nuviainc.com, ip: 209.85.128.48, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f48.google.com with SMTP id l7-20020a1c2507000000b002e6be5d86b3so4148841wml.3 for ; Thu, 16 Sep 2021 03:46:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=KeLlNdHPVPWqS/p5oXoSz2DwEuAEb4durDgmAYg6ngE=; b=ou0YF6EVJnr0hjC7xvrmdWD9aJUZQfeZMTcRxRyfamc/iBvzNc8Z4oFrk+tgIWCrtQ jFmBCSOkvUgGXjvhpRLYT4WgK2yLSMWuBZFMkLthO2K5OqohsMZNxsoVoxdUphUqJ6vF SzKXJoSURossaKyxquY7JOp+aFAebBvp2lc+XrXMnHl/4sAeLwCyYhq7mO1mBYuDCZOd moICVbEp4jeSq7dCusFiVg68byBt212jSXIvBBaSvaCfAD9sNb2Pik/Hetl4iEMHbMEx djoVdEkpu+GwJWo+VLrbqcJS+XAmcciFi2YLlirVbcvWWtqGgENGm+n49ekLATi8hwKI aFyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=KeLlNdHPVPWqS/p5oXoSz2DwEuAEb4durDgmAYg6ngE=; b=F5mE2YcQYHb6Yl+8zEYwOvPZE9yy0E2sTf34W8HiYAdATTwBytosKvjcJPWG8NSr5m Dg3md8Gk76kAQ6jD/eTXDjDQGvTn0NSFvICPQrq7vAPE4YKpLRk6P4kSsaqjQhdozmLw rurvtmcoe4zWg8CVOoSsfrb9FlKriSGNfUF6j+mLEGZfnljiNRVn/sn4q+9MB4zqyYrf LYiimvCrXNo65PCE/idQlmu0Je4qCpHficlzlYfmGVEwagn8sPaHjbADZw25OTm8awwu 2tfLdZe3Ub8ldoeG3sG2aoNOx1Nj9xeTcULlfXDW5wKJB8CfYVtoyGtt7zKeE5pRthB7 z40Q== X-Gm-Message-State: AOAM5314n7ILvgZHtjzQ0v0sg7KV/5QdrGVxFYLKPeo2NxDx6bC+MJ5b GhqwuINpXKgBTugPT8xABXkemg== X-Google-Smtp-Source: ABdhPJydD/6rLQNkI/goOYekFf4c7lzxFw8qnAvt9jFGtfWQZSBAsDBRHvYpDKzm5FYc0/QBknlnqA== X-Received: by 2002:a1c:4b15:: with SMTP id y21mr4288254wma.183.1631789216286; Thu, 16 Sep 2021 03:46:56 -0700 (PDT) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id t23sm3153006wrb.71.2021.09.16.03.46.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Sep 2021 03:46:55 -0700 (PDT) Date: Thu, 16 Sep 2021 11:46:54 +0100 From: "Leif Lindholm" To: Nhi Pham Cc: devel@edk2.groups.io, patches@amperecomputing.com, vunguyen@os.amperecomputing.com, Thang Nguyen , Chuong Tran , Phong Vo , Michael D Kinney , Ard Biesheuvel , Nate DeSimone Subject: Re: [PATCH v3 01/28] Ampere: Initial support for Ampere Altra processor and Mt. Jade platform Message-ID: <20210916104654.dxfri4polb6zcjrr@leviathan> References: <20210915155527.8176-1-nhi@os.amperecomputing.com> <20210915155527.8176-2-nhi@os.amperecomputing.com> <20210916104045.73wihadbuxfg77e7@leviathan> MIME-Version: 1.0 In-Reply-To: <20210916104045.73wihadbuxfg77e7@leviathan> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Thu, Sep 16, 2021 at 11:40:45 +0100, Leif Lindholm wrote: > On Wed, Sep 15, 2021 at 22:55:00 +0700, Nhi Pham wrote: > > From: Vu Nguyen > > > > This commit adds the support for Ampere’s Altra processor-based Mt. Jade > > platform that provides up to 160 processor cores in a dual socket > > configuration. The essential modules are wired up enough to boot system > > to EDK2 UiApp. > > > > Cc: Thang Nguyen > > Cc: Chuong Tran > > Cc: Phong Vo > > Cc: Leif Lindholm > > Cc: Michael D Kinney > > Cc: Ard Biesheuvel > > Cc: Nate DeSimone > > > > Signed-off-by: Vu Nguyen > > Reviewed-by: Leif Lindholm Err, actually, no. You cannot give sign-off for Vu, but you need to sign off for yourself. So we will need a v4. If this patch in that set contains your Signed-off-by, and no-one elses, that can retain my reviewed-by. Please address this situation for all other affected patches in the set. But don't send out v4 vefore v3 review is complete. Best Regards, Leif