From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by mx.groups.io with SMTP id smtpd.web10.9423.1631791383696141752 for ; Thu, 16 Sep 2021 04:23:04 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=JVdCPKkh; spf=pass (domain: nuviainc.com, ip: 209.85.128.41, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f41.google.com with SMTP id i3so4529857wmq.3 for ; Thu, 16 Sep 2021 04:23:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Pmhag/aIm6B0kuxsiKVO+2CicRTzNcRXJL+xE5EsFmg=; b=JVdCPKkhRRv/HsjR1aQkrla3waXUmtoVZY+/pM/coiHAq6eExqAs9e66hBfMmMy+OK j4mt8qCDjAr2QtecgexFycFcNmivG9w6IX6ls/wBGOllnLL+klS8hMB0hNIq/Hr+qis/ bLQXyEX8ntv1TujjN9o2rPV2Yt1T1rtnUbYkNHB2XFi67NjVjEDCNstOzKjuMKi+Yo6w syTO4mREO21Nn8HAsgMGVjfiDwzViVTZSVCdulhZb6U0eejfkwtB6MLAzkv8wCFcG53J swWQpWBWsGkE5P8dZsg7bWKWWJOKaEsww5d+bCY+rOPvDCSIxHT9rmMPmvg92N9pCBTR S21g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Pmhag/aIm6B0kuxsiKVO+2CicRTzNcRXJL+xE5EsFmg=; b=KVuHZCQJGqv90QDKH5lbSIG2RirT22egxt/5/Qq8TrfMkJtnoO7S7XpiZUCYC9V3LZ NfZ0CIO+SlzzuwyeTXMgu3nlIod+R4M0vSbVy3j8Epl9cWz+LpKob1V5DW4Oc7T2UTDb PQaf+h0EsXy3qDtnvaKuzObtQ79IZxTbkbgaEThAn1MAn3jrCPUnyZaVLijIYikszkIY /girgECyDGF1EcsdB8Az+BOyUDPGjhPrBPozJKpVsvfneue6Nuf6KCPF474/NiaIVpH/ v8CbkRXc/a0UR9+tJvwk1/TmAr8u6lXv0cTUFWdXEcht8CZVVWi+0NtXkYblxsdluVs3 xkPg== X-Gm-Message-State: AOAM531jLFnzg5rXLFzupQYmJ7f06esQaa8i8wJsUVKESP6qvgjB68F0 0/VmD0E8Nl1FcJHkAP5mY43J+A== X-Google-Smtp-Source: ABdhPJxqMqKQDf02fjKIgsLM3q6dbdnyaEbri3NtpKkjJm+TUPl8M0Oyq3TD849xcV2/ywlVBCgrcg== X-Received: by 2002:a7b:c5d2:: with SMTP id n18mr9336788wmk.97.1631791381981; Thu, 16 Sep 2021 04:23:01 -0700 (PDT) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id l15sm7148597wme.42.2021.09.16.04.23.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Sep 2021 04:23:01 -0700 (PDT) Date: Thu, 16 Sep 2021 12:22:59 +0100 From: "Leif Lindholm" To: Nhi Pham Cc: devel@edk2.groups.io, patches@amperecomputing.com, vunguyen@os.amperecomputing.com, Thang Nguyen , Chuong Tran , Phong Vo , Michael D Kinney , Ard Biesheuvel , Nate DeSimone Subject: Re: [PATCH v3 04/28] AmperePlatformPkg: Add FailSafe and WDT support Message-ID: <20210916112259.fxk5yue2a6lhlqjn@leviathan> References: <20210915155527.8176-1-nhi@os.amperecomputing.com> <20210915155527.8176-5-nhi@os.amperecomputing.com> MIME-Version: 1.0 In-Reply-To: <20210915155527.8176-5-nhi@os.amperecomputing.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Sep 15, 2021 at 22:55:03 +0700, Nhi Pham wrote: > The FailSafeDxe is a driver for the FailSafe feature which reverts the > system's configuration to known good values if the system fails to boot > up multiple times. Also, this driver implements the Watchdog Timer > Architectural Protocol to reset the system if it hangs, which is > implemented by the MdeModulePkg/Universal/WatchdogTimerDxe module. So, > the WDT is now used exclusively by the FailSafeDxe. > > By default, when system starts, it configures the secure watchdog timer > with a default value of 5 minutes. If the system boots up cleanly to the > considered good stage, the counter is cleared as it indicates FailSafe > monitor (ATF) that has booted up successfully. If the timer expires, it > is considered a failed boot and the system is rebooted. > > Cc: Thang Nguyen > Cc: Chuong Tran > Cc: Phong Vo > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Ard Biesheuvel > Cc: Nate DeSimone > > Signed-off-by: Nhi Pham Reviewed-by: Leif Lindholm