From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (EUR01-HE1-obe.outbound.protection.outlook.com [40.107.13.53]) by mx.groups.io with SMTP id smtpd.web10.261.1631803582351251954 for ; Thu, 16 Sep 2021 07:46:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=AMR8HbYm; spf=pass (domain: arm.com, ip: 40.107.13.53, mailfrom: joey.gouly@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8ehCvKZhDagW1TjudX4mw5FMelTe2K/ZmC1eByou3Po=; b=AMR8HbYmLMXR6jOujTtVHcYPRGn9RmR6M4MC9sriBpr+RQ4SfOF2uezfU0309eAhLNlT1t6mFfmWOhP6NwZFj6tOY4bOslcyjA6AJTq8ScbQUVqU2wFT1hZkNA3/aRcDLYyiibJ6SYyD84iNu1BU74VRAlB5TiEkuAY51EJNze0= Received: from PR1P264CA0002.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:19e::7) by PA4PR08MB6223.eurprd08.prod.outlook.com (2603:10a6:102:e8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.19; Thu, 16 Sep 2021 14:46:16 +0000 Received: from VE1EUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:102:19e:cafe::6) by PR1P264CA0002.outlook.office365.com (2603:10a6:102:19e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Thu, 16 Sep 2021 14:46:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT030.mail.protection.outlook.com (10.152.18.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Thu, 16 Sep 2021 14:46:15 +0000 Received: ("Tessian outbound f1898412aff1:v103"); Thu, 16 Sep 2021 14:46:15 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: d8f884880fb79841 X-CR-MTA-TID: 64aa7808 Received: from 05cf8ff22f68.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id AA0BD9BE-43E3-4251-852C-E975EF93DB6D.1; Thu, 16 Sep 2021 14:46:08 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 05cf8ff22f68.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 16 Sep 2021 14:46:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NGifnF4ytjUrq29sot67Y2tmffR01QFji4HLmLFQEASd8lnks6n1NeRbkHgeXcqfXF2rBdadlQKrSc5FytjGJ0FhodZF3OkXlWvTlbeqdYX6iRi8+lmjSwKX+lOsymfq+AEHzQ9pi4iYm2dtOnbYKW90PcY6agxCN9U6RaQDFw1tT8ZBFeEFqm8YJh5a4N80bbhr50JQ3RuUPzLxIJUgjoSRfv2rXFMfnZ3XFsqEBu2HC0zJIXDnsn3/Y3bjgg870xZGj1giVair8H+yIsHvWBKG81M91XTuX3AcSdNmbJOGEeNoxc2lwi3Q0Kp6kz2Yobl4lA8wG3+OM5F66AEaiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8ehCvKZhDagW1TjudX4mw5FMelTe2K/ZmC1eByou3Po=; b=Ou5LQN0L1pu5U6S/EJQJnw85R/lGg6hpKO5wBj79qAwf74FOChD8DxnCxOJE9PQvErutltOQSUZvGBCWHjRQLovp8Htqp0gi7CkDfG190311Z82RUSUnOuZKdWpDEI7A4dP0I3un9TeLvluWuWXx7oKRjYUWwFCKYsvpSAxF57gMXR0xbh96aPwC40SG49HA9eq4e2ebaRqiew0NiF6vQcjaFj1LHLCAGMYrXnKf+qRxet0x9WnoywV+Efio+3+0uKQm1Sb3Xinlk7WvOGeOEvvLav7fNlA4zHzqlmWMpeuMQbCcPqzRkYPpi+WvzDw/aw/zNUJs/p8okRYUlzQ9wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8ehCvKZhDagW1TjudX4mw5FMelTe2K/ZmC1eByou3Po=; b=AMR8HbYmLMXR6jOujTtVHcYPRGn9RmR6M4MC9sriBpr+RQ4SfOF2uezfU0309eAhLNlT1t6mFfmWOhP6NwZFj6tOY4bOslcyjA6AJTq8ScbQUVqU2wFT1hZkNA3/aRcDLYyiibJ6SYyD84iNu1BU74VRAlB5TiEkuAY51EJNze0= Received: from DU2PR04CA0218.eurprd04.prod.outlook.com (2603:10a6:10:2b1::13) by VE1PR08MB5792.eurprd08.prod.outlook.com (2603:10a6:800:1a6::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.16; Thu, 16 Sep 2021 14:46:06 +0000 Received: from DB5EUR03FT020.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b1:cafe::89) by DU2PR04CA0218.outlook.office365.com (2603:10a6:10:2b1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Thu, 16 Sep 2021 14:46:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT020.mail.protection.outlook.com (10.152.20.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4523.14 via Frontend Transport; Thu, 16 Sep 2021 14:46:06 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Thu, 16 Sep 2021 14:46:14 +0000 Received: from e124191.cambridge.arm.com (10.11.7.12) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.14 via Frontend Transport; Thu, 16 Sep 2021 14:46:13 +0000 From: "Joey Gouly" To: CC: , , , , Subject: [PATCH v2 0/5] Dot graph generator for PPTT Date: Thu, 16 Sep 2021 15:46:00 +0100 Message-ID: <20210916144605.42071-1-joey.gouly@arm.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 75761fdb-8d5c-4234-a408-08d97920bc9b X-MS-TrafficTypeDiagnostic: VE1PR08MB5792:|PA4PR08MB6223: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8273;OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: WWKtkST2AgLn+MM/rSoC3Hf2pMxmyu3WFYpzaF9Jo3r4tTNnIyWiHREkvZsf/67hd4yAITLZbRvof8jFd/sqcp4ZL9W5I4fQc4krzt8aMOH1ju9xwp67G+r7cX/fO+2h12ErOFwud5+a76djJQkV3iy0NxDrXpb0dtJBCvHnr/vN7iotPJnqW/Dl8mi5qmuU+rfA/7KCcAZAtClABVbWNOEgs8jGcbzlMoUujYjqK0nOVCGRkhO6BCZ0zIPbY5k92GADfjR3sF/q6XTuEp1uYaibwx/gnLj+j49kO4xqBFdcUQar+6FRwa5DfVOW7fSBV0qXQN+oDptSqazHHhSDY5SP4lyG0om0oQCNEEi0mw9HABa/iLwLbBQ60BINWM7Hc65ecbRQc9G+LLrjJCqk4L/UHu2iFuKa3AXmRzYhgyERXxFd5YgQZ7QuN2IhFR/aVWUXX5fRMU98hQME6CABcxyrQ6dGgV2DVP6eX10DC5xP32OWUaFcfaq6QeGJ1zHtVSAcpbyq68CgsKOP1pu214tIDGcauJonMyko01W9SIkkS1ncbCcs7OmVuuaM4h0G273SSfSZ0xEu58l1EmIRRS/VCoQNmj3KeACmYqVdUbpWefeyKIG9jj56nuLD7aJ00zkZ1FKAkCkUZKj7RSZlU1/i/6anRdDmY8Rn9c4Xw7mlWN74+1L0FhdAETSirvT8zdx/i/iyP7MipaLLr8g/BtxSImlctk682cqxQkRH3Q6CticpGuBW3Y0A02hPu8gpPzbY6G5+qXMz6KXtexWMzQw+xTAeMPGKRrdrM7YC+D1Y55N4uyHh4cJ4lyPHG6CXWHKSjYymZr3fNeSFCtqD+4QuMTD8MoFo6XY9hnyLH/8= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(508600001)(1076003)(81166007)(8936002)(5660300002)(86362001)(7696005)(83380400001)(6916009)(8676002)(336012)(70586007)(36756003)(966005)(82310400003)(426003)(2906002)(19627235002)(47076005)(54906003)(44832011)(186003)(356005)(2616005)(6666004)(4326008)(36860700001)(316002)(70206006)(26005)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5792 Return-Path: Joey.Gouly@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 05633485-6260-4141-187e-08d97920b6fe X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: loG1ij03JseWqQQ7lcVS9rwWZb+Nk1Q/V5xydD/qoFfqy8uZS+h7VhR++OD5xUSK3B0M1yWXioUWeGUhyXSJEeYG/teSj8elVVdLkka+/rz3HEiLOwjHQHvHRlhc2zhAR40AS+JptDlxGFydL+upgW3Z5cGkbfXs68uDaE/Lf9wM0v2y5Ff2xzLNVzRvASU73BHKa2jgDH3EDIXHOZI9EKe6AkXQywjPgZMvT9jNmZtk6Y7iE7qRf+YWgTmv+GJSWJLaRvtY9At+tNlCwCuV4/dz1Eo3AkTAIvlbr+ejcw6VQWsMxThKzKxTbOjGnaKaa7jVcTSDz2P3O8DK7FxN8kSA5RndwJDPQfYlsNlWObQRwZkbs3Sy3NMrvZifeg8+YL+KXVoeXHk40gklIMkDVNSP/y6CxpMCFGbzd0/ZAlSFraiug5CsoDw9cLwRVspgtIrmEhce4RZqGSFsPiiqrqTkwnq6EfMIE1iDUFiP8g+LxE3KBQv5YQl69t2fApWM/vwzAp1zaL5cV+jA9gFFHboWXl+nlfxUKUJSoc1oEPtl1EX0ZDtVITAQBvh/+pVah+KWoNmxg4DA9TZAtbpMFv1HOCn627o/cFEy++VL5hQO17o27Fdojv6ZEEqoAoq07v7hkrYM0+zZxlyrzIjvDcalXZq2JuMWsk65LzZjLUZ7ZrSZiA06fZ2XIdLFsS6qmTxqm0EbTw/r34eM0GffYD/hhUGd5NbglyCJPgGaS7NdUVlO53Qyu/w0Pj3mNmhwI4exdhD9KF3MkRdVP7Eav3SW4i/jpa4ClesENgxEB4H7LVtNxMaL20HGj6i7xsge X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(346002)(39860400002)(136003)(396003)(376002)(36840700001)(46966006)(82740400003)(6916009)(316002)(186003)(8936002)(54906003)(26005)(2906002)(70586007)(2616005)(83380400001)(966005)(336012)(82310400003)(5660300002)(6666004)(81166007)(70206006)(86362001)(478600001)(36756003)(19627235002)(1076003)(36860700001)(4326008)(44832011)(7696005)(426003)(8676002)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2021 14:46:15.8837 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 75761fdb-8d5c-4234-a408-08d97920bc9b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6223 Content-Type: text/plain This series adds functionality to print a dot graph of a PPTT table. This helps with understanding and debugging PPTT tables. The dot graph generator functionality is generic and could be used by other tables that would benefit from graph output. Bugzilla: 3378 (https://bugzilla.tianocore.org/show_bug.cgi?id=3378) The changes can be seen at https://github.com/jgouly/edk2/tree/1484_pptt_dot_graph_v2 Changes since v1: # Fixed errors found by CI # Rebased onto latest master branch Marc Moisson-Franckhauser (5): ShellPkg: Replace 'Trace' parameter with 'ParseFlags' ShellPkg: add a helper function for getting a new file name ShellPkg: add a Graph option to the Parser Flags ShellPkg: add dot file generator functions ShellPkg: add PPTT dot file genration .../UefiShellAcpiViewCommandLib.inf | 4 +- .../UefiShellAcpiViewCommandLib/AcpiParser.h | 79 +++-- .../AcpiTableParser.h | 6 +- .../UefiShellAcpiViewCommandLib/AcpiView.h | 25 +- .../AcpiViewConfig.h | 3 +- .../DotGenerator.h | 101 +++++++ .../AcpiTableParser.c | 20 +- .../UefiShellAcpiViewCommandLib/AcpiView.c | 117 +++++-- .../DotGenerator.c | 283 +++++++++++++++++ .../Parsers/Bgrt/BgrtParser.c | 10 +- .../Parsers/Dbg2/Dbg2Parser.c | 8 +- .../Parsers/Dsdt/DsdtParser.c | 8 +- .../Parsers/Facs/FacsParser.c | 10 +- .../Parsers/Fadt/FadtParser.c | 27 +- .../Parsers/Gtdt/GtdtParser.c | 8 +- .../Parsers/Iort/IortParser.c | 8 +- .../Parsers/Madt/MadtParser.c | 8 +- .../Parsers/Mcfg/McfgParser.c | 8 +- .../Parsers/Pptt/PpttParser.c | 285 +++++++++++++++--- .../Parsers/Rsdp/RsdpParser.c | 10 +- .../Parsers/Slit/SlitParser.c | 8 +- .../Parsers/Spcr/SpcrParser.c | 8 +- .../Parsers/Srat/SratParser.c | 8 +- .../Parsers/Ssdt/SsdtParser.c | 8 +- .../Parsers/Xsdt/XsdtParser.c | 10 +- .../UefiShellAcpiViewCommandLib.c | 24 +- .../UefiShellAcpiViewCommandLib.uni | 9 +- 27 files changed, 914 insertions(+), 189 deletions(-) create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/DotGenerator.h create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/DotGenerator.c -- Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")