From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.89]) by mx.groups.io with SMTP id smtpd.web11.220.1631803585504452343 for ; Thu, 16 Sep 2021 07:46:26 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=TCi/tD0b; spf=pass (domain: arm.com, ip: 40.107.20.89, mailfrom: joey.gouly@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uW68lwuFaSu1Z48o7pdg6P3V/E1/2HQF3+zjc9kIaMs=; b=TCi/tD0b/16/CnMb///D9Kd5Oy4k4X+9YLCj1AKW1wxjkbxoH+kvmD08OnfOfrFoDRqeW6oN4sWz8xtqdJgjSUim/tZF6Ci556T6lGK3zWl9raHqscu/QGuUJbTtsDHYa1gs2w1SVX6Szvxu/Sjy2teudNOy9vsZLhez/A5Sf6I= Received: from DU2PR04CA0181.eurprd04.prod.outlook.com (2603:10a6:10:28d::6) by DB9PR08MB6329.eurprd08.prod.outlook.com (2603:10a6:10:25a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.16; Thu, 16 Sep 2021 14:46:18 +0000 Received: from DB5EUR03FT047.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28d:cafe::fd) by DU2PR04CA0181.outlook.office365.com (2603:10a6:10:28d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.16 via Frontend Transport; Thu, 16 Sep 2021 14:46:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT047.mail.protection.outlook.com (10.152.21.232) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Thu, 16 Sep 2021 14:46:18 +0000 Received: ("Tessian outbound b9598e0ead92:v103"); Thu, 16 Sep 2021 14:46:18 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 7476b39b99024f61 X-CR-MTA-TID: 64aa7808 Received: from b3957123ee04.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B32F022C-5459-44C5-88A0-E792003B5756.1; Thu, 16 Sep 2021 14:46:11 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b3957123ee04.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 16 Sep 2021 14:46:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yflo+7Ngi5R5F8Nx3u0DzaOLXseysSrlx4qVtSpAdpjVrlYl/v47B8ys/YQ/2yW9++mCFdRStHYmHrUKkrKblN2pE0lnsZapEByB3C6d7+R7/Qq+5UABxWDe1OT36/FnhMjNfAgLhAkiPV6/m7o3oLYTBS42hc5/K23rh+FVi/IvgtyvclKJrKSUoCfyBDc2FlR8Zj8NyXwnrUTCt4FIBVANOOTku6NpRR+Ery9EIO1oY5cn5Crviz+ASIE94IVTCuE+DPWkwtyev/bN55caJWjo7XKZydrTFcw3rmQiSEKiu4XGQkViOBa4nFGuUqUyHREOvF6cymYdMPgTxVNF4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=uW68lwuFaSu1Z48o7pdg6P3V/E1/2HQF3+zjc9kIaMs=; b=nGmkJeGtciBNrCLvwdfIddSeU8rWLp7OxNH2d0j2UnXB4NEKsuJ51uCVWfqxUdhM3hWdg5PTwUqnkKsew5QUO9ex3jXOkUKlmX31QxR1yqIhGZ8EKbZOhvZ33z+FT15E9ndwUDc0c7DNLNZqpBIf49l489P+Cmgm7UVabnYADiywMx3GuF1H5PfQDM47b29f8jTzMoqnUMOoCbf+E7iBz85F+p1JAsWmopYe7WzWLR8koY+4FNEZZJVC4MXeTcdA8YQ0yaTu+vZ0JPSiXj8449i/oTFdNb6xS3XXHGoRY3/zN/w/6OrZiVScEiXrIBtyQE3gCi+01R1bg1OcE0pSiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uW68lwuFaSu1Z48o7pdg6P3V/E1/2HQF3+zjc9kIaMs=; b=TCi/tD0b/16/CnMb///D9Kd5Oy4k4X+9YLCj1AKW1wxjkbxoH+kvmD08OnfOfrFoDRqeW6oN4sWz8xtqdJgjSUim/tZF6Ci556T6lGK3zWl9raHqscu/QGuUJbTtsDHYa1gs2w1SVX6Szvxu/Sjy2teudNOy9vsZLhez/A5Sf6I= Received: from DU2PR04CA0233.eurprd04.prod.outlook.com (2603:10a6:10:2b1::28) by DB6PR0802MB2581.eurprd08.prod.outlook.com (2603:10a6:4:a1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Thu, 16 Sep 2021 14:46:07 +0000 Received: from DB5EUR03FT020.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b1:cafe::4b) by DU2PR04CA0233.outlook.office365.com (2603:10a6:10:2b1::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.16 via Frontend Transport; Thu, 16 Sep 2021 14:46:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT020.mail.protection.outlook.com (10.152.20.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4523.14 via Frontend Transport; Thu, 16 Sep 2021 14:46:07 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Thu, 16 Sep 2021 14:46:14 +0000 Received: from e124191.cambridge.arm.com (10.11.7.12) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.14 via Frontend Transport; Thu, 16 Sep 2021 14:46:14 +0000 From: "Joey Gouly" To: CC: , , , , Subject: [PATCH v2 3/5] ShellPkg: add a Graph option to the Parser Flags Date: Thu, 16 Sep 2021 15:46:03 +0100 Message-ID: <20210916144605.42071-4-joey.gouly@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210916144605.42071-1-joey.gouly@arm.com> References: <20210916144605.42071-1-joey.gouly@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 94ff2c19-3b50-42d2-1abc-08d97920be4c X-MS-TrafficTypeDiagnostic: DB6PR0802MB2581:|DB9PR08MB6329: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:1051;OLM:1051; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Q4i/lhMMf8on/4C8nkkpxDnsq2K9qooDU1RiYVc9F58852pWswxVHMlkC5e5uj4XE9m7UAl0F3ynipky0JYTAcco1EP/Bid8qH8eIl6ZtciVwykQ/up+X49sJqDXoV1ZK2JW0bNZDFpmIQcJifADly5DL6hoVEodE3ZSqasNvDyFo6lXzW1KqqPeuJW+ys6iFhs4nnlu0oyrR9IZ9Otb8rl7FMZMishTTUckqkMxLYcsOHZPZXIuWzY0xb1nY+wXMm7EI/1U1m53yvVKBfYmYlugZnA0t/dSL+SU22RioBWOjnQjI1IvkWYzOA/pdhtp+WRJ3sNzlTnwiHsXtZbZxsBMvcBG35UwJFadECdNSVRZXNETvj0/EbO/E2Cl9FmwjANqchYv3EPud7yobrk01kCBD0CsZsNthk+zcx6hzGIl99OSjGi5N5JedOk7FAhYQRRAw/20/MuMDLKLWRRu0mkCqE3A5ivwiE3R/oSzhjQnxisrMBssNygjAGn9LxhmxU2QBNbWOWzqNy6YXxHcLWXinEpqM2N9RYnggSFs8YimkA3uzVEY4u9lw2PbMN+h1JRIp2uaAiJW+spnQfAOVA0ss3h1qbZNhsG/UFm17xaqTWprTmLcCEVStCM+rIs+eQQAHlBowlbAJLg7m2w1Rj3+i//E55CMmcr+rk33z6UcuZLYXKT7rxP1y2ESEu67H593crOzO6F6FgHpSw8hyuAlGe3nhJJcILf3Sru3rUhK+7QiNlAsQrVEkXlzl52evvwsds0Ty1V2yPlOasaD8KmtO1+JjMjGSrnn/b5Y4+23IcWl/AVjTUkBpFkygyI+ X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(39860400002)(136003)(376002)(396003)(346002)(36840700001)(46966006)(81166007)(2616005)(4326008)(7696005)(356005)(186003)(26005)(44832011)(2906002)(54906003)(426003)(82740400003)(336012)(316002)(47076005)(36756003)(478600001)(8936002)(36860700001)(1076003)(83380400001)(5660300002)(70206006)(70586007)(6916009)(82310400003)(86362001)(8676002)(6666004)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2581 Return-Path: Joey.Gouly@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 5fd484fa-140a-4b27-0725-08d97920b7bf X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DJjvHuCBcpfZ88StqaxlWJQZO9BTDFgT96nOsAWqFQXh6czjA8S6YBDnDfuug9TAoUEVs0WJ6V5aL49sCsBadzRxQgImKBzZnCkPhbX94CSJn48ZJ8JTYgaNFC6tnjd4elzrWBPdofW/+kXSfBERoaTk38nJY8XIMepXXOzGB0b8Kvi6QiYODExHVBmfwpz99FYpZPeaTCN8oXsMhCtoAmexsqiFga5f0yQYW8M8vEuPjx8jXSZxkZxAFnP9lvGwPPmDxH8TDqNs92wQfZJ38waIgRO2HOgJWYt08AUCXo6Sf5k6QxaMveuIhy2VZLHDpVwdrfQTxv6xGSsCjs5/sxGNSpxB0L5aVaHlmPE3HEMxtIPxa3HDKfcBY5d1zxpW7NXSiyJpg3YmokjI3onQbmoYFWfbZiUpYpb/2zBMh0zMNz0/bPOGDBH7q+jxnwAwQBmwmDvclTDr66zI2oA5A7y1IT3/INYobyhBGQSoTtkQEqgqjNbANaMPxfe7NSg4fFI9ROAhn+7wj6VsKMhJ0kF6mUIBTHKkweqOTbWMcmmtOcmJnl5kL3do0uV4SHhkDopgCADGR5YZJQwOnD3kHQxFB96oq3ekxOt+O2wWMxOdadilrOh7i/zRrqNyovisJISQsjwI75NlV7EhkBw2AfVvURPwx8AFCpKgQqcvUwTf8HpO8r1NI9xwfOa2K58qrUbE8pyOwlzUtYYxOq5nG5qf24zeoN+ePB9++uviuR7T3o4s48arme/j2TtTiBWmOxEpydeB1m8Gi6+180U5O1zRkY8nN2IOxRenVhPg/8E= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(396003)(376002)(39860400002)(136003)(346002)(36840700001)(46966006)(70586007)(2906002)(82310400003)(26005)(70206006)(8676002)(54906003)(186003)(1076003)(86362001)(36756003)(5660300002)(426003)(2616005)(36860700001)(316002)(6666004)(4326008)(82740400003)(8936002)(6916009)(44832011)(478600001)(83380400001)(81166007)(336012)(47076005)(7696005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2021 14:46:18.8138 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 94ff2c19-3b50-42d2-1abc-08d97920be4c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6329 Content-Type: text/plain From: Marc Moisson-Franckhauser Bugzilla: 3378 (https://bugzilla.tianocore.org/show_bug.cgi?id=3378) This option informs the parser to generate a dot graph of a table. This can be useful to understand or debug a table, such as the PPTT table. Signed-off-by: Joey Gouly --- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h | 2 ++ ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewConfig.h | 3 ++- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 9 +++++++- ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c | 24 +++++++++++++++++--- ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni | 9 ++++++-- 5 files changed, 40 insertions(+), 7 deletions(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h index b078c0b99335ba28f7589cac6b0a4190d9a6c3b5..9a67fe084327434bf21b37b3089779468edfb0f1 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h @@ -20,11 +20,13 @@ Flags for the parser. */ #define PARSE_FLAGS_TRACE BIT0 +#define PARSE_FLAGS_GRAPH BIT1 /** Helper macros to test parser flags. */ #define IS_TRACE_FLAG_SET(Flags) (((Flags) & PARSE_FLAGS_TRACE) != 0) +#define IS_GRAPH_FLAG_SET(Flags) (((Flags) & PARSE_FLAGS_GRAPH) != 0) /** This function increments the ACPI table error counter. diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewConfig.h b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewConfig.h index 2db4a65415d8f9e70686cb2cc432862ab4e4c2dd..262302a15cbbe04a228fd55e523930fb76bcf6a8 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewConfig.h +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewConfig.h @@ -1,7 +1,7 @@ /** @file Header file for 'acpiview' configuration. - Copyright (c) 2016 - 2020, ARM Limited. All rights reserved.
+ Copyright (c) 2016 - 2021, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -106,6 +106,7 @@ typedef enum { ReportSelected, ///< Report Selected table. ReportTableList, ///< Report List of tables. ReportDumpBinFile, ///< Dump selected table to a file. + ReportDotGraph, ///< Create Dot Graph for selected compatible table. ReportMax, } EREPORT_OPTION; diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c index db7b2e2a30525cc85a333b93f5eb97ec3a517b37..1155b2f3f411247c866f635fb666dd76455f18a4 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c @@ -192,6 +192,12 @@ ProcessTableReportOptions ( DumpAcpiTableToFile (TablePtr, Length); } break; + case ReportDotGraph: + if (Signature == SelectedTable->Type) { + SelectedTable->Found = TRUE; + ParseFlags |= PARSE_FLAGS_GRAPH; + } + break; case ReportMax: // We should never be here. // This case is only present to prevent compiler warning. @@ -340,7 +346,8 @@ AcpiView ( ReportOption = GetReportOption (); if (ReportTableList != ReportOption) { - if (((ReportSelected == ReportOption) || + if (((ReportSelected == ReportOption) || + (ReportDotGraph == ReportOption) || (ReportDumpBinFile == ReportOption)) && (!SelectedTable->Found)) { Print (L"\nRequested ACPI Table not found.\n"); diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c index b30ed3fc8597b229dd15b6ad4f2aab2e3d0ca583..d837b390938f3c3bc5cb90c1161e2feeb1ed6a6b 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c @@ -1,7 +1,7 @@ /** @file Main file for 'acpiview' Shell command function. - Copyright (c) 2016 - 2020, Arm Limited. All rights reserved.
+ Copyright (c) 2016 - 2021, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -34,6 +34,7 @@ EFI_HII_HANDLE gShellAcpiViewHiiHandle = NULL; STATIC CONST SHELL_PARAM_ITEM ParamList[] = { {L"-q", TypeFlag}, {L"-d", TypeFlag}, + {L"-g", TypeFlag}, {L"-h", TypeFlag}, {L"-l", TypeFlag}, {L"-s", TypeValue}, @@ -293,6 +294,18 @@ ShellCommandRunAcpiView ( L"-d" ); ShellStatus = SHELL_INVALID_PARAMETER; + } else if (ShellCommandLineGetFlag (Package, L"-g") && + !ShellCommandLineGetFlag (Package, L"-s")) { + ShellPrintHiiEx ( + -1, + -1, + NULL, + STRING_TOKEN (STR_GEN_MISSING_OPTION), + gShellAcpiViewHiiHandle, + L"acpiview", + L"-s", + L"-g" + ); } else { // Turn on colour highlighting if requested SetColourHighlighting (ShellCommandLineGetFlag (Package, L"-h")); @@ -316,10 +329,15 @@ ShellCommandRunAcpiView ( SelectAcpiTable (SelectedTableName); SetReportOption (ReportSelected); - if (ShellCommandLineGetFlag (Package, L"-d")) { + if (ShellCommandLineGetFlag (Package, L"-d") || + ShellCommandLineGetFlag (Package, L"-g")) { // Create a temporary file to check if the media is writable. CHAR16 FileNameBuffer[MAX_FILE_NAME_LEN]; - SetReportOption (ReportDumpBinFile); + if (ShellCommandLineGetFlag (Package, L"-d")) { + SetReportOption (ReportDumpBinFile); + } else { + SetReportOption (ReportDotGraph); + } UnicodeSPrint ( FileNameBuffer, diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni index 393110e0ee98d54b3be0309c2d297a121c258570..51f2bea10f7b768e5e67f930237207193cba4246 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni @@ -1,6 +1,6 @@ // /** // -// Copyright (c) 2016 - 2020, Arm Limited. All rights reserved.
+// Copyright (c) 2016 - 2021, Arm Limited. All rights reserved.
// SPDX-License-Identifier: BSD-2-Clause-Patent // // Module Name: @@ -30,7 +30,7 @@ "Display ACPI Table information.\r\n" ".SH SYNOPSIS\r\n" " \r\n" -"ACPIVIEW [[-?] | [[[[-l] | [-s AcpiTable [-d]]] [-q] [-h]] [-r Spec]]]\r\n" +"ACPIVIEW [[-?] | [[[[-l] | [-s AcpiTable [-d] [-g]]] [-q] [-h]] [-r Spec]]]\r\n" " \r\n" ".SH OPTIONS\r\n" " \r\n" @@ -39,6 +39,7 @@ " invocation option.\r\n" " AcpiTable : The required ACPI Table type.\r\n" " -d - Generate a binary file dump of the specified AcpiTable.\r\n" +" -g - Generate a dot graph of the specified AcpiTable.\r\n" " -q - Quiet. Suppress errors and warnings. Disables consistency checks.\r\n" " -h - Enable colour highlighting.\r\n" " -r - Validate that all required ACPI tables are installed\r\n" @@ -123,6 +124,10 @@ " in the current working directory:\r\n" " fs0:\> acpiview -s DSDT -d\r\n" " \r\n" +" * To save a dot graph in the current working directory\r\n" +" representing the processor architecture described in the PPTT table:\r\n" +" fs0:\> acpiview -s PPTT -g\r\n" +" \r\n" " * To display contents of all ACPI tables:\r\n" " fs0:\> acpiview\r\n" " \r\n" -- Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")