From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by mx.groups.io with SMTP id smtpd.web12.264.1631803645904450803 for ; Thu, 16 Sep 2021 07:47:26 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=RXxJUx46; spf=pass (domain: nuviainc.com, ip: 209.85.221.43, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f43.google.com with SMTP id u15so9918936wru.6 for ; Thu, 16 Sep 2021 07:47:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nUIGDDzcdHbkhOrYBhHXgB5zgxZvhE/CIJQrV0/QvCw=; b=RXxJUx46OQQSCbim119s9Nna7xq4+AjA3nM8aV9neUw/c8OhkeNK6QoASOJX4N9OxT E2ZhKm8JN/5moarHxJSAuMhH+kJmSLVQExxwD5n3aLCGntFxbgBR7iZINKbVCE/uEAzX aIb/0ckOGDrDyU4tQq268BPAN7Ujt6p8uZk4r2cp/MH+vVmq6MWvlbDf9JPFEaZM3xyZ GBSKzGzz6BIXIFcDXcUkL7NSRhvwjBjAbN6qhTPFdte8r4A0s19/0K/BgDN1MslTaGOx XpHPFgamgpnKFtkmTO9RkhD1SkaWt53LZ95+3AcpLvEMXbL+r477hP8LgUDvK9Xtipzy z1ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nUIGDDzcdHbkhOrYBhHXgB5zgxZvhE/CIJQrV0/QvCw=; b=7NSpJNkJ5fWv03G1fMsFnJ4HVWTTusgbHo9hObISZqxBoFObrHADm64e12/VwZYOK/ NQA2lsrrWtL+WpLfNEbzN/jsSBAK89Od23PfGtVjNIm8im/fFVwaK8vU3qKoRXgizK3H yiIWdpCAn2fg7uayJyTVrodG4DvlfyIKFntFVhT2y1rnvSlOkH9tpngNJVx/BarRLtgj AXrw+49v/K1dPHlnaQSCHv9B1AuHVbbV/HeA2FcIR/tkexyB5Z0fYgTRJXLEOOqTOVER FIo1ohuc5Jy42oy0ZzYbSISCh56gCkL8OV5wgXQMmRnijfZrsu+2r/SJfZQzcgh7zcwY ++MQ== X-Gm-Message-State: AOAM531bGRktK97osCZHB7k5QW1p3GdS0RlvVYZnt2BE8S/NDZ9mgqTt mkcs93sivjGvxsmEcAkDbGftGQ== X-Google-Smtp-Source: ABdhPJzdgvzFORyXJ6gy6S03Fz8gyeThMB5uv5nGgR8QuxSrnK/vO+vsMZcfKB8hRAdaXSIQnLXzUw== X-Received: by 2002:a05:6000:11c6:: with SMTP id i6mr6416576wrx.177.1631803644542; Thu, 16 Sep 2021 07:47:24 -0700 (PDT) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id h16sm3594303wre.52.2021.09.16.07.47.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Sep 2021 07:47:24 -0700 (PDT) Date: Thu, 16 Sep 2021 15:47:22 +0100 From: "Leif Lindholm" To: Rebecca Cran , Nhi Pham Cc: devel@edk2.groups.io, patches@amperecomputing.com, Ard Biesheuvel Subject: Re: [PATCH 1/1] ArmPkg/ProcessorSubClassDxe: Fix the format of ProcessorId Message-ID: <20210916144722.ritzbuvapwv757u6@leviathan> References: <20210915135532.3465-1-nhi@os.amperecomputing.com> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 16, 2021 at 04:45:29 -0600, Rebecca Cran wrote: > Reviewed-by: Rebecca Cran > > > -- > > Rebecca Cran > > > On 9/15/21 7:55 AM, Nhi Pham wrote: > > According to SMBIOS 3.4, section 7.5.3.3 ARM64-class CPUs, if > > SMCCC_ARCH_SOC_ID is supported, the first DWORD is the JEP-106 code and > > the second DWORD is the SoC revision value. But in the current > > implementation, they are set in reverse. This patch is to correct it. > > > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Cc: Rebecca Cran > > Signed-off-by: Nhi Pham Acked-by: Leif Lindholm Pushed as ac6388add4ad. Thanks! > > --- > > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c > > index 292f10bf97eb..d644cd33d249 100644 > > --- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c > > +++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c > > @@ -2,6 +2,7 @@ > > Functions for processor information common to ARM and AARCH64. > > Copyright (c) 2021, NUVIA Inc. All rights reserved.
> > + Copyright (c) 2021, Ampere Computing LLC. All rights reserved.
> > SPDX-License-Identifier: BSD-2-Clause-Patent > > @@ -171,7 +172,7 @@ SmbiosGetProcessorId ( > > if (HasSmcArm64SocId ()) { > > SmbiosGetSmcArm64SocId (&Jep106Code, &SocRevision); > > - ProcessorId = ((UINT64)Jep106Code << 32) | SocRevision; > > + ProcessorId = ((UINT64)SocRevision << 32) | Jep106Code; > > } else { > > ProcessorId = ArmReadMidr (); > > }