From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.42]) by mx.groups.io with SMTP id smtpd.web10.1354.1632163593290461097 for ; Mon, 20 Sep 2021 11:46:35 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amd.com header.s=selector1 header.b=iOlV/fAy; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.92.42, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G3jaFGjRoKFbCjSF1y6CA/7hf3eoA3S374McieMIEK+MKIjpFJrVoQCkcEG7ltJs4asNZs24ISyk5PjPCEnd2A+44LMwriJ+/BpW3T/nP7DHNoepnKeirM1XPvDRd/q4yoOk1SpqjUOMx49SFB++U4O08mm3lHOal9SxpqV29X0v28RvltTFa2P5eViw4DDhiaGIH2oQvA7FeSlUPNK1bQSt16MjbcSfvsjaVd/goME3bdXcQFpseCkGKcugTEy1V0/AkrR7vfZJv6tZqnb0HIVddIBEQ5lDbanNUukQJyFDQbZnwSdC2wZ1PwvM9CkL4HVrZlKpubnb3IyVUFp9Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=kSf0MS4OVD6gJPRnWtA4Sfx85IajPM731GEwF/G78eY=; b=dry7ybzwPv/yzwrRL43JFnNPxwMt7neVeOyqlV+k7F7x1rRDi4cxXe7VP4+nc2zWg4Sfy/WVtuaAu7Hdl0g5BSoksn8+XdjkePLNZ4zsGRDwi2EqtUVZFsnPu3RhTgKSU4M4dA/bnSYhV91hQX8L54UOBFrWW/82EMFc4/Cr6whQLCpIKus8Cm7uLsJkdt+jwU0LALnj37Q8d/RZncnkxkF4VCgh/k+BqXSzEE1ehrzhhWWNMqAWJtlNhpCTjh+uF9H8d1czEMRmxrVqn9Hgp2ToNgyhIZH+h4nM3fz+quPiejNprCieFJRRQdgaX4+XjuJsYJ4SiPiaM5Ls264u5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kSf0MS4OVD6gJPRnWtA4Sfx85IajPM731GEwF/G78eY=; b=iOlV/fAy1VwTPWM8Y221eEF3pu7mvgBHj3DOesk3pCp3giQAhLf36o9RykjNtYZFbqiFnxdS0CNmOMNFwZL6fSAnUUdlVRWoRRyXxxWV3xq8Z+JIfKtcUZ6O9R6NEOYREYpcO7A3yi+DSXn/w/fKTJ7TgxCOj6BVjE4qUT6H7HE= Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=amd.com; Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SA0PR12MB4575.namprd12.prod.outlook.com (2603:10b6:806:73::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Mon, 20 Sep 2021 18:46:33 +0000 Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::78b7:7336:d363:9be3]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::78b7:7336:d363:9be3%6]) with mapi id 15.20.4523.018; Mon, 20 Sep 2021 18:46:33 +0000 From: "Brijesh Singh" To: devel@edk2.groups.io CC: James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Erdem Aktas , Michael Roth , Gerd Hoffmann , Brijesh Singh , Michael Roth , Jiewen Yao Subject: [PATCH v8 18/32] OvmfPkg/SecMain: validate the memory used for decompressing Fv Date: Mon, 20 Sep 2021 13:45:50 -0500 Message-ID: <20210920184604.31590-19-brijesh.singh@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210920184604.31590-1-brijesh.singh@amd.com> References: <20210920184604.31590-1-brijesh.singh@amd.com> X-ClientProxiedBy: SN4PR0201CA0034.namprd02.prod.outlook.com (2603:10b6:803:2e::20) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) Return-Path: brijesh.singh@amd.com MIME-Version: 1.0 Received: from sbrijesh-desktop.amd.com (165.204.77.1) by SN4PR0201CA0034.namprd02.prod.outlook.com (2603:10b6:803:2e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Mon, 20 Sep 2021 18:46:32 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6ea8186d-8181-475a-606b-08d97c66f782 X-MS-TrafficTypeDiagnostic: SA0PR12MB4575: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ESMstJvwMzmM+sQy0WH9uTFZkU98i0bTiGNVwWfd8WOn9/OpJGGEm/7ij2cYMuIUQIwQiV8N9IuyEbfvcQr3QrqZSz0jXSFA+mlAklbSgjtUgsZ3cfeGUsT2QOmMTRgI3I98Z3Dxpg7hFhtL9Wk6Krbak9IvfnNQy5toKFxO2K6LC32lp9/PGWI5m+u6mgsAqwgyhf2m8r+1LSINsttwmZ+DcmnyP89ryOPvrOQS8C/93fp1pMJrhp7wmf+FIbKrvHdLsrNu8UXYQYxudfx1mu2l+rnzYyRkxbkE/Kliga9q07icfsBhOvsxhcibTGCzg/BZvpOujsOiVmoL7WPFAPOQwVBw1UciUYfOqYLblS2PVclbDInXCiO2N/FceX+0V3sbCYj5BG1KP+ZLAPozf1S/Jcy6BqmjOT/h0ihW1FIRiSAWNwfGVgPf7dUZuK5iakl6cvIcLRc7efd3ffFL1qwxWaZDwfrW4mfsvzbayJhd73GKok0aV7sXecmbB3qNS8kcfbR5kF3cEsMh3fqiisX2dfSbAtqJiVvvq77156jShbIEln8I38W0hjegW9zP5p0BMwN6DMAmC6qvnQ3LM88Em/LGJ7YBBjtLHqrWm/4nsmvxs+7yUdby8Te0i6xCAMTLdNkb6wXiDOIvy78sM/jtzvbyUOFgEPZKGA/1k/ARwYajfjL0+yhqBt0+iYKciZFUU/qZQb4dRBhQ5YCF/zqTRh8eMQvbyzkGu3Fp4TH9hylD8d8eqh+OIK79fd+9N+5GD2s8tnLUFFnOM7XoZQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2718.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38350700002)(44832011)(5660300002)(15650500001)(36756003)(83380400001)(38100700002)(8936002)(66946007)(508600001)(6916009)(7696005)(52116002)(1076003)(6666004)(956004)(8676002)(186003)(54906003)(2616005)(2906002)(6486002)(26005)(19627235002)(316002)(66556008)(66476007)(966005)(86362001)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rn4swfP3oy7wiRnErG5ZS8EvUtGFFS8K/OiCJYHVD431522I7r7KP9pPhd7n?= =?us-ascii?Q?zvQGTqkUN84xlYMyOO05GFv4mLmodU3yp6gjGr3BElVSC3x5u1m/73IUz4OZ?= =?us-ascii?Q?pt+J4/pc3JF7nhxge1LHv9Mke8rBQJZpuVWLcWgKFfs+jOgSGBGKKjAgetkA?= =?us-ascii?Q?dxdEswuPhV7BCpOIJsZUmCtwz00WnYiDwNQ7lX6Kjw+xi6BVaUgupjSTMxep?= =?us-ascii?Q?OpGJ4qZFyxMh2CwuEWca5SRcRf89WYtXE68TiYQTLByaOXh2NMU2TprQ96ws?= =?us-ascii?Q?tn3U/1K8136rug5aNi/Cc1Q3vFroHoKsi1GASy8nrSYja+ANgCti2gauFSCO?= =?us-ascii?Q?G6Ozw1fpfF3EyQD2RErF9sggOC7+fv9JeYZ2MyH/QsuJESRmc9Uoud1ZxRex?= =?us-ascii?Q?NqTreamgDWUk68gVks7ntaZ4pS+xajEcAusCWNugmA8MmCvVP2HJYPQIXtZm?= =?us-ascii?Q?QooO2uIhFPyIGAdA867QTfBNl4p6RDM/LRMZjY7zGhNX11LE44g5iDVLcWjO?= =?us-ascii?Q?H8hpXvjd6xo18ZtFHlLCkEhkWQ6ypGTCn/sTitc92Nol9alpC3mQTTSQ99e8?= =?us-ascii?Q?UX+FCqJ1csp1BtDuLMbJZqbfygol2MmWrHjnTsPDKX4DQkSwwH6I0yBNPB0j?= =?us-ascii?Q?6jEneON5r03udiDICArOEiQdDIev3FmF/sp3H+1NOyYyp7P4F2o110WrG/jH?= =?us-ascii?Q?jwdymA7vTdEhSVGz2K06r1ugTbTYfygY89zRNlqPS6KaEmv9SSYaqo4AegZ2?= =?us-ascii?Q?J9WCUMuMr1OLBBwYSG731sGxJ3ZwKFGJQK9Mf6m64Jj+IBbgIOkK/+jrX+pu?= =?us-ascii?Q?y58URYZLKoyFEz6MZaRr7u/SFQFK7whONwbi6AgzntlVyITd4i3AVPM7Osva?= =?us-ascii?Q?hvWBl8NmhRtAoTeqhbK97OrGQYsXEYWaC/NmS5Em3xmmhpJN/tjTbgyToNs2?= =?us-ascii?Q?aN+pAbeCROQ7a0WPvwkebR6Pdjy3v6NE331jCZYlKvO48bDU7XWRyFP1kHoL?= =?us-ascii?Q?ElkmjMX1PsXtYvabmW3b7VWxyKR58x8EiisduEJUFFfVyLAFrnHPCUEwZ/up?= =?us-ascii?Q?iJpQQbkERp14wf5tuIquS+ZIj337QyhbLx9AGkvHhD0SsROJVpmtm1wEMfBQ?= =?us-ascii?Q?Y/OZW5bH4RkS2WElhglph2AfFQaRjWpyprqfOv4AlO71ENqEbDJo8hSQ8wDa?= =?us-ascii?Q?ozmi5s3u9gMSJ0CdIWVmQl/9tbzubQI9R9EOAie+HPhWJpeWaANEsPxuu/PK?= =?us-ascii?Q?lydW6xzUQUg84hAg3ftxg+Udf3LG+2ak9lVpoAG30dlHWdbb2xwVxVkishm7?= =?us-ascii?Q?6MS+PXERnrNl5ZyVnMTqOJPu?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ea8186d-8181-475a-606b-08d97c66f782 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2021 18:46:33.5907 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uK0Zxxxy1FpauXrhTCEVNPX4CT282A7iPHHwuKjQylp6hAPoA5W9C9Wu0pWME8i10Lhch+icgvL+5FEBLyuptw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4575 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3275 The VMM launch sequence should have pre-validated all the data pages used in the Reset vector. The range does not cover the data pages used during the SEC phase (mainly PEI and DXE firmware volume decompression memory). When SEV-SNP is active, the memory must be pre-validated before the access. Add support to pre-validate the memory range from SnpSecPreValidatedStart to SnpSecPreValidatedEnd. This should be sufficent to enter into the PEI phase. Cc: Michael Roth Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Erdem Aktas Cc: Gerd Hoffmann Acked-by: Jiewen Yao Signed-off-by: Brijesh Singh --- OvmfPkg/OvmfPkg.dec | 4 ++++ .../PeiMemEncryptSevLib.inf | 2 ++ OvmfPkg/Sec/SecMain.inf | 3 +++ OvmfPkg/Sec/AmdSev.h | 23 +++++++++++++++++++ .../X64/PeiSnpSystemRamValidate.c | 5 ++++ OvmfPkg/Sec/AmdSev.c | 22 +++++++++++++++++- OvmfPkg/Sec/SecMain.c | 5 ++++ OvmfPkg/FvmainCompactScratchEnd.fdf.inc | 5 ++++ 8 files changed, 68 insertions(+), 1 deletion(-) diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec index efa0de6d0600..052784c18864 100644 --- a/OvmfPkg/OvmfPkg.dec +++ b/OvmfPkg/OvmfPkg.dec @@ -354,6 +354,10 @@ [PcdsFixedAtBuild] gUefiOvmfPkgTokenSpaceGuid.PcdOvmfCpuidBase|0|UINT32|0x54 gUefiOvmfPkgTokenSpaceGuid.PcdOvmfCpuidSize|0|UINT32|0x55 =20 + ## The range of memory that is validated by the SEC phase. + gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecValidatedStart|0|UINT32|0x56 + gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecValidatedEnd|0|UINT32|0x57 + [PcdsDynamic, PcdsDynamicEx] gUefiOvmfPkgTokenSpaceGuid.PcdEmuVariableEvent|0|UINT64|2 gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashVariablesEnable|FALSE|BOOLEAN|0x1= 0 diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/PeiMemEncryptSevLib.inf b= /OvmfPkg/Library/BaseMemEncryptSevLib/PeiMemEncryptSevLib.inf index 1cc9dd6691a2..291eef39ca8d 100644 --- a/OvmfPkg/Library/BaseMemEncryptSevLib/PeiMemEncryptSevLib.inf +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/PeiMemEncryptSevLib.inf @@ -78,3 +78,5 @@ [FixedPcd] gUefiOvmfPkgTokenSpaceGuid.PcdOvmfLockBoxStorageSize gEfiMdePkgTokenSpaceGuid.PcdGuidedExtractHandlerTableAddress gUefiOvmfPkgTokenSpaceGuid.PcdGuidedExtractHandlerTableSize + gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecValidatedEnd + gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecValidatedStart diff --git a/OvmfPkg/Sec/SecMain.inf b/OvmfPkg/Sec/SecMain.inf index 9523a8ea6c8f..282e60a2764f 100644 --- a/OvmfPkg/Sec/SecMain.inf +++ b/OvmfPkg/Sec/SecMain.inf @@ -51,6 +51,7 @@ [LibraryClasses] PeCoffExtraActionLib ExtractGuidedSectionLib LocalApicLib + MemEncryptSevLib CpuExceptionHandlerLib =20 [Ppis] @@ -73,6 +74,8 @@ [Pcd] gEfiMdeModulePkgTokenSpaceGuid.PcdInitValueInTempStack gUefiOvmfPkgTokenSpaceGuid.PcdOvmfConfidentialComputingWorkAreaHeader gUefiOvmfPkgTokenSpaceGuid.PcdOvmfWorkAreaBase + gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecValidatedStart + gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecValidatedEnd =20 [FeaturePcd] gUefiOvmfPkgTokenSpaceGuid.PcdSmmSmramRequire diff --git a/OvmfPkg/Sec/AmdSev.h b/OvmfPkg/Sec/AmdSev.h index adad96d23189..411bbedae4cf 100644 --- a/OvmfPkg/Sec/AmdSev.h +++ b/OvmfPkg/Sec/AmdSev.h @@ -69,4 +69,27 @@ SevEsIsEnabled ( VOID ); =20 +/** + Validate System RAM used for decompressing the PEI and DXE firmware volum= es + when SEV-SNP is active. The PCDs SecValidatedStart and SecValidatedEnd ar= e + set in OvmfPkg/FvmainCompactScratchEnd.fdf.inc. + +**/ +VOID +SecValidateSystemRam ( + VOID + ); + +/** + Determine if SEV-SNP is active. + + @retval TRUE SEV-SNP is enabled + @retval FALSE SEV-SNP is not enabled + +**/ +BOOLEAN +SevSnpIsEnabled ( + VOID + ); + #endif diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/PeiSnpSystemRamValida= te.c b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/PeiSnpSystemRamValidate.c index a0803e1255dc..f8b44fe040b6 100644 --- a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/PeiSnpSystemRamValidate.c +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/PeiSnpSystemRamValidate.c @@ -65,6 +65,11 @@ STATIC SNP_PRE_VALIDATED_RANGE mPreValidatedRange[] =3D = { FixedPcdGet32 (PcdOvmfSecPeiTempRamBase), FixedPcdGet32 (PcdOvmfSecPeiTempRamBase) + FixedPcdGet32 (PcdOvmfSecPe= iTempRamSize), }, + // The below range is pre-validated by the Sec/SecMain.c + { + FixedPcdGet32 (PcdOvmfSecValidatedStart), + FixedPcdGet32 (PcdOvmfSecValidatedEnd) + }, }; =20 STATIC diff --git a/OvmfPkg/Sec/AmdSev.c b/OvmfPkg/Sec/AmdSev.c index 9dd42b195785..aef27d9727b2 100644 --- a/OvmfPkg/Sec/AmdSev.c +++ b/OvmfPkg/Sec/AmdSev.c @@ -55,7 +55,6 @@ SevEsProtocolFailure ( @retval FALSE SEV-SNP is not enabled =20 **/ -STATIC BOOLEAN SevSnpIsEnabled ( VOID @@ -277,3 +276,24 @@ SevEsIsEnabled ( =20 return (SevEsWorkArea->SevEsEnabled !=3D 0); } + +/** + Validate System RAM used for decompressing the PEI and DXE firmware volum= es + when SEV-SNP is active. The PCDs SecValidatedStart and SecValidatedEnd ar= e + set in OvmfPkg/FvmainCompactScratchEnd.fdf.inc. + +**/ +VOID +SecValidateSystemRam ( + VOID + ) +{ + PHYSICAL_ADDRESS Start, End; + + if (IsSevGuest () && SevSnpIsEnabled ()) { + Start =3D (EFI_PHYSICAL_ADDRESS) PcdGet32 (PcdOvmfSecValidatedStart); + End =3D (EFI_PHYSICAL_ADDRESS) PcdGet32 (PcdOvmfSecValidatedEnd); + + MemEncryptSevSnpPreValidateSystemRam (Start, EFI_SIZE_TO_PAGES (End - = Start)); + } +} diff --git a/OvmfPkg/Sec/SecMain.c b/OvmfPkg/Sec/SecMain.c index 406e3a25d0cd..b173ff976073 100644 --- a/OvmfPkg/Sec/SecMain.c +++ b/OvmfPkg/Sec/SecMain.c @@ -847,6 +847,11 @@ SecCoreStartupWithStack ( SecCoreData.BootFirmwareVolumeBase =3D BootFv; SecCoreData.BootFirmwareVolumeSize =3D (UINTN) BootFv->FvLength; =20 + // + // Validate the System RAM used in the SEC Phase + // + SecValidateSystemRam (); + // // Make sure the 8259 is masked before initializing the Debug Agent and = the debug timer is enabled // diff --git a/OvmfPkg/FvmainCompactScratchEnd.fdf.inc b/OvmfPkg/FvmainCompac= tScratchEnd.fdf.inc index 46f52583297c..d8d45fc9aa6d 100644 --- a/OvmfPkg/FvmainCompactScratchEnd.fdf.inc +++ b/OvmfPkg/FvmainCompactScratchEnd.fdf.inc @@ -63,3 +63,8 @@ DEFINE DECOMP_SCRATCH_BASE =3D (($(DECOMP_SCRATCH_BASE_UNALIGNED= ) + $(DECOMP_SCRATCH_BASE_ALIGNMENT)) & $(DECOMP_SCRATCH_BASE_MASK)) =20 SET gUefiOvmfPkgTokenSpaceGuid.PcdOvmfDecompressionScratchEnd =3D $(DECOMP= _SCRATCH_BASE) + $(DECOMP_SCRATCH_SIZE) + +# +# The range of pages that should be pre-validated during the SEC phase whe= n SEV-SNP is active in the guest VM. +SET gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecValidatedStart =3D $(MEMFD_BASE_A= DDRESS) + gUefiOvmfPkgTokenSpaceGuid.PcdOvmfPeiMemFvBase +SET gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecValidatedEnd =3D $(DECOMP_SCRATCH= _BASE) + $(DECOMP_SCRATCH_SIZE) --=20 2.25.1