From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web09.4248.1632296976119216014 for ; Wed, 22 Sep 2021 00:49:36 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=RI+AS4Bz; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632296975; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9bnH4S6QPUJTJ8gJWSYIoHthlGIbNal03VyCLVt5LOU=; b=RI+AS4BzIeLW7I19zVDJ+Ab/fHM2NDJwi8WxviLbOM9wpkuwAzXTSaSfiq1EqmeYchsoGR HMWO6JTdrgzrqlUMWkL9DYprowIATyKJ69G0etyO5C9FBJXXJM0DgQONS64kkj7I4za4JK caqcpeq6h4BrxpZWrFlGY5xrpUMKB0s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-297-mxznpaWPNduJ5hTl7jTYww-1; Wed, 22 Sep 2021 03:49:33 -0400 X-MC-Unique: mxznpaWPNduJ5hTl7jTYww-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F25129F92A; Wed, 22 Sep 2021 07:49:31 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.193.134]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6781A5F707; Wed, 22 Sep 2021 07:49:31 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id B4A601800923; Wed, 22 Sep 2021 09:49:29 +0200 (CEST) Date: Wed, 22 Sep 2021 09:49:29 +0200 From: "Gerd Hoffmann" To: Min Xu Cc: devel@edk2.groups.io, Ard Biesheuvel , Jordan Justen , Brijesh Singh , Erdem Aktas , James Bottomley , Jiewen Yao , Tom Lendacky Subject: Re: [PATCH V7 1/1] OvmfPkg: Enable TDX in ResetVector Message-ID: <20210922074929.e5iwf24t6wyndgbu@sirius.home.kraxel.org> References: <12721dade1f2f9905cc34271d9abec24650442ff.1632214561.git.min.m.xu@intel.com> MIME-Version: 1.0 In-Reply-To: <12721dade1f2f9905cc34271d9abec24650442ff.1632214561.git.min.m.xu@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, > +%ifdef ARCH_X64 > +; > +; TDX Metadata offset block > +; > +; TdxMetadata.asm is included in ARCH_X64 because Inte TDX is only > +; available in ARCH_X64. Below block describes the offset of > +; TdxMetadata block in Ovmf image > +; > +; GUID : e47a6535-984a-4798-865e-4685a7bf8ec2 > +; > +tdxMetadataOffsetStart: > + DD tdxMetadataOffsetStart - TdxMetadataGuid - 16 > + DW tdxMetadataOffsetEnd - tdxMetadataOffsetStart > + DB 0x35, 0x65, 0x7a, 0xe4, 0x4a, 0x98, 0x98, 0x47 > + DB 0x86, 0x5e, 0x46, 0x85, 0xa7, 0xbf, 0x8e, 0xc2 > +tdxMetadataOffsetEnd: > + > +%endif This should be switched to common ovmf metadata (see patches 4-7 of the SEV-SNP series). Min: please have a look at these patches. Brijesh: It might be useful to post the metadata patches as separate series. > +; Load the GDT and set the CR0, then jump to Flat 32 protected mode. That comment isn't correct, you are already in 32-bit mode. > +; Modified: EAX, EBX, CR0, CR4, DS, ES, FS, GS, SS CS too ... > + jmp LINEAR_CODE_SEL:dword ADDR_OF(jumpToFlat32BitAndLandHere) > +jumpToFlat32BitAndLandHere: ... right here. > --- /dev/null > +++ b/OvmfPkg/ResetVector/Main.asm Can you add a separate patch for "copy Main.asm from UefiCpuPkg unmodified" please? Having the changes for TDX separately is helpful for review. take care, Gerd