From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web08.4177.1632297366403802737
 for <devel@edk2.groups.io>;
 Wed, 22 Sep 2021 00:56:07 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZKSOhR1a;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1632297365;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=ui2ZH8Xj9yEGm7GHYKVMvC6Va2RH01gQpX/wihkYj90=;
	b=ZKSOhR1aqIIvAv2A/NSmVrm1CuhGC9Qzgq1ZVcwv4lMk9Jz4h+sAV+omnoQOsqCdHY57ir
	sJ1SepQ2lp4uPazlpoVVBRXID4yYrPs7u9Wiy08inr7KoUSVCR0qGN59G3CFVsCNupePI/
	yp06Jqq3NMO5FSNZbVyIsfP7SJXqeGM=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-447-fIyXmRrcNMu9XovJ8oWRjg-1; Wed, 22 Sep 2021 03:56:02 -0400
X-MC-Unique: fIyXmRrcNMu9XovJ8oWRjg-1
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 93F2818125C1;
	Wed, 22 Sep 2021 07:56:00 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.193.134])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 3174E60BF4;
	Wed, 22 Sep 2021 07:56:00 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 79C171800923; Wed, 22 Sep 2021 09:55:58 +0200 (CEST)
Date: Wed, 22 Sep 2021 09:55:58 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Brijesh Singh <brijesh.singh@amd.com>
Cc: devel@edk2.groups.io, James Bottomley <jejb@linux.ibm.com>,
	Min Xu <min.m.xu@intel.com>, Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Erdem Aktas <erdemaktas@google.com>,
	Michael Roth <Michael.Roth@amd.com>
Subject: Re: [PATCH v8 08/32] OvmfPkg/ResetVector: use SEV-SNP-validated CPUID values
Message-ID: <20210922075558.zpbcyceegytfumqq@sirius.home.kraxel.org>
References: <20210920184604.31590-1-brijesh.singh@amd.com>
 <20210920184604.31590-9-brijesh.singh@amd.com>
MIME-Version: 1.0
In-Reply-To: <20210920184604.31590-9-brijesh.singh@amd.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> +    ; If SEV-SNP is enabled, use the CPUID page to handle the CPUID
> +    ; instruction.
> +    mov     ecx, SEV_STATUS_MSR
> +    rdmsr
> +    bt      eax, 2
> +    jc      SnpCpuidLookup

Maybe check SNP_CPUID_COUNT instead, so the cpuid page can also be used
without SEV-SNP ?

take care,
  Gerd