From: "PierreGondois" <pierre.gondois@arm.com>
To: devel@edk2.groups.io, Bob Feng <bob.c.feng@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Sami Mujawar <sami.mujawar@arm.com>
Subject: [PATCH v1 2/4] BaseTools/build: Set MakefileName
Date: Thu, 23 Sep 2021 09:59:01 +0100 [thread overview]
Message-ID: <20210923085903.15966-3-Pierre.Gondois@arm.com> (raw)
In-Reply-To: <20210923085903.15966-1-Pierre.Gondois@arm.com>
From: Pierre Gondois <Pierre.Gondois@arm.com>
Running the following command:
python3 build/build.py -a AARCH64 -t GCC5
-p ArmPlatformPkg/ArmPlatformPkg.dsc -b DEBUG libraries
triggers the following error:
make: *** Build/ArmPlatform/DEBUG_GCC5/AARCH64/MdePkg/Library/
BasePcdLibNull/BasePcdLibNull: Is a directory. Stop.
Indeed, MakefileName is set to en empty string. Setting MakefileName
resolves the error.
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
BaseTools/Source/Python/build/build.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Python/build/build.py
index 02b489892422..58081361c38d 100755
--- a/BaseTools/Source/Python/build/build.py
+++ b/BaseTools/Source/Python/build/build.py
@@ -4,7 +4,7 @@
# Copyright (c) 2014, Hewlett-Packard Development Company, L.P.<BR>
# Copyright (c) 2007 - 2021, Intel Corporation. All rights reserved.<BR>
# Copyright (c) 2018, Hewlett Packard Enterprise Development, L.P.<BR>
-# Copyright (c) 2020, ARM Limited. All rights reserved.<BR>
+# Copyright (c) 2020 - 2021, ARM Limited. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -1308,6 +1308,9 @@ class Build():
if Target == 'run':
return True
+ # Fetch the MakeFileName.
+ self.MakeFileName = AutoGenObject.MakeFileName
+
# build modules
if BuildModule:
BuildCommand = BuildCommand + [Target]
--
2.17.1
next prev parent reply other threads:[~2021-09-23 8:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 8:58 [PATCH v1 0/4] Set default Makefile name PierreGondois
2021-09-23 8:59 ` [PATCH v1 1/4] BaseTools/GenMake: Use ToolDefinition as fallback option PierreGondois
2021-09-23 8:59 ` PierreGondois [this message]
2021-09-23 8:59 ` [PATCH v1 3/4] BaseTools: Remove Makefile/MakefileName fields PierreGondois
2021-09-23 8:59 ` [PATCH v1 4/4] BaseTools: Remove hard-coded strings for target and tools_def PierreGondois
2021-09-23 10:05 ` [edk2-devel] [PATCH v1 0/4] Set default Makefile name Chris Jones
2021-09-24 0:48 ` 回复: " gaoliming
2021-09-24 11:57 ` PierreGondois
2021-09-29 1:35 ` 回复: [edk2-devel] " gaoliming
2021-09-29 11:43 ` Bob Feng
[not found] ` <16A94849D004DAA5.16095@groups.io>
2021-09-29 11:53 ` [edk2-devel] " Bob Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210923085903.15966-3-Pierre.Gondois@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox